All of lore.kernel.org
 help / color / mirror / Atom feed
From: robh@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: dts: imx7: Fix error in coresight TPIU graph connection
Date: Tue,  8 May 2018 08:59:28 -0500	[thread overview]
Message-ID: <20180508135930.5768-4-robh@kernel.org> (raw)
In-Reply-To: <20180508135930.5768-1-robh@kernel.org>

OF graph endpoint connections must be bidirectional and dtc will now
warn if they are not. i.MX7 based DTs have an error and generate
warnings:

Warning (graph_endpoint): /replicator/ports/port at 0/endpoint: graph connection to node '/soc/tpiu at 30087000/port/endpoint' is not bidirectional
Warning (graph_endpoint): /soc/tpiu at 30087000/port/endpoint: graph connection to node '/replicator/ports/port at 1/endpoint' is not bidirectional

This appears to be a copy-n-paste error and the TPIU input should be
connected to replicator port 0 instead of port 1.

Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Signed-off-by: Rob Herring <robh@kernel.org>
---
 arch/arm/boot/dts/imx7s.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
index 4d42335c0dee..5db530ec756e 100644
--- a/arch/arm/boot/dts/imx7s.dtsi
+++ b/arch/arm/boot/dts/imx7s.dtsi
@@ -321,7 +321,7 @@
 			port {
 				tpiu_in_port: endpoint {
 					slave-mode;
-					remote-endpoint = <&replicator_out_port1>;
+					remote-endpoint = <&replicator_out_port0>;
 				};
 			};
 		};
-- 
2.17.0

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: Fabio Estevam <fabio.estevam@nxp.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>,
	Pengutronix Kernel Team <kernel@pengutronix.de>
Subject: [PATCH] arm: dts: imx7: Fix error in coresight TPIU graph connection
Date: Tue,  8 May 2018 08:59:28 -0500	[thread overview]
Message-ID: <20180508135930.5768-4-robh@kernel.org> (raw)
In-Reply-To: <20180508135930.5768-1-robh@kernel.org>

OF graph endpoint connections must be bidirectional and dtc will now
warn if they are not. i.MX7 based DTs have an error and generate
warnings:

Warning (graph_endpoint): /replicator/ports/port@0/endpoint: graph connection to node '/soc/tpiu@30087000/port/endpoint' is not bidirectional
Warning (graph_endpoint): /soc/tpiu@30087000/port/endpoint: graph connection to node '/replicator/ports/port@1/endpoint' is not bidirectional

This appears to be a copy-n-paste error and the TPIU input should be
connected to replicator port 0 instead of port 1.

Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Signed-off-by: Rob Herring <robh@kernel.org>
---
 arch/arm/boot/dts/imx7s.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
index 4d42335c0dee..5db530ec756e 100644
--- a/arch/arm/boot/dts/imx7s.dtsi
+++ b/arch/arm/boot/dts/imx7s.dtsi
@@ -321,7 +321,7 @@
 			port {
 				tpiu_in_port: endpoint {
 					slave-mode;
-					remote-endpoint = <&replicator_out_port1>;
+					remote-endpoint = <&replicator_out_port0>;
 				};
 			};
 		};
-- 
2.17.0

  parent reply	other threads:[~2018-05-08 13:59 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-08 13:59 [PATCH] arm: dts: atmel: graph_child_address warning fixes Rob Herring
2018-05-08 13:59 ` Rob Herring
2018-05-08 13:59 ` [PATCH] arm: dts: imx: fix IPU OF graph endpoint node names Rob Herring
2018-05-08 13:59   ` Rob Herring
2018-05-08 14:06   ` Fabio Estevam
2018-05-08 14:06     ` Fabio Estevam
2018-05-08 15:22     ` Rob Herring
2018-05-08 15:22       ` Rob Herring
2018-05-11  8:35       ` Shawn Guo
2018-05-11  8:35         ` Shawn Guo
2018-05-08 14:19   ` Philipp Zabel
2018-05-08 14:19     ` Philipp Zabel
2018-05-08 15:26     ` Rob Herring
2018-05-08 15:26       ` Rob Herring
2018-05-08 13:59 ` [PATCH] arm: dts: imx53: Fix LDB OF graph warning Rob Herring
2018-05-08 13:59   ` Rob Herring
2018-05-08 14:16   ` Philipp Zabel
2018-05-08 14:16     ` Philipp Zabel
2018-05-11  8:47     ` Shawn Guo
2018-05-11  8:47       ` Shawn Guo
2018-05-08 13:59 ` Rob Herring [this message]
2018-05-08 13:59   ` [PATCH] arm: dts: imx7: Fix error in coresight TPIU graph connection Rob Herring
2018-05-08 13:59 ` [PATCH] arm: dts: omap: fix OF graph in omap3-devkit8000 Rob Herring
2018-05-08 13:59   ` Rob Herring
2018-05-15 18:11   ` Tony Lindgren
2018-05-15 18:11     ` Tony Lindgren
2018-05-08 13:59 ` [PATCH] arm: dts: omap: fix OMAP3 CM-T3x OF graph video connectors Rob Herring
2018-05-08 13:59   ` Rob Herring
2018-05-15 18:11   ` Tony Lindgren
2018-05-15 18:11     ` Tony Lindgren
2018-05-08 20:18 ` [PATCH] arm: dts: atmel: graph_child_address warning fixes Boris Brezillon
2018-05-08 20:18   ` Boris Brezillon
2018-05-08 20:41   ` Rob Herring
2018-05-08 20:41     ` Rob Herring
2018-05-08 21:00     ` Boris Brezillon
2018-05-08 21:00       ` Boris Brezillon
2018-05-08 20:50   ` Boris Brezillon
2018-05-08 20:50     ` Boris Brezillon
2018-05-08 21:04 ` Boris Brezillon
2018-05-08 21:04   ` Boris Brezillon
  -- strict thread matches above, loose matches on Subject: below --
2020-07-13 13:25 [PATCH] arm: dts: imx7: Fix error in coresight TPIU graph connection Ilko Iliev
2020-07-16 17:49 ` sbabic at denx.de

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180508135930.5768-4-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.