All of lore.kernel.org
 help / color / mirror / Atom feed
From: robh@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: dts: omap: fix OF graph in omap3-devkit8000
Date: Tue,  8 May 2018 08:59:29 -0500	[thread overview]
Message-ID: <20180508135930.5768-5-robh@kernel.org> (raw)
In-Reply-To: <20180508135930.5768-1-robh@kernel.org>

omap3-devkit8000-common.dtsi defines a graph connection for DVI, but
then omap3-devkit8000-lcd-common.dtsi overrides that with a graph
connection for the LCD as the same output signals are used. This
leaves an incomplete graph as the TFP410 output has only half a
connection. The result is the following warning:

arch/arm/boot/dts/omap3-devkit8000-lcd70.dtb: Warning (graph_endpoint): /encoder0/ports/port at 0/endpoint: graph connection to node '/ocp at 68000000/dss at 48050000/port/endpoint' is not bidirectional

Fix this by defining multiple endpoints which is the correct way to show
a 1 to many connection.

Cc: "Beno?t Cousson" <bcousson@baylibre.com>
Cc: Tony Lindgren <tony@atomide.com>
Signed-off-by: Rob Herring <robh@kernel.org>
---
 arch/arm/boot/dts/omap3-devkit8000-common.dtsi     | 9 ++++++++-
 arch/arm/boot/dts/omap3-devkit8000-lcd-common.dtsi | 5 ++++-
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/omap3-devkit8000-common.dtsi b/arch/arm/boot/dts/omap3-devkit8000-common.dtsi
index 0c0bb1b01b0b..746a658e84b6 100644
--- a/arch/arm/boot/dts/omap3-devkit8000-common.dtsi
+++ b/arch/arm/boot/dts/omap3-devkit8000-common.dtsi
@@ -349,10 +349,17 @@
 	vdda_dac-supply = <&vdac>;
 
 	port {
-		dpi_dvi_out: endpoint {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		dpi_dvi_out: endpoint at 0 {
+			reg = <0>;
 			remote-endpoint = <&tfp410_in>;
 			data-lines = <24>;
 		};
+
+		endpoint at 1 {
+			reg = <1>;
+		};
 	};
 };
 
diff --git a/arch/arm/boot/dts/omap3-devkit8000-lcd-common.dtsi b/arch/arm/boot/dts/omap3-devkit8000-lcd-common.dtsi
index 2d64bcffaaa8..1093387259e2 100644
--- a/arch/arm/boot/dts/omap3-devkit8000-lcd-common.dtsi
+++ b/arch/arm/boot/dts/omap3-devkit8000-lcd-common.dtsi
@@ -30,7 +30,10 @@
 
 &dss {
 	port {
-		dpi_lcd_out: endpoint {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		dpi_lcd_out: endpoint at 1 {
+			reg = <1>;
 			remote-endpoint = <&lcd_in>;
 			data-lines = <24>;
 		};
-- 
2.17.0

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: "Tony Lindgren" <tony@atomide.com>,
	"Benoît Cousson" <bcousson@baylibre.com>
Subject: [PATCH] arm: dts: omap: fix OF graph in omap3-devkit8000
Date: Tue,  8 May 2018 08:59:29 -0500	[thread overview]
Message-ID: <20180508135930.5768-5-robh@kernel.org> (raw)
In-Reply-To: <20180508135930.5768-1-robh@kernel.org>

omap3-devkit8000-common.dtsi defines a graph connection for DVI, but
then omap3-devkit8000-lcd-common.dtsi overrides that with a graph
connection for the LCD as the same output signals are used. This
leaves an incomplete graph as the TFP410 output has only half a
connection. The result is the following warning:

arch/arm/boot/dts/omap3-devkit8000-lcd70.dtb: Warning (graph_endpoint): /encoder0/ports/port@0/endpoint: graph connection to node '/ocp@68000000/dss@48050000/port/endpoint' is not bidirectional

Fix this by defining multiple endpoints which is the correct way to show
a 1 to many connection.

Cc: "Benoît Cousson" <bcousson@baylibre.com>
Cc: Tony Lindgren <tony@atomide.com>
Signed-off-by: Rob Herring <robh@kernel.org>
---
 arch/arm/boot/dts/omap3-devkit8000-common.dtsi     | 9 ++++++++-
 arch/arm/boot/dts/omap3-devkit8000-lcd-common.dtsi | 5 ++++-
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/omap3-devkit8000-common.dtsi b/arch/arm/boot/dts/omap3-devkit8000-common.dtsi
index 0c0bb1b01b0b..746a658e84b6 100644
--- a/arch/arm/boot/dts/omap3-devkit8000-common.dtsi
+++ b/arch/arm/boot/dts/omap3-devkit8000-common.dtsi
@@ -349,10 +349,17 @@
 	vdda_dac-supply = <&vdac>;
 
 	port {
-		dpi_dvi_out: endpoint {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		dpi_dvi_out: endpoint@0 {
+			reg = <0>;
 			remote-endpoint = <&tfp410_in>;
 			data-lines = <24>;
 		};
+
+		endpoint@1 {
+			reg = <1>;
+		};
 	};
 };
 
diff --git a/arch/arm/boot/dts/omap3-devkit8000-lcd-common.dtsi b/arch/arm/boot/dts/omap3-devkit8000-lcd-common.dtsi
index 2d64bcffaaa8..1093387259e2 100644
--- a/arch/arm/boot/dts/omap3-devkit8000-lcd-common.dtsi
+++ b/arch/arm/boot/dts/omap3-devkit8000-lcd-common.dtsi
@@ -30,7 +30,10 @@
 
 &dss {
 	port {
-		dpi_lcd_out: endpoint {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		dpi_lcd_out: endpoint@1 {
+			reg = <1>;
 			remote-endpoint = <&lcd_in>;
 			data-lines = <24>;
 		};
-- 
2.17.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2018-05-08 13:59 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-08 13:59 [PATCH] arm: dts: atmel: graph_child_address warning fixes Rob Herring
2018-05-08 13:59 ` Rob Herring
2018-05-08 13:59 ` [PATCH] arm: dts: imx: fix IPU OF graph endpoint node names Rob Herring
2018-05-08 13:59   ` Rob Herring
2018-05-08 14:06   ` Fabio Estevam
2018-05-08 14:06     ` Fabio Estevam
2018-05-08 15:22     ` Rob Herring
2018-05-08 15:22       ` Rob Herring
2018-05-11  8:35       ` Shawn Guo
2018-05-11  8:35         ` Shawn Guo
2018-05-08 14:19   ` Philipp Zabel
2018-05-08 14:19     ` Philipp Zabel
2018-05-08 15:26     ` Rob Herring
2018-05-08 15:26       ` Rob Herring
2018-05-08 13:59 ` [PATCH] arm: dts: imx53: Fix LDB OF graph warning Rob Herring
2018-05-08 13:59   ` Rob Herring
2018-05-08 14:16   ` Philipp Zabel
2018-05-08 14:16     ` Philipp Zabel
2018-05-11  8:47     ` Shawn Guo
2018-05-11  8:47       ` Shawn Guo
2018-05-08 13:59 ` [PATCH] arm: dts: imx7: Fix error in coresight TPIU graph connection Rob Herring
2018-05-08 13:59   ` Rob Herring
2018-05-08 13:59 ` Rob Herring [this message]
2018-05-08 13:59   ` [PATCH] arm: dts: omap: fix OF graph in omap3-devkit8000 Rob Herring
2018-05-15 18:11   ` Tony Lindgren
2018-05-15 18:11     ` Tony Lindgren
2018-05-08 13:59 ` [PATCH] arm: dts: omap: fix OMAP3 CM-T3x OF graph video connectors Rob Herring
2018-05-08 13:59   ` Rob Herring
2018-05-15 18:11   ` Tony Lindgren
2018-05-15 18:11     ` Tony Lindgren
2018-05-08 20:18 ` [PATCH] arm: dts: atmel: graph_child_address warning fixes Boris Brezillon
2018-05-08 20:18   ` Boris Brezillon
2018-05-08 20:41   ` Rob Herring
2018-05-08 20:41     ` Rob Herring
2018-05-08 21:00     ` Boris Brezillon
2018-05-08 21:00       ` Boris Brezillon
2018-05-08 20:50   ` Boris Brezillon
2018-05-08 20:50     ` Boris Brezillon
2018-05-08 21:04 ` Boris Brezillon
2018-05-08 21:04   ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180508135930.5768-5-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.