From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: dts: imx53: Fix LDB OF graph warning
Date: Fri, 11 May 2018 16:47:10 +0800 [thread overview]
Message-ID: <20180511084708.GG26863@dragon> (raw)
In-Reply-To: <1525788997.18091.5.camel@pengutronix.de>
On Tue, May 08, 2018 at 04:16:37PM +0200, Philipp Zabel wrote:
> On Tue, 2018-05-08 at 08:59 -0500, Rob Herring wrote:
> > Single child nodes in OF graph don't need an address and now dtc will
> > warn about this:
> >
> > Warning (graph_child_address): /soc/aips at 50000000/ldb at 53fa8008/lvds-channel at 0: graph node has single child node 'port at 0', #address-cells/#size-cells are not necessary
> >
> > Since the LDB should always have an output port, fix the warning by
> > adding the output port, 2, to the DT.
> >
> > Cc: Shawn Guo <shawnguo@kernel.org>
> > Cc: Sascha Hauer <s.hauer@pengutronix.de>
> > Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> > Cc: Fabio Estevam <fabio.estevam@nxp.com>
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> > arch/arm/boot/dts/imx53.dtsi | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi
> > index 7d647d043f52..1cf2fc9d0a58 100644
> > --- a/arch/arm/boot/dts/imx53.dtsi
> > +++ b/arch/arm/boot/dts/imx53.dtsi
> > @@ -488,6 +488,10 @@
> > remote-endpoint = <&ipu_di0_lvds0>;
> > };
> > };
> > +
> > + port at 2 {
> > + reg = <2>;
> > + };
>
> Now that the reg property of port at 2 is added in the .dtsi, it could be
> removed from the one .dts files that use it:
>
> ----------8<----------
> --- a/arch/arm/boot/dts/imx53-ppd.dts
> +++ b/arch/arm/boot/dts/imx53-ppd.dts
> @@ -559,8 +559,6 @@
> status = "okay";
>
> port at 2 {
> - reg = <2>;
> -
> lvds0_out: endpoint {
> remote-endpoint = <&panel_in_lvds0>;
> };
I incorporate the change and applied patch. Thanks.
Shawn
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Rob Herring <robh@kernel.org>,
devicetree@vger.kernel.org, Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm: dts: imx53: Fix LDB OF graph warning
Date: Fri, 11 May 2018 16:47:10 +0800 [thread overview]
Message-ID: <20180511084708.GG26863@dragon> (raw)
In-Reply-To: <1525788997.18091.5.camel@pengutronix.de>
On Tue, May 08, 2018 at 04:16:37PM +0200, Philipp Zabel wrote:
> On Tue, 2018-05-08 at 08:59 -0500, Rob Herring wrote:
> > Single child nodes in OF graph don't need an address and now dtc will
> > warn about this:
> >
> > Warning (graph_child_address): /soc/aips@50000000/ldb@53fa8008/lvds-channel@0: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary
> >
> > Since the LDB should always have an output port, fix the warning by
> > adding the output port, 2, to the DT.
> >
> > Cc: Shawn Guo <shawnguo@kernel.org>
> > Cc: Sascha Hauer <s.hauer@pengutronix.de>
> > Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> > Cc: Fabio Estevam <fabio.estevam@nxp.com>
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> > arch/arm/boot/dts/imx53.dtsi | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi
> > index 7d647d043f52..1cf2fc9d0a58 100644
> > --- a/arch/arm/boot/dts/imx53.dtsi
> > +++ b/arch/arm/boot/dts/imx53.dtsi
> > @@ -488,6 +488,10 @@
> > remote-endpoint = <&ipu_di0_lvds0>;
> > };
> > };
> > +
> > + port@2 {
> > + reg = <2>;
> > + };
>
> Now that the reg property of port@2 is added in the .dtsi, it could be
> removed from the one .dts files that use it:
>
> ----------8<----------
> --- a/arch/arm/boot/dts/imx53-ppd.dts
> +++ b/arch/arm/boot/dts/imx53-ppd.dts
> @@ -559,8 +559,6 @@
> status = "okay";
>
> port@2 {
> - reg = <2>;
> -
> lvds0_out: endpoint {
> remote-endpoint = <&panel_in_lvds0>;
> };
I incorporate the change and applied patch. Thanks.
Shawn
next prev parent reply other threads:[~2018-05-11 8:47 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 13:59 [PATCH] arm: dts: atmel: graph_child_address warning fixes Rob Herring
2018-05-08 13:59 ` Rob Herring
2018-05-08 13:59 ` [PATCH] arm: dts: imx: fix IPU OF graph endpoint node names Rob Herring
2018-05-08 13:59 ` Rob Herring
2018-05-08 14:06 ` Fabio Estevam
2018-05-08 14:06 ` Fabio Estevam
2018-05-08 15:22 ` Rob Herring
2018-05-08 15:22 ` Rob Herring
2018-05-11 8:35 ` Shawn Guo
2018-05-11 8:35 ` Shawn Guo
2018-05-08 14:19 ` Philipp Zabel
2018-05-08 14:19 ` Philipp Zabel
2018-05-08 15:26 ` Rob Herring
2018-05-08 15:26 ` Rob Herring
2018-05-08 13:59 ` [PATCH] arm: dts: imx53: Fix LDB OF graph warning Rob Herring
2018-05-08 13:59 ` Rob Herring
2018-05-08 14:16 ` Philipp Zabel
2018-05-08 14:16 ` Philipp Zabel
2018-05-11 8:47 ` Shawn Guo [this message]
2018-05-11 8:47 ` Shawn Guo
2018-05-08 13:59 ` [PATCH] arm: dts: imx7: Fix error in coresight TPIU graph connection Rob Herring
2018-05-08 13:59 ` Rob Herring
2018-05-08 13:59 ` [PATCH] arm: dts: omap: fix OF graph in omap3-devkit8000 Rob Herring
2018-05-08 13:59 ` Rob Herring
2018-05-15 18:11 ` Tony Lindgren
2018-05-15 18:11 ` Tony Lindgren
2018-05-08 13:59 ` [PATCH] arm: dts: omap: fix OMAP3 CM-T3x OF graph video connectors Rob Herring
2018-05-08 13:59 ` Rob Herring
2018-05-15 18:11 ` Tony Lindgren
2018-05-15 18:11 ` Tony Lindgren
2018-05-08 20:18 ` [PATCH] arm: dts: atmel: graph_child_address warning fixes Boris Brezillon
2018-05-08 20:18 ` Boris Brezillon
2018-05-08 20:41 ` Rob Herring
2018-05-08 20:41 ` Rob Herring
2018-05-08 21:00 ` Boris Brezillon
2018-05-08 21:00 ` Boris Brezillon
2018-05-08 20:50 ` Boris Brezillon
2018-05-08 20:50 ` Boris Brezillon
2018-05-08 21:04 ` Boris Brezillon
2018-05-08 21:04 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180511084708.GG26863@dragon \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.