From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Thomas Huth <thuth@redhat.com>, Stefan Weil <sw@weilnetz.de>,
qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
Igor Mammedov <imammedo@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [Qemu-trivial] [PATCH v4 33/40] hw/i386: Use the IEC binary prefix definitions
Date: Mon, 11 Jun 2018 05:18:43 +0300 [thread overview]
Message-ID: <20180611051748-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20180611011501.10235-34-f4bug@amsat.org>
On Sun, Jun 10, 2018 at 10:14:54PM -0300, Philippe Mathieu-Daudé wrote:
> @@ -1392,11 +1393,11 @@ void pc_memory_init(PCMachineState *pcms,
> }
>
> machine->device_memory->base =
> - ROUND_UP(0x100000000ULL + pcms->above_4g_mem_size, 1ULL << 30);
> + ROUND_UP(0x100000000ULL + pcms->above_4g_mem_size, GiB);
>
For some reason, GiB got special treatment. Why not 1* GiB?
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Thomas Huth <thuth@redhat.com>, Stefan Weil <sw@weilnetz.de>,
qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
Igor Mammedov <imammedo@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 33/40] hw/i386: Use the IEC binary prefix definitions
Date: Mon, 11 Jun 2018 05:18:43 +0300 [thread overview]
Message-ID: <20180611051748-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20180611011501.10235-34-f4bug@amsat.org>
On Sun, Jun 10, 2018 at 10:14:54PM -0300, Philippe Mathieu-Daudé wrote:
> @@ -1392,11 +1393,11 @@ void pc_memory_init(PCMachineState *pcms,
> }
>
> machine->device_memory->base =
> - ROUND_UP(0x100000000ULL + pcms->above_4g_mem_size, 1ULL << 30);
> + ROUND_UP(0x100000000ULL + pcms->above_4g_mem_size, GiB);
>
For some reason, GiB got special treatment. Why not 1* GiB?
next prev parent reply other threads:[~2018-06-11 2:18 UTC|newest]
Thread overview: 147+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 1:14 [Qemu-trivial] [PATCH v4 00/40] Use the IEC binary prefix definitions Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-arm] " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-trivial] [PATCH v4 01/40] include: Add IEC binary prefixes in "qemu/units.h" Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-12 20:42 ` [Qemu-trivial] " Richard Henderson
2018-06-12 20:42 ` Richard Henderson
2018-06-11 1:14 ` [Qemu-trivial] [PATCH v4 02/40] vdi: Use definitions from "qemu/units.h" Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11 19:27 ` [Qemu-trivial] " Stefan Weil
2018-06-11 19:27 ` Stefan Weil
2018-06-11 1:14 ` [Qemu-trivial] [PATCH v4 03/40] x86/cpu: " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11 18:42 ` [Qemu-trivial] " Eduardo Habkost
2018-06-11 18:42 ` [Qemu-devel] " Eduardo Habkost
2018-06-11 1:14 ` [Qemu-trivial] [PATCH v4 04/40] checkpatch: Recognize IEC binary prefix definitions Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-13 19:54 ` [Qemu-trivial] " Philippe Mathieu-Daudé
2018-06-13 19:54 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-trivial] [PATCH v4 05/40] hw: Use IEC binary prefix definitions from "qemu/units.h" Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11 1:14 ` Philippe Mathieu-Daudé
2018-06-11 2:11 ` [Qemu-trivial] " David Gibson
2018-06-11 2:11 ` [Qemu-devel] " David Gibson
2018-06-11 2:11 ` David Gibson
2018-06-11 1:14 ` [Qemu-trivial] [PATCH v4 06/40] hw: Directly use "qemu/units.h" instead of "qemu/cutils.h" Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11 1:14 ` Philippe Mathieu-Daudé
2018-06-11 2:16 ` [Qemu-trivial] " David Gibson
2018-06-11 2:16 ` [Qemu-devel] " David Gibson
2018-06-11 2:16 ` David Gibson
2018-06-11 1:14 ` [Qemu-trivial] [PATCH v4 07/40] hw/ivshmem: Use the IEC binary prefix definitions Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-trivial] [PATCH v4 08/40] hw/ipack: " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-trivial] [PATCH v4 09/40] hw/scsi: " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-trivial] [PATCH v4 10/40] hw/smbios: " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-trivial] [PATCH v4 11/40] hw/xen: " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11 1:14 ` Philippe Mathieu-Daudé
2018-06-12 20:51 ` [Qemu-devel] " Richard Henderson
2018-06-12 20:51 ` [Qemu-trivial] " Richard Henderson
2018-06-12 20:51 ` Richard Henderson
2018-06-12 21:04 ` Eric Blake
2018-06-12 21:04 ` [Qemu-trivial] " Eric Blake
2018-06-12 21:04 ` Eric Blake
2018-06-12 21:10 ` [Qemu-trivial] " Richard Henderson
2018-06-12 21:10 ` Richard Henderson
2018-06-13 12:13 ` [Qemu-trivial] " Eric Blake
2018-06-13 12:13 ` Eric Blake
2018-06-13 19:31 ` Richard Henderson
2018-06-13 19:31 ` [Qemu-trivial] " Richard Henderson
2018-06-13 19:31 ` Richard Henderson
2018-06-13 20:02 ` [Qemu-trivial] " Philippe Mathieu-Daudé
2018-06-13 20:02 ` Philippe Mathieu-Daudé
2018-06-13 12:13 ` Eric Blake
2018-06-12 21:10 ` Richard Henderson
2018-06-11 1:14 ` [Qemu-trivial] [PATCH v4 12/40] hw/tpm: " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-trivial] [PATCH v4 13/40] hw/block: " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-trivial] [PATCH v4 14/40] hw/display: " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11 1:14 ` Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-trivial] [PATCH v4 15/40] hw/misc: " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-trivial] [PATCH v4 16/40] hw/riscv: " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11 1:22 ` [Qemu-trivial] " Michael Clark
2018-06-11 1:22 ` [Qemu-devel] " Michael Clark
2018-06-11 1:14 ` [Qemu-trivial] [PATCH v4 17/40] hw/m68k: " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-trivial] [PATCH v4 18/40] hw/sparc: " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-trivial] [PATCH v4 19/40] hw/s390x: " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-trivial] [PATCH v4 20/40] hw/hppa: " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-trivial] [PATCH v4 21/40] hw/xtensa: " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-trivial] [PATCH v4 22/40] hw/alpha: " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-trivial] [PATCH v4 23/40] hw/tricore: " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-trivial] [PATCH v4 24/40] hw/microblaze: " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-trivial] [PATCH v4 25/40] hw/nios2: " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-trivial] [PATCH v4 26/40] hw/cris: " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-trivial] [PATCH v4 27/40] hw/lm32: " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-trivial] [PATCH v4 28/40] hw/sh4: " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-trivial] [PATCH v4 29/40] hw/mips/r4k: Constify params_size Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-trivial] [PATCH v4 30/40] hw/mips: Use the IEC binary prefix definitions Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-trivial] [PATCH v4 32/40] hw/ppc: " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11 8:09 ` [Qemu-trivial] [Qemu-ppc] " BALATON Zoltan
2018-06-11 8:09 ` [Qemu-devel] " BALATON Zoltan
2018-06-11 15:44 ` [Qemu-trivial] " Philippe Mathieu-Daudé
2018-06-11 15:44 ` Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-trivial] [PATCH v4 34/40] hw/net: " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11 1:14 ` Philippe Mathieu-Daudé
2018-06-11 19:20 ` [Qemu-trivial] " Stefan Weil
2018-06-11 19:20 ` Stefan Weil
2018-06-11 19:20 ` [Qemu-arm] " Stefan Weil
2018-06-11 1:14 ` [Qemu-trivial] [PATCH v4 35/40] hw/usb: " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-trivial] [PATCH v4 36/40] hw/sd: " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-trivial] [PATCH v4 37/40] hw/vfio: " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-trivial] [PATCH v4 38/40] hw/virtio: " Philippe Mathieu-Daudé
2018-06-11 1:14 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11 1:15 ` [Qemu-trivial] [PATCH v4 39/40] hw/rdma: " Philippe Mathieu-Daudé
2018-06-11 1:15 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11 1:15 ` [Qemu-trivial] [PATCH v4 40/40] cutils: Do not include "qemu/units.h" directly Philippe Mathieu-Daudé
2018-06-11 1:15 ` [Qemu-devel] " Philippe Mathieu-Daudé
[not found] ` <20180611011501.10235-34-f4bug@amsat.org>
2018-06-11 2:18 ` Michael S. Tsirkin [this message]
2018-06-11 2:18 ` [Qemu-devel] [PATCH v4 33/40] hw/i386: Use the IEC binary prefix definitions Michael S. Tsirkin
2018-06-11 2:29 ` [Qemu-trivial] " Philippe Mathieu-Daudé
2018-06-11 2:29 ` Philippe Mathieu-Daudé
2018-06-11 2:22 ` [Qemu-trivial] [PATCH v4 00/40] " Michael S. Tsirkin
2018-06-11 2:22 ` [Qemu-devel] " Michael S. Tsirkin
2018-06-11 2:22 ` [Qemu-arm] " Michael S. Tsirkin
2018-06-11 2:32 ` [Qemu-trivial] " Philippe Mathieu-Daudé
2018-06-11 2:32 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11 2:32 ` Philippe Mathieu-Daudé
2018-06-11 15:55 ` [Qemu-trivial] " Eric Blake
2018-06-11 15:55 ` [Qemu-devel] " Eric Blake
2018-06-11 15:55 ` [Qemu-arm] " Eric Blake
2018-06-11 16:11 ` [Qemu-trivial] " Peter Maydell
2018-06-11 16:11 ` [Qemu-devel] " Peter Maydell
2018-06-11 16:11 ` [Qemu-arm] " Peter Maydell
2018-06-11 16:27 ` [Qemu-trivial] " Michael S. Tsirkin
2018-06-11 16:27 ` [Qemu-devel] " Michael S. Tsirkin
2018-06-11 16:27 ` [Qemu-arm] " Michael S. Tsirkin
2018-06-11 16:18 ` [Qemu-trivial] " Cornelia Huck
2018-06-11 16:18 ` [Qemu-devel] " Cornelia Huck
2018-06-11 16:18 ` [Qemu-arm] " Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180611051748-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=imammedo@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=rth@twiddle.net \
--cc=sw@weilnetz.de \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.