All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: "Thomas Huth" <thuth@redhat.com>, "Stefan Weil" <sw@weilnetz.de>,
	"Nikunj A Dadhania" <nikunj@linux.vnet.ibm.com>,
	qemu-arm@nongnu.org, qemu-block@nongnu.org,
	qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
	qemu-s390x@nongnu.org, qemu-trivial@nongnu.org,
	"Fabien Chouteau" <chouteau@adacore.com>,
	"Alistair Francis" <alistair@alistair23.me>,
	"Aurelien Jarno" <aurelien@aurel32.net>,
	"Anthony Perard" <anthony.perard@citrix.com>,
	"Christian Borntraeger" <borntraeger@de.ibm.com>,
	"Marek Vasut" <marex@denx.de>,
	"Sagar Karandikar" <sagark@eecs.berkeley.edu>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Antony Pavlov" <antonynpavlov@gmail.com>,
	"Artyom Tarasenko" <atar4qemu@gmail.com>,
	"Andrzej Zaborowski" <balrogg@gmail.com>,
	"Beniamino Galvani" <b.galvani@gmail.com>,
	"Peter Crosthwaite" <crosthwaite.peter@gmail.com>,
	"Chris Wulff" <crwulff@gmail.com>,
	"Dmitry Fleytman" <dmitry.fleytman@gmail.com>,
	"Edgar E . Iglesias" <edgar.iglesias@gmail.com>,
	"Igor Mitsyanko" <i.mitsyanko@gmail.com>,
	"Max Filippov" <jcmvbkbc@gmail.com>,
	"Magnus Damm" <magnus.damm@gmail.com>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Subbaraya Sundeep" <sundeep.lkml@gmail.com>,
	"Alberto Garcia" <berto@igalia.com>,
	"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
	"Keith Busch" <keith.busch@intel.com>,
	"Stefano Stabellini" <sstabellini@kernel.org>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Stefan Berger" <stefanb@linux.vnet.ibm.com>,
	"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
	"Paul Burton" <paul.burton@mips.com>,
	"Yongbok Kim" <yongbok.kim@mips.com>,
	"Peter Chubb" <peter.chubb@nicta.com.au>,
	"Yuval Shaia" <yuval.shaia@oracle.com>,
	"Hervé Poussineau" <hpoussin@reactos.org>,
	"Alex Williamson" <alex.williamson@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Cornelia Huck" <cohuck@redhat.com>,
	"David Hildenbrand" <david@redhat.com>,
	"Eric Blake" <eblake@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Fam Zheng" <famz@redhat.com>,
	"Igor Mammedov" <imammedo@redhat.com>,
	"Jason Wang" <jasowang@redhat.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Kevin Wolf" <kwolf@redhat.com>, "Max Reitz" <mreitz@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Michael Clark" <mjc@sifive.com>,
	"Palmer Dabbelt" <palmer@sifive.com>,
	"Jiri Slaby" <jslaby@suse.cz>, "Alexander Graf" <agraf@suse.de>,
	"Richard Henderson" <rth@twiddle.net>,
	"Michael Walle" <michael@walle.cc>,
	"Jan Kiszka" <jan.kiszka@web.de>
Subject: Re: [Qemu-trivial] [PATCH v4 00/40] Use the IEC binary prefix definitions
Date: Mon, 11 Jun 2018 05:22:16 +0300	[thread overview]
Message-ID: <20180611052040-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20180611011501.10235-1-f4bug@amsat.org>

On Sun, Jun 10, 2018 at 10:14:21PM -0300, Philippe Mathieu-Daudé wrote:
> Hi,
> 
> This series:
> 
> - split the byte-based definitions from "qemu/cutils.h" to "qemu/units.h"
>   (this now triggers WARNING: 1 added file, does MAINTAINERS need updating?)
> - clean hw/ includes;
> - replace different constants used for byte size with their corresponding
>   IEC binary prefix definitions.
> 
> Since v3:
> - use IEC binary prefix definitions (Stefan Weil)
> - rebased
> - added R-b tags

It violates our coding style which requires KIB for macros.
But strangely, I like how this looks anyway.

So series

Reviewed-by: Michael S. Tsirkin <mst@redhat.com>


but I think you need to update the coding style explaining
that there's an exception.

> Since v2:
> - use "qemu/units.h" instead of "qemu/cunits.h" (Daniel P. Berrangé)
> - avoid rebuilding the world including "qemu/units.h" in "hw/hw.h" (Thomas Huth)
> - more constant replaced
> 
> Since v1:
> - corrected Xen mult -> div (Alan Robinson)
> - tagged 'include "qemu/cunits.h" in "hw/hw.h" as RFC
> - fixed mips_r4k 'params_size' (Thomas Huth)
> - added command used to generate patch in each commit (Alistair Francis)
> - use G_BYTE for the raspi3 machine
> - added Reviewed-by tags
> 
> Regards,
> 
> Phil.
> 
> Philippe Mathieu-Daudé (40):
>   include: Add IEC binary prefixes in "qemu/units.h"
>   vdi: Use definitions from "qemu/units.h"
>   x86/cpu: Use definitions from "qemu/units.h"
>   checkpatch: Recognize IEC binary prefix definitions
>   hw: Use IEC binary prefix definitions from "qemu/units.h"
>   hw: Directly use "qemu/units.h" instead of "qemu/cutils.h"
>   hw/ivshmem: Use the IEC binary prefix definitions
>   hw/ipack: Use the IEC binary prefix definitions
>   hw/scsi: Use the IEC binary prefix definitions
>   hw/smbios: Use the IEC binary prefix definitions
>   hw/xen: Use the IEC binary prefix definitions
>   hw/tpm: Use the IEC binary prefix definitions
>   hw/block: Use the IEC binary prefix definitions
>   hw/display: Use the IEC binary prefix definitions
>   hw/misc: Use the IEC binary prefix definitions
>   hw/riscv: Use the IEC binary prefix definitions
>   hw/m68k: Use the IEC binary prefix definitions
>   hw/sparc: Use the IEC binary prefix definitions
>   hw/s390x: Use the IEC binary prefix definitions
>   hw/hppa: Use the IEC binary prefix definitions
>   hw/xtensa: Use the IEC binary prefix definitions
>   hw/alpha: Use the IEC binary prefix definitions
>   hw/tricore: Use the IEC binary prefix definitions
>   hw/microblaze: Use the IEC binary prefix definitions
>   hw/nios2: Use the IEC binary prefix definitions
>   hw/cris: Use the IEC binary prefix definitions
>   hw/lm32: Use the IEC binary prefix definitions
>   hw/sh4: Use the IEC binary prefix definitions
>   hw/mips/r4k: Constify params_size
>   hw/mips: Use the IEC binary prefix definitions
>   hw/arm: Use the IEC binary prefix definitions
>   hw/ppc: Use the IEC binary prefix definitions
>   hw/i386: Use the IEC binary prefix definitions
>   hw/net: Use the IEC binary prefix definitions
>   hw/usb: Use the IEC binary prefix definitions
>   hw/sd: Use the IEC binary prefix definitions
>   hw/vfio: Use the IEC binary prefix definitions
>   hw/virtio: Use the IEC binary prefix definitions
>   hw/rdma: Use the IEC binary prefix definitions
>   cutils: Do not include "qemu/units.h" directly
> 
>  hw/net/ne2000.h                          |  5 ++--
>  hw/ppc/mac.h                             |  3 ++-
>  hw/rdma/vmw/pvrdma.h                     |  3 ++-
>  include/hw/acpi/tpm.h                    |  3 ++-
>  include/hw/arm/fsl-imx7.h                |  5 ++--
>  include/hw/arm/stm32f205_soc.h           |  5 ++--
>  include/hw/display/xlnx_dp.h             |  5 ++--
>  include/hw/i386/ich9.h                   |  3 ++-
>  include/hw/intc/mips_gic.h               |  3 ++-
>  include/hw/mips/bios.h                   |  3 ++-
>  include/hw/net/allwinner_emac.h          |  5 ++--
>  include/hw/ppc/spapr.h                   |  5 ++--
>  include/hw/virtio/virtio-net.h           |  3 ++-
>  include/qemu/cutils.h                    |  7 ------
>  include/qemu/units.h                     | 20 ++++++++++++++++
>  block/vdi.c                              |  8 +++----
>  hw/alpha/typhoon.c                       | 17 +++++++-------
>  hw/arm/bcm2835_peripherals.c             |  3 ++-
>  hw/arm/boot.c                            |  7 +++---
>  hw/arm/collie.c                          |  5 ++--
>  hw/arm/digic_boards.c                    |  7 +++---
>  hw/arm/exynos4_boards.c                  |  3 ++-
>  hw/arm/gumstix.c                         |  3 ++-
>  hw/arm/integratorcp.c                    |  3 ++-
>  hw/arm/mainstone.c                       |  3 ++-
>  hw/arm/msf2-soc.c                        |  6 ++---
>  hw/arm/msf2-som.c                        |  8 +++----
>  hw/arm/musicpal.c                        |  9 +++----
>  hw/arm/omap_sx1.c                        | 11 +++++----
>  hw/arm/raspi.c                           |  5 ++--
>  hw/arm/smmu-common.c                     |  3 ++-
>  hw/arm/stellaris.c                       |  5 ++--
>  hw/arm/versatilepb.c                     |  5 ++--
>  hw/arm/vexpress.c                        |  7 +++---
>  hw/arm/virt.c                            |  5 ++--
>  hw/arm/xilinx_zynq.c                     |  7 +++---
>  hw/block/m25p80.c                        |  5 ++--
>  hw/block/nvme.c                          |  3 ++-
>  hw/block/tc58128.c                       |  3 ++-
>  hw/block/xen_disk.c                      |  5 ++--
>  hw/core/loader-fit.c                     |  3 ++-
>  hw/core/machine.c                        |  4 ++--
>  hw/cris/axis_dev88.c                     |  3 ++-
>  hw/display/bochs-display.c               |  9 +++----
>  hw/display/cirrus_vga.c                  | 10 ++++----
>  hw/display/g364fb.c                      |  4 ++--
>  hw/display/qxl.c                         | 28 ++++++++++------------
>  hw/display/sm501.c                       | 16 ++++++-------
>  hw/display/vga-isa-mm.c                  |  5 ++--
>  hw/display/vga.c                         |  5 ++--
>  hw/display/virtio-gpu.c                  |  4 ++--
>  hw/display/vmware_vga.c                  |  3 ++-
>  hw/display/xenfb.c                       |  3 ++-
>  hw/hppa/dino.c                           |  3 ++-
>  hw/hppa/machine.c                        | 12 +++++-----
>  hw/i386/acpi-build.c                     |  5 ++--
>  hw/i386/pc.c                             | 19 ++++++++-------
>  hw/i386/pc_piix.c                        |  4 ++--
>  hw/i386/pc_q35.c                         |  3 ++-
>  hw/i386/pc_sysfw.c                       |  9 +++----
>  hw/i386/xen/xen-mapcache.c               |  3 ++-
>  hw/intc/apic_common.c                    |  3 ++-
>  hw/ipack/tpci200.c                       |  5 ++--
>  hw/lm32/lm32_boards.c                    | 13 +++++-----
>  hw/lm32/milkymist.c                      | 10 ++++----
>  hw/m68k/mcf5208.c                        |  3 ++-
>  hw/microblaze/petalogix_ml605_mmu.c      |  7 +++---
>  hw/microblaze/petalogix_s3adsp1800_mmu.c |  7 +++---
>  hw/mips/boston.c                         | 30 ++++++++++++------------
>  hw/mips/mips_fulong2e.c                  |  7 +++---
>  hw/mips/mips_malta.c                     | 23 ++++++++++--------
>  hw/mips/mips_r4k.c                       | 15 ++++++------
>  hw/misc/aspeed_sdmc.c                    |  9 +++----
>  hw/misc/auxbus.c                         |  3 ++-
>  hw/misc/edu.c                            |  3 ++-
>  hw/misc/imx7_gpr.c                       |  3 ++-
>  hw/misc/ivshmem.c                        |  3 ++-
>  hw/misc/mips_itu.c                       |  3 ++-
>  hw/misc/omap_gpmc.c                      |  5 ++--
>  hw/net/e1000e.c                          |  7 +++---
>  hw/net/e1000x_common.c                   |  3 ++-
>  hw/net/eepro100.c                        |  3 +--
>  hw/nios2/boot.c                          |  6 ++---
>  hw/nvram/spapr_nvram.c                   | 10 ++++----
>  hw/pci-host/designware.c                 |  3 ++-
>  hw/pci-host/gpex.c                       |  3 ++-
>  hw/pci-host/piix.c                       |  5 ++--
>  hw/pci-host/prep.c                       |  3 ++-
>  hw/pci-host/q35.c                        | 17 +++++++-------
>  hw/pci-host/xilinx-pcie.c                |  5 ++--
>  hw/ppc/e500.c                            | 13 +++++-----
>  hw/ppc/e500plat.c                        |  3 ++-
>  hw/ppc/mac_newworld.c                    |  1 -
>  hw/ppc/mac_oldworld.c                    |  9 ++++---
>  hw/ppc/pnv.c                             |  6 ++---
>  hw/ppc/ppc405_boards.c                   |  9 +++----
>  hw/ppc/ppc405_uc.c                       |  7 +++---
>  hw/ppc/ppc440_bamboo.c                   |  6 +++--
>  hw/ppc/ppc440_uc.c                       | 28 +++++++++++-----------
>  hw/ppc/ppc4xx_devs.c                     | 22 +++++++++--------
>  hw/ppc/ppce500_spin.c                    |  3 ++-
>  hw/ppc/prep.c                            |  6 ++---
>  hw/ppc/rs6000_mc.c                       | 13 +++++-----
>  hw/ppc/sam460ex.c                        | 20 +++++++++-------
>  hw/ppc/spapr.c                           | 12 +++++-----
>  hw/ppc/spapr_rtas.c                      |  2 +-
>  hw/ppc/virtex_ml507.c                    |  7 +++---
>  hw/riscv/virt.c                          |  3 ++-
>  hw/s390x/s390-skeys.c                    |  3 ++-
>  hw/s390x/s390-stattrib.c                 |  3 ++-
>  hw/s390x/sclp.c                          |  4 ++--
>  hw/scsi/scsi-disk.c                      |  9 +++----
>  hw/sd/sd.c                               |  8 +++----
>  hw/sd/sdhci.c                            |  6 ++---
>  hw/sh4/r2d.c                             |  3 ++-
>  hw/smbios/smbios.c                       | 15 +++++-------
>  hw/sparc/leon3.c                         |  9 +++----
>  hw/sparc/sun4m.c                         |  9 ++++---
>  hw/sparc64/niagara.c                     |  3 ++-
>  hw/sparc64/sun4u.c                       |  4 ++--
>  hw/ssi/aspeed_smc.c                      | 29 ++++++++++++-----------
>  hw/tricore/tricore_testboard.c           | 13 +++++-----
>  hw/usb/ccid-card-passthru.c              |  5 ++--
>  hw/usb/combined-packet.c                 |  3 ++-
>  hw/usb/dev-smartcard-reader.c            |  3 ++-
>  hw/usb/redirect.c                        |  3 ++-
>  hw/vfio/pci-quirks.c                     |  9 +++----
>  hw/vfio/pci.c                            |  3 ++-
>  hw/xenpv/xen_domainbuild.c               | 13 +++++-----
>  hw/xtensa/xtfpga.c                       |  5 ++--
>  target/i386/cpu.c                        |  4 +---
>  tests/test-cutils.c                      | 18 +++++++-------
>  tests/test-keyval.c                      |  6 ++---
>  tests/test-qemu-opts.c                   |  7 +++---
>  scripts/checkpatch.pl                    |  1 +
>  135 files changed, 533 insertions(+), 431 deletions(-)
>  create mode 100644 include/qemu/units.h
> 
> -- 
> 2.17.1


WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Dmitry Fleytman" <dmitry.fleytman@gmail.com>,
	"Jan Kiszka" <jan.kiszka@web.de>,
	"Sagar Karandikar" <sagark@eecs.berkeley.edu>,
	"David Hildenbrand" <david@redhat.com>,
	"Jason Wang" <jasowang@redhat.com>,
	"Palmer Dabbelt" <palmer@sifive.com>,
	"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
	qemu-devel@nongnu.org, "Alexander Graf" <agraf@suse.de>,
	"Keith Busch" <keith.busch@intel.com>,
	"Max Filippov" <jcmvbkbc@gmail.com>,
	"Michael Clark" <mjc@sifive.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Max Reitz" <mreitz@redhat.com>,
	"Yongbok Kim" <yongbok.kim@mips.com>,
	"Marek Vasut" <marex@denx.de>,
	"Stefano Stabellini" <sstabellini@kernel.org>,
	"Alberto Garcia" <berto@igalia.com>,
	qemu-block@nongnu.org,
	"Stefan Berger" <stefanb@linux.vnet.ibm.com>,
	qemu-trivial@nongnu.org, "Eric Blake" <eblake@redhat.com>,
	"Magnus Damm" <magnus.damm@gmail.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Michael Walle" <michael@walle.cc>,
	"Christian Borntraeger" <borntraeger@de.ibm.com>,
	"Hervé Poussineau" <hpoussin@reactos.org>,
	"Antony Pavlov" <antonynpavlov@gmail.com>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Anthony Perard" <anthony.perard@citrix.com>,
	"Richard Henderson" <rth@twiddle.net>,
	"Andrzej Zaborowski" <balrogg@gmail.com>,
	"Artyom Tarasenko" <atar4qemu@gmail.com>,
	"Thomas Huth" <thuth@redhat.com>, "Fam Zheng" <famz@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Nikunj A Dadhania" <nikunj@linux.vnet.ibm.com>,
	"Stefan Weil" <sw@weilnetz.de>,
	"Alistair Francis" <alistair@alistair23.me>,
	"Fabien Chouteau" <chouteau@adacore.com>,
	"Beniamino Galvani" <b.galvani@gmail.com>,
	qemu-s390x@nongnu.org, qemu-arm@nongnu.org,
	"Peter Chubb" <peter.chubb@nicta.com.au>,
	"Yuval Shaia" <yuval.shaia@oracle.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Jiri Slaby" <jslaby@suse.cz>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Kevin Wolf" <kwolf@redhat.com>,
	"Igor Mitsyanko" <i.mitsyanko@gmail.com>,
	"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
	"Chris Wulff" <crwulff@gmail.com>,
	"Alex Williamson" <alex.williamson@redhat.com>,
	"Subbaraya Sundeep" <sundeep.lkml@gmail.com>,
	"Paul Burton" <paul.burton@mips.com>,
	qemu-ppc@nongnu.org, "Cornelia Huck" <cohuck@redhat.com>,
	"Igor Mammedov" <imammedo@redhat.com>,
	"Aurelien Jarno" <aurelien@aurel32.net>
Subject: Re: [Qemu-arm] [PATCH v4 00/40] Use the IEC binary prefix definitions
Date: Mon, 11 Jun 2018 05:22:16 +0300	[thread overview]
Message-ID: <20180611052040-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20180611011501.10235-1-f4bug@amsat.org>

On Sun, Jun 10, 2018 at 10:14:21PM -0300, Philippe Mathieu-Daudé wrote:
> Hi,
> 
> This series:
> 
> - split the byte-based definitions from "qemu/cutils.h" to "qemu/units.h"
>   (this now triggers WARNING: 1 added file, does MAINTAINERS need updating?)
> - clean hw/ includes;
> - replace different constants used for byte size with their corresponding
>   IEC binary prefix definitions.
> 
> Since v3:
> - use IEC binary prefix definitions (Stefan Weil)
> - rebased
> - added R-b tags

It violates our coding style which requires KIB for macros.
But strangely, I like how this looks anyway.

So series

Reviewed-by: Michael S. Tsirkin <mst@redhat.com>


but I think you need to update the coding style explaining
that there's an exception.

> Since v2:
> - use "qemu/units.h" instead of "qemu/cunits.h" (Daniel P. Berrangé)
> - avoid rebuilding the world including "qemu/units.h" in "hw/hw.h" (Thomas Huth)
> - more constant replaced
> 
> Since v1:
> - corrected Xen mult -> div (Alan Robinson)
> - tagged 'include "qemu/cunits.h" in "hw/hw.h" as RFC
> - fixed mips_r4k 'params_size' (Thomas Huth)
> - added command used to generate patch in each commit (Alistair Francis)
> - use G_BYTE for the raspi3 machine
> - added Reviewed-by tags
> 
> Regards,
> 
> Phil.
> 
> Philippe Mathieu-Daudé (40):
>   include: Add IEC binary prefixes in "qemu/units.h"
>   vdi: Use definitions from "qemu/units.h"
>   x86/cpu: Use definitions from "qemu/units.h"
>   checkpatch: Recognize IEC binary prefix definitions
>   hw: Use IEC binary prefix definitions from "qemu/units.h"
>   hw: Directly use "qemu/units.h" instead of "qemu/cutils.h"
>   hw/ivshmem: Use the IEC binary prefix definitions
>   hw/ipack: Use the IEC binary prefix definitions
>   hw/scsi: Use the IEC binary prefix definitions
>   hw/smbios: Use the IEC binary prefix definitions
>   hw/xen: Use the IEC binary prefix definitions
>   hw/tpm: Use the IEC binary prefix definitions
>   hw/block: Use the IEC binary prefix definitions
>   hw/display: Use the IEC binary prefix definitions
>   hw/misc: Use the IEC binary prefix definitions
>   hw/riscv: Use the IEC binary prefix definitions
>   hw/m68k: Use the IEC binary prefix definitions
>   hw/sparc: Use the IEC binary prefix definitions
>   hw/s390x: Use the IEC binary prefix definitions
>   hw/hppa: Use the IEC binary prefix definitions
>   hw/xtensa: Use the IEC binary prefix definitions
>   hw/alpha: Use the IEC binary prefix definitions
>   hw/tricore: Use the IEC binary prefix definitions
>   hw/microblaze: Use the IEC binary prefix definitions
>   hw/nios2: Use the IEC binary prefix definitions
>   hw/cris: Use the IEC binary prefix definitions
>   hw/lm32: Use the IEC binary prefix definitions
>   hw/sh4: Use the IEC binary prefix definitions
>   hw/mips/r4k: Constify params_size
>   hw/mips: Use the IEC binary prefix definitions
>   hw/arm: Use the IEC binary prefix definitions
>   hw/ppc: Use the IEC binary prefix definitions
>   hw/i386: Use the IEC binary prefix definitions
>   hw/net: Use the IEC binary prefix definitions
>   hw/usb: Use the IEC binary prefix definitions
>   hw/sd: Use the IEC binary prefix definitions
>   hw/vfio: Use the IEC binary prefix definitions
>   hw/virtio: Use the IEC binary prefix definitions
>   hw/rdma: Use the IEC binary prefix definitions
>   cutils: Do not include "qemu/units.h" directly
> 
>  hw/net/ne2000.h                          |  5 ++--
>  hw/ppc/mac.h                             |  3 ++-
>  hw/rdma/vmw/pvrdma.h                     |  3 ++-
>  include/hw/acpi/tpm.h                    |  3 ++-
>  include/hw/arm/fsl-imx7.h                |  5 ++--
>  include/hw/arm/stm32f205_soc.h           |  5 ++--
>  include/hw/display/xlnx_dp.h             |  5 ++--
>  include/hw/i386/ich9.h                   |  3 ++-
>  include/hw/intc/mips_gic.h               |  3 ++-
>  include/hw/mips/bios.h                   |  3 ++-
>  include/hw/net/allwinner_emac.h          |  5 ++--
>  include/hw/ppc/spapr.h                   |  5 ++--
>  include/hw/virtio/virtio-net.h           |  3 ++-
>  include/qemu/cutils.h                    |  7 ------
>  include/qemu/units.h                     | 20 ++++++++++++++++
>  block/vdi.c                              |  8 +++----
>  hw/alpha/typhoon.c                       | 17 +++++++-------
>  hw/arm/bcm2835_peripherals.c             |  3 ++-
>  hw/arm/boot.c                            |  7 +++---
>  hw/arm/collie.c                          |  5 ++--
>  hw/arm/digic_boards.c                    |  7 +++---
>  hw/arm/exynos4_boards.c                  |  3 ++-
>  hw/arm/gumstix.c                         |  3 ++-
>  hw/arm/integratorcp.c                    |  3 ++-
>  hw/arm/mainstone.c                       |  3 ++-
>  hw/arm/msf2-soc.c                        |  6 ++---
>  hw/arm/msf2-som.c                        |  8 +++----
>  hw/arm/musicpal.c                        |  9 +++----
>  hw/arm/omap_sx1.c                        | 11 +++++----
>  hw/arm/raspi.c                           |  5 ++--
>  hw/arm/smmu-common.c                     |  3 ++-
>  hw/arm/stellaris.c                       |  5 ++--
>  hw/arm/versatilepb.c                     |  5 ++--
>  hw/arm/vexpress.c                        |  7 +++---
>  hw/arm/virt.c                            |  5 ++--
>  hw/arm/xilinx_zynq.c                     |  7 +++---
>  hw/block/m25p80.c                        |  5 ++--
>  hw/block/nvme.c                          |  3 ++-
>  hw/block/tc58128.c                       |  3 ++-
>  hw/block/xen_disk.c                      |  5 ++--
>  hw/core/loader-fit.c                     |  3 ++-
>  hw/core/machine.c                        |  4 ++--
>  hw/cris/axis_dev88.c                     |  3 ++-
>  hw/display/bochs-display.c               |  9 +++----
>  hw/display/cirrus_vga.c                  | 10 ++++----
>  hw/display/g364fb.c                      |  4 ++--
>  hw/display/qxl.c                         | 28 ++++++++++------------
>  hw/display/sm501.c                       | 16 ++++++-------
>  hw/display/vga-isa-mm.c                  |  5 ++--
>  hw/display/vga.c                         |  5 ++--
>  hw/display/virtio-gpu.c                  |  4 ++--
>  hw/display/vmware_vga.c                  |  3 ++-
>  hw/display/xenfb.c                       |  3 ++-
>  hw/hppa/dino.c                           |  3 ++-
>  hw/hppa/machine.c                        | 12 +++++-----
>  hw/i386/acpi-build.c                     |  5 ++--
>  hw/i386/pc.c                             | 19 ++++++++-------
>  hw/i386/pc_piix.c                        |  4 ++--
>  hw/i386/pc_q35.c                         |  3 ++-
>  hw/i386/pc_sysfw.c                       |  9 +++----
>  hw/i386/xen/xen-mapcache.c               |  3 ++-
>  hw/intc/apic_common.c                    |  3 ++-
>  hw/ipack/tpci200.c                       |  5 ++--
>  hw/lm32/lm32_boards.c                    | 13 +++++-----
>  hw/lm32/milkymist.c                      | 10 ++++----
>  hw/m68k/mcf5208.c                        |  3 ++-
>  hw/microblaze/petalogix_ml605_mmu.c      |  7 +++---
>  hw/microblaze/petalogix_s3adsp1800_mmu.c |  7 +++---
>  hw/mips/boston.c                         | 30 ++++++++++++------------
>  hw/mips/mips_fulong2e.c                  |  7 +++---
>  hw/mips/mips_malta.c                     | 23 ++++++++++--------
>  hw/mips/mips_r4k.c                       | 15 ++++++------
>  hw/misc/aspeed_sdmc.c                    |  9 +++----
>  hw/misc/auxbus.c                         |  3 ++-
>  hw/misc/edu.c                            |  3 ++-
>  hw/misc/imx7_gpr.c                       |  3 ++-
>  hw/misc/ivshmem.c                        |  3 ++-
>  hw/misc/mips_itu.c                       |  3 ++-
>  hw/misc/omap_gpmc.c                      |  5 ++--
>  hw/net/e1000e.c                          |  7 +++---
>  hw/net/e1000x_common.c                   |  3 ++-
>  hw/net/eepro100.c                        |  3 +--
>  hw/nios2/boot.c                          |  6 ++---
>  hw/nvram/spapr_nvram.c                   | 10 ++++----
>  hw/pci-host/designware.c                 |  3 ++-
>  hw/pci-host/gpex.c                       |  3 ++-
>  hw/pci-host/piix.c                       |  5 ++--
>  hw/pci-host/prep.c                       |  3 ++-
>  hw/pci-host/q35.c                        | 17 +++++++-------
>  hw/pci-host/xilinx-pcie.c                |  5 ++--
>  hw/ppc/e500.c                            | 13 +++++-----
>  hw/ppc/e500plat.c                        |  3 ++-
>  hw/ppc/mac_newworld.c                    |  1 -
>  hw/ppc/mac_oldworld.c                    |  9 ++++---
>  hw/ppc/pnv.c                             |  6 ++---
>  hw/ppc/ppc405_boards.c                   |  9 +++----
>  hw/ppc/ppc405_uc.c                       |  7 +++---
>  hw/ppc/ppc440_bamboo.c                   |  6 +++--
>  hw/ppc/ppc440_uc.c                       | 28 +++++++++++-----------
>  hw/ppc/ppc4xx_devs.c                     | 22 +++++++++--------
>  hw/ppc/ppce500_spin.c                    |  3 ++-
>  hw/ppc/prep.c                            |  6 ++---
>  hw/ppc/rs6000_mc.c                       | 13 +++++-----
>  hw/ppc/sam460ex.c                        | 20 +++++++++-------
>  hw/ppc/spapr.c                           | 12 +++++-----
>  hw/ppc/spapr_rtas.c                      |  2 +-
>  hw/ppc/virtex_ml507.c                    |  7 +++---
>  hw/riscv/virt.c                          |  3 ++-
>  hw/s390x/s390-skeys.c                    |  3 ++-
>  hw/s390x/s390-stattrib.c                 |  3 ++-
>  hw/s390x/sclp.c                          |  4 ++--
>  hw/scsi/scsi-disk.c                      |  9 +++----
>  hw/sd/sd.c                               |  8 +++----
>  hw/sd/sdhci.c                            |  6 ++---
>  hw/sh4/r2d.c                             |  3 ++-
>  hw/smbios/smbios.c                       | 15 +++++-------
>  hw/sparc/leon3.c                         |  9 +++----
>  hw/sparc/sun4m.c                         |  9 ++++---
>  hw/sparc64/niagara.c                     |  3 ++-
>  hw/sparc64/sun4u.c                       |  4 ++--
>  hw/ssi/aspeed_smc.c                      | 29 ++++++++++++-----------
>  hw/tricore/tricore_testboard.c           | 13 +++++-----
>  hw/usb/ccid-card-passthru.c              |  5 ++--
>  hw/usb/combined-packet.c                 |  3 ++-
>  hw/usb/dev-smartcard-reader.c            |  3 ++-
>  hw/usb/redirect.c                        |  3 ++-
>  hw/vfio/pci-quirks.c                     |  9 +++----
>  hw/vfio/pci.c                            |  3 ++-
>  hw/xenpv/xen_domainbuild.c               | 13 +++++-----
>  hw/xtensa/xtfpga.c                       |  5 ++--
>  target/i386/cpu.c                        |  4 +---
>  tests/test-cutils.c                      | 18 +++++++-------
>  tests/test-keyval.c                      |  6 ++---
>  tests/test-qemu-opts.c                   |  7 +++---
>  scripts/checkpatch.pl                    |  1 +
>  135 files changed, 533 insertions(+), 431 deletions(-)
>  create mode 100644 include/qemu/units.h
> 
> -- 
> 2.17.1

WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: "Thomas Huth" <thuth@redhat.com>, "Stefan Weil" <sw@weilnetz.de>,
	"Nikunj A Dadhania" <nikunj@linux.vnet.ibm.com>,
	qemu-arm@nongnu.org, qemu-block@nongnu.org,
	qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
	qemu-s390x@nongnu.org, qemu-trivial@nongnu.org,
	"Fabien Chouteau" <chouteau@adacore.com>,
	"Alistair Francis" <alistair@alistair23.me>,
	"Aurelien Jarno" <aurelien@aurel32.net>,
	"Anthony Perard" <anthony.perard@citrix.com>,
	"Christian Borntraeger" <borntraeger@de.ibm.com>,
	"Marek Vasut" <marex@denx.de>,
	"Sagar Karandikar" <sagark@eecs.berkeley.edu>,
	"David Gibson" <david@gibson.dropbear.id.au>,
	"Antony Pavlov" <antonynpavlov@gmail.com>,
	"Artyom Tarasenko" <atar4qemu@gmail.com>,
	"Andrzej Zaborowski" <balrogg@gmail.com>,
	"Beniamino Galvani" <b.galvani@gmail.com>,
	"Peter Crosthwaite" <crosthwaite.peter@gmail.com>,
	"Chris Wulff" <crwulff@gmail.com>,
	"Dmitry Fleytman" <dmitry.fleytman@gmail.com>,
	"Edgar E . Iglesias" <edgar.iglesias@gmail.com>,
	"Igor Mitsyanko" <i.mitsyanko@gmail.com>,
	"Max Filippov" <jcmvbkbc@gmail.com>,
	"Magnus Damm" <magnus.damm@gmail.com>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Subbaraya Sundeep" <sundeep.lkml@gmail.com>,
	"Alberto Garcia" <berto@igalia.com>,
	"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
	"Keith Busch" <keith.busch@intel.com>,
	"Stefano Stabellini" <sstabellini@kernel.org>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Stefan Berger" <stefanb@linux.vnet.ibm.com>,
	"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
	"Paul Burton" <paul.burton@mips.com>,
	"Yongbok Kim" <yongbok.kim@mips.com>,
	"Peter Chubb" <peter.chubb@nicta.com.au>,
	"Yuval Shaia" <yuval.shaia@oracle.com>,
	"Hervé Poussineau" <hpoussin@reactos.org>,
	"Alex Williamson" <alex.williamson@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	"Cornelia Huck" <cohuck@redhat.com>,
	"David Hildenbrand" <david@redhat.com>,
	"Eric Blake" <eblake@redhat.com>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Fam Zheng" <famz@redhat.com>,
	"Igor Mammedov" <imammedo@redhat.com>,
	"Jason Wang" <jasowang@redhat.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Kevin Wolf" <kwolf@redhat.com>, "Max Reitz" <mreitz@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Michael Clark" <mjc@sifive.com>,
	"Palmer Dabbelt" <palmer@sifive.com>,
	"Jiri Slaby" <jslaby@suse.cz>, "Alexander Graf" <agraf@suse.de>,
	"Richard Henderson" <rth@twiddle.net>,
	"Michael Walle" <michael@walle.cc>,
	"Jan Kiszka" <jan.kiszka@web.de>
Subject: Re: [Qemu-devel] [PATCH v4 00/40] Use the IEC binary prefix definitions
Date: Mon, 11 Jun 2018 05:22:16 +0300	[thread overview]
Message-ID: <20180611052040-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20180611011501.10235-1-f4bug@amsat.org>

On Sun, Jun 10, 2018 at 10:14:21PM -0300, Philippe Mathieu-Daudé wrote:
> Hi,
> 
> This series:
> 
> - split the byte-based definitions from "qemu/cutils.h" to "qemu/units.h"
>   (this now triggers WARNING: 1 added file, does MAINTAINERS need updating?)
> - clean hw/ includes;
> - replace different constants used for byte size with their corresponding
>   IEC binary prefix definitions.
> 
> Since v3:
> - use IEC binary prefix definitions (Stefan Weil)
> - rebased
> - added R-b tags

It violates our coding style which requires KIB for macros.
But strangely, I like how this looks anyway.

So series

Reviewed-by: Michael S. Tsirkin <mst@redhat.com>


but I think you need to update the coding style explaining
that there's an exception.

> Since v2:
> - use "qemu/units.h" instead of "qemu/cunits.h" (Daniel P. Berrangé)
> - avoid rebuilding the world including "qemu/units.h" in "hw/hw.h" (Thomas Huth)
> - more constant replaced
> 
> Since v1:
> - corrected Xen mult -> div (Alan Robinson)
> - tagged 'include "qemu/cunits.h" in "hw/hw.h" as RFC
> - fixed mips_r4k 'params_size' (Thomas Huth)
> - added command used to generate patch in each commit (Alistair Francis)
> - use G_BYTE for the raspi3 machine
> - added Reviewed-by tags
> 
> Regards,
> 
> Phil.
> 
> Philippe Mathieu-Daudé (40):
>   include: Add IEC binary prefixes in "qemu/units.h"
>   vdi: Use definitions from "qemu/units.h"
>   x86/cpu: Use definitions from "qemu/units.h"
>   checkpatch: Recognize IEC binary prefix definitions
>   hw: Use IEC binary prefix definitions from "qemu/units.h"
>   hw: Directly use "qemu/units.h" instead of "qemu/cutils.h"
>   hw/ivshmem: Use the IEC binary prefix definitions
>   hw/ipack: Use the IEC binary prefix definitions
>   hw/scsi: Use the IEC binary prefix definitions
>   hw/smbios: Use the IEC binary prefix definitions
>   hw/xen: Use the IEC binary prefix definitions
>   hw/tpm: Use the IEC binary prefix definitions
>   hw/block: Use the IEC binary prefix definitions
>   hw/display: Use the IEC binary prefix definitions
>   hw/misc: Use the IEC binary prefix definitions
>   hw/riscv: Use the IEC binary prefix definitions
>   hw/m68k: Use the IEC binary prefix definitions
>   hw/sparc: Use the IEC binary prefix definitions
>   hw/s390x: Use the IEC binary prefix definitions
>   hw/hppa: Use the IEC binary prefix definitions
>   hw/xtensa: Use the IEC binary prefix definitions
>   hw/alpha: Use the IEC binary prefix definitions
>   hw/tricore: Use the IEC binary prefix definitions
>   hw/microblaze: Use the IEC binary prefix definitions
>   hw/nios2: Use the IEC binary prefix definitions
>   hw/cris: Use the IEC binary prefix definitions
>   hw/lm32: Use the IEC binary prefix definitions
>   hw/sh4: Use the IEC binary prefix definitions
>   hw/mips/r4k: Constify params_size
>   hw/mips: Use the IEC binary prefix definitions
>   hw/arm: Use the IEC binary prefix definitions
>   hw/ppc: Use the IEC binary prefix definitions
>   hw/i386: Use the IEC binary prefix definitions
>   hw/net: Use the IEC binary prefix definitions
>   hw/usb: Use the IEC binary prefix definitions
>   hw/sd: Use the IEC binary prefix definitions
>   hw/vfio: Use the IEC binary prefix definitions
>   hw/virtio: Use the IEC binary prefix definitions
>   hw/rdma: Use the IEC binary prefix definitions
>   cutils: Do not include "qemu/units.h" directly
> 
>  hw/net/ne2000.h                          |  5 ++--
>  hw/ppc/mac.h                             |  3 ++-
>  hw/rdma/vmw/pvrdma.h                     |  3 ++-
>  include/hw/acpi/tpm.h                    |  3 ++-
>  include/hw/arm/fsl-imx7.h                |  5 ++--
>  include/hw/arm/stm32f205_soc.h           |  5 ++--
>  include/hw/display/xlnx_dp.h             |  5 ++--
>  include/hw/i386/ich9.h                   |  3 ++-
>  include/hw/intc/mips_gic.h               |  3 ++-
>  include/hw/mips/bios.h                   |  3 ++-
>  include/hw/net/allwinner_emac.h          |  5 ++--
>  include/hw/ppc/spapr.h                   |  5 ++--
>  include/hw/virtio/virtio-net.h           |  3 ++-
>  include/qemu/cutils.h                    |  7 ------
>  include/qemu/units.h                     | 20 ++++++++++++++++
>  block/vdi.c                              |  8 +++----
>  hw/alpha/typhoon.c                       | 17 +++++++-------
>  hw/arm/bcm2835_peripherals.c             |  3 ++-
>  hw/arm/boot.c                            |  7 +++---
>  hw/arm/collie.c                          |  5 ++--
>  hw/arm/digic_boards.c                    |  7 +++---
>  hw/arm/exynos4_boards.c                  |  3 ++-
>  hw/arm/gumstix.c                         |  3 ++-
>  hw/arm/integratorcp.c                    |  3 ++-
>  hw/arm/mainstone.c                       |  3 ++-
>  hw/arm/msf2-soc.c                        |  6 ++---
>  hw/arm/msf2-som.c                        |  8 +++----
>  hw/arm/musicpal.c                        |  9 +++----
>  hw/arm/omap_sx1.c                        | 11 +++++----
>  hw/arm/raspi.c                           |  5 ++--
>  hw/arm/smmu-common.c                     |  3 ++-
>  hw/arm/stellaris.c                       |  5 ++--
>  hw/arm/versatilepb.c                     |  5 ++--
>  hw/arm/vexpress.c                        |  7 +++---
>  hw/arm/virt.c                            |  5 ++--
>  hw/arm/xilinx_zynq.c                     |  7 +++---
>  hw/block/m25p80.c                        |  5 ++--
>  hw/block/nvme.c                          |  3 ++-
>  hw/block/tc58128.c                       |  3 ++-
>  hw/block/xen_disk.c                      |  5 ++--
>  hw/core/loader-fit.c                     |  3 ++-
>  hw/core/machine.c                        |  4 ++--
>  hw/cris/axis_dev88.c                     |  3 ++-
>  hw/display/bochs-display.c               |  9 +++----
>  hw/display/cirrus_vga.c                  | 10 ++++----
>  hw/display/g364fb.c                      |  4 ++--
>  hw/display/qxl.c                         | 28 ++++++++++------------
>  hw/display/sm501.c                       | 16 ++++++-------
>  hw/display/vga-isa-mm.c                  |  5 ++--
>  hw/display/vga.c                         |  5 ++--
>  hw/display/virtio-gpu.c                  |  4 ++--
>  hw/display/vmware_vga.c                  |  3 ++-
>  hw/display/xenfb.c                       |  3 ++-
>  hw/hppa/dino.c                           |  3 ++-
>  hw/hppa/machine.c                        | 12 +++++-----
>  hw/i386/acpi-build.c                     |  5 ++--
>  hw/i386/pc.c                             | 19 ++++++++-------
>  hw/i386/pc_piix.c                        |  4 ++--
>  hw/i386/pc_q35.c                         |  3 ++-
>  hw/i386/pc_sysfw.c                       |  9 +++----
>  hw/i386/xen/xen-mapcache.c               |  3 ++-
>  hw/intc/apic_common.c                    |  3 ++-
>  hw/ipack/tpci200.c                       |  5 ++--
>  hw/lm32/lm32_boards.c                    | 13 +++++-----
>  hw/lm32/milkymist.c                      | 10 ++++----
>  hw/m68k/mcf5208.c                        |  3 ++-
>  hw/microblaze/petalogix_ml605_mmu.c      |  7 +++---
>  hw/microblaze/petalogix_s3adsp1800_mmu.c |  7 +++---
>  hw/mips/boston.c                         | 30 ++++++++++++------------
>  hw/mips/mips_fulong2e.c                  |  7 +++---
>  hw/mips/mips_malta.c                     | 23 ++++++++++--------
>  hw/mips/mips_r4k.c                       | 15 ++++++------
>  hw/misc/aspeed_sdmc.c                    |  9 +++----
>  hw/misc/auxbus.c                         |  3 ++-
>  hw/misc/edu.c                            |  3 ++-
>  hw/misc/imx7_gpr.c                       |  3 ++-
>  hw/misc/ivshmem.c                        |  3 ++-
>  hw/misc/mips_itu.c                       |  3 ++-
>  hw/misc/omap_gpmc.c                      |  5 ++--
>  hw/net/e1000e.c                          |  7 +++---
>  hw/net/e1000x_common.c                   |  3 ++-
>  hw/net/eepro100.c                        |  3 +--
>  hw/nios2/boot.c                          |  6 ++---
>  hw/nvram/spapr_nvram.c                   | 10 ++++----
>  hw/pci-host/designware.c                 |  3 ++-
>  hw/pci-host/gpex.c                       |  3 ++-
>  hw/pci-host/piix.c                       |  5 ++--
>  hw/pci-host/prep.c                       |  3 ++-
>  hw/pci-host/q35.c                        | 17 +++++++-------
>  hw/pci-host/xilinx-pcie.c                |  5 ++--
>  hw/ppc/e500.c                            | 13 +++++-----
>  hw/ppc/e500plat.c                        |  3 ++-
>  hw/ppc/mac_newworld.c                    |  1 -
>  hw/ppc/mac_oldworld.c                    |  9 ++++---
>  hw/ppc/pnv.c                             |  6 ++---
>  hw/ppc/ppc405_boards.c                   |  9 +++----
>  hw/ppc/ppc405_uc.c                       |  7 +++---
>  hw/ppc/ppc440_bamboo.c                   |  6 +++--
>  hw/ppc/ppc440_uc.c                       | 28 +++++++++++-----------
>  hw/ppc/ppc4xx_devs.c                     | 22 +++++++++--------
>  hw/ppc/ppce500_spin.c                    |  3 ++-
>  hw/ppc/prep.c                            |  6 ++---
>  hw/ppc/rs6000_mc.c                       | 13 +++++-----
>  hw/ppc/sam460ex.c                        | 20 +++++++++-------
>  hw/ppc/spapr.c                           | 12 +++++-----
>  hw/ppc/spapr_rtas.c                      |  2 +-
>  hw/ppc/virtex_ml507.c                    |  7 +++---
>  hw/riscv/virt.c                          |  3 ++-
>  hw/s390x/s390-skeys.c                    |  3 ++-
>  hw/s390x/s390-stattrib.c                 |  3 ++-
>  hw/s390x/sclp.c                          |  4 ++--
>  hw/scsi/scsi-disk.c                      |  9 +++----
>  hw/sd/sd.c                               |  8 +++----
>  hw/sd/sdhci.c                            |  6 ++---
>  hw/sh4/r2d.c                             |  3 ++-
>  hw/smbios/smbios.c                       | 15 +++++-------
>  hw/sparc/leon3.c                         |  9 +++----
>  hw/sparc/sun4m.c                         |  9 ++++---
>  hw/sparc64/niagara.c                     |  3 ++-
>  hw/sparc64/sun4u.c                       |  4 ++--
>  hw/ssi/aspeed_smc.c                      | 29 ++++++++++++-----------
>  hw/tricore/tricore_testboard.c           | 13 +++++-----
>  hw/usb/ccid-card-passthru.c              |  5 ++--
>  hw/usb/combined-packet.c                 |  3 ++-
>  hw/usb/dev-smartcard-reader.c            |  3 ++-
>  hw/usb/redirect.c                        |  3 ++-
>  hw/vfio/pci-quirks.c                     |  9 +++----
>  hw/vfio/pci.c                            |  3 ++-
>  hw/xenpv/xen_domainbuild.c               | 13 +++++-----
>  hw/xtensa/xtfpga.c                       |  5 ++--
>  target/i386/cpu.c                        |  4 +---
>  tests/test-cutils.c                      | 18 +++++++-------
>  tests/test-keyval.c                      |  6 ++---
>  tests/test-qemu-opts.c                   |  7 +++---
>  scripts/checkpatch.pl                    |  1 +
>  135 files changed, 533 insertions(+), 431 deletions(-)
>  create mode 100644 include/qemu/units.h
> 
> -- 
> 2.17.1

  parent reply	other threads:[~2018-06-11 12:54 UTC|newest]

Thread overview: 147+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-11  1:14 [Qemu-trivial] [PATCH v4 00/40] Use the IEC binary prefix definitions Philippe Mathieu-Daudé
2018-06-11  1:14 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11  1:14 ` [Qemu-arm] " Philippe Mathieu-Daudé
2018-06-11  1:14 ` [Qemu-trivial] [PATCH v4 01/40] include: Add IEC binary prefixes in "qemu/units.h" Philippe Mathieu-Daudé
2018-06-11  1:14   ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-12 20:42   ` [Qemu-trivial] " Richard Henderson
2018-06-12 20:42     ` Richard Henderson
2018-06-11  1:14 ` [Qemu-trivial] [PATCH v4 02/40] vdi: Use definitions from "qemu/units.h" Philippe Mathieu-Daudé
2018-06-11  1:14   ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11 19:27   ` [Qemu-trivial] " Stefan Weil
2018-06-11 19:27     ` Stefan Weil
2018-06-11  1:14 ` [Qemu-trivial] [PATCH v4 03/40] x86/cpu: " Philippe Mathieu-Daudé
2018-06-11  1:14   ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11 18:42   ` [Qemu-trivial] " Eduardo Habkost
2018-06-11 18:42     ` [Qemu-devel] " Eduardo Habkost
2018-06-11  1:14 ` [Qemu-trivial] [PATCH v4 04/40] checkpatch: Recognize IEC binary prefix definitions Philippe Mathieu-Daudé
2018-06-11  1:14   ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-13 19:54   ` [Qemu-trivial] " Philippe Mathieu-Daudé
2018-06-13 19:54     ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11  1:14 ` [Qemu-trivial] [PATCH v4 05/40] hw: Use IEC binary prefix definitions from "qemu/units.h" Philippe Mathieu-Daudé
2018-06-11  1:14   ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11  1:14   ` Philippe Mathieu-Daudé
2018-06-11  2:11   ` [Qemu-trivial] " David Gibson
2018-06-11  2:11     ` [Qemu-devel] " David Gibson
2018-06-11  2:11     ` David Gibson
2018-06-11  1:14 ` [Qemu-trivial] [PATCH v4 06/40] hw: Directly use "qemu/units.h" instead of "qemu/cutils.h" Philippe Mathieu-Daudé
2018-06-11  1:14   ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11  1:14   ` Philippe Mathieu-Daudé
2018-06-11  2:16   ` [Qemu-trivial] " David Gibson
2018-06-11  2:16     ` [Qemu-devel] " David Gibson
2018-06-11  2:16     ` David Gibson
2018-06-11  1:14 ` [Qemu-trivial] [PATCH v4 07/40] hw/ivshmem: Use the IEC binary prefix definitions Philippe Mathieu-Daudé
2018-06-11  1:14   ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11  1:14 ` [Qemu-trivial] [PATCH v4 08/40] hw/ipack: " Philippe Mathieu-Daudé
2018-06-11  1:14   ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11  1:14 ` [Qemu-trivial] [PATCH v4 09/40] hw/scsi: " Philippe Mathieu-Daudé
2018-06-11  1:14   ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11  1:14 ` [Qemu-trivial] [PATCH v4 10/40] hw/smbios: " Philippe Mathieu-Daudé
2018-06-11  1:14   ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11  1:14 ` [Qemu-trivial] [PATCH v4 11/40] hw/xen: " Philippe Mathieu-Daudé
2018-06-11  1:14   ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11  1:14   ` Philippe Mathieu-Daudé
2018-06-12 20:51   ` [Qemu-devel] " Richard Henderson
2018-06-12 20:51   ` [Qemu-trivial] " Richard Henderson
2018-06-12 20:51     ` Richard Henderson
2018-06-12 21:04     ` Eric Blake
2018-06-12 21:04     ` [Qemu-trivial] " Eric Blake
2018-06-12 21:04       ` Eric Blake
2018-06-12 21:10       ` Richard Henderson
2018-06-12 21:10       ` [Qemu-trivial] " Richard Henderson
2018-06-12 21:10         ` Richard Henderson
2018-06-13 12:13         ` Eric Blake
2018-06-13 12:13         ` [Qemu-trivial] " Eric Blake
2018-06-13 12:13           ` Eric Blake
2018-06-13 19:31           ` Richard Henderson
2018-06-13 19:31           ` [Qemu-trivial] " Richard Henderson
2018-06-13 19:31             ` Richard Henderson
2018-06-13 20:02             ` [Qemu-trivial] " Philippe Mathieu-Daudé
2018-06-13 20:02               ` Philippe Mathieu-Daudé
2018-06-11  1:14 ` [Qemu-trivial] [PATCH v4 12/40] hw/tpm: " Philippe Mathieu-Daudé
2018-06-11  1:14   ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11  1:14 ` [Qemu-trivial] [PATCH v4 13/40] hw/block: " Philippe Mathieu-Daudé
2018-06-11  1:14   ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11  1:14 ` [Qemu-trivial] [PATCH v4 14/40] hw/display: " Philippe Mathieu-Daudé
2018-06-11  1:14   ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11  1:14   ` Philippe Mathieu-Daudé
2018-06-11  1:14   ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11  1:14 ` [Qemu-trivial] [PATCH v4 15/40] hw/misc: " Philippe Mathieu-Daudé
2018-06-11  1:14   ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11  1:14 ` [Qemu-trivial] [PATCH v4 16/40] hw/riscv: " Philippe Mathieu-Daudé
2018-06-11  1:14   ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11  1:22   ` [Qemu-trivial] " Michael Clark
2018-06-11  1:22     ` [Qemu-devel] " Michael Clark
2018-06-11  1:14 ` [Qemu-trivial] [PATCH v4 17/40] hw/m68k: " Philippe Mathieu-Daudé
2018-06-11  1:14   ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11  1:14 ` [Qemu-trivial] [PATCH v4 18/40] hw/sparc: " Philippe Mathieu-Daudé
2018-06-11  1:14   ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11  1:14 ` [Qemu-trivial] [PATCH v4 19/40] hw/s390x: " Philippe Mathieu-Daudé
2018-06-11  1:14   ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11  1:14 ` [Qemu-trivial] [PATCH v4 20/40] hw/hppa: " Philippe Mathieu-Daudé
2018-06-11  1:14   ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11  1:14 ` [Qemu-trivial] [PATCH v4 21/40] hw/xtensa: " Philippe Mathieu-Daudé
2018-06-11  1:14   ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11  1:14 ` [Qemu-trivial] [PATCH v4 22/40] hw/alpha: " Philippe Mathieu-Daudé
2018-06-11  1:14   ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11  1:14 ` [Qemu-trivial] [PATCH v4 23/40] hw/tricore: " Philippe Mathieu-Daudé
2018-06-11  1:14   ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11  1:14 ` [Qemu-trivial] [PATCH v4 24/40] hw/microblaze: " Philippe Mathieu-Daudé
2018-06-11  1:14   ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11  1:14 ` [Qemu-trivial] [PATCH v4 25/40] hw/nios2: " Philippe Mathieu-Daudé
2018-06-11  1:14   ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11  1:14 ` [Qemu-trivial] [PATCH v4 26/40] hw/cris: " Philippe Mathieu-Daudé
2018-06-11  1:14   ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11  1:14 ` [Qemu-trivial] [PATCH v4 27/40] hw/lm32: " Philippe Mathieu-Daudé
2018-06-11  1:14   ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11  1:14 ` [Qemu-trivial] [PATCH v4 28/40] hw/sh4: " Philippe Mathieu-Daudé
2018-06-11  1:14   ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11  1:14 ` [Qemu-trivial] [PATCH v4 29/40] hw/mips/r4k: Constify params_size Philippe Mathieu-Daudé
2018-06-11  1:14   ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11  1:14 ` [Qemu-trivial] [PATCH v4 30/40] hw/mips: Use the IEC binary prefix definitions Philippe Mathieu-Daudé
2018-06-11  1:14   ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11  1:14 ` [Qemu-trivial] [PATCH v4 32/40] hw/ppc: " Philippe Mathieu-Daudé
2018-06-11  1:14   ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11  8:09   ` [Qemu-trivial] [Qemu-ppc] " BALATON Zoltan
2018-06-11  8:09     ` [Qemu-devel] " BALATON Zoltan
2018-06-11 15:44     ` [Qemu-trivial] " Philippe Mathieu-Daudé
2018-06-11 15:44       ` Philippe Mathieu-Daudé
2018-06-11  1:14 ` [Qemu-trivial] [PATCH v4 34/40] hw/net: " Philippe Mathieu-Daudé
2018-06-11  1:14   ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11  1:14   ` Philippe Mathieu-Daudé
2018-06-11 19:20   ` [Qemu-trivial] " Stefan Weil
2018-06-11 19:20     ` Stefan Weil
2018-06-11 19:20     ` [Qemu-arm] " Stefan Weil
2018-06-11  1:14 ` [Qemu-trivial] [PATCH v4 35/40] hw/usb: " Philippe Mathieu-Daudé
2018-06-11  1:14   ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11  1:14 ` [Qemu-trivial] [PATCH v4 36/40] hw/sd: " Philippe Mathieu-Daudé
2018-06-11  1:14   ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11  1:14 ` [Qemu-trivial] [PATCH v4 37/40] hw/vfio: " Philippe Mathieu-Daudé
2018-06-11  1:14   ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11  1:14 ` [Qemu-trivial] [PATCH v4 38/40] hw/virtio: " Philippe Mathieu-Daudé
2018-06-11  1:14   ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11  1:15 ` [Qemu-trivial] [PATCH v4 39/40] hw/rdma: " Philippe Mathieu-Daudé
2018-06-11  1:15   ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11  1:15 ` [Qemu-trivial] [PATCH v4 40/40] cutils: Do not include "qemu/units.h" directly Philippe Mathieu-Daudé
2018-06-11  1:15   ` [Qemu-devel] " Philippe Mathieu-Daudé
     [not found] ` <20180611011501.10235-34-f4bug@amsat.org>
2018-06-11  2:18   ` [Qemu-trivial] [PATCH v4 33/40] hw/i386: Use the IEC binary prefix definitions Michael S. Tsirkin
2018-06-11  2:18     ` [Qemu-devel] " Michael S. Tsirkin
2018-06-11  2:29     ` [Qemu-trivial] " Philippe Mathieu-Daudé
2018-06-11  2:29       ` Philippe Mathieu-Daudé
2018-06-11  2:22 ` Michael S. Tsirkin [this message]
2018-06-11  2:22   ` [Qemu-devel] [PATCH v4 00/40] " Michael S. Tsirkin
2018-06-11  2:22   ` [Qemu-arm] " Michael S. Tsirkin
2018-06-11  2:32   ` [Qemu-trivial] " Philippe Mathieu-Daudé
2018-06-11  2:32     ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-06-11  2:32     ` Philippe Mathieu-Daudé
2018-06-11 15:55 ` [Qemu-trivial] " Eric Blake
2018-06-11 15:55   ` [Qemu-devel] " Eric Blake
2018-06-11 15:55   ` [Qemu-arm] " Eric Blake
2018-06-11 16:11   ` [Qemu-trivial] " Peter Maydell
2018-06-11 16:11     ` [Qemu-devel] " Peter Maydell
2018-06-11 16:11     ` [Qemu-arm] " Peter Maydell
2018-06-11 16:27   ` [Qemu-trivial] " Michael S. Tsirkin
2018-06-11 16:27     ` [Qemu-devel] " Michael S. Tsirkin
2018-06-11 16:27     ` [Qemu-arm] " Michael S. Tsirkin
2018-06-11 16:18 ` [Qemu-trivial] " Cornelia Huck
2018-06-11 16:18   ` [Qemu-devel] " Cornelia Huck
2018-06-11 16:18   ` [Qemu-arm] " Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180611052040-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=agraf@suse.de \
    --cc=alex.williamson@redhat.com \
    --cc=alistair@alistair23.me \
    --cc=anthony.perard@citrix.com \
    --cc=antonynpavlov@gmail.com \
    --cc=armbru@redhat.com \
    --cc=atar4qemu@gmail.com \
    --cc=aurelien@aurel32.net \
    --cc=b.galvani@gmail.com \
    --cc=balrogg@gmail.com \
    --cc=berto@igalia.com \
    --cc=borntraeger@de.ibm.com \
    --cc=chouteau@adacore.com \
    --cc=cohuck@redhat.com \
    --cc=crosthwaite.peter@gmail.com \
    --cc=crwulff@gmail.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=david@redhat.com \
    --cc=dmitry.fleytman@gmail.com \
    --cc=eblake@redhat.com \
    --cc=edgar.iglesias@gmail.com \
    --cc=ehabkost@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=famz@redhat.com \
    --cc=hpoussin@reactos.org \
    --cc=i.mitsyanko@gmail.com \
    --cc=imammedo@redhat.com \
    --cc=jan.kiszka@web.de \
    --cc=jasowang@redhat.com \
    --cc=jcmvbkbc@gmail.com \
    --cc=jslaby@suse.cz \
    --cc=kbastian@mail.uni-paderborn.de \
    --cc=keith.busch@intel.com \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=magnus.damm@gmail.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=marex@denx.de \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=michael@walle.cc \
    --cc=mjc@sifive.com \
    --cc=mreitz@redhat.com \
    --cc=nikunj@linux.vnet.ibm.com \
    --cc=palmer@sifive.com \
    --cc=paul.burton@mips.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.chubb@nicta.com.au \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=sagark@eecs.berkeley.edu \
    --cc=sstabellini@kernel.org \
    --cc=stefanb@linux.vnet.ibm.com \
    --cc=sundeep.lkml@gmail.com \
    --cc=sw@weilnetz.de \
    --cc=thuth@redhat.com \
    --cc=yongbok.kim@mips.com \
    --cc=yuval.shaia@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.