From: Vinod Koul <vkoul@kernel.org>
To: Li Yang <leoyang.li@nxp.com>
Cc: Wen He <wen.he_1@nxp.com>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, Jiafei Pan <jiafei.pan@nxp.com>,
Jiaheng Fan <jiaheng.fan@nxp.com>
Subject: [v5,2/6] dmaengine: fsl-qdma: Add qDMA controller driver for Layerscape SoCs
Date: Tue, 12 Jun 2018 09:30:31 +0530 [thread overview]
Message-ID: <20180612040031.GI2452@vkoul-mobl> (raw)
On 05-06-18, 12:24, Li Yang wrote:
> On Tue, Jun 5, 2018 at 11:30 AM, Vinod <vkoul@kernel.org> wrote:
> > On 04-06-18, 09:53, Wen He wrote:
> >
> >>
> >> > > +// SPDX-License-Identifier: GPL-2.0
> >> > > +// Copyright 2018 NXP
> >> >
> >> > I know the SPDX tag is recommended to be the 1st line, but copyright normally
> >> > goes below the file description not above.
> >
> > I do not think that is specified anywhere.. can you point it?
>
> No. It is not documented. But the majority of the source files in
> Linux are using this header format like below, so I assume it is
> something like a convention.
>
> /*
> * {filename --} file description
> *
> * Copyright ...
> *
> * License ...
> */
>
> The Documentation/process/license-rules.rst only mentioned about the
> requirement for SPDX tags. So I think we should keep the format for
> other part of the header.
And Linus said this https://lkml.org/lkml/2017/11/25/133
WARNING: multiple messages have this Message-ID (diff)
From: Vinod <vkoul@kernel.org>
To: Li Yang <leoyang.li@nxp.com>
Cc: Wen He <wen.he_1@nxp.com>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, Jiafei Pan <jiafei.pan@nxp.com>,
Jiaheng Fan <jiaheng.fan@nxp.com>
Subject: Re: [v5 2/6] dmaengine: fsl-qdma: Add qDMA controller driver for Layerscape SoCs
Date: Tue, 12 Jun 2018 09:30:31 +0530 [thread overview]
Message-ID: <20180612040031.GI2452@vkoul-mobl> (raw)
In-Reply-To: <CADRPPNQzn=1Nvp0h3xdTU7DdwFKN1grxyUKhESCV5u8V9FeMjg@mail.gmail.com>
On 05-06-18, 12:24, Li Yang wrote:
> On Tue, Jun 5, 2018 at 11:30 AM, Vinod <vkoul@kernel.org> wrote:
> > On 04-06-18, 09:53, Wen He wrote:
> >
> >>
> >> > > +// SPDX-License-Identifier: GPL-2.0
> >> > > +// Copyright 2018 NXP
> >> >
> >> > I know the SPDX tag is recommended to be the 1st line, but copyright normally
> >> > goes below the file description not above.
> >
> > I do not think that is specified anywhere.. can you point it?
>
> No. It is not documented. But the majority of the source files in
> Linux are using this header format like below, so I assume it is
> something like a convention.
>
> /*
> * {filename --} file description
> *
> * Copyright ...
> *
> * License ...
> */
>
> The Documentation/process/license-rules.rst only mentioned about the
> requirement for SPDX tags. So I think we should keep the format for
> other part of the header.
And Linus said this https://lkml.org/lkml/2017/11/25/133
--
~Vinod
next reply other threads:[~2018-06-12 4:00 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-12 4:00 Vinod Koul [this message]
2018-06-12 4:00 ` [v5 2/6] dmaengine: fsl-qdma: Add qDMA controller driver for Layerscape SoCs Vinod
-- strict thread matches above, loose matches on Subject: below --
2018-06-14 7:26 [v5,2/6] " Vinod Koul
2018-06-14 7:26 ` [v5 2/6] " Vinod
2018-06-14 2:15 [v5,2/6] " Wen He
2018-06-14 2:15 ` [v5 2/6] " Wen He
2018-06-12 16:32 [v5,2/6] " Li Yang
2018-06-12 16:32 ` [v5 2/6] " Li Yang
2018-06-11 8:14 [v5,2/6] " Wen He
2018-06-11 8:14 ` [v5 2/6] " Wen He
2018-06-05 17:24 [v5,2/6] " Li Yang
2018-06-05 17:24 ` [v5 2/6] " Li Yang
2018-06-05 16:30 [v5,2/6] " Vinod Koul
2018-06-05 16:30 ` [v5 2/6] " Vinod
2018-06-05 16:28 [v5,2/6] " Vinod Koul
2018-06-05 16:28 ` [v5 2/6] " Vinod
2018-06-04 9:53 [v5,2/6] " Wen He
2018-06-04 9:53 ` [v5 2/6] " Wen He
2018-05-31 1:58 [v5,2/6] " Wen He
2018-05-31 1:58 ` [v5 2/6] " Wen He
2018-05-31 0:49 [v5,3/6] dt-bindings: fsl-qdma: Add NXP Layerscpae qDMA controller bindings Rob Herring
2018-05-31 0:49 ` [v5 3/6] " Rob Herring
2018-05-30 18:51 [v5,2/6] dmaengine: fsl-qdma: Add qDMA controller driver for Layerscape SoCs Li Yang
2018-05-30 18:51 ` [v5 2/6] " Li Yang
2018-05-30 10:27 [v5,2/6] " Vinod Koul
2018-05-30 10:27 ` [v5 2/6] " Vinod Koul
2018-05-29 10:38 [v5,2/6] " Wen He
2018-05-29 10:38 ` [v5 2/6] " Wen He
2018-05-29 10:22 [v5,1/6] dmaengine: fsldma: Replace DMA_IN/OUT by FSL_DMA_IN/OUT Wen He
2018-05-29 10:22 ` [v5 1/6] " Wen He
2018-05-29 10:21 [v5,1/6] " Vinod Koul
2018-05-29 10:21 ` [v5 1/6] " Vinod
2018-05-29 10:19 [v5,2/6] dmaengine: fsl-qdma: Add qDMA controller driver for Layerscape SoCs Vinod Koul
2018-05-29 10:19 ` [v5 2/6] " Vinod
2018-05-29 10:14 [v5,1/6] dmaengine: fsldma: Replace DMA_IN/OUT by FSL_DMA_IN/OUT Wen He
2018-05-29 10:14 ` [v5 1/6] " Wen He
2018-05-29 9:59 [v5,2/6] dmaengine: fsl-qdma: Add qDMA controller driver for Layerscape SoCs Wen He
2018-05-29 9:59 ` [v5 2/6] " Wen He
2018-05-29 7:07 [v5,2/6] " Vinod Koul
2018-05-29 7:07 ` [v5 2/6] " Vinod
2018-05-29 4:49 [v5,1/6] dmaengine: fsldma: Replace DMA_IN/OUT by FSL_DMA_IN/OUT Vinod Koul
2018-05-29 4:49 ` [v5 1/6] " Vinod
2018-05-25 11:19 [v5,6/6] arm: dts: ls1021a: add qdma device tree nodes Wen He
2018-05-25 11:19 ` [v5 6/6] " Wen He
2018-05-25 11:19 [v5,5/6] arm64: dts: ls1046a: " Wen He
2018-05-25 11:19 ` [v5 5/6] " Wen He
2018-05-25 11:19 [v5,4/6] arm64: dts: ls1043a: " Wen He
2018-05-25 11:19 ` [v5 4/6] " Wen He
2018-05-25 11:19 [v5,3/6] dt-bindings: fsl-qdma: Add NXP Layerscpae qDMA controller bindings Wen He
2018-05-25 11:19 ` [v5 3/6] " Wen He
2018-05-25 11:19 [v5,2/6] dmaengine: fsl-qdma: Add qDMA controller driver for Layerscape SoCs Wen He
2018-05-25 11:19 ` [v5 2/6] " Wen He
2018-05-25 11:19 [v5,1/6] dmaengine: fsldma: Replace DMA_IN/OUT by FSL_DMA_IN/OUT Wen He
2018-05-25 11:19 ` [v5 1/6] " Wen He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180612040031.GI2452@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=jiafei.pan@nxp.com \
--cc=jiaheng.fan@nxp.com \
--cc=leoyang.li@nxp.com \
--cc=robh+dt@kernel.org \
--cc=wen.he_1@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.