All of lore.kernel.org
 help / color / mirror / Atom feed
* [v2] Fixed a checkpatch error
  2018-06-14  6:32 ` [PATCH v2] " Parth Y Shah
@ 2018-06-14  6:42 ` Greg KH
  -1 siblings, 0 replies; 10+ messages in thread
From: Greg Kroah-Hartman @ 2018-06-14  6:42 UTC (permalink / raw)
  To: Parth Y Shah; +Cc: balbi, linux-usb, linux-kernel

On Thu, Jun 14, 2018 at 12:02:46PM +0530, Parth Y Shah wrote:
> ERROR: code indent should use tabs where possible
> 
> Here, spaces are replaced by a tab in 2 lines.
> 
> Signed-off-by: Parth Y Shah <sparth1292@gmail.com>

Your subject line needs work, please see how other subject lines are
composed for this subsystem.

Also note, please do not use anything but the drivers/staging/ area of
the kernel for beginning "I'm going to do checkpatch cleanups" type of
"learning to get changes into the kernel" work.  That is a great place
to start with this, not in other subsystems where you might have
reviewers who do not care so much about whitespace cleanups like this.

So please learn the process there, and when you have it all working
well, then you could move on to other subsystems and areas of the
kernel, like this one, if you want to.

thanks,

greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [v2] Fixed a checkpatch error
  2018-06-13 12:32 ` [PATCH] " Joe Perches
@ 2018-06-14  6:32 ` Parth Y Shah
  -1 siblings, 0 replies; 10+ messages in thread
From: Parth Y Shah @ 2018-06-14  6:32 UTC (permalink / raw)
  To: balbi, gregkh, linux-usb; +Cc: linux-kernel, Parth Y Shah

ERROR: code indent should use tabs where possible

Here, spaces are replaced by a tab in 2 lines.

Signed-off-by: Parth Y Shah <sparth1292@gmail.com>
---
Changes since v1:
 * Updated commit description
 * Removed one extra tab and replaced spaces with tab to resolve
   checkpatch error

 drivers/usb/gadget/configfs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
index efba66c..0251299 100644
--- a/drivers/usb/gadget/configfs.c
+++ b/drivers/usb/gadget/configfs.c
@@ -1217,8 +1217,8 @@ static void purge_configs_funcs(struct gadget_info *gi)
 			list_move_tail(&f->list, &cfg->func_list);
 			if (f->unbind) {
 				dev_dbg(&gi->cdev.gadget->dev,
-				         "unbind function '%s'/%p\n",
-				         f->name, f);
+					"unbind function '%s'/%p\n",
+					f->name, f);
 				f->unbind(c, f);
 			}
 		}

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* Fixed an indentation error
  2018-06-13 12:25 ` [PATCH] " Parth Y Shah
@ 2018-06-13 12:36 ` Greg KH
  -1 siblings, 0 replies; 10+ messages in thread
From: Greg Kroah-Hartman @ 2018-06-13 12:36 UTC (permalink / raw)
  To: Parth Y Shah; +Cc: balbi, linux-usb, linux-kernel

On Wed, Jun 13, 2018 at 05:55:10PM +0530, Parth Y Shah wrote:
> Signed-off-by: Parth Y Shah <sparth1292@gmail.com>
> ---
>  drivers/usb/gadget/configfs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
> index efba66c..0675b4a 100644
> --- a/drivers/usb/gadget/configfs.c
> +++ b/drivers/usb/gadget/configfs.c
> @@ -1217,8 +1217,8 @@ static void purge_configs_funcs(struct gadget_info *gi)
>  			list_move_tail(&f->list, &cfg->func_list);
>  			if (f->unbind) {
>  				dev_dbg(&gi->cdev.gadget->dev,
> -				         "unbind function '%s'/%p\n",
> -				         f->name, f);
> +						"unbind function '%s'/%p\n",
> +						f->name, f);

I see no "error" with the original code here, please explain why this
needs to be changed.

thanks,

greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Fixed an indentation error
  2018-06-13 12:25 ` [PATCH] " Parth Y Shah
@ 2018-06-13 12:32 ` Joe Perches
  -1 siblings, 0 replies; 10+ messages in thread
From: Joe Perches @ 2018-06-13 12:32 UTC (permalink / raw)
  To: Parth Y Shah, balbi, gregkh, linux-usb; +Cc: linux-kernel

On Wed, 2018-06-13 at 17:55 +0530, Parth Y Shah wrote:
> Signed-off-by: Parth Y Shah <sparth1292@gmail.com>

-ENOCHANGELOG

Why do you think this is an error?
Why is the dev_dbg useful at all?

> diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
[]
> @@ -1217,8 +1217,8 @@ static void purge_configs_funcs(struct gadget_info *gi)
>  			list_move_tail(&f->list, &cfg->func_list);
>  			if (f->unbind) {
>  				dev_dbg(&gi->cdev.gadget->dev,
> -				         "unbind function '%s'/%p\n",
> -				         f->name, f);
> +						"unbind function '%s'/%p\n",
> +						f->name, f);
>  				f->unbind(c, f);
>  			}
>  		}
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Fixed an indentation error
@ 2018-06-13 12:25 ` Parth Y Shah
  0 siblings, 0 replies; 10+ messages in thread
From: Parth Y Shah @ 2018-06-13 12:25 UTC (permalink / raw)
  To: balbi, gregkh, linux-usb; +Cc: linux-kernel, Parth Y Shah

Signed-off-by: Parth Y Shah <sparth1292@gmail.com>
---
 drivers/usb/gadget/configfs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
index efba66c..0675b4a 100644
--- a/drivers/usb/gadget/configfs.c
+++ b/drivers/usb/gadget/configfs.c
@@ -1217,8 +1217,8 @@ static void purge_configs_funcs(struct gadget_info *gi)
 			list_move_tail(&f->list, &cfg->func_list);
 			if (f->unbind) {
 				dev_dbg(&gi->cdev.gadget->dev,
-				         "unbind function '%s'/%p\n",
-				         f->name, f);
+						"unbind function '%s'/%p\n",
+						f->name, f);
 				f->unbind(c, f);
 			}
 		}

^ permalink raw reply related	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2018-06-14  6:42 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-14  6:42 [v2] Fixed a checkpatch error Greg Kroah-Hartman
2018-06-14  6:42 ` [PATCH v2] " Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2018-06-14  6:32 [v2] " Parth Y Shah
2018-06-14  6:32 ` [PATCH v2] " Parth Y Shah
2018-06-13 12:36 Fixed an indentation error Greg Kroah-Hartman
2018-06-13 12:36 ` [PATCH] " Greg KH
2018-06-13 12:32 Joe Perches
2018-06-13 12:32 ` [PATCH] " Joe Perches
2018-06-13 12:25 Parth Y Shah
2018-06-13 12:25 ` [PATCH] " Parth Y Shah

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.