From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Thomas Gleixner <tglx@linutronix.de>, alexandre.chartre@oracle.com
Cc: Tom Lendacky <thomas.lendacky@amd.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
x86@kernel.org, andrew.cooper3@citrix.com,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Borislav Petkov <bp@suse.de>, David Woodhouse <dwmw@amazon.co.uk>,
Kees Cook <keescook@chromium.org>,
KarimAllah Ahmed <karahmed@amazon.de>
Subject: Re: [PATCH v1 3/3] x86/bugs: Switch the selection of mitigation from CPU vendor to CPU features
Date: Fri, 15 Jun 2018 15:38:37 -0400 [thread overview]
Message-ID: <20180615193837.GA20921@char.us.oracle.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1806152057020.1582@nanos.tec.linutronix.de>
On Fri, Jun 15, 2018 at 08:57:40PM +0200, Thomas Gleixner wrote:
> On Tue, 12 Jun 2018, Tom Lendacky wrote:
> > On 6/11/2018 9:01 AM, Konrad Rzeszutek Wilk wrote:
> > >> I think you will have to keep the case statements and explicitly check for
> > >> X86_FEATURE_AMD_SSBD before using SPEC_CTRL.
> > >
> > > .. we could or alternatively add an extra check for X86_FEATURE_AMD_SSBD ?
> >
> > Whichever you feel is best, so long as we only use SPEC_CTRL for SSBD on
> > AMD when X86_FEATURE_AMD_SSBD is present.
>
> Is there anyone working on a fix or has this been forgotten?
I have it on my TODO.
But a bit busy with the fpu lazy so will get to it done next week.
Maybe along with the X86_FEATURE_IA32_ARCH_CAPS Bit(1): IBRS_ALL to disable
retpoline on those machines.
CCing Alex
>
> Thanks,
>
> tglx
next prev parent reply other threads:[~2018-06-15 19:38 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 14:59 [PATCH v1] AMD SSB bits Konrad Rzeszutek Wilk
2018-06-01 14:59 ` [PATCH v1 1/3] x86/bugs: Add AMD's variant of SSB_NO Konrad Rzeszutek Wilk
2018-06-06 12:15 ` [tip:x86/pti] " tip-bot for Konrad Rzeszutek Wilk
2018-06-01 14:59 ` [PATCH v1 2/3] x86/bugs: Add AMD's SPEC_CTRL MSR usage Konrad Rzeszutek Wilk
2018-06-02 1:04 ` Tom Lendacky
2018-06-04 20:20 ` Konrad Rzeszutek Wilk
2018-06-04 20:43 ` Tom Lendacky
2018-06-04 20:54 ` Konrad Rzeszutek Wilk
2018-06-06 12:16 ` [tip:x86/pti] " tip-bot for Konrad Rzeszutek Wilk
2018-06-01 14:59 ` [PATCH v1 3/3] x86/bugs: Switch the selection of mitigation from CPU vendor to CPU features Konrad Rzeszutek Wilk
2018-06-06 12:16 ` [tip:x86/pti] " tip-bot for Konrad Rzeszutek Wilk
2018-06-08 21:30 ` [PATCH v1 3/3] " Tom Lendacky
2018-06-11 14:01 ` Konrad Rzeszutek Wilk
2018-06-12 14:38 ` Tom Lendacky
2018-06-15 18:57 ` Thomas Gleixner
2018-06-15 19:38 ` Konrad Rzeszutek Wilk [this message]
2018-06-01 15:38 ` [PATCH QEMU] Patches for new AMD CPU bits Konrad Rzeszutek Wilk
2018-06-01 15:38 ` [Qemu-devel] " Konrad Rzeszutek Wilk
2018-06-01 15:38 ` [PATCH 1/2] i386: define the AMD 'amd-ssbd' CPUID feature bit Konrad Rzeszutek Wilk
2018-06-01 15:38 ` [Qemu-devel] " Konrad Rzeszutek Wilk
2018-06-04 8:54 ` Daniel P. Berrangé
2018-06-04 8:54 ` [Qemu-devel] " Daniel P. Berrangé
2018-06-04 20:20 ` Konrad Rzeszutek Wilk
2018-06-04 20:20 ` [Qemu-devel] " Konrad Rzeszutek Wilk
2018-06-04 20:07 ` Eduardo Habkost
2018-06-04 20:07 ` [Qemu-devel] " Eduardo Habkost
2018-06-04 20:22 ` Konrad Rzeszutek Wilk
2018-06-04 20:22 ` [Qemu-devel] " Konrad Rzeszutek Wilk
2018-06-04 21:15 ` Eduardo Habkost
2018-06-04 21:15 ` [Qemu-devel] " Eduardo Habkost
2018-06-05 21:40 ` Konrad Rzeszutek Wilk
2018-06-05 21:40 ` [Qemu-devel] " Konrad Rzeszutek Wilk
2018-06-13 10:19 ` Daniel P. Berrangé
2018-06-13 10:19 ` [Qemu-devel] " Daniel P. Berrangé
2018-06-13 16:09 ` Konrad Rzeszutek Wilk
2018-06-13 16:09 ` [Qemu-devel] " Konrad Rzeszutek Wilk
2018-06-13 16:21 ` Daniel P. Berrangé
2018-06-13 16:21 ` [Qemu-devel] " Daniel P. Berrangé
2018-06-13 16:34 ` Konrad Rzeszutek Wilk
2018-06-13 16:34 ` [Qemu-devel] " Konrad Rzeszutek Wilk
2018-06-13 16:39 ` Daniel P. Berrangé
2018-06-13 16:39 ` [Qemu-devel] " Daniel P. Berrangé
2018-06-13 16:56 ` Eduardo Habkost
2018-06-13 16:56 ` [Qemu-devel] " Eduardo Habkost
2018-06-05 13:31 ` Tom Lendacky
2018-06-05 13:31 ` [Qemu-devel] " Tom Lendacky
2018-06-05 14:04 ` Daniel P. Berrangé
2018-06-05 14:04 ` [Qemu-devel] " Daniel P. Berrangé
2018-06-06 14:20 ` Daniel P. Berrangé
2018-06-06 14:20 ` [Qemu-devel] " Daniel P. Berrangé
2018-06-08 21:22 ` Tom Lendacky
2018-06-08 21:22 ` [Qemu-devel] " Tom Lendacky
2018-06-01 15:38 ` [PATCH 2/2] i386: Define AMD's no SSB mitigation needed Konrad Rzeszutek Wilk
2018-06-01 15:38 ` [Qemu-devel] " Konrad Rzeszutek Wilk
2018-06-13 21:38 ` [PATCH QEMU] Patches for new AMD CPU bits Eduardo Habkost
2018-06-13 21:38 ` [Qemu-devel] " Eduardo Habkost
2018-06-05 13:23 ` [PATCH v1] AMD SSB bits Tom Lendacky
2018-06-05 20:56 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180615193837.GA20921@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=alexandre.chartre@oracle.com \
--cc=andrew.cooper3@citrix.com \
--cc=bp@suse.de \
--cc=dwmw@amazon.co.uk \
--cc=hpa@zytor.com \
--cc=karahmed@amazon.de \
--cc=keescook@chromium.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.