All of lore.kernel.org
 help / color / mirror / Atom feed
From: hch@infradead.org (Christoph Hellwig)
To: linux-riscv@lists.infradead.org
Subject: [PATCH 4/5] RISC-V: Change variable type for 32-bit compatible
Date: Wed, 20 Jun 2018 23:41:35 -0700	[thread overview]
Message-ID: <20180621064135.GD19319@infradead.org> (raw)
In-Reply-To: <3f86f9eb853380686a86a8abe6bda0dd3720ee10.1529506497.git.zong@andestech.com>

> -	s64 offset = (void *)v - (void *)location;
> +	uintptr_t offset = (void *)v - (void *)location;

s64 is signed, uintptr is not, so this might change behavior and needs
an explanation.

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Zong Li <zong@andestech.com>
Cc: palmer@sifive.com, aou@eecs.berkeley.edu,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	greentime@adnestech.com
Subject: Re: [PATCH 4/5] RISC-V: Change variable type for 32-bit compatible
Date: Wed, 20 Jun 2018 23:41:35 -0700	[thread overview]
Message-ID: <20180621064135.GD19319@infradead.org> (raw)
In-Reply-To: <3f86f9eb853380686a86a8abe6bda0dd3720ee10.1529506497.git.zong@andestech.com>

> -	s64 offset = (void *)v - (void *)location;
> +	uintptr_t offset = (void *)v - (void *)location;

s64 is signed, uintptr is not, so this might change behavior and needs
an explanation.

  reply	other threads:[~2018-06-21  6:41 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-21  1:41 [PATCH 0/5] Building for 32-bit RISC-V kernel Zong Li
2018-06-21  1:41 ` Zong Li
2018-06-21  1:41 ` [PATCH 1/5] RISC-V: Add conditional macro for zone of DMA32 Zong Li
2018-06-21  1:41   ` Zong Li
2018-06-21  6:40   ` Christoph Hellwig
2018-06-21  6:40     ` Christoph Hellwig
2018-06-21  7:06     ` Zong Li
2018-06-21  7:06       ` Zong Li
2018-06-21  1:41 ` [PATCH] RISC-V: Add conditional marco for boot_sec_cpu Zong Li
2018-06-21  1:41   ` Zong Li
2018-06-21  1:41 ` [PATCH 2/5] RISC-V: Select GENERIC_UCMPDI2 on RV32I Zong Li
2018-06-21  1:41   ` Zong Li
2018-06-21  1:41 ` [PATCH 3/5] RISC-V: Add definiion of extract symbol's index and type for 32-bit Zong Li
2018-06-21  1:41   ` Zong Li
2018-06-21  1:41 ` [PATCH 4/5] RISC-V: Change variable type for 32-bit compatible Zong Li
2018-06-21  1:41   ` Zong Li
2018-06-21  6:41   ` Christoph Hellwig [this message]
2018-06-21  6:41     ` Christoph Hellwig
2018-06-21  7:12     ` Zong Li
2018-06-21  7:12       ` Zong Li
2018-06-21 15:19       ` Zong Li
2018-06-21 15:19         ` Zong Li
2018-06-21  1:41 ` [PATCH 5/5] RISC-V: Use fixed width integer types " Zong Li
2018-06-21  1:41   ` Zong Li
2018-06-21  6:43   ` Christoph Hellwig
2018-06-21  6:43     ` Christoph Hellwig
2018-06-21 10:13     ` Zong Li
2018-06-21 10:13       ` Zong Li
2018-06-21 10:21     ` Andreas Schwab
2018-06-21 10:21       ` Andreas Schwab
2018-06-21 14:53       ` Christoph Hellwig
2018-06-21 14:53         ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180621064135.GD19319@infradead.org \
    --to=hch@infradead.org \
    --cc=linux-riscv@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.