* [PATCH, for-4.19] dma-mapping: add the missing ARCH_HAS_SYNC_DMA_FOR_CPU_ALL declaration
@ 2018-09-11 9:00 ` Christoph Hellwig
0 siblings, 0 replies; 15+ messages in thread
From: Christoph Hellwig @ 2018-09-11 9:00 UTC (permalink / raw)
To: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA
Cc: linux-mips-6z/3iImG2C8G8FEW9MqTrA, paul.burton-8NJIiSa5LzA,
robin.murphy-5wv7dgnIgG8
The patch adding the infrastructure failed to actually add the symbol
declaration, oops..
Fixes: faef87723a ("dma-noncoherent: add a arch_sync_dma_for_cpu_all hook")
Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
---
kernel/dma/Kconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/kernel/dma/Kconfig b/kernel/dma/Kconfig
index 9bd54304446f..1b1d63b3634b 100644
--- a/kernel/dma/Kconfig
+++ b/kernel/dma/Kconfig
@@ -23,6 +23,9 @@ config ARCH_HAS_SYNC_DMA_FOR_CPU
bool
select NEED_DMA_MAP_STATE
+config ARCH_HAS_SYNC_DMA_FOR_CPU_ALL
+ bool
+
config DMA_DIRECT_OPS
bool
depends on HAS_DMA
--
2.18.0
^ permalink raw reply related [flat|nested] 15+ messages in thread* [PATCH, for-4.19] dma-mapping: add the missing ARCH_HAS_SYNC_DMA_FOR_CPU_ALL declaration @ 2018-09-11 9:00 ` Christoph Hellwig 0 siblings, 0 replies; 15+ messages in thread From: Christoph Hellwig @ 2018-09-11 9:00 UTC (permalink / raw) To: iommu; +Cc: m.szyprowski, robin.murphy, paul.burton, linux-mips The patch adding the infrastructure failed to actually add the symbol declaration, oops.. Fixes: faef87723a ("dma-noncoherent: add a arch_sync_dma_for_cpu_all hook") Signed-off-by: Christoph Hellwig <hch@lst.de> --- kernel/dma/Kconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/kernel/dma/Kconfig b/kernel/dma/Kconfig index 9bd54304446f..1b1d63b3634b 100644 --- a/kernel/dma/Kconfig +++ b/kernel/dma/Kconfig @@ -23,6 +23,9 @@ config ARCH_HAS_SYNC_DMA_FOR_CPU bool select NEED_DMA_MAP_STATE +config ARCH_HAS_SYNC_DMA_FOR_CPU_ALL + bool + config DMA_DIRECT_OPS bool depends on HAS_DMA -- 2.18.0 ^ permalink raw reply related [flat|nested] 15+ messages in thread
[parent not found: <20180911090049.10747-1-hch-jcswGhMUV9g@public.gmane.org>]
* Re: [PATCH, for-4.19] dma-mapping: add the missing ARCH_HAS_SYNC_DMA_FOR_CPU_ALL declaration 2018-09-11 9:00 ` Christoph Hellwig @ 2018-09-14 10:08 ` Christoph Hellwig -1 siblings, 0 replies; 15+ messages in thread From: Christoph Hellwig @ 2018-09-14 10:08 UTC (permalink / raw) To: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA Cc: linux-mips-6z/3iImG2C8G8FEW9MqTrA, paul.burton-8NJIiSa5LzA, robin.murphy-5wv7dgnIgG8 Aby chance to get a review for this? On Tue, Sep 11, 2018 at 11:00:49AM +0200, Christoph Hellwig wrote: > The patch adding the infrastructure failed to actually add the symbol > declaration, oops.. > > Fixes: faef87723a ("dma-noncoherent: add a arch_sync_dma_for_cpu_all hook") > Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org> > --- > kernel/dma/Kconfig | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/kernel/dma/Kconfig b/kernel/dma/Kconfig > index 9bd54304446f..1b1d63b3634b 100644 > --- a/kernel/dma/Kconfig > +++ b/kernel/dma/Kconfig > @@ -23,6 +23,9 @@ config ARCH_HAS_SYNC_DMA_FOR_CPU > bool > select NEED_DMA_MAP_STATE > > +config ARCH_HAS_SYNC_DMA_FOR_CPU_ALL > + bool > + > config DMA_DIRECT_OPS > bool > depends on HAS_DMA > -- > 2.18.0 > > _______________________________________________ > iommu mailing list > iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org > https://lists.linuxfoundation.org/mailman/listinfo/iommu ---end quoted text--- ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH, for-4.19] dma-mapping: add the missing ARCH_HAS_SYNC_DMA_FOR_CPU_ALL declaration @ 2018-09-14 10:08 ` Christoph Hellwig 0 siblings, 0 replies; 15+ messages in thread From: Christoph Hellwig @ 2018-09-14 10:08 UTC (permalink / raw) To: iommu; +Cc: linux-mips, paul.burton, robin.murphy Aby chance to get a review for this? On Tue, Sep 11, 2018 at 11:00:49AM +0200, Christoph Hellwig wrote: > The patch adding the infrastructure failed to actually add the symbol > declaration, oops.. > > Fixes: faef87723a ("dma-noncoherent: add a arch_sync_dma_for_cpu_all hook") > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > kernel/dma/Kconfig | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/kernel/dma/Kconfig b/kernel/dma/Kconfig > index 9bd54304446f..1b1d63b3634b 100644 > --- a/kernel/dma/Kconfig > +++ b/kernel/dma/Kconfig > @@ -23,6 +23,9 @@ config ARCH_HAS_SYNC_DMA_FOR_CPU > bool > select NEED_DMA_MAP_STATE > > +config ARCH_HAS_SYNC_DMA_FOR_CPU_ALL > + bool > + > config DMA_DIRECT_OPS > bool > depends on HAS_DMA > -- > 2.18.0 > > _______________________________________________ > iommu mailing list > iommu@lists.linux-foundation.org > https://lists.linuxfoundation.org/mailman/listinfo/iommu ---end quoted text--- ^ permalink raw reply [flat|nested] 15+ messages in thread
[parent not found: <20180914100842.GA23696-jcswGhMUV9g@public.gmane.org>]
* Re: [PATCH, for-4.19] dma-mapping: add the missing ARCH_HAS_SYNC_DMA_FOR_CPU_ALL declaration 2018-09-14 10:08 ` Christoph Hellwig @ 2018-09-14 15:44 ` Robin Murphy -1 siblings, 0 replies; 15+ messages in thread From: Robin Murphy @ 2018-09-14 15:44 UTC (permalink / raw) To: Christoph Hellwig, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA Cc: linux-mips-6z/3iImG2C8G8FEW9MqTrA, paul.burton-8NJIiSa5LzA On 14/09/18 11:08, Christoph Hellwig wrote: > Aby chance to get a review for this? So without this, the select does nothing, CONFIG_ARCH_HAS_SYNC_DMA_FOR_CPU_ALL is never defined, and BMIPS gets the static inline stub and never flushes the RAC when it should? I don't know enough MIPS to consider even compile-testing to check it, but that sounds like a legitimate fix to me. Robin. > On Tue, Sep 11, 2018 at 11:00:49AM +0200, Christoph Hellwig wrote: >> The patch adding the infrastructure failed to actually add the symbol >> declaration, oops.. >> >> Fixes: faef87723a ("dma-noncoherent: add a arch_sync_dma_for_cpu_all hook") >> Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org> >> --- >> kernel/dma/Kconfig | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/kernel/dma/Kconfig b/kernel/dma/Kconfig >> index 9bd54304446f..1b1d63b3634b 100644 >> --- a/kernel/dma/Kconfig >> +++ b/kernel/dma/Kconfig >> @@ -23,6 +23,9 @@ config ARCH_HAS_SYNC_DMA_FOR_CPU >> bool >> select NEED_DMA_MAP_STATE >> >> +config ARCH_HAS_SYNC_DMA_FOR_CPU_ALL >> + bool >> + >> config DMA_DIRECT_OPS >> bool >> depends on HAS_DMA >> -- >> 2.18.0 >> >> _______________________________________________ >> iommu mailing list >> iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org >> https://lists.linuxfoundation.org/mailman/listinfo/iommu > ---end quoted text--- > ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH, for-4.19] dma-mapping: add the missing ARCH_HAS_SYNC_DMA_FOR_CPU_ALL declaration @ 2018-09-14 15:44 ` Robin Murphy 0 siblings, 0 replies; 15+ messages in thread From: Robin Murphy @ 2018-09-14 15:44 UTC (permalink / raw) To: Christoph Hellwig, iommu; +Cc: linux-mips, paul.burton On 14/09/18 11:08, Christoph Hellwig wrote: > Aby chance to get a review for this? So without this, the select does nothing, CONFIG_ARCH_HAS_SYNC_DMA_FOR_CPU_ALL is never defined, and BMIPS gets the static inline stub and never flushes the RAC when it should? I don't know enough MIPS to consider even compile-testing to check it, but that sounds like a legitimate fix to me. Robin. > On Tue, Sep 11, 2018 at 11:00:49AM +0200, Christoph Hellwig wrote: >> The patch adding the infrastructure failed to actually add the symbol >> declaration, oops.. >> >> Fixes: faef87723a ("dma-noncoherent: add a arch_sync_dma_for_cpu_all hook") >> Signed-off-by: Christoph Hellwig <hch@lst.de> >> --- >> kernel/dma/Kconfig | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/kernel/dma/Kconfig b/kernel/dma/Kconfig >> index 9bd54304446f..1b1d63b3634b 100644 >> --- a/kernel/dma/Kconfig >> +++ b/kernel/dma/Kconfig >> @@ -23,6 +23,9 @@ config ARCH_HAS_SYNC_DMA_FOR_CPU >> bool >> select NEED_DMA_MAP_STATE >> >> +config ARCH_HAS_SYNC_DMA_FOR_CPU_ALL >> + bool >> + >> config DMA_DIRECT_OPS >> bool >> depends on HAS_DMA >> -- >> 2.18.0 >> >> _______________________________________________ >> iommu mailing list >> iommu@lists.linux-foundation.org >> https://lists.linuxfoundation.org/mailman/listinfo/iommu > ---end quoted text--- > ^ permalink raw reply [flat|nested] 15+ messages in thread
[parent not found: <00257a79-72cf-15aa-fed9-d75923eed51e-5wv7dgnIgG8@public.gmane.org>]
* Re: [PATCH, for-4.19] dma-mapping: add the missing ARCH_HAS_SYNC_DMA_FOR_CPU_ALL declaration 2018-09-14 15:44 ` Robin Murphy @ 2018-09-14 15:51 ` Christoph Hellwig -1 siblings, 0 replies; 15+ messages in thread From: Christoph Hellwig @ 2018-09-14 15:51 UTC (permalink / raw) To: Robin Murphy Cc: linux-mips-6z/3iImG2C8G8FEW9MqTrA, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA, paul.burton-8NJIiSa5LzA, Christoph Hellwig On Fri, Sep 14, 2018 at 04:44:15PM +0100, Robin Murphy wrote: > On 14/09/18 11:08, Christoph Hellwig wrote: >> Aby chance to get a review for this? > > So without this, the select does nothing, > CONFIG_ARCH_HAS_SYNC_DMA_FOR_CPU_ALL is never defined, and BMIPS gets the > static inline stub and never flushes the RAC when it should? Exactly! ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH, for-4.19] dma-mapping: add the missing ARCH_HAS_SYNC_DMA_FOR_CPU_ALL declaration @ 2018-09-14 15:51 ` Christoph Hellwig 0 siblings, 0 replies; 15+ messages in thread From: Christoph Hellwig @ 2018-09-14 15:51 UTC (permalink / raw) To: Robin Murphy; +Cc: Christoph Hellwig, iommu, linux-mips, paul.burton On Fri, Sep 14, 2018 at 04:44:15PM +0100, Robin Murphy wrote: > On 14/09/18 11:08, Christoph Hellwig wrote: >> Aby chance to get a review for this? > > So without this, the select does nothing, > CONFIG_ARCH_HAS_SYNC_DMA_FOR_CPU_ALL is never defined, and BMIPS gets the > static inline stub and never flushes the RAC when it should? Exactly! ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH, for-4.19] dma-mapping: add the missing ARCH_HAS_SYNC_DMA_FOR_CPU_ALL declaration 2018-09-11 9:00 ` Christoph Hellwig (?) (?) @ 2018-09-21 6:10 ` Christoph Hellwig [not found] ` <20180921061052.GA13705-jcswGhMUV9g@public.gmane.org> -1 siblings, 1 reply; 15+ messages in thread From: Christoph Hellwig @ 2018-09-21 6:10 UTC (permalink / raw) To: linux-mips, paul.burton; +Cc: robin.murphy, iommu Paul, other mips folks, any comments? At this point I'm tempted to just move it to 4.20 and add a stable tag given that no one cared so far. On Tue, Sep 11, 2018 at 11:00:49AM +0200, Christoph Hellwig wrote: > The patch adding the infrastructure failed to actually add the symbol > declaration, oops.. > > Fixes: faef87723a ("dma-noncoherent: add a arch_sync_dma_for_cpu_all hook") > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > kernel/dma/Kconfig | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/kernel/dma/Kconfig b/kernel/dma/Kconfig > index 9bd54304446f..1b1d63b3634b 100644 > --- a/kernel/dma/Kconfig > +++ b/kernel/dma/Kconfig > @@ -23,6 +23,9 @@ config ARCH_HAS_SYNC_DMA_FOR_CPU > bool > select NEED_DMA_MAP_STATE > > +config ARCH_HAS_SYNC_DMA_FOR_CPU_ALL > + bool > + > config DMA_DIRECT_OPS > bool > depends on HAS_DMA > -- > 2.18.0 > > _______________________________________________ > iommu mailing list > iommu@lists.linux-foundation.org > https://lists.linuxfoundation.org/mailman/listinfo/iommu ---end quoted text--- ^ permalink raw reply [flat|nested] 15+ messages in thread
[parent not found: <20180921061052.GA13705-jcswGhMUV9g@public.gmane.org>]
* Re: [PATCH, for-4.19] dma-mapping: add the missing ARCH_HAS_SYNC_DMA_FOR_CPU_ALL declaration 2018-09-21 6:10 ` Christoph Hellwig @ 2018-09-21 19:42 ` Paul Burton 0 siblings, 0 replies; 15+ messages in thread From: Paul Burton @ 2018-09-21 19:42 UTC (permalink / raw) To: Christoph Hellwig, Kevin Cernekee, Florian Fainelli Cc: linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, robin.murphy-5wv7dgnIgG8@public.gmane.org Hi Christoph, On Fri, Sep 21, 2018 at 08:10:52AM +0200, Christoph Hellwig wrote: > Paul, other mips folks, any comments? > > At this point I'm tempted to just move it to 4.20 and add a stable > tag given that no one cared so far. Copying Kevin & Florian as maintainers of the affected BMIPS systems in case they have anything to add. > On Tue, Sep 11, 2018 at 11:00:49AM +0200, Christoph Hellwig wrote: > > The patch adding the infrastructure failed to actually add the symbol > > declaration, oops.. > > > > Fixes: faef87723a ("dma-noncoherent: add a arch_sync_dma_for_cpu_all hook") > > Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org> > > --- > > kernel/dma/Kconfig | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/kernel/dma/Kconfig b/kernel/dma/Kconfig > > index 9bd54304446f..1b1d63b3634b 100644 > > --- a/kernel/dma/Kconfig > > +++ b/kernel/dma/Kconfig > > @@ -23,6 +23,9 @@ config ARCH_HAS_SYNC_DMA_FOR_CPU > > bool > > select NEED_DMA_MAP_STATE > > > > +config ARCH_HAS_SYNC_DMA_FOR_CPU_ALL > > + bool > > + > > config DMA_DIRECT_OPS > > bool > > depends on HAS_DMA The change looks reasonable to me, so feel free to take your choice of: Reviewed-by: Paul Burton <paul.burton-8NJIiSa5LzA@public.gmane.org> Acked-by: Paul Burton <paul.burton-8NJIiSa5LzA@public.gmane.org> My thought would be that it would be ideal to fix in 4.19 since that's where the breakage is, but having said that I don't have much insight into how bad the breakage is for the affected systems. Thanks, Paul ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH, for-4.19] dma-mapping: add the missing ARCH_HAS_SYNC_DMA_FOR_CPU_ALL declaration @ 2018-09-21 19:42 ` Paul Burton 0 siblings, 0 replies; 15+ messages in thread From: Paul Burton @ 2018-09-21 19:42 UTC (permalink / raw) To: Christoph Hellwig, Kevin Cernekee, Florian Fainelli Cc: linux-mips@linux-mips.org, robin.murphy@arm.com, iommu@lists.linux-foundation.org Hi Christoph, On Fri, Sep 21, 2018 at 08:10:52AM +0200, Christoph Hellwig wrote: > Paul, other mips folks, any comments? > > At this point I'm tempted to just move it to 4.20 and add a stable > tag given that no one cared so far. Copying Kevin & Florian as maintainers of the affected BMIPS systems in case they have anything to add. > On Tue, Sep 11, 2018 at 11:00:49AM +0200, Christoph Hellwig wrote: > > The patch adding the infrastructure failed to actually add the symbol > > declaration, oops.. > > > > Fixes: faef87723a ("dma-noncoherent: add a arch_sync_dma_for_cpu_all hook") > > Signed-off-by: Christoph Hellwig <hch@lst.de> > > --- > > kernel/dma/Kconfig | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/kernel/dma/Kconfig b/kernel/dma/Kconfig > > index 9bd54304446f..1b1d63b3634b 100644 > > --- a/kernel/dma/Kconfig > > +++ b/kernel/dma/Kconfig > > @@ -23,6 +23,9 @@ config ARCH_HAS_SYNC_DMA_FOR_CPU > > bool > > select NEED_DMA_MAP_STATE > > > > +config ARCH_HAS_SYNC_DMA_FOR_CPU_ALL > > + bool > > + > > config DMA_DIRECT_OPS > > bool > > depends on HAS_DMA The change looks reasonable to me, so feel free to take your choice of: Reviewed-by: Paul Burton <paul.burton@mips.com> Acked-by: Paul Burton <paul.burton@mips.com> My thought would be that it would be ideal to fix in 4.19 since that's where the breakage is, but having said that I don't have much insight into how bad the breakage is for the affected systems. Thanks, Paul ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH, for-4.19] dma-mapping: add the missing ARCH_HAS_SYNC_DMA_FOR_CPU_ALL declaration 2018-09-21 19:42 ` Paul Burton @ 2018-09-22 19:24 ` Florian Fainelli -1 siblings, 0 replies; 15+ messages in thread From: Florian Fainelli @ 2018-09-22 19:24 UTC (permalink / raw) To: Paul Burton, Christoph Hellwig, Kevin Cernekee Cc: linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, robin.murphy-5wv7dgnIgG8@public.gmane.org On September 21, 2018 12:42:20 PM PDT, Paul Burton <paul.burton-8NJIiSa5LzA@public.gmane.org> wrote: >Hi Christoph, > >On Fri, Sep 21, 2018 at 08:10:52AM +0200, Christoph Hellwig wrote: >> Paul, other mips folks, any comments? >> >> At this point I'm tempted to just move it to 4.20 and add a stable >> tag given that no one cared so far. > >Copying Kevin & Florian as maintainers of the affected BMIPS systems in >case they have anything to add. > >> On Tue, Sep 11, 2018 at 11:00:49AM +0200, Christoph Hellwig wrote: >> > The patch adding the infrastructure failed to actually add the >symbol >> > declaration, oops.. >> > >> > Fixes: faef87723a ("dma-noncoherent: add a >arch_sync_dma_for_cpu_all hook") >> > Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org> >> > --- >> > kernel/dma/Kconfig | 3 +++ >> > 1 file changed, 3 insertions(+) >> > >> > diff --git a/kernel/dma/Kconfig b/kernel/dma/Kconfig >> > index 9bd54304446f..1b1d63b3634b 100644 >> > --- a/kernel/dma/Kconfig >> > +++ b/kernel/dma/Kconfig >> > @@ -23,6 +23,9 @@ config ARCH_HAS_SYNC_DMA_FOR_CPU >> > bool >> > select NEED_DMA_MAP_STATE >> > >> > +config ARCH_HAS_SYNC_DMA_FOR_CPU_ALL >> > + bool >> > + >> > config DMA_DIRECT_OPS >> > bool >> > depends on HAS_DMA > >The change looks reasonable to me, so feel free to take your choice of: > > Reviewed-by: Paul Burton <paul.burton-8NJIiSa5LzA@public.gmane.org> > Acked-by: Paul Burton <paul.burton-8NJIiSa5LzA@public.gmane.org> > >My thought would be that it would be ideal to fix in 4.19 since that's >where the breakage is, but having said that I don't have much insight >into how bad the breakage is for the affected systems. AFAIR, DMA corruption is typically what you would observe, which could prove difficult if you are not exactly looking for it. In any case, I don't have a BMIPS system running 4.19 right now to exercise this on, but this looks correct: Acked-by: Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> -- Florian ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH, for-4.19] dma-mapping: add the missing ARCH_HAS_SYNC_DMA_FOR_CPU_ALL declaration @ 2018-09-22 19:24 ` Florian Fainelli 0 siblings, 0 replies; 15+ messages in thread From: Florian Fainelli @ 2018-09-22 19:24 UTC (permalink / raw) To: Paul Burton, Christoph Hellwig, Kevin Cernekee Cc: linux-mips@linux-mips.org, robin.murphy@arm.com, iommu@lists.linux-foundation.org On September 21, 2018 12:42:20 PM PDT, Paul Burton <paul.burton@mips.com> wrote: >Hi Christoph, > >On Fri, Sep 21, 2018 at 08:10:52AM +0200, Christoph Hellwig wrote: >> Paul, other mips folks, any comments? >> >> At this point I'm tempted to just move it to 4.20 and add a stable >> tag given that no one cared so far. > >Copying Kevin & Florian as maintainers of the affected BMIPS systems in >case they have anything to add. > >> On Tue, Sep 11, 2018 at 11:00:49AM +0200, Christoph Hellwig wrote: >> > The patch adding the infrastructure failed to actually add the >symbol >> > declaration, oops.. >> > >> > Fixes: faef87723a ("dma-noncoherent: add a >arch_sync_dma_for_cpu_all hook") >> > Signed-off-by: Christoph Hellwig <hch@lst.de> >> > --- >> > kernel/dma/Kconfig | 3 +++ >> > 1 file changed, 3 insertions(+) >> > >> > diff --git a/kernel/dma/Kconfig b/kernel/dma/Kconfig >> > index 9bd54304446f..1b1d63b3634b 100644 >> > --- a/kernel/dma/Kconfig >> > +++ b/kernel/dma/Kconfig >> > @@ -23,6 +23,9 @@ config ARCH_HAS_SYNC_DMA_FOR_CPU >> > bool >> > select NEED_DMA_MAP_STATE >> > >> > +config ARCH_HAS_SYNC_DMA_FOR_CPU_ALL >> > + bool >> > + >> > config DMA_DIRECT_OPS >> > bool >> > depends on HAS_DMA > >The change looks reasonable to me, so feel free to take your choice of: > > Reviewed-by: Paul Burton <paul.burton@mips.com> > Acked-by: Paul Burton <paul.burton@mips.com> > >My thought would be that it would be ideal to fix in 4.19 since that's >where the breakage is, but having said that I don't have much insight >into how bad the breakage is for the affected systems. AFAIR, DMA corruption is typically what you would observe, which could prove difficult if you are not exactly looking for it. In any case, I don't have a BMIPS system running 4.19 right now to exercise this on, but this looks correct: Acked-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian ^ permalink raw reply [flat|nested] 15+ messages in thread
[parent not found: <62B54A6B-6E10-4A40-8E61-C1D23A853816-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH, for-4.19] dma-mapping: add the missing ARCH_HAS_SYNC_DMA_FOR_CPU_ALL declaration 2018-09-22 19:24 ` Florian Fainelli @ 2018-09-25 20:05 ` Christoph Hellwig -1 siblings, 0 replies; 15+ messages in thread From: Christoph Hellwig @ 2018-09-25 20:05 UTC (permalink / raw) To: Florian Fainelli Cc: linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org, Kevin Cernekee, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Paul Burton, robin.murphy-5wv7dgnIgG8@public.gmane.org, Christoph Hellwig On Sat, Sep 22, 2018 at 12:24:33PM -0700, Florian Fainelli wrote: > >My thought would be that it would be ideal to fix in 4.19 since that's > >where the breakage is, but having said that I don't have much insight > >into how bad the breakage is for the affected systems. > > > AFAIR, DMA corruption is typically what you would observe, which could prove difficult if you are not exactly looking for it. In any case, I don't have a BMIPS system running 4.19 right now to exercise this on, but this looks correct: Well, I originally intended it for 4.19, but without reviews from the affected maintainers I'd fell bad about it. Now that we've got agreement I'll queue it for 4.19. ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH, for-4.19] dma-mapping: add the missing ARCH_HAS_SYNC_DMA_FOR_CPU_ALL declaration @ 2018-09-25 20:05 ` Christoph Hellwig 0 siblings, 0 replies; 15+ messages in thread From: Christoph Hellwig @ 2018-09-25 20:05 UTC (permalink / raw) To: Florian Fainelli Cc: Paul Burton, Christoph Hellwig, Kevin Cernekee, linux-mips@linux-mips.org, robin.murphy@arm.com, iommu@lists.linux-foundation.org On Sat, Sep 22, 2018 at 12:24:33PM -0700, Florian Fainelli wrote: > >My thought would be that it would be ideal to fix in 4.19 since that's > >where the breakage is, but having said that I don't have much insight > >into how bad the breakage is for the affected systems. > > > AFAIR, DMA corruption is typically what you would observe, which could prove difficult if you are not exactly looking for it. In any case, I don't have a BMIPS system running 4.19 right now to exercise this on, but this looks correct: Well, I originally intended it for 4.19, but without reviews from the affected maintainers I'd fell bad about it. Now that we've got agreement I'll queue it for 4.19. ^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2018-09-25 20:05 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-11 9:00 [PATCH, for-4.19] dma-mapping: add the missing ARCH_HAS_SYNC_DMA_FOR_CPU_ALL declaration Christoph Hellwig
2018-09-11 9:00 ` Christoph Hellwig
[not found] ` <20180911090049.10747-1-hch-jcswGhMUV9g@public.gmane.org>
2018-09-14 10:08 ` Christoph Hellwig
2018-09-14 10:08 ` Christoph Hellwig
[not found] ` <20180914100842.GA23696-jcswGhMUV9g@public.gmane.org>
2018-09-14 15:44 ` Robin Murphy
2018-09-14 15:44 ` Robin Murphy
[not found] ` <00257a79-72cf-15aa-fed9-d75923eed51e-5wv7dgnIgG8@public.gmane.org>
2018-09-14 15:51 ` Christoph Hellwig
2018-09-14 15:51 ` Christoph Hellwig
2018-09-21 6:10 ` Christoph Hellwig
[not found] ` <20180921061052.GA13705-jcswGhMUV9g@public.gmane.org>
2018-09-21 19:42 ` Paul Burton
2018-09-21 19:42 ` Paul Burton
2018-09-22 19:24 ` Florian Fainelli
2018-09-22 19:24 ` Florian Fainelli
[not found] ` <62B54A6B-6E10-4A40-8E61-C1D23A853816-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-09-25 20:05 ` Christoph Hellwig
2018-09-25 20:05 ` Christoph Hellwig
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.