From: Miroslav Lichvar <mlichvar@redhat.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [RFC PATCH 1/4] ptp: add PTP_SYS_OFFSET_EXTENDED ioctl
Date: Mon, 29 Oct 2018 13:52:09 +0100 [thread overview]
Message-ID: <20181029125209.GC31668@localhost> (raw)
In-Reply-To: <87in1o73qo.fsf@intel.com>
On Fri, Oct 26, 2018 at 03:16:47PM -0700, Vinicius Costa Gomes wrote:
> > + case PTP_SYS_OFFSET_EXTENDED:
> > + if (!ptp->info->gettimex64) {
> > + err = -EOPNOTSUPP;
> > + break;
> > + }
> > + sysoff_extended = memdup_user((void __user *)arg,
> > + sizeof(*sysoff_extended));
>
> Looks like you forgot to free 'sysoff_extended', no?
Oh, I did. Thanks for catching that. I'll fix it in the next version.
--
Miroslav Lichvar
WARNING: multiple messages have this Message-ID (diff)
From: Miroslav Lichvar <mlichvar@redhat.com>
To: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Cc: netdev@vger.kernel.org,
Richard Cochran <richardcochran@gmail.com>,
intel-wired-lan@lists.osuosl.org
Subject: Re: [Intel-wired-lan] [RFC PATCH 1/4] ptp: add PTP_SYS_OFFSET_EXTENDED ioctl
Date: Mon, 29 Oct 2018 13:52:09 +0100 [thread overview]
Message-ID: <20181029125209.GC31668@localhost> (raw)
In-Reply-To: <87in1o73qo.fsf@intel.com>
On Fri, Oct 26, 2018 at 03:16:47PM -0700, Vinicius Costa Gomes wrote:
> > + case PTP_SYS_OFFSET_EXTENDED:
> > + if (!ptp->info->gettimex64) {
> > + err = -EOPNOTSUPP;
> > + break;
> > + }
> > + sysoff_extended = memdup_user((void __user *)arg,
> > + sizeof(*sysoff_extended));
>
> Looks like you forgot to free 'sysoff_extended', no?
Oh, I did. Thanks for catching that. I'll fix it in the next version.
--
Miroslav Lichvar
next prev parent reply other threads:[~2018-10-29 12:52 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 16:27 [Intel-wired-lan] [RFC PATCH 0/4] More accurate PHC<->system clock synchronization Miroslav Lichvar
2018-10-26 16:27 ` Miroslav Lichvar
2018-10-26 16:27 ` [Intel-wired-lan] [RFC PATCH 1/4] ptp: add PTP_SYS_OFFSET_EXTENDED ioctl Miroslav Lichvar
2018-10-26 16:27 ` Miroslav Lichvar
2018-10-26 22:16 ` [Intel-wired-lan] " Vinicius Costa Gomes
2018-10-26 22:16 ` Vinicius Costa Gomes
2018-10-29 12:52 ` Miroslav Lichvar [this message]
2018-10-29 12:52 ` Miroslav Lichvar
2018-10-31 2:23 ` Richard Cochran
2018-10-31 2:23 ` Richard Cochran
2018-10-31 3:01 ` [Intel-wired-lan] " Richard Cochran
2018-10-31 3:01 ` Richard Cochran
2018-10-26 16:27 ` [Intel-wired-lan] [RFC PATCH 2/4] e1000e: add support for extended PHC gettime Miroslav Lichvar
2018-10-26 16:27 ` Miroslav Lichvar
2018-10-26 16:27 ` [Intel-wired-lan] [RFC PATCH 3/4] igb: " Miroslav Lichvar
2018-10-26 16:27 ` Miroslav Lichvar
2018-10-31 2:29 ` [Intel-wired-lan] " Richard Cochran
2018-10-31 2:29 ` Richard Cochran
2018-10-31 9:39 ` [Intel-wired-lan] " Miroslav Lichvar
2018-10-31 9:39 ` Miroslav Lichvar
2018-10-31 16:56 ` [Intel-wired-lan] " Keller, Jacob E
2018-10-31 16:56 ` Keller, Jacob E
2018-10-26 16:27 ` [Intel-wired-lan] [RFC PATCH 4/4] ixgbe: " Miroslav Lichvar
2018-10-26 16:27 ` Miroslav Lichvar
2018-10-26 16:54 ` [Intel-wired-lan] " Keller, Jacob E
2018-10-26 16:54 ` Keller, Jacob E
2018-10-29 13:31 ` [Intel-wired-lan] " Miroslav Lichvar
2018-10-29 13:31 ` Miroslav Lichvar
2018-10-29 16:02 ` [Intel-wired-lan] " Keller, Jacob E
2018-10-29 16:02 ` Keller, Jacob E
2018-10-31 14:40 ` [Intel-wired-lan] " Richard Cochran
2018-10-31 14:40 ` Richard Cochran
2018-10-31 14:49 ` [Intel-wired-lan] " Miroslav Lichvar
2018-10-31 14:49 ` Miroslav Lichvar
2018-10-31 21:16 ` [Intel-wired-lan] " Richard Cochran
2018-10-31 21:16 ` Richard Cochran
2018-10-31 22:08 ` [Intel-wired-lan] " Keller, Jacob E
2018-10-31 22:08 ` Keller, Jacob E
2018-10-31 16:55 ` [Intel-wired-lan] " Keller, Jacob E
2018-10-31 16:55 ` Keller, Jacob E
2018-10-26 16:40 ` [Intel-wired-lan] [RFC PATCH 0/4] More accurate PHC<->system clock synchronization Keller, Jacob E
2018-10-26 16:40 ` Keller, Jacob E
2018-10-26 16:51 ` [Intel-wired-lan] " Keller, Jacob E
2018-10-26 16:51 ` Keller, Jacob E
2018-10-31 2:25 ` [Intel-wired-lan] " Richard Cochran
2018-10-31 2:25 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181029125209.GC31668@localhost \
--to=mlichvar@redhat.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.