From: Richard Cochran <richardcochran@gmail.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [RFC PATCH 1/4] ptp: add PTP_SYS_OFFSET_EXTENDED ioctl
Date: Tue, 30 Oct 2018 20:01:11 -0700 [thread overview]
Message-ID: <20181031030111.2s4jsnunjrbfarix@localhost> (raw)
In-Reply-To: <20181031022351.24mmvf7u7bcx42rv@localhost>
On Tue, Oct 30, 2018 at 07:23:51PM -0700, Richard Cochran wrote:
> This collection of automatic variables is getting ugly. May I ask you
> to prefix a patch that puts them into reverse Christmas tree before
> your changes? (Patch below)
Forgot the diff. Here it is...
---
diff --git a/drivers/ptp/ptp_chardev.c b/drivers/ptp/ptp_chardev.c
index 2012551d93e0..b54b8158ff8a 100644
--- a/drivers/ptp/ptp_chardev.c
+++ b/drivers/ptp/ptp_chardev.c
@@ -121,18 +121,18 @@ int ptp_open(struct posix_clock *pc, fmode_t fmode)
long ptp_ioctl(struct posix_clock *pc, unsigned int cmd, unsigned long arg)
{
- struct ptp_clock_caps caps;
- struct ptp_clock_request req;
- struct ptp_sys_offset *sysoff = NULL;
- struct ptp_sys_offset_precise precise_offset;
- struct ptp_pin_desc pd;
struct ptp_clock *ptp = container_of(pc, struct ptp_clock, clock);
+ struct ptp_sys_offset_precise precise_offset;
+ struct system_device_crosststamp xtstamp;
struct ptp_clock_info *ops = ptp->info;
+ struct ptp_sys_offset *sysoff = NULL;
+ struct ptp_clock_request req;
+ struct ptp_clock_caps caps;
struct ptp_clock_time *pct;
+ unsigned int i, pin_index;
+ struct ptp_pin_desc pd;
struct timespec64 ts;
- struct system_device_crosststamp xtstamp;
int enable, err = 0;
- unsigned int i, pin_index;
switch (cmd) {
WARNING: multiple messages have this Message-ID (diff)
From: Richard Cochran <richardcochran@gmail.com>
To: Miroslav Lichvar <mlichvar@redhat.com>
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
Jacob Keller <jacob.e.keller@intel.com>
Subject: Re: [RFC PATCH 1/4] ptp: add PTP_SYS_OFFSET_EXTENDED ioctl
Date: Tue, 30 Oct 2018 20:01:11 -0700 [thread overview]
Message-ID: <20181031030111.2s4jsnunjrbfarix@localhost> (raw)
In-Reply-To: <20181031022351.24mmvf7u7bcx42rv@localhost>
On Tue, Oct 30, 2018 at 07:23:51PM -0700, Richard Cochran wrote:
> This collection of automatic variables is getting ugly. May I ask you
> to prefix a patch that puts them into reverse Christmas tree before
> your changes? (Patch below)
Forgot the diff. Here it is...
---
diff --git a/drivers/ptp/ptp_chardev.c b/drivers/ptp/ptp_chardev.c
index 2012551d93e0..b54b8158ff8a 100644
--- a/drivers/ptp/ptp_chardev.c
+++ b/drivers/ptp/ptp_chardev.c
@@ -121,18 +121,18 @@ int ptp_open(struct posix_clock *pc, fmode_t fmode)
long ptp_ioctl(struct posix_clock *pc, unsigned int cmd, unsigned long arg)
{
- struct ptp_clock_caps caps;
- struct ptp_clock_request req;
- struct ptp_sys_offset *sysoff = NULL;
- struct ptp_sys_offset_precise precise_offset;
- struct ptp_pin_desc pd;
struct ptp_clock *ptp = container_of(pc, struct ptp_clock, clock);
+ struct ptp_sys_offset_precise precise_offset;
+ struct system_device_crosststamp xtstamp;
struct ptp_clock_info *ops = ptp->info;
+ struct ptp_sys_offset *sysoff = NULL;
+ struct ptp_clock_request req;
+ struct ptp_clock_caps caps;
struct ptp_clock_time *pct;
+ unsigned int i, pin_index;
+ struct ptp_pin_desc pd;
struct timespec64 ts;
- struct system_device_crosststamp xtstamp;
int enable, err = 0;
- unsigned int i, pin_index;
switch (cmd) {
next prev parent reply other threads:[~2018-10-31 3:01 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 16:27 [Intel-wired-lan] [RFC PATCH 0/4] More accurate PHC<->system clock synchronization Miroslav Lichvar
2018-10-26 16:27 ` Miroslav Lichvar
2018-10-26 16:27 ` [Intel-wired-lan] [RFC PATCH 1/4] ptp: add PTP_SYS_OFFSET_EXTENDED ioctl Miroslav Lichvar
2018-10-26 16:27 ` Miroslav Lichvar
2018-10-26 22:16 ` [Intel-wired-lan] " Vinicius Costa Gomes
2018-10-26 22:16 ` Vinicius Costa Gomes
2018-10-29 12:52 ` Miroslav Lichvar
2018-10-29 12:52 ` Miroslav Lichvar
2018-10-31 2:23 ` Richard Cochran
2018-10-31 2:23 ` Richard Cochran
2018-10-31 3:01 ` Richard Cochran [this message]
2018-10-31 3:01 ` Richard Cochran
2018-10-26 16:27 ` [Intel-wired-lan] [RFC PATCH 2/4] e1000e: add support for extended PHC gettime Miroslav Lichvar
2018-10-26 16:27 ` Miroslav Lichvar
2018-10-26 16:27 ` [Intel-wired-lan] [RFC PATCH 3/4] igb: " Miroslav Lichvar
2018-10-26 16:27 ` Miroslav Lichvar
2018-10-31 2:29 ` [Intel-wired-lan] " Richard Cochran
2018-10-31 2:29 ` Richard Cochran
2018-10-31 9:39 ` [Intel-wired-lan] " Miroslav Lichvar
2018-10-31 9:39 ` Miroslav Lichvar
2018-10-31 16:56 ` [Intel-wired-lan] " Keller, Jacob E
2018-10-31 16:56 ` Keller, Jacob E
2018-10-26 16:27 ` [Intel-wired-lan] [RFC PATCH 4/4] ixgbe: " Miroslav Lichvar
2018-10-26 16:27 ` Miroslav Lichvar
2018-10-26 16:54 ` [Intel-wired-lan] " Keller, Jacob E
2018-10-26 16:54 ` Keller, Jacob E
2018-10-29 13:31 ` [Intel-wired-lan] " Miroslav Lichvar
2018-10-29 13:31 ` Miroslav Lichvar
2018-10-29 16:02 ` [Intel-wired-lan] " Keller, Jacob E
2018-10-29 16:02 ` Keller, Jacob E
2018-10-31 14:40 ` [Intel-wired-lan] " Richard Cochran
2018-10-31 14:40 ` Richard Cochran
2018-10-31 14:49 ` [Intel-wired-lan] " Miroslav Lichvar
2018-10-31 14:49 ` Miroslav Lichvar
2018-10-31 21:16 ` [Intel-wired-lan] " Richard Cochran
2018-10-31 21:16 ` Richard Cochran
2018-10-31 22:08 ` [Intel-wired-lan] " Keller, Jacob E
2018-10-31 22:08 ` Keller, Jacob E
2018-10-31 16:55 ` [Intel-wired-lan] " Keller, Jacob E
2018-10-31 16:55 ` Keller, Jacob E
2018-10-26 16:40 ` [Intel-wired-lan] [RFC PATCH 0/4] More accurate PHC<->system clock synchronization Keller, Jacob E
2018-10-26 16:40 ` Keller, Jacob E
2018-10-26 16:51 ` [Intel-wired-lan] " Keller, Jacob E
2018-10-26 16:51 ` Keller, Jacob E
2018-10-31 2:25 ` [Intel-wired-lan] " Richard Cochran
2018-10-31 2:25 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181031030111.2s4jsnunjrbfarix@localhost \
--to=richardcochran@gmail.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.