* [U-Boot] [PATCH] cmd: ubi: Make ubi_detach() static
@ 2018-10-31 11:37 Stefan Roese
2018-10-31 12:32 ` Miquel Raynal
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Stefan Roese @ 2018-10-31 11:37 UTC (permalink / raw)
To: u-boot
Its only called from this file, so make it static. While at it, remove
some occurances of multiple blank lines as well.
Signed-off-by: Stefan Roese <sr@denx.de>
Cc: Boris Brezillon <boris.brezillon@bootlin.com>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Jagan Teki <jagan@openedev.com>
---
cmd/ubi.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/cmd/ubi.c b/cmd/ubi.c
index 2b74a98144..a12ac703eb 100644
--- a/cmd/ubi.c
+++ b/cmd/ubi.c
@@ -101,7 +101,6 @@ static int ubi_check(char *name)
return 1;
}
-
static int verify_mkvol_req(const struct ubi_device *ubi,
const struct ubi_mkvol_req *req)
{
@@ -415,7 +414,7 @@ static int ubi_dev_scan(struct mtd_info *info, const char *vid_header_offset)
return 0;
}
-int ubi_detach(void)
+static int ubi_detach(void)
{
#ifdef CONFIG_CMD_UBIFS
/*
@@ -473,7 +472,6 @@ static int do_ubi(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
if (argc < 2)
return CMD_RET_USAGE;
-
if (strcmp(argv[1], "detach") == 0) {
if (argc < 2)
return CMD_RET_USAGE;
@@ -481,7 +479,6 @@ static int do_ubi(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
return ubi_detach();
}
-
if (strcmp(argv[1], "part") == 0) {
const char *vid_header_offset = NULL;
--
2.19.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] cmd: ubi: Make ubi_detach() static
2018-10-31 11:37 [U-Boot] [PATCH] cmd: ubi: Make ubi_detach() static Stefan Roese
@ 2018-10-31 12:32 ` Miquel Raynal
2018-10-31 12:52 ` Boris Brezillon
2018-11-22 6:11 ` Jagan Teki
2 siblings, 0 replies; 4+ messages in thread
From: Miquel Raynal @ 2018-10-31 12:32 UTC (permalink / raw)
To: u-boot
Stefan Roese <sr@denx.de> wrote on Wed, 31 Oct 2018 12:37:20 +0100:
> Its only called from this file, so make it static. While at it, remove
> some occurances of multiple blank lines as well.
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Boris Brezillon <boris.brezillon@bootlin.com>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Jagan Teki <jagan@openedev.com>
> ---
> cmd/ubi.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] cmd: ubi: Make ubi_detach() static
2018-10-31 11:37 [U-Boot] [PATCH] cmd: ubi: Make ubi_detach() static Stefan Roese
2018-10-31 12:32 ` Miquel Raynal
@ 2018-10-31 12:52 ` Boris Brezillon
2018-11-22 6:11 ` Jagan Teki
2 siblings, 0 replies; 4+ messages in thread
From: Boris Brezillon @ 2018-10-31 12:52 UTC (permalink / raw)
To: u-boot
On Wed, 31 Oct 2018 12:37:20 +0100
Stefan Roese <sr@denx.de> wrote:
> Its only called from this file, so make it static. While at it, remove
> some occurances of multiple blank lines as well.
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Boris Brezillon <boris.brezillon@bootlin.com>
Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Jagan Teki <jagan@openedev.com>
> ---
> cmd/ubi.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/cmd/ubi.c b/cmd/ubi.c
> index 2b74a98144..a12ac703eb 100644
> --- a/cmd/ubi.c
> +++ b/cmd/ubi.c
> @@ -101,7 +101,6 @@ static int ubi_check(char *name)
> return 1;
> }
>
> -
> static int verify_mkvol_req(const struct ubi_device *ubi,
> const struct ubi_mkvol_req *req)
> {
> @@ -415,7 +414,7 @@ static int ubi_dev_scan(struct mtd_info *info, const char *vid_header_offset)
> return 0;
> }
>
> -int ubi_detach(void)
> +static int ubi_detach(void)
> {
> #ifdef CONFIG_CMD_UBIFS
> /*
> @@ -473,7 +472,6 @@ static int do_ubi(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
> if (argc < 2)
> return CMD_RET_USAGE;
>
> -
> if (strcmp(argv[1], "detach") == 0) {
> if (argc < 2)
> return CMD_RET_USAGE;
> @@ -481,7 +479,6 @@ static int do_ubi(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
> return ubi_detach();
> }
>
> -
> if (strcmp(argv[1], "part") == 0) {
> const char *vid_header_offset = NULL;
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] cmd: ubi: Make ubi_detach() static
2018-10-31 11:37 [U-Boot] [PATCH] cmd: ubi: Make ubi_detach() static Stefan Roese
2018-10-31 12:32 ` Miquel Raynal
2018-10-31 12:52 ` Boris Brezillon
@ 2018-11-22 6:11 ` Jagan Teki
2 siblings, 0 replies; 4+ messages in thread
From: Jagan Teki @ 2018-11-22 6:11 UTC (permalink / raw)
To: u-boot
On Wed, Oct 31, 2018 at 5:07 PM Stefan Roese <sr@denx.de> wrote:
>
> Its only called from this file, so make it static. While at it, remove
> some occurances of multiple blank lines as well.
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Boris Brezillon <boris.brezillon@bootlin.com>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Jagan Teki <jagan@openedev.com>
> ---
Applied to u-boot-spi/master
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-11-22 6:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-31 11:37 [U-Boot] [PATCH] cmd: ubi: Make ubi_detach() static Stefan Roese
2018-10-31 12:32 ` Miquel Raynal
2018-10-31 12:52 ` Boris Brezillon
2018-11-22 6:11 ` Jagan Teki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.