[U-Boot] [PATCH] cmd: ubi: Make ubi_detach() static

[U-Boot] [PATCH] cmd: ubi: Make ubi_detach() static

[Stefan Roese]

Its only called from this file, so make it static. While at it, remove
some occurances of multiple blank lines as well.

Signed-off-by: Stefan Roese <sr@denx.de>
Cc: Boris Brezillon <boris.brezillon@bootlin.com>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Jagan Teki <jagan@openedev.com>
---
 cmd/ubi.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/cmd/ubi.c b/cmd/ubi.c
index 2b74a98144..a12ac703eb 100644
--- a/cmd/ubi.c
+++ b/cmd/ubi.c
@@ -101,7 +101,6 @@ static int ubi_check(char *name)
 	return 1;
 }
 
-
 static int verify_mkvol_req(const struct ubi_device *ubi,
 			    const struct ubi_mkvol_req *req)
 {
@@ -415,7 +414,7 @@ static int ubi_dev_scan(struct mtd_info *info, const char *vid_header_offset)
 	return 0;
 }
 
-int ubi_detach(void)
+static int ubi_detach(void)
 {
 #ifdef CONFIG_CMD_UBIFS
 	/*
@@ -473,7 +472,6 @@ static int do_ubi(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 	if (argc < 2)
 		return CMD_RET_USAGE;
 
-
 	if (strcmp(argv[1], "detach") == 0) {
 		if (argc < 2)
 			return CMD_RET_USAGE;
@@ -481,7 +479,6 @@ static int do_ubi(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 		return ubi_detach();
 	}
 
-
 	if (strcmp(argv[1], "part") == 0) {
 		const char *vid_header_offset = NULL;
 
-- 
2.19.1

[U-Boot] [PATCH] cmd: ubi: Make ubi_detach() static

[Miquel Raynal]

Stefan Roese <sr@denx.de> wrote on Wed, 31 Oct 2018 12:37:20 +0100:

> Its only called from this file, so make it static. While at it, remove
> some occurances of multiple blank lines as well.
> 
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Boris Brezillon <boris.brezillon@bootlin.com>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Jagan Teki <jagan@openedev.com>
> ---
>  cmd/ubi.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>


Thanks,
Miquèl

[U-Boot] [PATCH] cmd: ubi: Make ubi_detach() static

[Boris Brezillon]

On Wed, 31 Oct 2018 12:37:20 +0100
Stefan Roese <sr@denx.de> wrote:

> Its only called from this file, so make it static. While at it, remove
> some occurances of multiple blank lines as well.
> 
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Boris Brezillon <boris.brezillon@bootlin.com>

Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com>

> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Jagan Teki <jagan@openedev.com>
> ---
>  cmd/ubi.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/cmd/ubi.c b/cmd/ubi.c
> index 2b74a98144..a12ac703eb 100644
> --- a/cmd/ubi.c
> +++ b/cmd/ubi.c
> @@ -101,7 +101,6 @@ static int ubi_check(char *name)
>  	return 1;
>  }
>  
> -
>  static int verify_mkvol_req(const struct ubi_device *ubi,
>  			    const struct ubi_mkvol_req *req)
>  {
> @@ -415,7 +414,7 @@ static int ubi_dev_scan(struct mtd_info *info, const char *vid_header_offset)
>  	return 0;
>  }
>  
> -int ubi_detach(void)
> +static int ubi_detach(void)
>  {
>  #ifdef CONFIG_CMD_UBIFS
>  	/*
> @@ -473,7 +472,6 @@ static int do_ubi(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>  	if (argc < 2)
>  		return CMD_RET_USAGE;
>  
> -
>  	if (strcmp(argv[1], "detach") == 0) {
>  		if (argc < 2)
>  			return CMD_RET_USAGE;
> @@ -481,7 +479,6 @@ static int do_ubi(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>  		return ubi_detach();
>  	}
>  
> -
>  	if (strcmp(argv[1], "part") == 0) {
>  		const char *vid_header_offset = NULL;
>  

[U-Boot] [PATCH] cmd: ubi: Make ubi_detach() static

[Jagan Teki]

On Wed, Oct 31, 2018 at 5:07 PM Stefan Roese <sr@denx.de> wrote:
>
> Its only called from this file, so make it static. While at it, remove
> some occurances of multiple blank lines as well.
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Boris Brezillon <boris.brezillon@bootlin.com>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Jagan Teki <jagan@openedev.com>
> ---

Applied to u-boot-spi/master