All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/bridge: Fix 0-day build error
@ 2018-11-19 12:44 ` Fabrizio Castro
  0 siblings, 0 replies; 10+ messages in thread
From: Fabrizio Castro @ 2018-11-19 12:44 UTC (permalink / raw)
  To: Peter Rosin, Boris Brezillon, Archit Taneja, Andrzej Hajda,
	David Airlie
  Cc: Fabrizio Castro, Laurent Pinchart, dri-devel, Simon Horman,
	Geert Uytterhoeven, Chris Paterson, Biju Das, linux-renesas-soc

kbuild test robot reports:

>> ERROR: "i2c_mux_add_adapter" [drivers/gpu/drm/bridge/sii902x.ko]
undefined!
>> ERROR: "i2c_mux_alloc" [drivers/gpu/drm/bridge/sii902x.ko]
undefined!
>> ERROR: "i2c_mux_del_adapters" [drivers/gpu/drm/bridge/sii902x.ko]
undefined!

Quite obviously the driver depends on I2C_MUX, but adding a "depends on"
introduces a recursive dependency, therefore this patch selects I2C_MUX
instead.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Link: https://lists.01.org/pipermail/kbuild-all/2018-November/054924.html
---
 drivers/gpu/drm/bridge/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index 9eeb8ef..2fee47b 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -95,6 +95,7 @@ config DRM_SII902X
 	depends on OF
 	select DRM_KMS_HELPER
 	select REGMAP_I2C
+	select I2C_MUX
 	---help---
 	  Silicon Image sii902x bridge chip driver.
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH] drm/bridge: Fix 0-day build error
@ 2018-11-19 12:44 ` Fabrizio Castro
  0 siblings, 0 replies; 10+ messages in thread
From: Fabrizio Castro @ 2018-11-19 12:44 UTC (permalink / raw)
  To: Peter Rosin, Boris Brezillon, Archit Taneja, Andrzej Hajda,
	David Airlie
  Cc: Fabrizio Castro, Chris Paterson, Geert Uytterhoeven, dri-devel,
	Biju Das, linux-renesas-soc, Simon Horman, Laurent Pinchart

kbuild test robot reports:

>> ERROR: "i2c_mux_add_adapter" [drivers/gpu/drm/bridge/sii902x.ko]
undefined!
>> ERROR: "i2c_mux_alloc" [drivers/gpu/drm/bridge/sii902x.ko]
undefined!
>> ERROR: "i2c_mux_del_adapters" [drivers/gpu/drm/bridge/sii902x.ko]
undefined!

Quite obviously the driver depends on I2C_MUX, but adding a "depends on"
introduces a recursive dependency, therefore this patch selects I2C_MUX
instead.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Link: https://lists.01.org/pipermail/kbuild-all/2018-November/054924.html
---
 drivers/gpu/drm/bridge/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index 9eeb8ef..2fee47b 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -95,6 +95,7 @@ config DRM_SII902X
 	depends on OF
 	select DRM_KMS_HELPER
 	select REGMAP_I2C
+	select I2C_MUX
 	---help---
 	  Silicon Image sii902x bridge chip driver.
 
-- 
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* Re: [PATCH] drm/bridge: Fix 0-day build error
  2018-11-19 12:44 ` Fabrizio Castro
@ 2018-11-19 12:51   ` Boris Brezillon
  -1 siblings, 0 replies; 10+ messages in thread
From: Boris Brezillon @ 2018-11-19 12:51 UTC (permalink / raw)
  To: Fabrizio Castro
  Cc: Peter Rosin, Archit Taneja, Andrzej Hajda, David Airlie,
	Laurent Pinchart, dri-devel, Simon Horman, Geert Uytterhoeven,
	Chris Paterson, Biju Das, linux-renesas-soc

Hi Fabrizio,

The prefix should be "drm/bridge/sii902x:" and I'd prefer a short
explanation of what is problematic in the subject rather than "Fix
0-day build error". Maybe something like

"drm/bridge/sii902x: Add missing dependency on I2C_MUX"

On Mon, 19 Nov 2018 12:44:23 +0000
Fabrizio Castro <fabrizio.castro@bp.renesas.com> wrote:

> kbuild test robot reports:
> 
> >> ERROR: "i2c_mux_add_adapter" [drivers/gpu/drm/bridge/sii902x.ko]  
> undefined!
> >> ERROR: "i2c_mux_alloc" [drivers/gpu/drm/bridge/sii902x.ko]  
> undefined!
> >> ERROR: "i2c_mux_del_adapters" [drivers/gpu/drm/bridge/sii902x.ko]  
> undefined!
> 
> Quite obviously the driver depends on I2C_MUX, but adding a "depends on"
> introduces a recursive dependency, therefore this patch selects I2C_MUX
> instead.
> 

You need a fixes tag here:

Fixes: 21d808405fe4 ("drm/bridge/sii902x: Fix EDID readback")

Thanks,

Boris

> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Link: https://lists.01.org/pipermail/kbuild-all/2018-November/054924.html
> ---
>  drivers/gpu/drm/bridge/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index 9eeb8ef..2fee47b 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -95,6 +95,7 @@ config DRM_SII902X
>  	depends on OF
>  	select DRM_KMS_HELPER
>  	select REGMAP_I2C
> +	select I2C_MUX
>  	---help---
>  	  Silicon Image sii902x bridge chip driver.
>  

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH] drm/bridge: Fix 0-day build error
@ 2018-11-19 12:51   ` Boris Brezillon
  0 siblings, 0 replies; 10+ messages in thread
From: Boris Brezillon @ 2018-11-19 12:51 UTC (permalink / raw)
  To: Fabrizio Castro
  Cc: Geert Uytterhoeven, David Airlie, Chris Paterson, dri-devel,
	Biju Das, linux-renesas-soc, Simon Horman, Laurent Pinchart,
	Peter Rosin

Hi Fabrizio,

The prefix should be "drm/bridge/sii902x:" and I'd prefer a short
explanation of what is problematic in the subject rather than "Fix
0-day build error". Maybe something like

"drm/bridge/sii902x: Add missing dependency on I2C_MUX"

On Mon, 19 Nov 2018 12:44:23 +0000
Fabrizio Castro <fabrizio.castro@bp.renesas.com> wrote:

> kbuild test robot reports:
> 
> >> ERROR: "i2c_mux_add_adapter" [drivers/gpu/drm/bridge/sii902x.ko]  
> undefined!
> >> ERROR: "i2c_mux_alloc" [drivers/gpu/drm/bridge/sii902x.ko]  
> undefined!
> >> ERROR: "i2c_mux_del_adapters" [drivers/gpu/drm/bridge/sii902x.ko]  
> undefined!
> 
> Quite obviously the driver depends on I2C_MUX, but adding a "depends on"
> introduces a recursive dependency, therefore this patch selects I2C_MUX
> instead.
> 

You need a fixes tag here:

Fixes: 21d808405fe4 ("drm/bridge/sii902x: Fix EDID readback")

Thanks,

Boris

> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Link: https://lists.01.org/pipermail/kbuild-all/2018-November/054924.html
> ---
>  drivers/gpu/drm/bridge/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index 9eeb8ef..2fee47b 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -95,6 +95,7 @@ config DRM_SII902X
>  	depends on OF
>  	select DRM_KMS_HELPER
>  	select REGMAP_I2C
> +	select I2C_MUX
>  	---help---
>  	  Silicon Image sii902x bridge chip driver.
>  

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 10+ messages in thread
* RE: [PATCH] drm/bridge: Fix 0-day build error
  2018-11-19 12:51   ` Boris Brezillon
@ 2018-11-19 13:09     ` Fabrizio Castro
  -1 siblings, 0 replies; 10+ messages in thread
From: Fabrizio Castro @ 2018-11-19 13:09 UTC (permalink / raw)
  To: Boris Brezillon
  Cc: Peter Rosin, Archit Taneja, Andrzej Hajda, David Airlie,
	Laurent Pinchart, dri-devel@lists.freedesktop.org, Simon Horman,
	Geert Uytterhoeven, Chris Paterson, Biju Das,
	linux-renesas-soc@vger.kernel.org

Hi Boris,

> From: Boris Brezillon <boris.brezillon@bootlin.com>
> Sent: 19 November 2018 12:51
> Subject: Re: [PATCH] drm/bridge: Fix 0-day build error
>
> Hi Fabrizio,
>
> The prefix should be "drm/bridge/sii902x:" and I'd prefer a short
> explanation of what is problematic in the subject rather than "Fix
> 0-day build error". Maybe something like
>
> "drm/bridge/sii902x: Add missing dependency on I2C_MUX"
>
> On Mon, 19 Nov 2018 12:44:23 +0000
> Fabrizio Castro <fabrizio.castro@bp.renesas.com> wrote:
>
> > kbuild test robot reports:
> >
> > >> ERROR: "i2c_mux_add_adapter" [drivers/gpu/drm/bridge/sii902x.ko]
> > undefined!
> > >> ERROR: "i2c_mux_alloc" [drivers/gpu/drm/bridge/sii902x.ko]
> > undefined!
> > >> ERROR: "i2c_mux_del_adapters" [drivers/gpu/drm/bridge/sii902x.ko]
> > undefined!
> >
> > Quite obviously the driver depends on I2C_MUX, but adding a "depends on"
> > introduces a recursive dependency, therefore this patch selects I2C_MUX
> > instead.
> >
>
> You need a fixes tag here:
>
> Fixes: 21d808405fe4 ("drm/bridge/sii902x: Fix EDID readback")

Thank you for spotting this, I'll send a v2 right away.

Cheers,
Fab

>
> Thanks,
>
> Boris
>
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Link: https://lists.01.org/pipermail/kbuild-all/2018-November/054924.html
> > ---
> >  drivers/gpu/drm/bridge/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> > index 9eeb8ef..2fee47b 100644
> > --- a/drivers/gpu/drm/bridge/Kconfig
> > +++ b/drivers/gpu/drm/bridge/Kconfig
> > @@ -95,6 +95,7 @@ config DRM_SII902X
> >  depends on OF
> >  select DRM_KMS_HELPER
> >  select REGMAP_I2C
> > +select I2C_MUX
> >  ---help---
> >    Silicon Image sii902x bridge chip driver.
> >




Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

^ permalink raw reply	[flat|nested] 10+ messages in thread
* RE: [PATCH] drm/bridge: Fix 0-day build error
@ 2018-11-19 13:09     ` Fabrizio Castro
  0 siblings, 0 replies; 10+ messages in thread
From: Fabrizio Castro @ 2018-11-19 13:09 UTC (permalink / raw)
  To: Boris Brezillon
  Cc: Geert Uytterhoeven, David Airlie, Chris Paterson,
	dri-devel@lists.freedesktop.org, Biju Das,
	linux-renesas-soc@vger.kernel.org, Simon Horman, Laurent Pinchart,
	Peter Rosin

Hi Boris,

> From: Boris Brezillon <boris.brezillon@bootlin.com>
> Sent: 19 November 2018 12:51
> Subject: Re: [PATCH] drm/bridge: Fix 0-day build error
>
> Hi Fabrizio,
>
> The prefix should be "drm/bridge/sii902x:" and I'd prefer a short
> explanation of what is problematic in the subject rather than "Fix
> 0-day build error". Maybe something like
>
> "drm/bridge/sii902x: Add missing dependency on I2C_MUX"
>
> On Mon, 19 Nov 2018 12:44:23 +0000
> Fabrizio Castro <fabrizio.castro@bp.renesas.com> wrote:
>
> > kbuild test robot reports:
> >
> > >> ERROR: "i2c_mux_add_adapter" [drivers/gpu/drm/bridge/sii902x.ko]
> > undefined!
> > >> ERROR: "i2c_mux_alloc" [drivers/gpu/drm/bridge/sii902x.ko]
> > undefined!
> > >> ERROR: "i2c_mux_del_adapters" [drivers/gpu/drm/bridge/sii902x.ko]
> > undefined!
> >
> > Quite obviously the driver depends on I2C_MUX, but adding a "depends on"
> > introduces a recursive dependency, therefore this patch selects I2C_MUX
> > instead.
> >
>
> You need a fixes tag here:
>
> Fixes: 21d808405fe4 ("drm/bridge/sii902x: Fix EDID readback")

Thank you for spotting this, I'll send a v2 right away.

Cheers,
Fab

>
> Thanks,
>
> Boris
>
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Link: https://lists.01.org/pipermail/kbuild-all/2018-November/054924.html
> > ---
> >  drivers/gpu/drm/bridge/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> > index 9eeb8ef..2fee47b 100644
> > --- a/drivers/gpu/drm/bridge/Kconfig
> > +++ b/drivers/gpu/drm/bridge/Kconfig
> > @@ -95,6 +95,7 @@ config DRM_SII902X
> >  depends on OF
> >  select DRM_KMS_HELPER
> >  select REGMAP_I2C
> > +select I2C_MUX
> >  ---help---
> >    Silicon Image sii902x bridge chip driver.
> >




Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH] drm/bridge: Fix 0-day build error
  2018-11-19 13:09     ` Fabrizio Castro
@ 2018-11-19 13:22       ` Boris Brezillon
  -1 siblings, 0 replies; 10+ messages in thread
From: Boris Brezillon @ 2018-11-19 13:22 UTC (permalink / raw)
  To: Fabrizio Castro
  Cc: Peter Rosin, Archit Taneja, Andrzej Hajda, David Airlie,
	Laurent Pinchart, dri-devel@lists.freedesktop.org, Simon Horman,
	Geert Uytterhoeven, Chris Paterson, Biju Das,
	linux-renesas-soc@vger.kernel.org

On Mon, 19 Nov 2018 13:09:16 +0000
Fabrizio Castro <fabrizio.castro@bp.renesas.com> wrote:

> Hi Boris,
> 
> > From: Boris Brezillon <boris.brezillon@bootlin.com>
> > Sent: 19 November 2018 12:51
> > Subject: Re: [PATCH] drm/bridge: Fix 0-day build error
> >
> > Hi Fabrizio,
> >
> > The prefix should be "drm/bridge/sii902x:" and I'd prefer a short
> > explanation of what is problematic in the subject rather than "Fix
> > 0-day build error". Maybe something like
> >
> > "drm/bridge/sii902x: Add missing dependency on I2C_MUX"
> >
> > On Mon, 19 Nov 2018 12:44:23 +0000
> > Fabrizio Castro <fabrizio.castro@bp.renesas.com> wrote:
> >  
> > > kbuild test robot reports:
> > >  
> > > >> ERROR: "i2c_mux_add_adapter" [drivers/gpu/drm/bridge/sii902x.ko]  
> > > undefined!  
> > > >> ERROR: "i2c_mux_alloc" [drivers/gpu/drm/bridge/sii902x.ko]  
> > > undefined!  
> > > >> ERROR: "i2c_mux_del_adapters" [drivers/gpu/drm/bridge/sii902x.ko]  
> > > undefined!
> > >
> > > Quite obviously the driver depends on I2C_MUX, but adding a "depends on"
> > > introduces a recursive dependency, therefore this patch selects I2C_MUX
> > > instead.
> > >  
> >
> > You need a fixes tag here:
> >
> > Fixes: 21d808405fe4 ("drm/bridge/sii902x: Fix EDID readback")  
> 
> Thank you for spotting this, I'll send a v2 right away.

Looks like you didn't change the subject in your v2.

> 
> Cheers,
> Fab
> 
> >
> > Thanks,
> >
> > Boris
> >  
> > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > Link: https://lists.01.org/pipermail/kbuild-all/2018-November/054924.html
> > > ---
> > >  drivers/gpu/drm/bridge/Kconfig | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> > > index 9eeb8ef..2fee47b 100644
> > > --- a/drivers/gpu/drm/bridge/Kconfig
> > > +++ b/drivers/gpu/drm/bridge/Kconfig
> > > @@ -95,6 +95,7 @@ config DRM_SII902X
> > >  depends on OF
> > >  select DRM_KMS_HELPER
> > >  select REGMAP_I2C
> > > +select I2C_MUX
> > >  ---help---
> > >    Silicon Image sii902x bridge chip driver.
> > >  
> 
> 
> 
> 
> Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH] drm/bridge: Fix 0-day build error
@ 2018-11-19 13:22       ` Boris Brezillon
  0 siblings, 0 replies; 10+ messages in thread
From: Boris Brezillon @ 2018-11-19 13:22 UTC (permalink / raw)
  To: Fabrizio Castro
  Cc: Geert Uytterhoeven, David Airlie, Chris Paterson,
	dri-devel@lists.freedesktop.org, Biju Das,
	linux-renesas-soc@vger.kernel.org, Simon Horman, Laurent Pinchart,
	Peter Rosin

On Mon, 19 Nov 2018 13:09:16 +0000
Fabrizio Castro <fabrizio.castro@bp.renesas.com> wrote:

> Hi Boris,
> 
> > From: Boris Brezillon <boris.brezillon@bootlin.com>
> > Sent: 19 November 2018 12:51
> > Subject: Re: [PATCH] drm/bridge: Fix 0-day build error
> >
> > Hi Fabrizio,
> >
> > The prefix should be "drm/bridge/sii902x:" and I'd prefer a short
> > explanation of what is problematic in the subject rather than "Fix
> > 0-day build error". Maybe something like
> >
> > "drm/bridge/sii902x: Add missing dependency on I2C_MUX"
> >
> > On Mon, 19 Nov 2018 12:44:23 +0000
> > Fabrizio Castro <fabrizio.castro@bp.renesas.com> wrote:
> >  
> > > kbuild test robot reports:
> > >  
> > > >> ERROR: "i2c_mux_add_adapter" [drivers/gpu/drm/bridge/sii902x.ko]  
> > > undefined!  
> > > >> ERROR: "i2c_mux_alloc" [drivers/gpu/drm/bridge/sii902x.ko]  
> > > undefined!  
> > > >> ERROR: "i2c_mux_del_adapters" [drivers/gpu/drm/bridge/sii902x.ko]  
> > > undefined!
> > >
> > > Quite obviously the driver depends on I2C_MUX, but adding a "depends on"
> > > introduces a recursive dependency, therefore this patch selects I2C_MUX
> > > instead.
> > >  
> >
> > You need a fixes tag here:
> >
> > Fixes: 21d808405fe4 ("drm/bridge/sii902x: Fix EDID readback")  
> 
> Thank you for spotting this, I'll send a v2 right away.

Looks like you didn't change the subject in your v2.

> 
> Cheers,
> Fab
> 
> >
> > Thanks,
> >
> > Boris
> >  
> > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > Link: https://lists.01.org/pipermail/kbuild-all/2018-November/054924.html
> > > ---
> > >  drivers/gpu/drm/bridge/Kconfig | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> > > index 9eeb8ef..2fee47b 100644
> > > --- a/drivers/gpu/drm/bridge/Kconfig
> > > +++ b/drivers/gpu/drm/bridge/Kconfig
> > > @@ -95,6 +95,7 @@ config DRM_SII902X
> > >  depends on OF
> > >  select DRM_KMS_HELPER
> > >  select REGMAP_I2C
> > > +select I2C_MUX
> > >  ---help---
> > >    Silicon Image sii902x bridge chip driver.
> > >  
> 
> 
> 
> 
> Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 10+ messages in thread
* RE: [PATCH] drm/bridge: Fix 0-day build error
  2018-11-19 13:22       ` Boris Brezillon
@ 2018-11-19 13:24         ` Fabrizio Castro
  -1 siblings, 0 replies; 10+ messages in thread
From: Fabrizio Castro @ 2018-11-19 13:24 UTC (permalink / raw)
  To: Boris Brezillon
  Cc: Peter Rosin, Archit Taneja, Andrzej Hajda, David Airlie,
	Laurent Pinchart, dri-devel@lists.freedesktop.org, Simon Horman,
	Geert Uytterhoeven, Chris Paterson, Biju Das,
	linux-renesas-soc@vger.kernel.org



> -----Original Message-----
> From: linux-renesas-soc-owner@vger.kernel.org <linux-renesas-soc-owner@vger.kernel.org> On Behalf Of Boris Brezillon
> Sent: 19 November 2018 13:23
> To: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Cc: Peter Rosin <peda@axentia.se>; Archit Taneja <architt@codeaurora.org>; Andrzej Hajda <a.hajda@samsung.com>; David Airlie
> <airlied@linux.ie>; Laurent Pinchart <Laurent.pinchart@ideasonboard.com>; dri-devel@lists.freedesktop.org; Simon Horman
> <horms@verge.net.au>; Geert Uytterhoeven <geert+renesas@glider.be>; Chris Paterson <Chris.Paterson2@renesas.com>; Biju Das
> <biju.das@bp.renesas.com>; linux-renesas-soc@vger.kernel.org
> Subject: Re: [PATCH] drm/bridge: Fix 0-day build error
>
> On Mon, 19 Nov 2018 13:09:16 +0000
> Fabrizio Castro <fabrizio.castro@bp.renesas.com> wrote:
>
> > Hi Boris,
> >
> > > From: Boris Brezillon <boris.brezillon@bootlin.com>
> > > Sent: 19 November 2018 12:51
> > > Subject: Re: [PATCH] drm/bridge: Fix 0-day build error
> > >
> > > Hi Fabrizio,
> > >
> > > The prefix should be "drm/bridge/sii902x:" and I'd prefer a short
> > > explanation of what is problematic in the subject rather than "Fix
> > > 0-day build error". Maybe something like
> > >
> > > "drm/bridge/sii902x: Add missing dependency on I2C_MUX"
> > >
> > > On Mon, 19 Nov 2018 12:44:23 +0000
> > > Fabrizio Castro <fabrizio.castro@bp.renesas.com> wrote:
> > >
> > > > kbuild test robot reports:
> > > >
> > > > >> ERROR: "i2c_mux_add_adapter" [drivers/gpu/drm/bridge/sii902x.ko]
> > > > undefined!
> > > > >> ERROR: "i2c_mux_alloc" [drivers/gpu/drm/bridge/sii902x.ko]
> > > > undefined!
> > > > >> ERROR: "i2c_mux_del_adapters" [drivers/gpu/drm/bridge/sii902x.ko]
> > > > undefined!
> > > >
> > > > Quite obviously the driver depends on I2C_MUX, but adding a "depends on"
> > > > introduces a recursive dependency, therefore this patch selects I2C_MUX
> > > > instead.
> > > >
> > >
> > > You need a fixes tag here:
> > >
> > > Fixes: 21d808405fe4 ("drm/bridge/sii902x: Fix EDID readback")
> >
> > Thank you for spotting this, I'll send a v2 right away.
>
> Looks like you didn't change the subject in your v2.

Will send a v3...

Thanks,
Fab

>
> >
> > Cheers,
> > Fab
> >
> > >
> > > Thanks,
> > >
> > > Boris
> > >
> > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > > Link: https://lists.01.org/pipermail/kbuild-all/2018-November/054924.html
> > > > ---
> > > >  drivers/gpu/drm/bridge/Kconfig | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> > > > index 9eeb8ef..2fee47b 100644
> > > > --- a/drivers/gpu/drm/bridge/Kconfig
> > > > +++ b/drivers/gpu/drm/bridge/Kconfig
> > > > @@ -95,6 +95,7 @@ config DRM_SII902X
> > > >  depends on OF
> > > >  select DRM_KMS_HELPER
> > > >  select REGMAP_I2C
> > > > +select I2C_MUX
> > > >  ---help---
> > > >    Silicon Image sii902x bridge chip driver.
> > > >
> >
> >
> >
> >
> > Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England
> & Wales under Registered No. 04586709.




Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

^ permalink raw reply	[flat|nested] 10+ messages in thread
* RE: [PATCH] drm/bridge: Fix 0-day build error
@ 2018-11-19 13:24         ` Fabrizio Castro
  0 siblings, 0 replies; 10+ messages in thread
From: Fabrizio Castro @ 2018-11-19 13:24 UTC (permalink / raw)
  To: Boris Brezillon
  Cc: Geert Uytterhoeven, David Airlie, Chris Paterson,
	dri-devel@lists.freedesktop.org, Biju Das,
	linux-renesas-soc@vger.kernel.org, Simon Horman, Laurent Pinchart,
	Peter Rosin



> -----Original Message-----
> From: linux-renesas-soc-owner@vger.kernel.org <linux-renesas-soc-owner@vger.kernel.org> On Behalf Of Boris Brezillon
> Sent: 19 November 2018 13:23
> To: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Cc: Peter Rosin <peda@axentia.se>; Archit Taneja <architt@codeaurora.org>; Andrzej Hajda <a.hajda@samsung.com>; David Airlie
> <airlied@linux.ie>; Laurent Pinchart <Laurent.pinchart@ideasonboard.com>; dri-devel@lists.freedesktop.org; Simon Horman
> <horms@verge.net.au>; Geert Uytterhoeven <geert+renesas@glider.be>; Chris Paterson <Chris.Paterson2@renesas.com>; Biju Das
> <biju.das@bp.renesas.com>; linux-renesas-soc@vger.kernel.org
> Subject: Re: [PATCH] drm/bridge: Fix 0-day build error
>
> On Mon, 19 Nov 2018 13:09:16 +0000
> Fabrizio Castro <fabrizio.castro@bp.renesas.com> wrote:
>
> > Hi Boris,
> >
> > > From: Boris Brezillon <boris.brezillon@bootlin.com>
> > > Sent: 19 November 2018 12:51
> > > Subject: Re: [PATCH] drm/bridge: Fix 0-day build error
> > >
> > > Hi Fabrizio,
> > >
> > > The prefix should be "drm/bridge/sii902x:" and I'd prefer a short
> > > explanation of what is problematic in the subject rather than "Fix
> > > 0-day build error". Maybe something like
> > >
> > > "drm/bridge/sii902x: Add missing dependency on I2C_MUX"
> > >
> > > On Mon, 19 Nov 2018 12:44:23 +0000
> > > Fabrizio Castro <fabrizio.castro@bp.renesas.com> wrote:
> > >
> > > > kbuild test robot reports:
> > > >
> > > > >> ERROR: "i2c_mux_add_adapter" [drivers/gpu/drm/bridge/sii902x.ko]
> > > > undefined!
> > > > >> ERROR: "i2c_mux_alloc" [drivers/gpu/drm/bridge/sii902x.ko]
> > > > undefined!
> > > > >> ERROR: "i2c_mux_del_adapters" [drivers/gpu/drm/bridge/sii902x.ko]
> > > > undefined!
> > > >
> > > > Quite obviously the driver depends on I2C_MUX, but adding a "depends on"
> > > > introduces a recursive dependency, therefore this patch selects I2C_MUX
> > > > instead.
> > > >
> > >
> > > You need a fixes tag here:
> > >
> > > Fixes: 21d808405fe4 ("drm/bridge/sii902x: Fix EDID readback")
> >
> > Thank you for spotting this, I'll send a v2 right away.
>
> Looks like you didn't change the subject in your v2.

Will send a v3...

Thanks,
Fab

>
> >
> > Cheers,
> > Fab
> >
> > >
> > > Thanks,
> > >
> > > Boris
> > >
> > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > > Link: https://lists.01.org/pipermail/kbuild-all/2018-November/054924.html
> > > > ---
> > > >  drivers/gpu/drm/bridge/Kconfig | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> > > > index 9eeb8ef..2fee47b 100644
> > > > --- a/drivers/gpu/drm/bridge/Kconfig
> > > > +++ b/drivers/gpu/drm/bridge/Kconfig
> > > > @@ -95,6 +95,7 @@ config DRM_SII902X
> > > >  depends on OF
> > > >  select DRM_KMS_HELPER
> > > >  select REGMAP_I2C
> > > > +select I2C_MUX
> > > >  ---help---
> > > >    Silicon Image sii902x bridge chip driver.
> > > >
> >
> >
> >
> >
> > Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England
> & Wales under Registered No. 04586709.




Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2018-11-19 23:48 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-19 12:44 [PATCH] drm/bridge: Fix 0-day build error Fabrizio Castro
2018-11-19 12:44 ` Fabrizio Castro
2018-11-19 12:51 ` Boris Brezillon
2018-11-19 12:51   ` Boris Brezillon
2018-11-19 13:09   ` Fabrizio Castro
2018-11-19 13:09     ` Fabrizio Castro
2018-11-19 13:22     ` Boris Brezillon
2018-11-19 13:22       ` Boris Brezillon
2018-11-19 13:24       ` Fabrizio Castro
2018-11-19 13:24         ` Fabrizio Castro

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.