From: Lukasz Majewski <lukma@denx.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-kernel <linux-kernel@vger.kernel.org>,
Stefan Agner <stefan@agner.ch>, Rob Herring <robh+dt@kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3] ARM: dts: Add support for Liebherr's BK4 device (vf610 based)
Date: Fri, 7 Dec 2018 10:29:50 +0100 [thread overview]
Message-ID: <20181207102950.68796cf0@jawa> (raw)
In-Reply-To: <CAOMZO5CUfN7uLf7bsw6Xg4+TNrRYodw11Ekg5ypqyXU6q-UFtg@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1282 bytes --]
Hi Fabio,
> Hi Lukasz,
>
> On Thu, Dec 6, 2018 at 11:08 AM Lukasz Majewski <lukma@denx.de> wrote:
>
> > I will check this latter this week...
>
> Reading the spi dt-binding it states that the spi slave node is
> optional.
>
> If I remove it like this, then the warning is gone:
Unfortunately, the "slave" node is necessary - the "lwn,bk4" compatible
causes the spidev driver to be bound.
Use space applications on this system use it to perform SPI
transmission.
IMHO, removing the node is not a solution - we shall discover why on
current next we do see such errors.
>
> --- a/arch/arm/boot/dts/vf610-bk4.dts
> +++ b/arch/arm/boot/dts/vf610-bk4.dts
> @@ -109,12 +109,6 @@
> bus-num = <3>;
> status = "okay";
> spi-slave;
> -
> - slave@0 {
> - compatible = "lwn,bk4";
> - spi-max-frequency = <30000000>;
> - reg = <0>;
> - };
> };
>
> &edma0 {
>
> Does spi slave still work without it?
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Lukasz Majewski <lukma@denx.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
Sascha Hauer <kernel@pengutronix.de>,
Stefan Agner <stefan@agner.ch>,
Fabio Estevam <fabio.estevam@nxp.com>
Subject: Re: [PATCH v3] ARM: dts: Add support for Liebherr's BK4 device (vf610 based)
Date: Fri, 7 Dec 2018 10:29:50 +0100 [thread overview]
Message-ID: <20181207102950.68796cf0@jawa> (raw)
In-Reply-To: <CAOMZO5CUfN7uLf7bsw6Xg4+TNrRYodw11Ekg5ypqyXU6q-UFtg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1282 bytes --]
Hi Fabio,
> Hi Lukasz,
>
> On Thu, Dec 6, 2018 at 11:08 AM Lukasz Majewski <lukma@denx.de> wrote:
>
> > I will check this latter this week...
>
> Reading the spi dt-binding it states that the spi slave node is
> optional.
>
> If I remove it like this, then the warning is gone:
Unfortunately, the "slave" node is necessary - the "lwn,bk4" compatible
causes the spidev driver to be bound.
Use space applications on this system use it to perform SPI
transmission.
IMHO, removing the node is not a solution - we shall discover why on
current next we do see such errors.
>
> --- a/arch/arm/boot/dts/vf610-bk4.dts
> +++ b/arch/arm/boot/dts/vf610-bk4.dts
> @@ -109,12 +109,6 @@
> bus-num = <3>;
> status = "okay";
> spi-slave;
> -
> - slave@0 {
> - compatible = "lwn,bk4";
> - spi-max-frequency = <30000000>;
> - reg = <0>;
> - };
> };
>
> &edma0 {
>
> Does spi slave still work without it?
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-12-07 9:43 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 15:27 [PATCH] ARM: dts: Add support for Liebherr's BK4 device (vf610 based) Lukasz Majewski
2018-09-21 15:27 ` Lukasz Majewski
2018-09-21 22:30 ` Stefan Agner
2018-09-21 22:30 ` Stefan Agner
2018-09-22 12:41 ` Lukasz Majewski
2018-09-22 12:41 ` Lukasz Majewski
2018-09-23 14:32 ` Fabio Estevam
2018-09-23 14:32 ` Fabio Estevam
2018-09-24 8:30 ` Lukasz Majewski
2018-09-24 8:30 ` Lukasz Majewski
2018-09-27 22:18 ` [PATCH v2] " Lukasz Majewski
2018-09-27 22:18 ` Lukasz Majewski
2018-09-28 9:00 ` Stefan Agner
2018-09-28 9:00 ` Stefan Agner
2018-10-08 12:25 ` Lukasz Majewski
2018-10-08 12:25 ` Lukasz Majewski
2018-10-08 14:34 ` Shawn Guo
2018-10-08 14:34 ` Shawn Guo
2018-10-09 10:50 ` [PATCH v3] " Lukasz Majewski
2018-10-09 10:50 ` Lukasz Majewski
2018-10-09 11:09 ` Fabio Estevam
2018-10-09 11:09 ` Fabio Estevam
2018-10-12 0:40 ` Shawn Guo
2018-10-12 0:40 ` Shawn Guo
2018-10-15 8:14 ` Lukasz Majewski
2018-10-15 8:14 ` Lukasz Majewski
2018-12-05 23:12 ` Fabio Estevam
2018-12-05 23:12 ` Fabio Estevam
2018-12-06 8:22 ` Lukasz Majewski
2018-12-06 8:22 ` Lukasz Majewski
2018-12-06 11:09 ` Fabio Estevam
2018-12-06 11:09 ` Fabio Estevam
2018-12-06 13:08 ` Lukasz Majewski
2018-12-06 13:08 ` Lukasz Majewski
2018-12-06 13:11 ` Fabio Estevam
2018-12-06 13:11 ` Fabio Estevam
2018-12-07 9:29 ` Lukasz Majewski [this message]
2018-12-07 9:29 ` Lukasz Majewski
2018-12-09 22:20 ` Lukasz Majewski
2018-12-09 22:20 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181207102950.68796cf0@jawa \
--to=lukma@denx.de \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.