From: Oleg Nesterov <oleg@redhat.com>
To: "Dmitry V. Levin" <ldv@altlinux.org>
Cc: Eugene Syromyatnikov <esyr@redhat.com>,
linux-kernel@vger.kernel.org,
Elvira Khabirova <lineprinter@altlinux.org>,
Paul Mackerras <paulus@samba.org>,
Andy Lutomirski <luto@kernel.org>,
Breno Leitao <leitao@debian.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v4] powerpc/ptrace: replace ptrace_report_syscall() with a tracehook call
Date: Fri, 7 Dec 2018 17:34:10 +0100 [thread overview]
Message-ID: <20181207163410.GA19110@redhat.com> (raw)
In-Reply-To: <20181207154255.GA28964@altlinux.org>
On 12/07, Dmitry V. Levin wrote:
>
> On Fri, Dec 07, 2018 at 10:12:49PM +1100, Michael Ellerman wrote:
>
> > > Sorry, this patch does not work, please ignore it.
> >
> > Hmm OK. Why exactly?
>
> Unfortunately, I have no idea why it doesn't work.
> All I can say is it breaks strace because the kernel no longer sends
> syscall entry stops.
May be because TIF_SYSCALL_EMU/etc is a bit number, not a mask? IOW, rather
than
whatever & TIF_XXX
you should do
whatever & _TIF_XXX
intstead?
Oleg.
WARNING: multiple messages have this Message-ID (diff)
From: Oleg Nesterov <oleg@redhat.com>
To: "Dmitry V. Levin" <ldv@altlinux.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Breno Leitao <leitao@debian.org>,
Andy Lutomirski <luto@kernel.org>,
Eugene Syromyatnikov <esyr@redhat.com>,
Elvira Khabirova <lineprinter@altlinux.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] powerpc/ptrace: replace ptrace_report_syscall() with a tracehook call
Date: Fri, 7 Dec 2018 17:34:10 +0100 [thread overview]
Message-ID: <20181207163410.GA19110@redhat.com> (raw)
In-Reply-To: <20181207154255.GA28964@altlinux.org>
On 12/07, Dmitry V. Levin wrote:
>
> On Fri, Dec 07, 2018 at 10:12:49PM +1100, Michael Ellerman wrote:
>
> > > Sorry, this patch does not work, please ignore it.
> >
> > Hmm OK. Why exactly?
>
> Unfortunately, I have no idea why it doesn't work.
> All I can say is it breaks strace because the kernel no longer sends
> syscall entry stops.
May be because TIF_SYSCALL_EMU/etc is a bit number, not a mask? IOW, rather
than
whatever & TIF_XXX
you should do
whatever & _TIF_XXX
intstead?
Oleg.
next prev parent reply other threads:[~2018-12-07 16:36 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-16 11:17 [PATCH v2] powerpc/ptrace: replace ptrace_report_syscall() with a tracehook call Elvira Khabirova
2018-11-16 11:17 ` Elvira Khabirova
2018-11-16 12:42 ` Michael Ellerman
2018-11-16 12:42 ` Michael Ellerman
2018-11-19 21:01 ` [PATCH v3] " Dmitry V. Levin
2018-11-19 21:01 ` Dmitry V. Levin
2018-11-21 21:17 ` Michael Ellerman
2018-11-21 21:17 ` Michael Ellerman
2018-12-03 3:18 ` [PATCH v4] " Dmitry V. Levin
2018-12-03 3:18 ` Dmitry V. Levin
2018-12-07 1:19 ` Dmitry V. Levin
2018-12-07 1:19 ` Dmitry V. Levin
2018-12-07 11:12 ` Michael Ellerman
2018-12-07 11:12 ` Michael Ellerman
2018-12-07 15:42 ` Dmitry V. Levin
2018-12-07 15:42 ` Dmitry V. Levin
2018-12-07 15:56 ` [PATCH v5] " Dmitry V. Levin
2018-12-07 15:56 ` Dmitry V. Levin
2018-12-07 18:52 ` [PATCH v6] " Dmitry V. Levin
2018-12-07 18:52 ` Dmitry V. Levin
2018-12-10 13:28 ` Oleg Nesterov
2018-12-10 13:28 ` Oleg Nesterov
2018-12-10 13:36 ` Dmitry V. Levin
2018-12-10 13:36 ` Dmitry V. Levin
2018-12-16 17:28 ` [PATCH] powerpc/ptrace: cleanup do_syscall_trace_enter Dmitry V. Levin
2018-12-17 11:20 ` Michael Ellerman
2018-12-17 11:23 ` Dmitry V. Levin
2018-12-17 11:23 ` Dmitry V. Levin
2018-12-17 11:27 ` Oleg Nesterov
2018-12-17 11:27 ` Oleg Nesterov
2018-12-22 9:54 ` Michael Ellerman
2018-12-11 13:45 ` [v5] powerpc/ptrace: replace ptrace_report_syscall() with a tracehook call Michael Ellerman
2018-12-11 13:45 ` Michael Ellerman
2018-12-07 16:34 ` Oleg Nesterov [this message]
2018-12-07 16:34 ` [PATCH v4] " Oleg Nesterov
2018-12-07 18:42 ` Dmitry V. Levin
2018-12-07 18:42 ` Dmitry V. Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181207163410.GA19110@redhat.com \
--to=oleg@redhat.com \
--cc=esyr@redhat.com \
--cc=ldv@altlinux.org \
--cc=leitao@debian.org \
--cc=lineprinter@altlinux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=luto@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.