All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
Cc: linux-pci@vger.kernel.org, dmaengine@vger.kernel.org,
	Vinod Koul <vkoul@kernel.org>,
	Eugeniy Paltsev <eugeniy.paltsev@synopsys.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Joao Pinto <joao.pinto@synopsys.com>
Subject: [RFC,1/6] dma: Add Synopsys eDMA IP core driver
Date: Wed, 12 Dec 2018 17:00:41 -0600	[thread overview]
Message-ID: <20181212230041.GM99796@google.com> (raw)

On Wed, Dec 12, 2018 at 12:13:21PM +0100, Gustavo Pimentel wrote:
> Add Synopsys eDMA IP core driver to kernel.
> 
> This core driver, initializes and configures the eDMA IP using vma-helpers
> functions and dma-engine subsystem.
> 
> Also creates an abstration layer through callbacks allowing different
> registers mappings in the future, organized in to versions.
> 
> This driver can be compile as built-in or external module in kernel.
> 
> To enable this driver just select DW_EDMA option in kernel configuration,
> however it requires and selects automatically DMA_ENGINE and
> DMA_VIRTUAL_CHANNELS option too.
> 
> Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Eugeniy Paltsev <paltsev@synopsys.com>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Joao Pinto <jpinto@synopsys.com>

> --- /dev/null
> +++ b/drivers/dma/dw-edma/dw-edma-core.c
> @@ -0,0 +1,925 @@
> +// SPDX-License-Identifier: GPL-2.0
> +// Copyright (c) 2018 Synopsys, Inc. and/or its affiliates.
> +// Synopsys DesignWare eDMA core driver

The SPDX line in .c files needs the // comment for some obscure reason
I can't remember, but based on the other drivers/dma/*.c files, it
looks like the convention is the usual /* .. */ comments for the rest.

I think the SPDX line is /* */ in .h files though.  The rules are
under Documentation/ somewhere.

WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org>
To: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
Cc: linux-pci@vger.kernel.org, dmaengine@vger.kernel.org,
	Vinod Koul <vkoul@kernel.org>,
	Eugeniy Paltsev <eugeniy.paltsev@synopsys.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Joao Pinto <joao.pinto@synopsys.com>
Subject: Re: [RFC 1/6] dma: Add Synopsys eDMA IP core driver
Date: Wed, 12 Dec 2018 17:00:41 -0600	[thread overview]
Message-ID: <20181212230041.GM99796@google.com> (raw)
In-Reply-To: <bf4eb88265bf8bd95f7b2effdbfbeda8c52a2e0b.1544610287.git.gustavo.pimentel@synopsys.com>

On Wed, Dec 12, 2018 at 12:13:21PM +0100, Gustavo Pimentel wrote:
> Add Synopsys eDMA IP core driver to kernel.
> 
> This core driver, initializes and configures the eDMA IP using vma-helpers
> functions and dma-engine subsystem.
> 
> Also creates an abstration layer through callbacks allowing different
> registers mappings in the future, organized in to versions.
> 
> This driver can be compile as built-in or external module in kernel.
> 
> To enable this driver just select DW_EDMA option in kernel configuration,
> however it requires and selects automatically DMA_ENGINE and
> DMA_VIRTUAL_CHANNELS option too.
> 
> Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Eugeniy Paltsev <paltsev@synopsys.com>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Joao Pinto <jpinto@synopsys.com>

> --- /dev/null
> +++ b/drivers/dma/dw-edma/dw-edma-core.c
> @@ -0,0 +1,925 @@
> +// SPDX-License-Identifier: GPL-2.0
> +// Copyright (c) 2018 Synopsys, Inc. and/or its affiliates.
> +// Synopsys DesignWare eDMA core driver

The SPDX line in .c files needs the // comment for some obscure reason
I can't remember, but based on the other drivers/dma/*.c files, it
looks like the convention is the usual /* .. */ comments for the rest.

I think the SPDX line is /* */ in .h files though.  The rules are
under Documentation/ somewhere.


             reply	other threads:[~2018-12-12 23:00 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-12 23:00 Bjorn Helgaas [this message]
2018-12-12 23:00 ` [RFC 1/6] dma: Add Synopsys eDMA IP core driver Bjorn Helgaas
  -- strict thread matches above, loose matches on Subject: below --
2019-01-03 18:00 [RFC,4/6] dma: Add Synopsys eDMA IP PCIe glue-logic Gustavo Pimentel
2019-01-03 18:00 ` [RFC 4/6] " Gustavo Pimentel
2019-01-03 17:35 [RFC,4/6] " Andy Shevchenko
2019-01-03 17:35 ` [RFC 4/6] " Andy Shevchenko
2019-01-03 14:53 [RFC,1/6] dma: Add Synopsys eDMA IP core driver Vinod Koul
2019-01-03 14:53 ` [RFC 1/6] " Vinod Koul
2019-01-03 12:55 [RFC,1/6] " Gustavo Pimentel
2019-01-03 12:55 ` [RFC 1/6] " Gustavo Pimentel
2019-01-03 12:45 [RFC,1/6] " Vinod Koul
2019-01-03 12:45 ` [RFC 1/6] " Vinod Koul
2019-01-03  9:53 [RFC,1/6] " Gustavo Pimentel
2019-01-03  9:53 ` [RFC 1/6] " Gustavo Pimentel
2018-12-18 10:58 [RFC,1/6] " Gustavo Pimentel
2018-12-18 10:58 ` [RFC 1/6] " Gustavo Pimentel
2018-12-18  3:54 [RFC,1/6] " Vinod Koul
2018-12-18  3:54 ` [RFC 1/6] " Vinod Koul
2018-12-17 15:56 [RFC,1/6] " Gustavo Pimentel
2018-12-17 15:56 ` [RFC 1/6] " Gustavo Pimentel
2018-12-17  7:23 [RFC,1/6] " Vinod Koul
2018-12-17  7:23 ` [RFC 1/6] " Vinod Koul
2018-12-17  6:51 [RFC,1/6] " Vinod Koul
2018-12-17  6:51 ` [RFC 1/6] " Vinod Koul
2018-12-13 14:40 [RFC,4/6] dma: Add Synopsys eDMA IP PCIe glue-logic Gustavo Pimentel
2018-12-13 14:40 ` [RFC 4/6] " Gustavo Pimentel
2018-12-13 11:51 [RFC,2/6] dma: Add Synopsys eDMA IP version 0 support Gustavo Pimentel
2018-12-13 11:51 ` [RFC 2/6] " Gustavo Pimentel
2018-12-13 11:49 [RFC,6/6] pci: pci_ids: Add Synopsys device id 0xedda Gustavo Pimentel
2018-12-13 11:49 ` [RFC 6/6] " Gustavo Pimentel
2018-12-13 11:03 [RFC,1/6] dma: Add Synopsys eDMA IP core driver Gustavo Pimentel
2018-12-13 11:03 ` [RFC 1/6] " Gustavo Pimentel
2018-12-12 23:03 [RFC,6/6] pci: pci_ids: Add Synopsys device id 0xedda Bjorn Helgaas
2018-12-12 23:03 ` [RFC 6/6] " Bjorn Helgaas
2018-12-12 13:39 [RFC,2/6] dma: Add Synopsys eDMA IP version 0 support Eugeniy Paltsev
2018-12-12 13:39 ` [RFC 2/6] " Eugeniy Paltsev
2018-12-12 13:25 [RFC,4/6] dma: Add Synopsys eDMA IP PCIe glue-logic Andy Shevchenko
2018-12-12 13:25 ` [RFC 4/6] " Andy Shevchenko
2018-12-12 11:13 [RFC,6/6] pci: pci_ids: Add Synopsys device id 0xedda Gustavo Pimentel
2018-12-12 11:13 ` [RFC 6/6] " Gustavo Pimentel
2018-12-12 11:13 [RFC,5/6] MAINTAINERS: Add Synopsys eDMA IP driver maintainer Gustavo Pimentel
2018-12-12 11:13 ` [RFC 5/6] " Gustavo Pimentel
2018-12-12 11:13 [RFC,4/6] dma: Add Synopsys eDMA IP PCIe glue-logic Gustavo Pimentel
2018-12-12 11:13 ` [RFC 4/6] " Gustavo Pimentel
2018-12-12 11:13 [RFC,3/6] dma: Add Synopsys eDMA IP version 0 debugfs support Gustavo Pimentel
2018-12-12 11:13 ` [RFC 3/6] " Gustavo Pimentel
2018-12-12 11:13 [RFC,2/6] dma: Add Synopsys eDMA IP version 0 support Gustavo Pimentel
2018-12-12 11:13 ` [RFC 2/6] " Gustavo Pimentel
2018-12-12 11:13 [RFC,1/6] dma: Add Synopsys eDMA IP core driver Gustavo Pimentel
2018-12-12 11:13 ` [RFC 1/6] " Gustavo Pimentel
2018-12-12 11:13 [RFC 0/6] dma: Add Synopsys eDMA IP driver (version 0) Gustavo Pimentel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181212230041.GM99796@google.com \
    --to=helgaas@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=eugeniy.paltsev@synopsys.com \
    --cc=gustavo.pimentel@synopsys.com \
    --cc=joao.pinto@synopsys.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.