All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
Cc: linux-pci@vger.kernel.org, dmaengine@vger.kernel.org,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Joao Pinto <joao.pinto@synopsys.com>
Subject: [RFC,6/6] pci: pci_ids: Add Synopsys device id 0xedda
Date: Wed, 12 Dec 2018 17:03:45 -0600	[thread overview]
Message-ID: <20181212230345.GN99796@google.com> (raw)

On Wed, Dec 12, 2018 at 12:13:26PM +0100, Gustavo Pimentel wrote:
> Create and add Synopsys device id (0xedda) to pci id list, since this id
> is now being use on two different drivers (pci_endpoint_test.ko and
> dw-edma-pcie.ko).

Please run "git log --oneline include/linux/pci_ids.h" and make your
subject line match, i.e.,

  PCI: Add Synopsys endpoint EDDA Device ID

Also, if you want, you can reorder this to add the ID first and use it
in drivers/misc/pci_endpoint_test.c, and then just use it from the
first appearance of drivers/dma/dw-edma/dw-edma-pcie.c.  Either way is
fine.

For the include/linux/pci_ids.h change,

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

> Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Cc: Joao Pinto <jpinto@synopsys.com>
> ---
>  drivers/dma/dw-edma/dw-edma-pcie.c | 2 +-
>  drivers/misc/pci_endpoint_test.c   | 2 +-
>  include/linux/pci_ids.h            | 1 +
>  3 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c
> index f29a861..50e0db4 100644
> --- a/drivers/dma/dw-edma/dw-edma-pcie.c
> +++ b/drivers/dma/dw-edma/dw-edma-pcie.c
> @@ -280,7 +280,7 @@ static const struct dev_pm_ops dw_edma_pcie_dev_pm_ops = {
>  };
>  
>  static const struct pci_device_id dw_edma_pcie_id_table[] = {
> -	{ PCI_DEVICE_DATA(SYNOPSYS, 0xedda, &snps_edda_data) },
> +	{ PCI_DEVICE_DATA(SYNOPSYS, EDDA, &snps_edda_data) },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(pci, dw_edma_pcie_id_table);
> diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c
> index 896e2df..d27efe838 100644
> --- a/drivers/misc/pci_endpoint_test.c
> +++ b/drivers/misc/pci_endpoint_test.c
> @@ -788,7 +788,7 @@ static void pci_endpoint_test_remove(struct pci_dev *pdev)
>  static const struct pci_device_id pci_endpoint_test_tbl[] = {
>  	{ PCI_DEVICE(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_DRA74x) },
>  	{ PCI_DEVICE(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_DRA72x) },
> -	{ PCI_DEVICE(PCI_VENDOR_ID_SYNOPSYS, 0xedda) },
> +	{ PCI_DEVICE_DATA(SYNOPSYS, EDDA, NULL) },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(pci, pci_endpoint_test_tbl);
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index 69f0abe..57f17dd 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -2358,6 +2358,7 @@
>  #define PCI_DEVICE_ID_CENATEK_IDE	0x0001
>  
>  #define PCI_VENDOR_ID_SYNOPSYS		0x16c3
> +#define PCI_DEVICE_ID_SYNOPSYS_EDDA	0xedda
>  
>  #define PCI_VENDOR_ID_VITESSE		0x1725
>  #define PCI_DEVICE_ID_VITESSE_VSC7174	0x7174
> -- 
> 2.7.4
>

WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org>
To: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
Cc: linux-pci@vger.kernel.org, dmaengine@vger.kernel.org,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Joao Pinto <joao.pinto@synopsys.com>
Subject: Re: [RFC 6/6] pci: pci_ids: Add Synopsys device id 0xedda
Date: Wed, 12 Dec 2018 17:03:45 -0600	[thread overview]
Message-ID: <20181212230345.GN99796@google.com> (raw)
In-Reply-To: <df5417ded1e55e5f994ab0ec7f696ddba83eaa35.1544610287.git.gustavo.pimentel@synopsys.com>

On Wed, Dec 12, 2018 at 12:13:26PM +0100, Gustavo Pimentel wrote:
> Create and add Synopsys device id (0xedda) to pci id list, since this id
> is now being use on two different drivers (pci_endpoint_test.ko and
> dw-edma-pcie.ko).

Please run "git log --oneline include/linux/pci_ids.h" and make your
subject line match, i.e.,

  PCI: Add Synopsys endpoint EDDA Device ID

Also, if you want, you can reorder this to add the ID first and use it
in drivers/misc/pci_endpoint_test.c, and then just use it from the
first appearance of drivers/dma/dw-edma/dw-edma-pcie.c.  Either way is
fine.

For the include/linux/pci_ids.h change,

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

> Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
> Cc: Kishon Vijay Abraham I <kishon@ti.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Cc: Joao Pinto <jpinto@synopsys.com>
> ---
>  drivers/dma/dw-edma/dw-edma-pcie.c | 2 +-
>  drivers/misc/pci_endpoint_test.c   | 2 +-
>  include/linux/pci_ids.h            | 1 +
>  3 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c
> index f29a861..50e0db4 100644
> --- a/drivers/dma/dw-edma/dw-edma-pcie.c
> +++ b/drivers/dma/dw-edma/dw-edma-pcie.c
> @@ -280,7 +280,7 @@ static const struct dev_pm_ops dw_edma_pcie_dev_pm_ops = {
>  };
>  
>  static const struct pci_device_id dw_edma_pcie_id_table[] = {
> -	{ PCI_DEVICE_DATA(SYNOPSYS, 0xedda, &snps_edda_data) },
> +	{ PCI_DEVICE_DATA(SYNOPSYS, EDDA, &snps_edda_data) },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(pci, dw_edma_pcie_id_table);
> diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c
> index 896e2df..d27efe838 100644
> --- a/drivers/misc/pci_endpoint_test.c
> +++ b/drivers/misc/pci_endpoint_test.c
> @@ -788,7 +788,7 @@ static void pci_endpoint_test_remove(struct pci_dev *pdev)
>  static const struct pci_device_id pci_endpoint_test_tbl[] = {
>  	{ PCI_DEVICE(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_DRA74x) },
>  	{ PCI_DEVICE(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_DRA72x) },
> -	{ PCI_DEVICE(PCI_VENDOR_ID_SYNOPSYS, 0xedda) },
> +	{ PCI_DEVICE_DATA(SYNOPSYS, EDDA, NULL) },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(pci, pci_endpoint_test_tbl);
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index 69f0abe..57f17dd 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -2358,6 +2358,7 @@
>  #define PCI_DEVICE_ID_CENATEK_IDE	0x0001
>  
>  #define PCI_VENDOR_ID_SYNOPSYS		0x16c3
> +#define PCI_DEVICE_ID_SYNOPSYS_EDDA	0xedda
>  
>  #define PCI_VENDOR_ID_VITESSE		0x1725
>  #define PCI_DEVICE_ID_VITESSE_VSC7174	0x7174
> -- 
> 2.7.4
> 

             reply	other threads:[~2018-12-12 23:03 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-12 23:03 Bjorn Helgaas [this message]
2018-12-12 23:03 ` [RFC 6/6] pci: pci_ids: Add Synopsys device id 0xedda Bjorn Helgaas
  -- strict thread matches above, loose matches on Subject: below --
2019-01-03 18:00 [RFC,4/6] dma: Add Synopsys eDMA IP PCIe glue-logic Gustavo Pimentel
2019-01-03 18:00 ` [RFC 4/6] " Gustavo Pimentel
2019-01-03 17:35 [RFC,4/6] " Andy Shevchenko
2019-01-03 17:35 ` [RFC 4/6] " Andy Shevchenko
2019-01-03 14:53 [RFC,1/6] dma: Add Synopsys eDMA IP core driver Vinod Koul
2019-01-03 14:53 ` [RFC 1/6] " Vinod Koul
2019-01-03 12:55 [RFC,1/6] " Gustavo Pimentel
2019-01-03 12:55 ` [RFC 1/6] " Gustavo Pimentel
2019-01-03 12:45 [RFC,1/6] " Vinod Koul
2019-01-03 12:45 ` [RFC 1/6] " Vinod Koul
2019-01-03  9:53 [RFC,1/6] " Gustavo Pimentel
2019-01-03  9:53 ` [RFC 1/6] " Gustavo Pimentel
2018-12-18 10:58 [RFC,1/6] " Gustavo Pimentel
2018-12-18 10:58 ` [RFC 1/6] " Gustavo Pimentel
2018-12-18  3:54 [RFC,1/6] " Vinod Koul
2018-12-18  3:54 ` [RFC 1/6] " Vinod Koul
2018-12-17 15:56 [RFC,1/6] " Gustavo Pimentel
2018-12-17 15:56 ` [RFC 1/6] " Gustavo Pimentel
2018-12-17  7:23 [RFC,1/6] " Vinod Koul
2018-12-17  7:23 ` [RFC 1/6] " Vinod Koul
2018-12-17  6:51 [RFC,1/6] " Vinod Koul
2018-12-17  6:51 ` [RFC 1/6] " Vinod Koul
2018-12-13 14:40 [RFC,4/6] dma: Add Synopsys eDMA IP PCIe glue-logic Gustavo Pimentel
2018-12-13 14:40 ` [RFC 4/6] " Gustavo Pimentel
2018-12-13 11:51 [RFC,2/6] dma: Add Synopsys eDMA IP version 0 support Gustavo Pimentel
2018-12-13 11:51 ` [RFC 2/6] " Gustavo Pimentel
2018-12-13 11:49 [RFC,6/6] pci: pci_ids: Add Synopsys device id 0xedda Gustavo Pimentel
2018-12-13 11:49 ` [RFC 6/6] " Gustavo Pimentel
2018-12-13 11:03 [RFC,1/6] dma: Add Synopsys eDMA IP core driver Gustavo Pimentel
2018-12-13 11:03 ` [RFC 1/6] " Gustavo Pimentel
2018-12-12 23:00 [RFC,1/6] " Bjorn Helgaas
2018-12-12 23:00 ` [RFC 1/6] " Bjorn Helgaas
2018-12-12 13:39 [RFC,2/6] dma: Add Synopsys eDMA IP version 0 support Eugeniy Paltsev
2018-12-12 13:39 ` [RFC 2/6] " Eugeniy Paltsev
2018-12-12 13:25 [RFC,4/6] dma: Add Synopsys eDMA IP PCIe glue-logic Andy Shevchenko
2018-12-12 13:25 ` [RFC 4/6] " Andy Shevchenko
2018-12-12 11:13 [RFC,6/6] pci: pci_ids: Add Synopsys device id 0xedda Gustavo Pimentel
2018-12-12 11:13 ` [RFC 6/6] " Gustavo Pimentel
2018-12-12 11:13 [RFC,5/6] MAINTAINERS: Add Synopsys eDMA IP driver maintainer Gustavo Pimentel
2018-12-12 11:13 ` [RFC 5/6] " Gustavo Pimentel
2018-12-12 11:13 [RFC,4/6] dma: Add Synopsys eDMA IP PCIe glue-logic Gustavo Pimentel
2018-12-12 11:13 ` [RFC 4/6] " Gustavo Pimentel
2018-12-12 11:13 [RFC,3/6] dma: Add Synopsys eDMA IP version 0 debugfs support Gustavo Pimentel
2018-12-12 11:13 ` [RFC 3/6] " Gustavo Pimentel
2018-12-12 11:13 [RFC,2/6] dma: Add Synopsys eDMA IP version 0 support Gustavo Pimentel
2018-12-12 11:13 ` [RFC 2/6] " Gustavo Pimentel
2018-12-12 11:13 [RFC,1/6] dma: Add Synopsys eDMA IP core driver Gustavo Pimentel
2018-12-12 11:13 ` [RFC 1/6] " Gustavo Pimentel
2018-12-12 11:13 [RFC 0/6] dma: Add Synopsys eDMA IP driver (version 0) Gustavo Pimentel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181212230345.GN99796@google.com \
    --to=helgaas@kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=gustavo.pimentel@synopsys.com \
    --cc=joao.pinto@synopsys.com \
    --cc=kishon@ti.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.