From: Ido Schimmel <idosch@mellanox.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: "open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"moderated list:ETHERNET BRIDGE"
<bridge@lists.linux-foundation.org>,
open list <linux-kernel@vger.kernel.org>,
"vivien.didelot@gmail.com" <vivien.didelot@gmail.com>,
Jiri Pirko <jiri@mellanox.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Bridge] [PATCH net-next 8/9] net: Remove SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS_SUPPORT
Date: Thu, 14 Feb 2019 11:27:51 +0000 [thread overview]
Message-ID: <20190214112749.GA9620@splinter> (raw)
In-Reply-To: <20190213220638.1552-9-f.fainelli@gmail.com>
On Wed, Feb 13, 2019 at 02:06:37PM -0800, Florian Fainelli wrote:
> Now that we have converted the bridge code and the drivers to check for
> bridge port(s) flags at the time we try to set them, there is no need
> for a get() -> set() sequence anymore and
> SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS_SUPPORT therefore becomes unused.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Ido Schimmel <idosch@mellanox.com>
WARNING: multiple messages have this Message-ID (diff)
From: Ido Schimmel <idosch@mellanox.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
open list <linux-kernel@vger.kernel.org>,
"open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>,
"moderated list:ETHERNET BRIDGE"
<bridge@lists.linux-foundation.org>,
Jiri Pirko <jiri@mellanox.com>, "andrew@lunn.ch" <andrew@lunn.ch>,
"vivien.didelot@gmail.com" <vivien.didelot@gmail.com>
Subject: Re: [PATCH net-next 8/9] net: Remove SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS_SUPPORT
Date: Thu, 14 Feb 2019 11:27:51 +0000 [thread overview]
Message-ID: <20190214112749.GA9620@splinter> (raw)
In-Reply-To: <20190213220638.1552-9-f.fainelli@gmail.com>
On Wed, Feb 13, 2019 at 02:06:37PM -0800, Florian Fainelli wrote:
> Now that we have converted the bridge code and the drivers to check for
> bridge port(s) flags at the time we try to set them, there is no need
> for a get() -> set() sequence anymore and
> SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS_SUPPORT therefore becomes unused.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Ido Schimmel <idosch@mellanox.com>
next prev parent reply other threads:[~2019-02-14 11:27 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 22:06 [Bridge] [PATCH net-next 0/9] net: Get rid of switchdev_port_attr_get() Florian Fainelli
2019-02-13 22:06 ` Florian Fainelli
2019-02-13 22:06 ` [Bridge] [PATCH net-next 1/9] Documentation: networking: switchdev: Update port parent ID section Florian Fainelli
2019-02-13 22:06 ` Florian Fainelli
2019-02-14 10:58 ` [Bridge] " Ido Schimmel
2019-02-14 10:58 ` Ido Schimmel
2019-02-13 22:06 ` [Bridge] [PATCH net-next 2/9] net: switchdev: Add PORT_PRE_BRIDGE_FLAGS Florian Fainelli
2019-02-13 22:06 ` Florian Fainelli
2019-02-13 22:06 ` [Bridge] [PATCH net-next 3/9] mlxsw: spectrum: Check bridge flags during prepare phase Florian Fainelli
2019-02-13 22:06 ` Florian Fainelli
2019-02-14 13:11 ` [Bridge] " Ido Schimmel
2019-02-14 13:11 ` Ido Schimmel
2019-02-13 22:06 ` [Bridge] [PATCH net-next 4/9] staging: fsl-dpaa2: ethsw: Check bridge port flags during prepare Florian Fainelli
2019-02-13 22:06 ` Florian Fainelli
2019-02-13 22:06 ` [Bridge] [PATCH net-next 5/9] net: dsa: Add setter for SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS Florian Fainelli
2019-02-13 22:06 ` Florian Fainelli
2019-02-13 22:06 ` [Bridge] [PATCH net-next 6/9] rocker: Check bridge flags during prepare phase Florian Fainelli
2019-02-13 22:06 ` Florian Fainelli
2019-02-13 22:06 ` [Bridge] [PATCH net-next 7/9] net: bridge: Stop calling switchdev_port_attr_get() Florian Fainelli
2019-02-13 22:06 ` Florian Fainelli
2019-02-14 11:20 ` [Bridge] " Ido Schimmel
2019-02-14 11:20 ` Ido Schimmel
2019-02-14 13:02 ` [Bridge] " Ido Schimmel
2019-02-14 13:02 ` Ido Schimmel
2019-02-13 22:06 ` [Bridge] [PATCH net-next 8/9] net: Remove SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS_SUPPORT Florian Fainelli
2019-02-13 22:06 ` Florian Fainelli
2019-02-14 11:27 ` Ido Schimmel [this message]
2019-02-14 11:27 ` Ido Schimmel
2019-02-13 22:06 ` [Bridge] [PATCH net-next 9/9] net: Get rid of switchdev_port_attr_get() Florian Fainelli
2019-02-13 22:06 ` Florian Fainelli
2019-02-14 12:10 ` [Bridge] " Ido Schimmel
2019-02-14 12:10 ` Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190214112749.GA9620@splinter \
--to=idosch@mellanox.com \
--cc=andrew@lunn.ch \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=f.fainelli@gmail.com \
--cc=jiri@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.