* [PATCH] carl9170: clean up a clamp() call
@ 2019-02-18 9:31 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2019-02-18 9:31 UTC (permalink / raw)
To: Christian Lamparter; +Cc: Kalle Valo, linux-wireless, kernel-janitors
The parameter order for clamp is supposed to be clamp(value, low, high).
When we write it in this order it's equivalent to
min(head->plcp[3] & 0x7f, 75) which works in this context where the min
is zero. But it's not a correct use of the API.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/net/wireless/ath/carl9170/rx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/carl9170/rx.c b/drivers/net/wireless/ath/carl9170/rx.c
index f7c2f19e81c1..8e154f6364a3 100644
--- a/drivers/net/wireless/ath/carl9170/rx.c
+++ b/drivers/net/wireless/ath/carl9170/rx.c
@@ -427,7 +427,7 @@ static int carl9170_rx_mac_status(struct ar9170 *ar,
if (head->plcp[6] & 0x80)
status->enc_flags |= RX_ENC_FLAG_SHORT_GI;
- status->rate_idx = clamp(0, 75, head->plcp[3] & 0x7f);
+ status->rate_idx = clamp(head->plcp[3] & 0x7f, 0, 75);
status->encoding = RX_ENC_HT;
break;
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] carl9170: clean up a clamp() call
@ 2019-02-18 9:31 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2019-02-18 9:31 UTC (permalink / raw)
To: Christian Lamparter; +Cc: Kalle Valo, linux-wireless, kernel-janitors
The parameter order for clamp is supposed to be clamp(value, low, high).
When we write it in this order it's equivalent to
min(head->plcp[3] & 0x7f, 75) which works in this context where the min
is zero. But it's not a correct use of the API.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/net/wireless/ath/carl9170/rx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/carl9170/rx.c b/drivers/net/wireless/ath/carl9170/rx.c
index f7c2f19e81c1..8e154f6364a3 100644
--- a/drivers/net/wireless/ath/carl9170/rx.c
+++ b/drivers/net/wireless/ath/carl9170/rx.c
@@ -427,7 +427,7 @@ static int carl9170_rx_mac_status(struct ar9170 *ar,
if (head->plcp[6] & 0x80)
status->enc_flags |= RX_ENC_FLAG_SHORT_GI;
- status->rate_idx = clamp(0, 75, head->plcp[3] & 0x7f);
+ status->rate_idx = clamp(head->plcp[3] & 0x7f, 0, 75);
status->encoding = RX_ENC_HT;
break;
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] carl9170: clean up a clamp() call
2019-02-18 9:31 ` Dan Carpenter
@ 2019-02-18 16:04 ` Christian Lamparter
-1 siblings, 0 replies; 6+ messages in thread
From: Christian Lamparter @ 2019-02-18 16:04 UTC (permalink / raw)
To: Dan Carpenter
Cc: Christian Lamparter, Kalle Valo, linux-wireless, kernel-janitors
On Monday, February 18, 2019 10:31:54 AM CET Dan Carpenter wrote:
> The parameter order for clamp is supposed to be clamp(value, low, high).
> When we write it in this order it's equivalent to
> min(head->plcp[3] & 0x7f, 75) which works in this context where the min
> is zero. But it's not a correct use of the API.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Christian Lamparter <chunkeey@gmail.com>
> ---
> drivers/net/wireless/ath/carl9170/rx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/carl9170/rx.c b/drivers/net/wireless/ath/carl9170/rx.c
> index f7c2f19e81c1..8e154f6364a3 100644
> --- a/drivers/net/wireless/ath/carl9170/rx.c
> +++ b/drivers/net/wireless/ath/carl9170/rx.c
> @@ -427,7 +427,7 @@ static int carl9170_rx_mac_status(struct ar9170 *ar,
> if (head->plcp[6] & 0x80)
> status->enc_flags |= RX_ENC_FLAG_SHORT_GI;
>
> - status->rate_idx = clamp(0, 75, head->plcp[3] & 0x7f);
> + status->rate_idx = clamp(head->plcp[3] & 0x7f, 0, 75);
> status->encoding = RX_ENC_HT;
> break;
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] carl9170: clean up a clamp() call
@ 2019-02-18 16:04 ` Christian Lamparter
0 siblings, 0 replies; 6+ messages in thread
From: Christian Lamparter @ 2019-02-18 16:04 UTC (permalink / raw)
To: Dan Carpenter
Cc: Christian Lamparter, Kalle Valo, linux-wireless, kernel-janitors
On Monday, February 18, 2019 10:31:54 AM CET Dan Carpenter wrote:
> The parameter order for clamp is supposed to be clamp(value, low, high).
> When we write it in this order it's equivalent to
> min(head->plcp[3] & 0x7f, 75) which works in this context where the min
> is zero. But it's not a correct use of the API.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Christian Lamparter <chunkeey@gmail.com>
> ---
> drivers/net/wireless/ath/carl9170/rx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/carl9170/rx.c b/drivers/net/wireless/ath/carl9170/rx.c
> index f7c2f19e81c1..8e154f6364a3 100644
> --- a/drivers/net/wireless/ath/carl9170/rx.c
> +++ b/drivers/net/wireless/ath/carl9170/rx.c
> @@ -427,7 +427,7 @@ static int carl9170_rx_mac_status(struct ar9170 *ar,
> if (head->plcp[6] & 0x80)
> status->enc_flags |= RX_ENC_FLAG_SHORT_GI;
>
> - status->rate_idx = clamp(0, 75, head->plcp[3] & 0x7f);
> + status->rate_idx = clamp(head->plcp[3] & 0x7f, 0, 75);
> status->encoding = RX_ENC_HT;
> break;
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] carl9170: clean up a clamp() call
2019-02-18 9:31 ` Dan Carpenter
@ 2019-02-19 15:18 ` Kalle Valo
-1 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2019-02-19 15:18 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Christian Lamparter, linux-wireless, kernel-janitors
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The parameter order for clamp is supposed to be clamp(value, low, high).
> When we write it in this order it's equivalent to
> min(head->plcp[3] & 0x7f, 75) which works in this context where the min
> is zero. But it's not a correct use of the API.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Acked-by: Christian Lamparter <chunkeey@gmail.com>
Patch applied to wireless-drivers-next.git, thanks.
dc76bb1e12e9 carl9170: clean up a clamp() call
--
https://patchwork.kernel.org/patch/10817541/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-02-19 15:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-18 9:31 [PATCH] carl9170: clean up a clamp() call Dan Carpenter
2019-02-18 9:31 ` Dan Carpenter
2019-02-18 16:04 ` Christian Lamparter
2019-02-18 16:04 ` Christian Lamparter
2019-02-19 15:18 ` Kalle Valo
2019-02-19 15:18 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.