[PATCH v2 0/8] Fix checkpatch.pl issues

[PATCH v2 0/8] Fix checkpatch.pl issues

[Madhumitha Prabakaran]

These patches fix warnings of line over 80 characters, comment style
issues of SPDX License Identifier and remove unnecessary blank line.

Madhumitha Prabakaran (8):
  Staging: vt6655: card.h: Fix line over 80 character
  Staging: vt6655: card.h: Fix line over 80 characters
  Staging: vt6655: device.h: Fix comment style of SPDX License Identifier
  Staging: vt6655: device_cfg.h: Fix comment style of SPDX License Identifer
  Staging: vt6655: dpc.h: Fix comment style of SPDX License Identifier
  Staging: vt6655: key.h: Fix comment style of SPDX License Identifier
  Staging: vt6655: mac.c: Remove unnecessary blank line
  Staging: vt6655: mac.h: Fix comment style of SPDX License Identifier

 drivers/staging/vt6655/card.h       | 6 ++++--
 drivers/staging/vt6655/device.h     | 2 +-
 drivers/staging/vt6655/device_cfg.h | 2 +-
 drivers/staging/vt6655/dpc.h        | 2 +-
 drivers/staging/vt6655/key.h        | 2 +-
 drivers/staging/vt6655/mac.c        | 1 -
 drivers/staging/vt6655/mac.h        | 2 +-
 7 files changed, 9 insertions(+), 8 deletions(-)

-- 
2.17.1

[PATCH v2 1/8] Staging: vt6655: Fix line over 80 character

[Madhumitha Prabakaran]

Fix the warning
WARNING: line over 80 characters

Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
 drivers/staging/vt6655/card.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/vt6655/card.h b/drivers/staging/vt6655/card.h
index d71022aa3f86..6bbbbe1314d5 100644
--- a/drivers/staging/vt6655/card.h
+++ b/drivers/staging/vt6655/card.h
@@ -44,7 +44,8 @@ struct vnt_private;
 void CARDvSetRSPINF(struct vnt_private *priv, u8 bb_type);
 void CARDvUpdateBasicTopRate(struct vnt_private *priv);
 bool CARDbIsOFDMinBasicRate(struct vnt_private *priv);
-void CARDvSetLoopbackMode(struct vnt_private *priv, unsigned short wLoopbackMode);
+void CARDvSetLoopbackMode(struct vnt_private *priv,
+			  unsigned short wLoopbackMode);
 bool CARDbSoftwareReset(struct vnt_private *priv);
 void CARDvSetFirstNextTBTT(struct vnt_private *priv,
 			   unsigned short wBeaconInterval);
-- 
2.17.1

[PATCH v2 2/8] Staging: vt6655: Fix line over 80 characters

[Madhumitha Prabakaran]

Fix the warning
WARNING: line over 80 characters

Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
 drivers/staging/vt6655/card.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/vt6655/card.h b/drivers/staging/vt6655/card.h
index 6bbbbe1314d5..490cecf8fb9d 100644
--- a/drivers/staging/vt6655/card.h
+++ b/drivers/staging/vt6655/card.h
@@ -62,6 +62,7 @@ bool CARDbRadioPowerOn(struct vnt_private *priv);
 bool CARDbSetPhyParameter(struct vnt_private *priv, u8 bb_type);
 bool CARDbUpdateTSF(struct vnt_private *priv, unsigned char byRxRate,
 		    u64 qwBSSTimestamp);
-bool CARDbSetBeaconPeriod(struct vnt_private *priv, unsigned short wBeaconInterval);
+bool CARDbSetBeaconPeriod(struct vnt_private *priv,
+			  unsigned short wBeaconInterval);
 
 #endif /* __CARD_H__ */
-- 
2.17.1

[PATCH v2 3/8] Staging: vt6655: Fix comment style of SPDX License Identifier

[Madhumitha Prabakaran]

Fix comment style of SPDX License Identifier based on License Identifier
syntax for header type file.

Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
 drivers/staging/vt6655/device_cfg.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6655/device_cfg.h b/drivers/staging/vt6655/device_cfg.h
index 6b41c74f7c2a..04db6a8d3db3 100644
--- a/drivers/staging/vt6655/device_cfg.h
+++ b/drivers/staging/vt6655/device_cfg.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
-- 
2.17.1

[PATCH v2 4/8] Staging: vt6655: Fix comment style of SPDX License Identifer

[Madhumitha Prabakaran]

Fix comment style of SPDX License Identifer for header type file based
on License Identifier syntax.

Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
 drivers/staging/vt6655/device.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h
index 2f9e9219e8c8..29f354ced563 100644
--- a/drivers/staging/vt6655/device.h
+++ b/drivers/staging/vt6655/device.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
-- 
2.17.1

[PATCH v2 5/8] Staging: vt6655: Fix comment style of SPDX License Identifier

[Madhumitha Prabakaran]

Fix comment style of SPDX License Identifer for header file based on
License Identifier syntax.

Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
 drivers/staging/vt6655/dpc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6655/dpc.h b/drivers/staging/vt6655/dpc.h
index 93af4220605f..eac67794cc49 100644
--- a/drivers/staging/vt6655/dpc.h
+++ b/drivers/staging/vt6655/dpc.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
-- 
2.17.1

[PATCH v2 6/8] Staging: vt6655: Fix comment style of SPDX License Identifier

[Madhumitha Prabakaran]

Fix comment style of SPDX License Identifier for header file type based
on License Identifer syntax.

Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
 drivers/staging/vt6655/key.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6655/key.h b/drivers/staging/vt6655/key.h
index 0942d8703f98..9347776fa3a5 100644
--- a/drivers/staging/vt6655/key.h
+++ b/drivers/staging/vt6655/key.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
-- 
2.17.1

[PATCH v2 7/8] Staging: vt6655: Remove unnecessary blank line

[Madhumitha Prabakaran]

Remove unnecessary blank line before end of block brace so that it fix
the check
CHECK: Blank lines aren't necessary before a close brace '}'

Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
 drivers/staging/vt6655/mac.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/vt6655/mac.c b/drivers/staging/vt6655/mac.c
index 4750863c1bb7..40a8f1ce837c 100644
--- a/drivers/staging/vt6655/mac.c
+++ b/drivers/staging/vt6655/mac.c
@@ -593,7 +593,6 @@ void MACvSetCurrRx1DescAddr(struct vnt_private *priv, u32 curr_desc_addr)
 	iowrite32(curr_desc_addr, io_base + MAC_REG_RXDMAPTR1);
 	if (org_dma_ctl & DMACTL_RUN)
 		iowrite8(DMACTL_RUN, io_base + MAC_REG_RXDMACTL1);
-
 }
 
 /*
-- 
2.17.1

[PATCH v2 8/8] Staging: vt6655: Fix comment style of SPDX License Identifier

[Madhumitha Prabakaran]

Fix comment style of SPDX License Identifer for header type file based
on License Identifer syntax.

Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
---
 drivers/staging/vt6655/mac.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h
index b8ab09434773..8c8c26792343 100644
--- a/drivers/staging/vt6655/mac.h
+++ b/drivers/staging/vt6655/mac.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
-- 
2.17.1

Re: [Outreachy kernel] [PATCH v2 0/8] Fix checkpatch.pl issues

[Julia Lawall]

On Sat, 2 Mar 2019, Madhumitha Prabakaran wrote:

> These patches fix warnings of line over 80 characters, comment style
> issues of SPDX License Identifier and remove unnecessary blank line.
>
> Madhumitha Prabakaran (8):
>   Staging: vt6655: card.h: Fix line over 80 character
>   Staging: vt6655: card.h: Fix line over 80 characters
>   Staging: vt6655: device.h: Fix comment style of SPDX License Identifier
>   Staging: vt6655: device_cfg.h: Fix comment style of SPDX License Identifer
>   Staging: vt6655: dpc.h: Fix comment style of SPDX License Identifier
>   Staging: vt6655: key.h: Fix comment style of SPDX License Identifier
>   Staging: vt6655: mac.c: Remove unnecessary blank line
>   Staging: vt6655: mac.h: Fix comment style of SPDX License Identifier

I'm confused about this series.  I have the impression that it touches the
same files as the other series with only two patches.  And it has the same
problem with the subject lines.  You have made them unique in the cover
letter, but they are not unique in the patches.  You should use

git rebase -i HEAD~n

where n is the number of patches you need to go back in the history to get
to the ones you want to adjust.  Then in the menu that it offers you, you
can edit the log message of each one, specifically the first line, which
will become the subject line.  Then regenerate your patches in the normal
way.

julia


> ---
> Changes in v2
> - Fixed subject line difference
>
>  drivers/staging/vt6655/card.h       | 6 ++++--
>  drivers/staging/vt6655/device.h     | 2 +-
>  drivers/staging/vt6655/device_cfg.h | 2 +-
>  drivers/staging/vt6655/dpc.h        | 2 +-
>  drivers/staging/vt6655/key.h        | 2 +-
>  drivers/staging/vt6655/mac.c        | 1 -
>  drivers/staging/vt6655/mac.h        | 2 +-
>  7 files changed, 9 insertions(+), 8 deletions(-)
>
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cover.1551550323.git.madhumithabiw%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [PATCH v2 0/8] Fix checkpatch.pl issues

[Greg KH]

On Sat, Mar 02, 2019 at 12:34:42PM -0600, Madhumitha Prabakaran wrote:
> These patches fix warnings of line over 80 characters, comment style
> issues of SPDX License Identifier and remove unnecessary blank line.
> 
> Madhumitha Prabakaran (8):
>   Staging: vt6655: card.h: Fix line over 80 character
>   Staging: vt6655: card.h: Fix line over 80 characters
>   Staging: vt6655: device.h: Fix comment style of SPDX License Identifier
>   Staging: vt6655: device_cfg.h: Fix comment style of SPDX License Identifer
>   Staging: vt6655: dpc.h: Fix comment style of SPDX License Identifier
>   Staging: vt6655: key.h: Fix comment style of SPDX License Identifier
>   Staging: vt6655: mac.c: Remove unnecessary blank line
>   Staging: vt6655: mac.h: Fix comment style of SPDX License Identifier

Again, does not match the subject lines :(

Perhaps if you typed out here _exactly_ what you did to create this
cover letter, and send them off to us, it might help in determining what
you did wrong.

thanks,

greg k-h

Re: [PATCH v2 0/8] Fix checkpatch.pl issues

[Madhumthia Prabakaran]

On Sun, Mar 03, 2019 at 09:09:15AM +0100, Greg KH wrote:
> On Sat, Mar 02, 2019 at 12:34:42PM -0600, Madhumitha Prabakaran wrote:
> > These patches fix warnings of line over 80 characters, comment style
> > issues of SPDX License Identifier and remove unnecessary blank line.
> > 
> > Madhumitha Prabakaran (8):
> >   Staging: vt6655: card.h: Fix line over 80 character
> >   Staging: vt6655: card.h: Fix line over 80 characters
> >   Staging: vt6655: device.h: Fix comment style of SPDX License Identifier
> >   Staging: vt6655: device_cfg.h: Fix comment style of SPDX License Identifer
> >   Staging: vt6655: dpc.h: Fix comment style of SPDX License Identifier
> >   Staging: vt6655: key.h: Fix comment style of SPDX License Identifier
> >   Staging: vt6655: mac.c: Remove unnecessary blank line
> >   Staging: vt6655: mac.h: Fix comment style of SPDX License Identifier
> 
> Again, does not match the subject lines :(
> 
> Perhaps if you typed out here _exactly_ what you did to create this
> cover letter, and send them off to us, it might help in determining what
> you did wrong.
> 
> thanks,
> 
> greg k-h

Thanks

Task: commit patchsets, which contains two patches

1. git log --pretty=oneline --abbrev-commit 

8f8d8bbad6bc (HEAD -> staging-testing) Staging: vt6655: Fix ...
f68b96b7f7f5 Staging: vt6655: Fix comment ...

08b9bee66e3e (origin/staging-testing, origin/staging-next) ...

2. Format-patch 

git format-patch -o /tmp/three/ --cover-letter -n --thread=shallow --cc="madhumithabiw@gmail.com" f68b96b7f7f5^..8f8d8bbad6bc

/tmp/three/0000-cover-letter.patch
/tmp/three/0001-Staging-vt6655-Fix-comment-style-of-SPDX-License-Ide.patch
/tmp/three/0002-Staging-vt6655-Fix-comment-style-of-SPDX-License-Ide.patch

3. Format patch for versioning 

git format-patch -n --subject-prefix="PATCH v2" --cover-letter

On executing this, my subject prefix never changed. I assume, this is the issues. As this creates same version of subject line and clubs all version into same conversation. 

4. I manually edit the vim /tmp/three/0000-cover-letter.patch

5. Edited the 'SUBJECT HERE'  and 'BLURB HERE'. Here too I noticed that the subject prefix never changed.. So i tried to edit it manually.
   I tried to change subject prefix for all the three files manually

6. After that I tried using mutt and git to send files 

For git I used 
git send-email --to-cover --cc-cover /tmp/three/*.patch

For mutt I used 
mutt -H /tmp/third/0000......patch
For all three files I individually sent  it via mutt

Referred: 1. https://kernelnewbies.org/Outreachyfirstpatch
          2. https://kernelnewbies.org/PatchSeries

Thanks,

Madhumitha

Re: [PATCH v2 0/8] Fix checkpatch.pl issues

[Greg KH]

On Sun, Mar 03, 2019 at 12:30:23PM -0600, Madhumthia Prabakaran wrote:
> On Sun, Mar 03, 2019 at 09:09:15AM +0100, Greg KH wrote:
> > On Sat, Mar 02, 2019 at 12:34:42PM -0600, Madhumitha Prabakaran wrote:
> > > These patches fix warnings of line over 80 characters, comment style
> > > issues of SPDX License Identifier and remove unnecessary blank line.
> > > 
> > > Madhumitha Prabakaran (8):
> > >   Staging: vt6655: card.h: Fix line over 80 character
> > >   Staging: vt6655: card.h: Fix line over 80 characters
> > >   Staging: vt6655: device.h: Fix comment style of SPDX License Identifier
> > >   Staging: vt6655: device_cfg.h: Fix comment style of SPDX License Identifer
> > >   Staging: vt6655: dpc.h: Fix comment style of SPDX License Identifier
> > >   Staging: vt6655: key.h: Fix comment style of SPDX License Identifier
> > >   Staging: vt6655: mac.c: Remove unnecessary blank line
> > >   Staging: vt6655: mac.h: Fix comment style of SPDX License Identifier
> > 
> > Again, does not match the subject lines :(
> > 
> > Perhaps if you typed out here _exactly_ what you did to create this
> > cover letter, and send them off to us, it might help in determining what
> > you did wrong.
> > 
> > thanks,
> > 
> > greg k-h
> 
> Thanks
> 
> Task: commit patchsets, which contains two patches
> 
> 1. git log --pretty=oneline --abbrev-commit 
> 
> 8f8d8bbad6bc (HEAD -> staging-testing) Staging: vt6655: Fix ...
> f68b96b7f7f5 Staging: vt6655: Fix comment ...
> 
> 08b9bee66e3e (origin/staging-testing, origin/staging-next) ...

Ah, the problem is you never changed the actual changelog text in the
patch itself.  You need to do that.

> 2. Format-patch 
> 
> git format-patch -o /tmp/three/ --cover-letter -n --thread=shallow --cc="madhumithabiw@gmail.com" f68b96b7f7f5^..8f8d8bbad6bc
> 
> /tmp/three/0000-cover-letter.patch
> /tmp/three/0001-Staging-vt6655-Fix-comment-style-of-SPDX-License-Ide.patch
> /tmp/three/0002-Staging-vt6655-Fix-comment-style-of-SPDX-License-Ide.patch

See the subject line does not have the file name in it.

> 3. Format patch for versioning 
> 
> git format-patch -n --subject-prefix="PATCH v2" --cover-letter
> 
> On executing this, my subject prefix never changed. I assume, this is the issues. As this creates same version of subject line and clubs all version into same conversation. 

As discussed on irc, you don't need to use --subject-prefix.

Also, no need to call format-patch twice.

> 4. I manually edit the vim /tmp/three/0000-cover-letter.patch
> 
> 5. Edited the 'SUBJECT HERE'  and 'BLURB HERE'. Here too I noticed that the subject prefix never changed.. So i tried to edit it manually.
>    I tried to change subject prefix for all the three files manually

Editing this file does not change the actual text in the patches
themselves.

> 6. After that I tried using mutt and git to send files 
> 
> For git I used 
> git send-email --to-cover --cc-cover /tmp/three/*.patch
> 
> For mutt I used 
> mutt -H /tmp/third/0000......patch
> For all three files I individually sent  it via mutt

Sending is fine.

Ok, you need to change the subject lines of your patch.

to do this, rebase the patches and edit the changelog text.  Look up how
'git rebase -i' works, with the "reword" option.  That will give you the
chance to reword the changlog text to properly change the first line of
the patches to contain the filenames.

Then do your step 3 and others and all should be good.

Hope this helps,

greg k-h

Re: [PATCH v2 0/8] Fix checkpatch.pl issues

[Madhumthia Prabakaran]

On Mon, Mar 04, 2019 at 08:44:46AM +0100, Greg KH wrote:
> On Sun, Mar 03, 2019 at 12:30:23PM -0600, Madhumthia Prabakaran wrote:
> > On Sun, Mar 03, 2019 at 09:09:15AM +0100, Greg KH wrote:
> > > On Sat, Mar 02, 2019 at 12:34:42PM -0600, Madhumitha Prabakaran wrote:
> > > > These patches fix warnings of line over 80 characters, comment style
> > > > issues of SPDX License Identifier and remove unnecessary blank line.
> > > > 
> > > > Madhumitha Prabakaran (8):
> > > >   Staging: vt6655: card.h: Fix line over 80 character
> > > >   Staging: vt6655: card.h: Fix line over 80 characters
> > > >   Staging: vt6655: device.h: Fix comment style of SPDX License Identifier
> > > >   Staging: vt6655: device_cfg.h: Fix comment style of SPDX License Identifer
> > > >   Staging: vt6655: dpc.h: Fix comment style of SPDX License Identifier
> > > >   Staging: vt6655: key.h: Fix comment style of SPDX License Identifier
> > > >   Staging: vt6655: mac.c: Remove unnecessary blank line
> > > >   Staging: vt6655: mac.h: Fix comment style of SPDX License Identifier
> > > 
> > > Again, does not match the subject lines :(
> > > 
> > > Perhaps if you typed out here _exactly_ what you did to create this
> > > cover letter, and send them off to us, it might help in determining what
> > > you did wrong.
> > > 
> > > thanks,
> > > 
> > > greg k-h
> > 
> > Thanks
> > 
> > Task: commit patchsets, which contains two patches
> > 
> > 1. git log --pretty=oneline --abbrev-commit 
> > 
> > 8f8d8bbad6bc (HEAD -> staging-testing) Staging: vt6655: Fix ...
> > f68b96b7f7f5 Staging: vt6655: Fix comment ...
> > 
> > 08b9bee66e3e (origin/staging-testing, origin/staging-next) ...
> 
> Ah, the problem is you never changed the actual changelog text in the
> patch itself.  You need to do that.
> 
> > 2. Format-patch 
> > 
> > git format-patch -o /tmp/three/ --cover-letter -n --thread=shallow --cc="madhumithabiw@gmail.com" f68b96b7f7f5^..8f8d8bbad6bc
> > 
> > /tmp/three/0000-cover-letter.patch
> > /tmp/three/0001-Staging-vt6655-Fix-comment-style-of-SPDX-License-Ide.patch
> > /tmp/three/0002-Staging-vt6655-Fix-comment-style-of-SPDX-License-Ide.patch
> 
> See the subject line does not have the file name in it.
> 
> > 3. Format patch for versioning 
> > 
> > git format-patch -n --subject-prefix="PATCH v2" --cover-letter
> > 
> > On executing this, my subject prefix never changed. I assume, this is the issues. As this creates same version of subject line and clubs all version into same conversation. 
> 
> As discussed on irc, you don't need to use --subject-prefix.
> 
> Also, no need to call format-patch twice.
> 
> > 4. I manually edit the vim /tmp/three/0000-cover-letter.patch
> > 
> > 5. Edited the 'SUBJECT HERE'  and 'BLURB HERE'. Here too I noticed that the subject prefix never changed.. So i tried to edit it manually.
> >    I tried to change subject prefix for all the three files manually
> 
> Editing this file does not change the actual text in the patches
> themselves.
> 
> > 6. After that I tried using mutt and git to send files 
> > 
> > For git I used 
> > git send-email --to-cover --cc-cover /tmp/three/*.patch
> > 
> > For mutt I used 
> > mutt -H /tmp/third/0000......patch
> > For all three files I individually sent  it via mutt
> 
> Sending is fine.
> 
> Ok, you need to change the subject lines of your patch.
> 
> to do this, rebase the patches and edit the changelog text.  Look up how
> 'git rebase -i' works, with the "reword" option.  That will give you the
> chance to reword the changlog text to properly change the first line of
> the patches to contain the filenames.
> 
> Then do your step 3 and others and all should be good.
> 
> Hope this helps,
> 
> greg k-h

Thanks, I will fix it and resend it. 

Madhumitha