* Build error in 4.14 stable-queue
@ 2019-03-20 22:27 Eric Biggers
2019-03-20 23:50 ` Samuel Holland
0 siblings, 1 reply; 5+ messages in thread
From: Eric Biggers @ 2019-03-20 22:27 UTC (permalink / raw)
To: stable, Greg Kroah-Hartman; +Cc: Samuel Holland
queue-4.14/clocksource-drivers-arch_timer-workaround-for-allwinner-a64-timer-instability.patch
causes a build error:
CC drivers/clocksource/arm_arch_timer.o
drivers/clocksource/arm_arch_timer.c:433:4: error: 'const struct arch_timer_erratum_workaround' has no member named 'read_cntpct_el0'; did you mean 'read_cntvct_el0'?
.read_cntpct_el0 = sun50i_a64_read_cntpct_el0,
^~~~~~~~~~~~~~~
read_cntvct_el0
make[1]: *** [scripts/Makefile.build:327: drivers/clocksource/arm_arch_timer.o] Error 1
make: *** [Makefile:1686: drivers/clocksource/arm_arch_timer.o] Error 2
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: Build error in 4.14 stable-queue 2019-03-20 22:27 Build error in 4.14 stable-queue Eric Biggers @ 2019-03-20 23:50 ` Samuel Holland 2019-03-21 0:28 ` Sasha Levin 0 siblings, 1 reply; 5+ messages in thread From: Samuel Holland @ 2019-03-20 23:50 UTC (permalink / raw) To: Eric Biggers, stable, Greg Kroah-Hartman On 03/20/19 17:27, Eric Biggers wrote: > queue-4.14/clocksource-drivers-arch_timer-workaround-for-allwinner-a64-timer-instability.patch > causes a build error: > > CC drivers/clocksource/arm_arch_timer.o > drivers/clocksource/arm_arch_timer.c:433:4: error: 'const struct arch_timer_erratum_workaround' has no member named 'read_cntpct_el0'; did you mean 'read_cntvct_el0'? > .read_cntpct_el0 = sun50i_a64_read_cntpct_el0, > ^~~~~~~~~~~~~~~ > read_cntvct_el0 > make[1]: *** [scripts/Makefile.build:327: drivers/clocksource/arm_arch_timer.o] Error 1 > make: *** [Makefile:1686: drivers/clocksource/arm_arch_timer.o] Error 2 4.14 looks to be before the kernel switched to using CNTPCT internally, so that hook doesn't exist. The line should be removed. (sun50i_a64_read_cntpct_el0 still needs to be there for the .read_cntp_tval_el0 implementation.) Apologies for the breakage, Samuel ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Build error in 4.14 stable-queue 2019-03-20 23:50 ` Samuel Holland @ 2019-03-21 0:28 ` Sasha Levin 2019-03-21 5:27 ` Greg Kroah-Hartman 0 siblings, 1 reply; 5+ messages in thread From: Sasha Levin @ 2019-03-21 0:28 UTC (permalink / raw) To: Samuel Holland; +Cc: Eric Biggers, stable, Greg Kroah-Hartman On Wed, Mar 20, 2019 at 06:50:00PM -0500, Samuel Holland wrote: >On 03/20/19 17:27, Eric Biggers wrote: >> queue-4.14/clocksource-drivers-arch_timer-workaround-for-allwinner-a64-timer-instability.patch >> causes a build error: >> >> CC drivers/clocksource/arm_arch_timer.o >> drivers/clocksource/arm_arch_timer.c:433:4: error: 'const struct arch_timer_erratum_workaround' has no member named 'read_cntpct_el0'; did you mean 'read_cntvct_el0'? >> .read_cntpct_el0 = sun50i_a64_read_cntpct_el0, >> ^~~~~~~~~~~~~~~ >> read_cntvct_el0 >> make[1]: *** [scripts/Makefile.build:327: drivers/clocksource/arm_arch_timer.o] Error 1 >> make: *** [Makefile:1686: drivers/clocksource/arm_arch_timer.o] Error 2 > >4.14 looks to be before the kernel switched to using CNTPCT internally, so that >hook doesn't exist. The line should be removed. (sun50i_a64_read_cntpct_el0 >still needs to be there for the .read_cntp_tval_el0 implementation.) > >Apologies for the breakage, >Samuel I've dropped it from 4.14, thanks all! -- Thanks, Sasha ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Build error in 4.14 stable-queue 2019-03-21 0:28 ` Sasha Levin @ 2019-03-21 5:27 ` Greg Kroah-Hartman 2019-03-21 13:51 ` Sasha Levin 0 siblings, 1 reply; 5+ messages in thread From: Greg Kroah-Hartman @ 2019-03-21 5:27 UTC (permalink / raw) To: Sasha Levin; +Cc: Samuel Holland, Eric Biggers, stable On Wed, Mar 20, 2019 at 08:28:44PM -0400, Sasha Levin wrote: > On Wed, Mar 20, 2019 at 06:50:00PM -0500, Samuel Holland wrote: > > On 03/20/19 17:27, Eric Biggers wrote: > > > queue-4.14/clocksource-drivers-arch_timer-workaround-for-allwinner-a64-timer-instability.patch > > > causes a build error: > > > > > > CC drivers/clocksource/arm_arch_timer.o > > > drivers/clocksource/arm_arch_timer.c:433:4: error: 'const struct arch_timer_erratum_workaround' has no member named 'read_cntpct_el0'; did you mean 'read_cntvct_el0'? > > > .read_cntpct_el0 = sun50i_a64_read_cntpct_el0, > > > ^~~~~~~~~~~~~~~ > > > read_cntvct_el0 > > > make[1]: *** [scripts/Makefile.build:327: drivers/clocksource/arm_arch_timer.o] Error 1 > > > make: *** [Makefile:1686: drivers/clocksource/arm_arch_timer.o] Error 2 > > > > 4.14 looks to be before the kernel switched to using CNTPCT internally, so that > > hook doesn't exist. The line should be removed. (sun50i_a64_read_cntpct_el0 > > still needs to be there for the .read_cntp_tval_el0 implementation.) > > > > Apologies for the breakage, > > Samuel > > I've dropped it from 4.14, thanks all! I don't see it dropped in the public tree, so I've dropped it for real now :) thanks, greg k-h ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Build error in 4.14 stable-queue 2019-03-21 5:27 ` Greg Kroah-Hartman @ 2019-03-21 13:51 ` Sasha Levin 0 siblings, 0 replies; 5+ messages in thread From: Sasha Levin @ 2019-03-21 13:51 UTC (permalink / raw) To: Greg Kroah-Hartman; +Cc: Samuel Holland, Eric Biggers, stable On Thu, Mar 21, 2019 at 06:27:22AM +0100, Greg Kroah-Hartman wrote: >On Wed, Mar 20, 2019 at 08:28:44PM -0400, Sasha Levin wrote: >> On Wed, Mar 20, 2019 at 06:50:00PM -0500, Samuel Holland wrote: >> > On 03/20/19 17:27, Eric Biggers wrote: >> > > queue-4.14/clocksource-drivers-arch_timer-workaround-for-allwinner-a64-timer-instability.patch >> > > causes a build error: >> > > >> > > CC drivers/clocksource/arm_arch_timer.o >> > > drivers/clocksource/arm_arch_timer.c:433:4: error: 'const struct arch_timer_erratum_workaround' has no member named 'read_cntpct_el0'; did you mean 'read_cntvct_el0'? >> > > .read_cntpct_el0 = sun50i_a64_read_cntpct_el0, >> > > ^~~~~~~~~~~~~~~ >> > > read_cntvct_el0 >> > > make[1]: *** [scripts/Makefile.build:327: drivers/clocksource/arm_arch_timer.o] Error 1 >> > > make: *** [Makefile:1686: drivers/clocksource/arm_arch_timer.o] Error 2 >> > >> > 4.14 looks to be before the kernel switched to using CNTPCT internally, so that >> > hook doesn't exist. The line should be removed. (sun50i_a64_read_cntpct_el0 >> > still needs to be there for the .read_cntp_tval_el0 implementation.) >> > >> > Apologies for the breakage, >> > Samuel >> >> I've dropped it from 4.14, thanks all! > >I don't see it dropped in the public tree, so I've dropped it for real >now :) You were not supposed to be awake that early! :p -- Thanks, Sasha ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-03-21 13:51 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-03-20 22:27 Build error in 4.14 stable-queue Eric Biggers 2019-03-20 23:50 ` Samuel Holland 2019-03-21 0:28 ` Sasha Levin 2019-03-21 5:27 ` Greg Kroah-Hartman 2019-03-21 13:51 ` Sasha Levin
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.