* [PATCH] mfd: stmfx: Fix macro definition spelling
@ 2019-05-11 1:23 ` Nathan Chancellor
0 siblings, 0 replies; 14+ messages in thread
From: Nathan Chancellor @ 2019-05-11 1:23 UTC (permalink / raw)
To: Amelie Delaunay, Lee Jones
Cc: Alexandre Torgue, linux-kernel, clang-built-linux,
Maxime Coquelin, Nathan Chancellor, linux-stm32, linux-arm-kernel
Clang warns:
In file included from drivers/mfd/stmfx.c:13:
include/linux/mfd/stmfx.h:7:9: warning: 'MFD_STMFX_H' is used as a
header guard here, followed by #define of a different macro
[-Wheader-guard]
Fixes: 06252ade9156 ("mfd: Add ST Multi-Function eXpander (STMFX) core driver")
Link: https://github.com/ClangBuiltLinux/linux/issues/475
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
include/linux/mfd/stmfx.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/mfd/stmfx.h b/include/linux/mfd/stmfx.h
index d890595b89b6..3c67983678ec 100644
--- a/include/linux/mfd/stmfx.h
+++ b/include/linux/mfd/stmfx.h
@@ -5,7 +5,7 @@
*/
#ifndef MFD_STMFX_H
-#define MFX_STMFX_H
+#define MFD_STMFX_H
#include <linux/regmap.h>
--
2.21.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH] mfd: stmfx: Fix macro definition spelling @ 2019-05-11 1:23 ` Nathan Chancellor 0 siblings, 0 replies; 14+ messages in thread From: Nathan Chancellor @ 2019-05-11 1:23 UTC (permalink / raw) To: Amelie Delaunay, Lee Jones Cc: Maxime Coquelin, Alexandre Torgue, linux-stm32, linux-arm-kernel, linux-kernel, clang-built-linux, Nathan Chancellor Clang warns: In file included from drivers/mfd/stmfx.c:13: include/linux/mfd/stmfx.h:7:9: warning: 'MFD_STMFX_H' is used as a header guard here, followed by #define of a different macro [-Wheader-guard] Fixes: 06252ade9156 ("mfd: Add ST Multi-Function eXpander (STMFX) core driver") Link: https://github.com/ClangBuiltLinux/linux/issues/475 Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> --- include/linux/mfd/stmfx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/mfd/stmfx.h b/include/linux/mfd/stmfx.h index d890595b89b6..3c67983678ec 100644 --- a/include/linux/mfd/stmfx.h +++ b/include/linux/mfd/stmfx.h @@ -5,7 +5,7 @@ */ #ifndef MFD_STMFX_H -#define MFX_STMFX_H +#define MFD_STMFX_H #include <linux/regmap.h> -- 2.21.0 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] mfd: stmfx: Fix macro definition spelling 2019-05-11 1:23 ` Nathan Chancellor @ 2019-05-13 7:10 ` Amelie DELAUNAY -1 siblings, 0 replies; 14+ messages in thread From: Amelie DELAUNAY @ 2019-05-13 7:10 UTC (permalink / raw) To: Nathan Chancellor, Lee Jones Cc: Alexandre TORGUE, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, Maxime Coquelin, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org On 5/11/19 3:23 AM, Nathan Chancellor wrote: > Clang warns: > > In file included from drivers/mfd/stmfx.c:13: > include/linux/mfd/stmfx.h:7:9: warning: 'MFD_STMFX_H' is used as a > header guard here, followed by #define of a different macro > [-Wheader-guard] > > Fixes: 06252ade9156 ("mfd: Add ST Multi-Function eXpander (STMFX) core driver") > Link: https://github.com/ClangBuiltLinux/linux/issues/475 > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Reviewed-by: Amelie Delaunay <amelie.delaunay@st.com> > --- > include/linux/mfd/stmfx.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/mfd/stmfx.h b/include/linux/mfd/stmfx.h > index d890595b89b6..3c67983678ec 100644 > --- a/include/linux/mfd/stmfx.h > +++ b/include/linux/mfd/stmfx.h > @@ -5,7 +5,7 @@ > */ > > #ifndef MFD_STMFX_H > -#define MFX_STMFX_H > +#define MFD_STMFX_H > > #include <linux/regmap.h> > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] mfd: stmfx: Fix macro definition spelling @ 2019-05-13 7:10 ` Amelie DELAUNAY 0 siblings, 0 replies; 14+ messages in thread From: Amelie DELAUNAY @ 2019-05-13 7:10 UTC (permalink / raw) To: Nathan Chancellor, Lee Jones Cc: Maxime Coquelin, Alexandre TORGUE, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com On 5/11/19 3:23 AM, Nathan Chancellor wrote: > Clang warns: > > In file included from drivers/mfd/stmfx.c:13: > include/linux/mfd/stmfx.h:7:9: warning: 'MFD_STMFX_H' is used as a > header guard here, followed by #define of a different macro > [-Wheader-guard] > > Fixes: 06252ade9156 ("mfd: Add ST Multi-Function eXpander (STMFX) core driver") > Link: https://github.com/ClangBuiltLinux/linux/issues/475 > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Reviewed-by: Amelie Delaunay <amelie.delaunay@st.com> > --- > include/linux/mfd/stmfx.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/mfd/stmfx.h b/include/linux/mfd/stmfx.h > index d890595b89b6..3c67983678ec 100644 > --- a/include/linux/mfd/stmfx.h > +++ b/include/linux/mfd/stmfx.h > @@ -5,7 +5,7 @@ > */ > > #ifndef MFD_STMFX_H > -#define MFX_STMFX_H > +#define MFD_STMFX_H > > #include <linux/regmap.h> > > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] mfd: stmfx: Fix macro definition spelling 2019-05-11 1:23 ` Nathan Chancellor @ 2019-05-13 7:30 ` Lee Jones -1 siblings, 0 replies; 14+ messages in thread From: Lee Jones @ 2019-05-13 7:30 UTC (permalink / raw) To: Nathan Chancellor Cc: Amelie Delaunay, Alexandre Torgue, linux-kernel, clang-built-linux, Maxime Coquelin, linux-stm32, linux-arm-kernel On Fri, 10 May 2019, Nathan Chancellor wrote: > Clang warns: > > In file included from drivers/mfd/stmfx.c:13: > include/linux/mfd/stmfx.h:7:9: warning: 'MFD_STMFX_H' is used as a > header guard here, followed by #define of a different macro > [-Wheader-guard] > > Fixes: 06252ade9156 ("mfd: Add ST Multi-Function eXpander (STMFX) core driver") > Link: https://github.com/ClangBuiltLinux/linux/issues/475 > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> > --- > include/linux/mfd/stmfx.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] mfd: stmfx: Fix macro definition spelling @ 2019-05-13 7:30 ` Lee Jones 0 siblings, 0 replies; 14+ messages in thread From: Lee Jones @ 2019-05-13 7:30 UTC (permalink / raw) To: Nathan Chancellor Cc: Amelie Delaunay, Maxime Coquelin, Alexandre Torgue, linux-stm32, linux-arm-kernel, linux-kernel, clang-built-linux On Fri, 10 May 2019, Nathan Chancellor wrote: > Clang warns: > > In file included from drivers/mfd/stmfx.c:13: > include/linux/mfd/stmfx.h:7:9: warning: 'MFD_STMFX_H' is used as a > header guard here, followed by #define of a different macro > [-Wheader-guard] > > Fixes: 06252ade9156 ("mfd: Add ST Multi-Function eXpander (STMFX) core driver") > Link: https://github.com/ClangBuiltLinux/linux/issues/475 > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> > --- > include/linux/mfd/stmfx.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] mfd: stmfx: Fix macro definition spelling 2019-05-13 7:30 ` Lee Jones @ 2019-05-14 18:39 ` Nathan Chancellor -1 siblings, 0 replies; 14+ messages in thread From: Nathan Chancellor @ 2019-05-14 18:39 UTC (permalink / raw) To: Lee Jones Cc: Amelie Delaunay, Alexandre Torgue, linux-kernel, clang-built-linux, Maxime Coquelin, linux-stm32, linux-arm-kernel On Mon, May 13, 2019 at 08:30:59AM +0100, Lee Jones wrote: > On Fri, 10 May 2019, Nathan Chancellor wrote: > > > Clang warns: > > > > In file included from drivers/mfd/stmfx.c:13: > > include/linux/mfd/stmfx.h:7:9: warning: 'MFD_STMFX_H' is used as a > > header guard here, followed by #define of a different macro > > [-Wheader-guard] > > > > Fixes: 06252ade9156 ("mfd: Add ST Multi-Function eXpander (STMFX) core driver") > > Link: https://github.com/ClangBuiltLinux/linux/issues/475 > > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> > > --- > > include/linux/mfd/stmfx.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Applied, thanks. > > -- > Lee Jones [李琼斯] > Linaro Services Technical Lead > Linaro.org │ Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog Hi Lee, Thanks for picking it up. It seems this didn't make it into your MFD pull request for 5.2, was that intentional? It would be nice to avoid this warning. Thanks, Nathan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] mfd: stmfx: Fix macro definition spelling @ 2019-05-14 18:39 ` Nathan Chancellor 0 siblings, 0 replies; 14+ messages in thread From: Nathan Chancellor @ 2019-05-14 18:39 UTC (permalink / raw) To: Lee Jones Cc: Amelie Delaunay, Maxime Coquelin, Alexandre Torgue, linux-stm32, linux-arm-kernel, linux-kernel, clang-built-linux On Mon, May 13, 2019 at 08:30:59AM +0100, Lee Jones wrote: > On Fri, 10 May 2019, Nathan Chancellor wrote: > > > Clang warns: > > > > In file included from drivers/mfd/stmfx.c:13: > > include/linux/mfd/stmfx.h:7:9: warning: 'MFD_STMFX_H' is used as a > > header guard here, followed by #define of a different macro > > [-Wheader-guard] > > > > Fixes: 06252ade9156 ("mfd: Add ST Multi-Function eXpander (STMFX) core driver") > > Link: https://github.com/ClangBuiltLinux/linux/issues/475 > > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> > > --- > > include/linux/mfd/stmfx.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Applied, thanks. > > -- > Lee Jones [李琼斯] > Linaro Services Technical Lead > Linaro.org │ Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog Hi Lee, Thanks for picking it up. It seems this didn't make it into your MFD pull request for 5.2, was that intentional? It would be nice to avoid this warning. Thanks, Nathan ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] mfd: stmfx: Fix macro definition spelling 2019-05-14 18:39 ` Nathan Chancellor @ 2019-05-14 18:54 ` Lee Jones -1 siblings, 0 replies; 14+ messages in thread From: Lee Jones @ 2019-05-14 18:54 UTC (permalink / raw) To: Nathan Chancellor Cc: Amelie Delaunay, Alexandre Torgue, linux-kernel, clang-built-linux, Maxime Coquelin, linux-stm32, linux-arm-kernel On Tue, 14 May 2019, Nathan Chancellor wrote: > On Mon, May 13, 2019 at 08:30:59AM +0100, Lee Jones wrote: > > On Fri, 10 May 2019, Nathan Chancellor wrote: > > > > > Clang warns: > > > > > > In file included from drivers/mfd/stmfx.c:13: > > > include/linux/mfd/stmfx.h:7:9: warning: 'MFD_STMFX_H' is used as a > > > header guard here, followed by #define of a different macro > > > [-Wheader-guard] > > > > > > Fixes: 06252ade9156 ("mfd: Add ST Multi-Function eXpander (STMFX) core driver") > > > Link: https://github.com/ClangBuiltLinux/linux/issues/475 > > > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> > > > --- > > > include/linux/mfd/stmfx.h | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Applied, thanks. > > > > Hi Lee, > > Thanks for picking it up. It seems this didn't make it into your MFD > pull request for 5.2, was that intentional? It would be nice to avoid > this warning. Hmm... no it was not intentional. Not sure what happened there. I will pick it up for the -rcs. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] mfd: stmfx: Fix macro definition spelling @ 2019-05-14 18:54 ` Lee Jones 0 siblings, 0 replies; 14+ messages in thread From: Lee Jones @ 2019-05-14 18:54 UTC (permalink / raw) To: Nathan Chancellor Cc: Amelie Delaunay, Maxime Coquelin, Alexandre Torgue, linux-stm32, linux-arm-kernel, linux-kernel, clang-built-linux On Tue, 14 May 2019, Nathan Chancellor wrote: > On Mon, May 13, 2019 at 08:30:59AM +0100, Lee Jones wrote: > > On Fri, 10 May 2019, Nathan Chancellor wrote: > > > > > Clang warns: > > > > > > In file included from drivers/mfd/stmfx.c:13: > > > include/linux/mfd/stmfx.h:7:9: warning: 'MFD_STMFX_H' is used as a > > > header guard here, followed by #define of a different macro > > > [-Wheader-guard] > > > > > > Fixes: 06252ade9156 ("mfd: Add ST Multi-Function eXpander (STMFX) core driver") > > > Link: https://github.com/ClangBuiltLinux/linux/issues/475 > > > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> > > > --- > > > include/linux/mfd/stmfx.h | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Applied, thanks. > > > > Hi Lee, > > Thanks for picking it up. It seems this didn't make it into your MFD > pull request for 5.2, was that intentional? It would be nice to avoid > this warning. Hmm... no it was not intentional. Not sure what happened there. I will pick it up for the -rcs. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] mfd: stmfx: Fix macro definition spelling 2019-05-14 18:54 ` Lee Jones @ 2019-05-14 19:45 ` Nathan Chancellor -1 siblings, 0 replies; 14+ messages in thread From: Nathan Chancellor @ 2019-05-14 19:45 UTC (permalink / raw) To: Lee Jones Cc: Amelie Delaunay, Alexandre Torgue, linux-kernel, clang-built-linux, Maxime Coquelin, linux-stm32, linux-arm-kernel On Tue, May 14, 2019 at 07:54:04PM +0100, Lee Jones wrote: > On Tue, 14 May 2019, Nathan Chancellor wrote: > > > On Mon, May 13, 2019 at 08:30:59AM +0100, Lee Jones wrote: > > > On Fri, 10 May 2019, Nathan Chancellor wrote: > > > > > > > Clang warns: > > > > > > > > In file included from drivers/mfd/stmfx.c:13: > > > > include/linux/mfd/stmfx.h:7:9: warning: 'MFD_STMFX_H' is used as a > > > > header guard here, followed by #define of a different macro > > > > [-Wheader-guard] > > > > > > > > Fixes: 06252ade9156 ("mfd: Add ST Multi-Function eXpander (STMFX) core driver") > > > > Link: https://github.com/ClangBuiltLinux/linux/issues/475 > > > > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> > > > > --- > > > > include/linux/mfd/stmfx.h | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > Applied, thanks. > > > > > > > Hi Lee, > > > > Thanks for picking it up. It seems this didn't make it into your MFD > > pull request for 5.2, was that intentional? It would be nice to avoid > > this warning. > > Hmm... no it was not intentional. Not sure what happened there. > > I will pick it up for the -rcs. > > -- > Lee Jones [李琼斯] > Linaro Services Technical Lead > Linaro.org │ Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog Thank you, I appreciate it! Nathan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] mfd: stmfx: Fix macro definition spelling @ 2019-05-14 19:45 ` Nathan Chancellor 0 siblings, 0 replies; 14+ messages in thread From: Nathan Chancellor @ 2019-05-14 19:45 UTC (permalink / raw) To: Lee Jones Cc: Amelie Delaunay, Maxime Coquelin, Alexandre Torgue, linux-stm32, linux-arm-kernel, linux-kernel, clang-built-linux On Tue, May 14, 2019 at 07:54:04PM +0100, Lee Jones wrote: > On Tue, 14 May 2019, Nathan Chancellor wrote: > > > On Mon, May 13, 2019 at 08:30:59AM +0100, Lee Jones wrote: > > > On Fri, 10 May 2019, Nathan Chancellor wrote: > > > > > > > Clang warns: > > > > > > > > In file included from drivers/mfd/stmfx.c:13: > > > > include/linux/mfd/stmfx.h:7:9: warning: 'MFD_STMFX_H' is used as a > > > > header guard here, followed by #define of a different macro > > > > [-Wheader-guard] > > > > > > > > Fixes: 06252ade9156 ("mfd: Add ST Multi-Function eXpander (STMFX) core driver") > > > > Link: https://github.com/ClangBuiltLinux/linux/issues/475 > > > > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> > > > > --- > > > > include/linux/mfd/stmfx.h | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > Applied, thanks. > > > > > > > Hi Lee, > > > > Thanks for picking it up. It seems this didn't make it into your MFD > > pull request for 5.2, was that intentional? It would be nice to avoid > > this warning. > > Hmm... no it was not intentional. Not sure what happened there. > > I will pick it up for the -rcs. > > -- > Lee Jones [李琼斯] > Linaro Services Technical Lead > Linaro.org │ Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog Thank you, I appreciate it! Nathan ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] mfd: stmfx: Fix macro definition spelling 2019-05-14 18:54 ` Lee Jones @ 2019-06-14 3:57 ` Nathan Chancellor -1 siblings, 0 replies; 14+ messages in thread From: Nathan Chancellor @ 2019-06-14 3:57 UTC (permalink / raw) To: Lee Jones Cc: Amelie Delaunay, Alexandre Torgue, linux-kernel, clang-built-linux, Maxime Coquelin, linux-stm32, linux-arm-kernel On Tue, May 14, 2019 at 07:54:04PM +0100, Lee Jones wrote: > On Tue, 14 May 2019, Nathan Chancellor wrote: > > > On Mon, May 13, 2019 at 08:30:59AM +0100, Lee Jones wrote: > > > On Fri, 10 May 2019, Nathan Chancellor wrote: > > > > > > > Clang warns: > > > > > > > > In file included from drivers/mfd/stmfx.c:13: > > > > include/linux/mfd/stmfx.h:7:9: warning: 'MFD_STMFX_H' is used as a > > > > header guard here, followed by #define of a different macro > > > > [-Wheader-guard] > > > > > > > > Fixes: 06252ade9156 ("mfd: Add ST Multi-Function eXpander (STMFX) core driver") > > > > Link: https://github.com/ClangBuiltLinux/linux/issues/475 > > > > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> > > > > --- > > > > include/linux/mfd/stmfx.h | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > Applied, thanks. > > > > > > > Hi Lee, > > > > Thanks for picking it up. It seems this didn't make it into your MFD > > pull request for 5.2, was that intentional? It would be nice to avoid > > this warning. > > Hmm... no it was not intentional. Not sure what happened there. > > I will pick it up for the -rcs. Hi Lee, Have you picked this up yet? I don't see it in -next or your public tree. Cheers, Nathan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] mfd: stmfx: Fix macro definition spelling @ 2019-06-14 3:57 ` Nathan Chancellor 0 siblings, 0 replies; 14+ messages in thread From: Nathan Chancellor @ 2019-06-14 3:57 UTC (permalink / raw) To: Lee Jones Cc: Amelie Delaunay, Maxime Coquelin, Alexandre Torgue, linux-stm32, linux-arm-kernel, linux-kernel, clang-built-linux On Tue, May 14, 2019 at 07:54:04PM +0100, Lee Jones wrote: > On Tue, 14 May 2019, Nathan Chancellor wrote: > > > On Mon, May 13, 2019 at 08:30:59AM +0100, Lee Jones wrote: > > > On Fri, 10 May 2019, Nathan Chancellor wrote: > > > > > > > Clang warns: > > > > > > > > In file included from drivers/mfd/stmfx.c:13: > > > > include/linux/mfd/stmfx.h:7:9: warning: 'MFD_STMFX_H' is used as a > > > > header guard here, followed by #define of a different macro > > > > [-Wheader-guard] > > > > > > > > Fixes: 06252ade9156 ("mfd: Add ST Multi-Function eXpander (STMFX) core driver") > > > > Link: https://github.com/ClangBuiltLinux/linux/issues/475 > > > > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> > > > > --- > > > > include/linux/mfd/stmfx.h | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > Applied, thanks. > > > > > > > Hi Lee, > > > > Thanks for picking it up. It seems this didn't make it into your MFD > > pull request for 5.2, was that intentional? It would be nice to avoid > > this warning. > > Hmm... no it was not intentional. Not sure what happened there. > > I will pick it up for the -rcs. Hi Lee, Have you picked this up yet? I don't see it in -next or your public tree. Cheers, Nathan ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2019-06-14 3:57 UTC | newest] Thread overview: 14+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-05-11 1:23 [PATCH] mfd: stmfx: Fix macro definition spelling Nathan Chancellor 2019-05-11 1:23 ` Nathan Chancellor 2019-05-13 7:10 ` Amelie DELAUNAY 2019-05-13 7:10 ` Amelie DELAUNAY 2019-05-13 7:30 ` Lee Jones 2019-05-13 7:30 ` Lee Jones 2019-05-14 18:39 ` Nathan Chancellor 2019-05-14 18:39 ` Nathan Chancellor 2019-05-14 18:54 ` Lee Jones 2019-05-14 18:54 ` Lee Jones 2019-05-14 19:45 ` Nathan Chancellor 2019-05-14 19:45 ` Nathan Chancellor 2019-06-14 3:57 ` Nathan Chancellor 2019-06-14 3:57 ` Nathan Chancellor
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.