All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: linux-fbdev@vger.kernel.org,
	Kernel Janitors <kernel-janitors@vger.kernel.org>,
	dri-devel@lists.freedesktop.org, nishadkamdar@gmail.com
Subject: Re: [RFC] Staging: fbtft: Typo in
Date: Thu, 25 Jul 2019 07:16:35 +0000	[thread overview]
Message-ID: <20190725071635.GA17271@kroah.com> (raw)
In-Reply-To: <f4881a63-8702-55f2-ed03-cfbc30970083@wanadoo.fr>

On Sun, Jul 21, 2019 at 08:54:39PM +0200, Christophe JAILLET wrote:
> Hi,
> 
> looking at the code in 'drivers/staging/fbtft/fb_pcd8544.c', there seems to
> be some typos.
> 
> At the end of the file, we can find:
> 
> FBTFT_REGISTER_DRIVER(DRVNAME, "philips,pdc8544", &display);
> ...
> MODULE_ALIAS("spi:pdc8544");
> 
> 
> It is likely that the 2 pdc8544 should be pcd8544. (d and c switched)
> 
> As I don't know the implication of such a change, I prefer to first report
> the potential issue, before proposing a patch for it.

Submit a patch, that's the best way to discuss it!

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: linux-fbdev@vger.kernel.org,
	Kernel Janitors <kernel-janitors@vger.kernel.org>,
	dri-devel@lists.freedesktop.org, nishadkamdar@gmail.com
Subject: Re: [RFC] Staging: fbtft: Typo in
Date: Thu, 25 Jul 2019 09:16:35 +0200	[thread overview]
Message-ID: <20190725071635.GA17271@kroah.com> (raw)
In-Reply-To: <f4881a63-8702-55f2-ed03-cfbc30970083@wanadoo.fr>

On Sun, Jul 21, 2019 at 08:54:39PM +0200, Christophe JAILLET wrote:
> Hi,
> 
> looking at the code in 'drivers/staging/fbtft/fb_pcd8544.c', there seems to
> be some typos.
> 
> At the end of the file, we can find:
> 
> FBTFT_REGISTER_DRIVER(DRVNAME, "philips,pdc8544", &display);
> ...
> MODULE_ALIAS("spi:pdc8544");
> 
> 
> It is likely that the 2 pdc8544 should be pcd8544. (d and c switched)
> 
> As I don't know the implication of such a change, I prefer to first report
> the potential issue, before proposing a patch for it.

Submit a patch, that's the best way to discuss it!

thanks,

greg k-h
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2019-07-25  7:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-21 18:54 [RFC] Staging: fbtft: Typo in Christophe JAILLET
2019-07-25  7:16 ` Greg KH [this message]
2019-07-25  7:16   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190725071635.GA17271@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=nishadkamdar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.