[RFC] Staging: fbtft: Typo in

[RFC] Staging: fbtft: Typo in

[Christophe JAILLET]

Hi,

looking at the code in 'drivers/staging/fbtft/fb_pcd8544.c', there seems 
to be some typos.

At the end of the file, we can find:

FBTFT_REGISTER_DRIVER(DRVNAME, "philips,pdc8544", &display);
...
MODULE_ALIAS("spi:pdc8544");


It is likely that the 2 pdc8544 should be pcd8544. (d and c switched)

As I don't know the implication of such a change, I prefer to first 
report the potential issue, before proposing a patch for it.

Any feedback back appreciated.

Best regards,
Christophe JAILLET

Re: [RFC] Staging: fbtft: Typo in

[Greg KH]

On Sun, Jul 21, 2019 at 08:54:39PM +0200, Christophe JAILLET wrote:
> Hi,
> 
> looking at the code in 'drivers/staging/fbtft/fb_pcd8544.c', there seems to
> be some typos.
> 
> At the end of the file, we can find:
> 
> FBTFT_REGISTER_DRIVER(DRVNAME, "philips,pdc8544", &display);
> ...
> MODULE_ALIAS("spi:pdc8544");
> 
> 
> It is likely that the 2 pdc8544 should be pcd8544. (d and c switched)
> 
> As I don't know the implication of such a change, I prefer to first report
> the potential issue, before proposing a patch for it.

Submit a patch, that's the best way to discuss it!

thanks,

greg k-h

Re: [RFC] Staging: fbtft: Typo in

[Greg KH]

On Sun, Jul 21, 2019 at 08:54:39PM +0200, Christophe JAILLET wrote:
> Hi,
> 
> looking at the code in 'drivers/staging/fbtft/fb_pcd8544.c', there seems to
> be some typos.
> 
> At the end of the file, we can find:
> 
> FBTFT_REGISTER_DRIVER(DRVNAME, "philips,pdc8544", &display);
> ...
> MODULE_ALIAS("spi:pdc8544");
> 
> 
> It is likely that the 2 pdc8544 should be pcd8544. (d and c switched)
> 
> As I don't know the implication of such a change, I prefer to first report
> the potential issue, before proposing a patch for it.

Submit a patch, that's the best way to discuss it!

thanks,

greg k-h
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel