From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
linux-samsung-soc@vger.kernel.org,
Maciej Falkowski <m.falkowski@samsung.com>,
Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>
Subject: Re: [alsa-devel] [PATCH] ASoC: samsung: i2s: Add clocks' macros descriptions
Date: Tue, 24 Sep 2019 13:53:07 +0200 [thread overview]
Message-ID: <20190924115307.GA9188@pi3> (raw)
In-Reply-To: <20190924114838.25482-1-m.szyprowski@samsung.com>
On Tue, Sep 24, 2019 at 01:48:38PM +0200, Marek Szyprowski wrote:
> From: Maciej Falkowski <m.falkowski@samsung.com>
>
> To increase macro readability added descriptions
> to clocks macros.
>
> Signed-off-by: Maciej Falkowski <m.falkowski@samsung.com>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> include/dt-bindings/sound/samsung-i2s.h | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/include/dt-bindings/sound/samsung-i2s.h b/include/dt-bindings/sound/samsung-i2s.h
> index 77545f14c379..fd752475c762 100644
> --- a/include/dt-bindings/sound/samsung-i2s.h
> +++ b/include/dt-bindings/sound/samsung-i2s.h
> @@ -2,8 +2,13 @@
> #ifndef _DT_BINDINGS_SAMSUNG_I2S_H
> #define _DT_BINDINGS_SAMSUNG_I2S_H
>
> -#define CLK_I2S_CDCLK 0
> -#define CLK_I2S_RCLK_SRC 1
> -#define CLK_I2S_RCLK_PSR 2
> +/* the CDCLK (CODECLKO) gate clock */
> +#define CLK_I2S_CDCLK 0
I do not find it more readable because of removal of indent after define name. Also the description is not accurate - you documented, not increased readability.
Best regards,
Krzysztof
> +
> +/* the RCLKSRC mux clock (corresponding to RCLKSRC bit in IISMOD register) */
> +#define CLK_I2S_RCLK_SRC 1
> +
> +/* the RCLK prescaler divider clock (corresponding to the IISPSR register) */
> +#define CLK_I2S_RCLK_PSR 2
>
> #endif /* _DT_BINDINGS_SAMSUNG_I2S_H */
> --
> 2.17.1
>
>
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Mark Brown <broonie@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Maciej Falkowski <m.falkowski@samsung.com>
Subject: Re: [PATCH] ASoC: samsung: i2s: Add clocks' macros descriptions
Date: Tue, 24 Sep 2019 13:53:07 +0200 [thread overview]
Message-ID: <20190924115307.GA9188@pi3> (raw)
In-Reply-To: <20190924114838.25482-1-m.szyprowski@samsung.com>
On Tue, Sep 24, 2019 at 01:48:38PM +0200, Marek Szyprowski wrote:
> From: Maciej Falkowski <m.falkowski@samsung.com>
>
> To increase macro readability added descriptions
> to clocks macros.
>
> Signed-off-by: Maciej Falkowski <m.falkowski@samsung.com>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> include/dt-bindings/sound/samsung-i2s.h | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/include/dt-bindings/sound/samsung-i2s.h b/include/dt-bindings/sound/samsung-i2s.h
> index 77545f14c379..fd752475c762 100644
> --- a/include/dt-bindings/sound/samsung-i2s.h
> +++ b/include/dt-bindings/sound/samsung-i2s.h
> @@ -2,8 +2,13 @@
> #ifndef _DT_BINDINGS_SAMSUNG_I2S_H
> #define _DT_BINDINGS_SAMSUNG_I2S_H
>
> -#define CLK_I2S_CDCLK 0
> -#define CLK_I2S_RCLK_SRC 1
> -#define CLK_I2S_RCLK_PSR 2
> +/* the CDCLK (CODECLKO) gate clock */
> +#define CLK_I2S_CDCLK 0
I do not find it more readable because of removal of indent after define name. Also the description is not accurate - you documented, not increased readability.
Best regards,
Krzysztof
> +
> +/* the RCLKSRC mux clock (corresponding to RCLKSRC bit in IISMOD register) */
> +#define CLK_I2S_RCLK_SRC 1
> +
> +/* the RCLK prescaler divider clock (corresponding to the IISPSR register) */
> +#define CLK_I2S_RCLK_PSR 2
>
> #endif /* _DT_BINDINGS_SAMSUNG_I2S_H */
> --
> 2.17.1
>
>
>
next prev parent reply other threads:[~2019-09-24 11:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190924114843eucas1p2ea9c36289d3912e022ad7c9070fc00ee@eucas1p2.samsung.com>
2019-09-24 11:48 ` [alsa-devel] [PATCH] ASoC: samsung: i2s: Add clocks' macros descriptions Marek Szyprowski
2019-09-24 11:48 ` Marek Szyprowski
2019-09-24 11:53 ` Krzysztof Kozlowski [this message]
2019-09-24 11:53 ` Krzysztof Kozlowski
2019-09-24 17:53 ` [alsa-devel] " Mark Brown
2019-09-24 17:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190924115307.GA9188@pi3 \
--to=krzk@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.falkowski@samsung.com \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.