* [alsa-devel] [PATCH] ASoC: samsung: i2s: Add clocks' macros descriptions
[not found] <CGME20190924114843eucas1p2ea9c36289d3912e022ad7c9070fc00ee@eucas1p2.samsung.com>
@ 2019-09-24 11:48 ` Marek Szyprowski
0 siblings, 0 replies; 6+ messages in thread
From: Marek Szyprowski @ 2019-09-24 11:48 UTC (permalink / raw)
To: devicetree, alsa-devel, linux-kernel, linux-samsung-soc
Cc: Mark Rutland, Maciej Falkowski, Liam Girdwood, Rob Herring,
Mark Brown, Krzysztof Kozlowski, Sylwester Nawrocki,
Marek Szyprowski
From: Maciej Falkowski <m.falkowski@samsung.com>
To increase macro readability added descriptions
to clocks macros.
Signed-off-by: Maciej Falkowski <m.falkowski@samsung.com>
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
include/dt-bindings/sound/samsung-i2s.h | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/include/dt-bindings/sound/samsung-i2s.h b/include/dt-bindings/sound/samsung-i2s.h
index 77545f14c379..fd752475c762 100644
--- a/include/dt-bindings/sound/samsung-i2s.h
+++ b/include/dt-bindings/sound/samsung-i2s.h
@@ -2,8 +2,13 @@
#ifndef _DT_BINDINGS_SAMSUNG_I2S_H
#define _DT_BINDINGS_SAMSUNG_I2S_H
-#define CLK_I2S_CDCLK 0
-#define CLK_I2S_RCLK_SRC 1
-#define CLK_I2S_RCLK_PSR 2
+/* the CDCLK (CODECLKO) gate clock */
+#define CLK_I2S_CDCLK 0
+
+/* the RCLKSRC mux clock (corresponding to RCLKSRC bit in IISMOD register) */
+#define CLK_I2S_RCLK_SRC 1
+
+/* the RCLK prescaler divider clock (corresponding to the IISPSR register) */
+#define CLK_I2S_RCLK_PSR 2
#endif /* _DT_BINDINGS_SAMSUNG_I2S_H */
--
2.17.1
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ASoC: samsung: i2s: Add clocks' macros descriptions
@ 2019-09-24 11:48 ` Marek Szyprowski
0 siblings, 0 replies; 6+ messages in thread
From: Marek Szyprowski @ 2019-09-24 11:48 UTC (permalink / raw)
To: devicetree, alsa-devel, linux-kernel, linux-samsung-soc
Cc: Rob Herring, Mark Rutland, Krzysztof Kozlowski, Mark Brown,
Sylwester Nawrocki, Liam Girdwood, Maciej Falkowski,
Marek Szyprowski
From: Maciej Falkowski <m.falkowski@samsung.com>
To increase macro readability added descriptions
to clocks macros.
Signed-off-by: Maciej Falkowski <m.falkowski@samsung.com>
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
include/dt-bindings/sound/samsung-i2s.h | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/include/dt-bindings/sound/samsung-i2s.h b/include/dt-bindings/sound/samsung-i2s.h
index 77545f14c379..fd752475c762 100644
--- a/include/dt-bindings/sound/samsung-i2s.h
+++ b/include/dt-bindings/sound/samsung-i2s.h
@@ -2,8 +2,13 @@
#ifndef _DT_BINDINGS_SAMSUNG_I2S_H
#define _DT_BINDINGS_SAMSUNG_I2S_H
-#define CLK_I2S_CDCLK 0
-#define CLK_I2S_RCLK_SRC 1
-#define CLK_I2S_RCLK_PSR 2
+/* the CDCLK (CODECLKO) gate clock */
+#define CLK_I2S_CDCLK 0
+
+/* the RCLKSRC mux clock (corresponding to RCLKSRC bit in IISMOD register) */
+#define CLK_I2S_RCLK_SRC 1
+
+/* the RCLK prescaler divider clock (corresponding to the IISPSR register) */
+#define CLK_I2S_RCLK_PSR 2
#endif /* _DT_BINDINGS_SAMSUNG_I2S_H */
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [alsa-devel] [PATCH] ASoC: samsung: i2s: Add clocks' macros descriptions
2019-09-24 11:48 ` Marek Szyprowski
@ 2019-09-24 11:53 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2019-09-24 11:53 UTC (permalink / raw)
To: Marek Szyprowski
Cc: Mark Rutland, devicetree, alsa-devel, linux-samsung-soc,
Maciej Falkowski, Mark Brown, linux-kernel, Liam Girdwood,
Rob Herring, Sylwester Nawrocki
On Tue, Sep 24, 2019 at 01:48:38PM +0200, Marek Szyprowski wrote:
> From: Maciej Falkowski <m.falkowski@samsung.com>
>
> To increase macro readability added descriptions
> to clocks macros.
>
> Signed-off-by: Maciej Falkowski <m.falkowski@samsung.com>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> include/dt-bindings/sound/samsung-i2s.h | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/include/dt-bindings/sound/samsung-i2s.h b/include/dt-bindings/sound/samsung-i2s.h
> index 77545f14c379..fd752475c762 100644
> --- a/include/dt-bindings/sound/samsung-i2s.h
> +++ b/include/dt-bindings/sound/samsung-i2s.h
> @@ -2,8 +2,13 @@
> #ifndef _DT_BINDINGS_SAMSUNG_I2S_H
> #define _DT_BINDINGS_SAMSUNG_I2S_H
>
> -#define CLK_I2S_CDCLK 0
> -#define CLK_I2S_RCLK_SRC 1
> -#define CLK_I2S_RCLK_PSR 2
> +/* the CDCLK (CODECLKO) gate clock */
> +#define CLK_I2S_CDCLK 0
I do not find it more readable because of removal of indent after define name. Also the description is not accurate - you documented, not increased readability.
Best regards,
Krzysztof
> +
> +/* the RCLKSRC mux clock (corresponding to RCLKSRC bit in IISMOD register) */
> +#define CLK_I2S_RCLK_SRC 1
> +
> +/* the RCLK prescaler divider clock (corresponding to the IISPSR register) */
> +#define CLK_I2S_RCLK_PSR 2
>
> #endif /* _DT_BINDINGS_SAMSUNG_I2S_H */
> --
> 2.17.1
>
>
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: samsung: i2s: Add clocks' macros descriptions
@ 2019-09-24 11:53 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2019-09-24 11:53 UTC (permalink / raw)
To: Marek Szyprowski
Cc: devicetree, alsa-devel, linux-kernel, linux-samsung-soc,
Rob Herring, Mark Rutland, Mark Brown, Sylwester Nawrocki,
Liam Girdwood, Maciej Falkowski
On Tue, Sep 24, 2019 at 01:48:38PM +0200, Marek Szyprowski wrote:
> From: Maciej Falkowski <m.falkowski@samsung.com>
>
> To increase macro readability added descriptions
> to clocks macros.
>
> Signed-off-by: Maciej Falkowski <m.falkowski@samsung.com>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> include/dt-bindings/sound/samsung-i2s.h | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/include/dt-bindings/sound/samsung-i2s.h b/include/dt-bindings/sound/samsung-i2s.h
> index 77545f14c379..fd752475c762 100644
> --- a/include/dt-bindings/sound/samsung-i2s.h
> +++ b/include/dt-bindings/sound/samsung-i2s.h
> @@ -2,8 +2,13 @@
> #ifndef _DT_BINDINGS_SAMSUNG_I2S_H
> #define _DT_BINDINGS_SAMSUNG_I2S_H
>
> -#define CLK_I2S_CDCLK 0
> -#define CLK_I2S_RCLK_SRC 1
> -#define CLK_I2S_RCLK_PSR 2
> +/* the CDCLK (CODECLKO) gate clock */
> +#define CLK_I2S_CDCLK 0
I do not find it more readable because of removal of indent after define name. Also the description is not accurate - you documented, not increased readability.
Best regards,
Krzysztof
> +
> +/* the RCLKSRC mux clock (corresponding to RCLKSRC bit in IISMOD register) */
> +#define CLK_I2S_RCLK_SRC 1
> +
> +/* the RCLK prescaler divider clock (corresponding to the IISPSR register) */
> +#define CLK_I2S_RCLK_PSR 2
>
> #endif /* _DT_BINDINGS_SAMSUNG_I2S_H */
> --
> 2.17.1
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [alsa-devel] [PATCH] ASoC: samsung: i2s: Add clocks' macros descriptions
2019-09-24 11:53 ` Krzysztof Kozlowski
@ 2019-09-24 17:53 ` Mark Brown
-1 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2019-09-24 17:53 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Mark Rutland, devicetree, alsa-devel, linux-samsung-soc,
Maciej Falkowski, linux-kernel, Liam Girdwood, Rob Herring,
Sylwester Nawrocki, Marek Szyprowski
[-- Attachment #1.1: Type: text/plain, Size: 713 bytes --]
On Tue, Sep 24, 2019 at 01:53:07PM +0200, Krzysztof Kozlowski wrote:
> On Tue, Sep 24, 2019 at 01:48:38PM +0200, Marek Szyprowski wrote:
> > +/* the CDCLK (CODECLKO) gate clock */
> > +#define CLK_I2S_CDCLK 0
> I do not find it more readable because of removal of indent
> after define name. Also the description is not accurate - you
> documented, not increased readability.
Yeah, I agree on both points. How about putting everything on
one line more like:
#define CLK_I2S_CDCLK 0 /* the CDCLK (CODECLKO) gate clock */
instead?
Please fix your mail client to word wrap within paragraphs at something
substantially less than 80 columns. Doing this makes your messages much
easier to read and reply to.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ASoC: samsung: i2s: Add clocks' macros descriptions
@ 2019-09-24 17:53 ` Mark Brown
0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2019-09-24 17:53 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Marek Szyprowski, devicetree, alsa-devel, linux-kernel,
linux-samsung-soc, Rob Herring, Mark Rutland, Sylwester Nawrocki,
Liam Girdwood, Maciej Falkowski
[-- Attachment #1: Type: text/plain, Size: 713 bytes --]
On Tue, Sep 24, 2019 at 01:53:07PM +0200, Krzysztof Kozlowski wrote:
> On Tue, Sep 24, 2019 at 01:48:38PM +0200, Marek Szyprowski wrote:
> > +/* the CDCLK (CODECLKO) gate clock */
> > +#define CLK_I2S_CDCLK 0
> I do not find it more readable because of removal of indent
> after define name. Also the description is not accurate - you
> documented, not increased readability.
Yeah, I agree on both points. How about putting everything on
one line more like:
#define CLK_I2S_CDCLK 0 /* the CDCLK (CODECLKO) gate clock */
instead?
Please fix your mail client to word wrap within paragraphs at something
substantially less than 80 columns. Doing this makes your messages much
easier to read and reply to.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-09-24 17:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20190924114843eucas1p2ea9c36289d3912e022ad7c9070fc00ee@eucas1p2.samsung.com>
2019-09-24 11:48 ` [alsa-devel] [PATCH] ASoC: samsung: i2s: Add clocks' macros descriptions Marek Szyprowski
2019-09-24 11:48 ` Marek Szyprowski
2019-09-24 11:53 ` [alsa-devel] " Krzysztof Kozlowski
2019-09-24 11:53 ` Krzysztof Kozlowski
2019-09-24 17:53 ` [alsa-devel] " Mark Brown
2019-09-24 17:53 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.