From: Jonah =?unknown-8bit?q?Br=C3=BCchert?= <jbb.prv@gmx.de>
To: ofono@ofono.org
Subject: [PATCH phonesim 1/7] Port to qt5
Date: Sun, 27 Oct 2019 02:04:19 +0200 [thread overview]
Message-ID: <20191027000425.14022-2-jbb.prv@gmx.de> (raw)
In-Reply-To: <20191027000425.14022-1-jbb.prv@gmx.de>
[-- Attachment #1: Type: text/plain, Size: 3065 bytes --]
From: Simon Busch <morphis@gravedo.de>
Signed-off-by: Simon Busch <morphis@gravedo.de>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
Makefile.am | 2 +-
configure.ac | 6 +++---
src/control.cpp | 4 ++--
src/qsimcommand.cpp | 2 +-
src/qsmsmessage.cpp | 2 +-
5 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index 2a6fccf..8c99b04 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -46,7 +46,7 @@ nodist_src_phonesim_SOURCES = src/ui_controlbase.h \
src_phonesim_LDADD = $(QT_LIBS)
-AM_CXXFLAGS = -Wall $(QT_CFLAGS)
+AM_CXXFLAGS = -Wall $(QT_CFLAGS) -fPIC -fPIE
AM_CPPFLAGS = -I$(top_srcdir)/src -I$(top_builddir)/src
diff --git a/configure.ac b/configure.ac
index e0152f0..253aa27 100644
--- a/configure.ac
+++ b/configure.ac
@@ -22,18 +22,18 @@ AC_ARG_ENABLE(optimization, AC_HELP_STRING([--disable-optimization],
fi
])
-PKG_CHECK_MODULES(QT, QtCore QtGui QtXml QtNetwork QtScript QtDBus, dummy=yes,
+PKG_CHECK_MODULES(QT, Qt5Core Qt5Gui Qt5Xml Qt5Network Qt5Script Qt5DBus Qt5Widgets, dummy=yes,
AC_MSG_ERROR(Qt is required))
AC_SUBST(QT_CFLAGS)
AC_SUBST(QT_LIBS)
AC_MSG_CHECKING(for moc)
-MOC="`$PKG_CONFIG --variable=moc_location QtCore`"
+MOC="`$PKG_CONFIG --variable=host_bins Qt5Core`/moc"
AC_SUBST(MOC)
AC_MSG_RESULT($MOC)
AC_MSG_CHECKING(for uic)
-UIC="`$PKG_CONFIG --variable=uic_location QtCore`"
+UIC="`$PKG_CONFIG --variable=host_bins Qt5Core`/uic"
AC_SUBST(UIC)
AC_MSG_RESULT($UIC)
diff --git a/src/control.cpp b/src/control.cpp
index e1838a6..5eb82f1 100644
--- a/src/control.cpp
+++ b/src/control.cpp
@@ -22,7 +22,7 @@
#include <qslider.h>
#include <qcheckbox.h>
#include <qcombobox.h>
-#include <QtGui/qmessagebox.h>
+#include <qmessagebox.h>
#include <qfiledialog.h>
#include <Qt>
#include <qbuffer.h>
@@ -31,7 +31,7 @@
#include <QFileInfo>
#include <QFile>
#include <QDir>
-#include <QtGui/QHeaderView>
+#include <QHeaderView>
#define TWO_BYTE_MAX 65535
#define FOUR_CHAR 4
diff --git a/src/qsimcommand.cpp b/src/qsimcommand.cpp
index 97e0b28..672ffb9 100644
--- a/src/qsimcommand.cpp
+++ b/src/qsimcommand.cpp
@@ -3764,7 +3764,7 @@ void QSimCommand::addExtensionField( int tag, const QByteArray& value )
QSimCommandPrivate *QSimCommand::dwrite()
{
// If we are the only user of the private object, return it as-is.
- if ( d->ref == 1 )
+ if ( d->ref.load() == 1 )
return d;
// Create a new private object and copy the current contents into it.
diff --git a/src/qsmsmessage.cpp b/src/qsmsmessage.cpp
index c2eeb29..54885bd 100644
--- a/src/qsmsmessage.cpp
+++ b/src/qsmsmessage.cpp
@@ -365,7 +365,7 @@ QSMSMessage::~QSMSMessage()
QSMSMessagePrivate *QSMSMessage::dwrite()
{
// If we are the only user of the private object, return it as-is.
- if ( d->ref == 1 )
+ if ( d->ref.load() == 1 )
return d;
// Create a new private object and copy the current contents into it.
--
2.23.0
next prev parent reply other threads:[~2019-10-27 0:04 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-27 0:04 Port ofono-phonesim to Qt5 Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 0:04 ` Jonah =?unknown-8bit?q?Br=C3=BCchert?= [this message]
2019-10-27 0:04 ` [PATCH phonesim 2/7] Fix random build failure Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 0:04 ` [PATCH phonesim 3/7] configure.ac: use gnu++11 to fix build with Qt 5.7 Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 0:04 ` [PATCH phonesim 4/7] Fix build with Qt 5.8 Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 0:04 ` [PATCH phonesim 5/7] configure.ac: fix checking for host_bins variable Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 0:04 ` [PATCH phonesim 6/7] Make Qt detect fPIC flag correctly Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 0:04 ` [PATCH phonesim 7/7] Fix handling of incoming connections Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 0:11 ` Port ofono-phonesim to Qt5 Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 11:42 ` Alexander Akulich
2019-10-27 16:05 ` Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 16:30 ` Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 16:30 ` [PATCH phonesim v2 1/8] Port to qt5 Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-29 16:06 ` Denis Kenzior
2019-10-29 16:58 ` Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-30 15:44 ` Denis Kenzior
2019-10-30 20:37 ` [PATCH phonesim v3 1/2] " Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-30 20:37 ` [PATCH phonesim v3 2/2] Use override at least in server header Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-11-07 0:10 ` [PATCH phonesim v3 1/2] Port to qt5 Denis Kenzior
2019-11-07 10:26 ` Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-11-12 2:28 ` Denis Kenzior
2019-10-27 16:30 ` [PATCH phonesim v2 2/8] Fix random build failure Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 16:30 ` [PATCH phonesim v2 3/8] configure.ac: use gnu++11 to fix build with Qt 5.7 Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 16:30 ` [PATCH phonesim v2 4/8] Fix build with Qt 5.8 Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 16:30 ` [PATCH phonesim v2 5/8] configure.ac: fix checking for host_bins variable Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 16:30 ` [PATCH phonesim v2 6/8] Make Qt detect fPIC flag correctly Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 16:30 ` [PATCH phonesim v2 7/8] Fix Qt5 port on 64-bit platforms Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 16:30 ` [PATCH phonesim v2 8/8] Use override at least in server header Jonah =?unknown-8bit?q?Br=C3=BCchert?=
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191027000425.14022-2-jbb.prv@gmx.de \
--to=jbb.prv@gmx.de \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.