From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH phonesim v3 1/2] Port to qt5
Date: Wed, 06 Nov 2019 18:10:50 -0600 [thread overview]
Message-ID: <2f8a4999-021a-1f80-0023-0994f24ff73e@gmail.com> (raw)
In-Reply-To: <20191030203720.10302-1-jbb.prv@gmx.de>
[-- Attachment #1: Type: text/plain, Size: 876 bytes --]
Hi Jonah,
On 10/30/19 3:37 PM, Jonah Brüchert wrote:
> From: Simon Busch <morphis@gravedo.de>
>
> Co-authored-by: Martin Jansa <Martin.Jansa@gmail.com>
> Co-authored-by: Jonah Brüchert <jbb.prv@gmx.de>
> Co-authored-by: Alexander Akulich <akulichalexander@gmail.com>
> ---
> Makefile.am | 4 +++-
> configure.ac | 15 ++++++++++++---
> src/control.cpp | 4 ++--
> src/phonesim.cpp | 2 +-
> src/phonesim.h | 2 +-
> src/qsimcommand.cpp | 2 +-
> src/qsmsmessage.cpp | 6 +++---
> src/server.cpp | 2 +-
> src/server.h | 2 +-
> 9 files changed, 25 insertions(+), 14 deletions(-)
>
Sorry for the delay. Took me a bit to sort out Qt5 on my VM. Anyway,
the changes look fine to me and things still appear to work. So I went
ahead and pushed both of these patches out.
Regards,
-Denis
next prev parent reply other threads:[~2019-11-07 0:10 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-27 0:04 Port ofono-phonesim to Qt5 Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 0:04 ` [PATCH phonesim 1/7] Port to qt5 Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 0:04 ` [PATCH phonesim 2/7] Fix random build failure Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 0:04 ` [PATCH phonesim 3/7] configure.ac: use gnu++11 to fix build with Qt 5.7 Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 0:04 ` [PATCH phonesim 4/7] Fix build with Qt 5.8 Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 0:04 ` [PATCH phonesim 5/7] configure.ac: fix checking for host_bins variable Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 0:04 ` [PATCH phonesim 6/7] Make Qt detect fPIC flag correctly Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 0:04 ` [PATCH phonesim 7/7] Fix handling of incoming connections Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 0:11 ` Port ofono-phonesim to Qt5 Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 11:42 ` Alexander Akulich
2019-10-27 16:05 ` Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 16:30 ` Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 16:30 ` [PATCH phonesim v2 1/8] Port to qt5 Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-29 16:06 ` Denis Kenzior
2019-10-29 16:58 ` Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-30 15:44 ` Denis Kenzior
2019-10-30 20:37 ` [PATCH phonesim v3 1/2] " Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-30 20:37 ` [PATCH phonesim v3 2/2] Use override at least in server header Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-11-07 0:10 ` Denis Kenzior [this message]
2019-11-07 10:26 ` [PATCH phonesim v3 1/2] Port to qt5 Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-11-12 2:28 ` Denis Kenzior
2019-10-27 16:30 ` [PATCH phonesim v2 2/8] Fix random build failure Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 16:30 ` [PATCH phonesim v2 3/8] configure.ac: use gnu++11 to fix build with Qt 5.7 Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 16:30 ` [PATCH phonesim v2 4/8] Fix build with Qt 5.8 Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 16:30 ` [PATCH phonesim v2 5/8] configure.ac: fix checking for host_bins variable Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 16:30 ` [PATCH phonesim v2 6/8] Make Qt detect fPIC flag correctly Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 16:30 ` [PATCH phonesim v2 7/8] Fix Qt5 port on 64-bit platforms Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 16:30 ` [PATCH phonesim v2 8/8] Use override at least in server header Jonah =?unknown-8bit?q?Br=C3=BCchert?=
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f8a4999-021a-1f80-0023-0994f24ff73e@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.