All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonah =?unknown-8bit?q?Br=C3=BCchert?= <jbb.prv@gmx.de>
To: ofono@ofono.org
Subject: [PATCH phonesim 4/7] Fix build with Qt 5.8
Date: Sun, 27 Oct 2019 02:04:22 +0200	[thread overview]
Message-ID: <20191027000425.14022-5-jbb.prv@gmx.de> (raw)
In-Reply-To: <20191027000425.14022-1-jbb.prv@gmx.de>

[-- Attachment #1: Type: text/plain, Size: 2631 bytes --]

From: Martin Jansa <Martin.Jansa@gmail.com>

../phonesim-1.20/src/qsmsmessage.cpp: In member function 'QCBSMessage QCBSDeliverMessage::unpack(QTextCodec*)':
../phonesim-1.20/src/qsmsmessage.cpp:2598:40: error: ambiguous overload for 'operator==' (operand types are 'QCharRef' and 'char')
                          text[len - 1] == '\0' ) ) {
                          ~~~~~~~~~~~~~~^~~~~~~
In file included from ../phonesim-1.20/src/qsmsmessage.h:23:0,
                 from ../phonesim-1.20/src/qsmsmessage.cpp:22:
/OE/build/owpb/webos-ports/tmp-glibc/work/i586-webos-linux/phonesim/1.20-r0/recipe-sysroot/usr/include/qt5/QtCore/qstring.h:1632:13: note: candidate: bool operator==(QChar, const QStringRef&)
 inline bool operator==(QChar lhs, const QStringRef &rhs) Q_DECL_NOTHROW
             ^~~~~~~~
/OE/build/owpb/webos-ports/tmp-glibc/work/i586-webos-linux/phonesim/1.20-r0/recipe-sysroot/usr/include/qt5/QtCore/qstring.h:1613:13: note: candidate: bool operator==(QChar, const QString&)
 inline bool operator==(QChar lhs, const QString &rhs) Q_DECL_NOTHROW
             ^~~~~~~~
In file included from /OE/build/owpb/webos-ports/tmp-glibc/work/i586-webos-linux/phonesim/1.20-r0/recipe-sysroot/usr/include/qt5/QtCore/qstring.h:48:0,
                 from ../phonesim-1.20/src/qsmsmessage.h:23,
                 from ../phonesim-1.20/src/qsmsmessage.cpp:22:
/OE/build/owpb/webos-ports/tmp-glibc/work/i586-webos-linux/phonesim/1.20-r0/recipe-sysroot/usr/include/qt5/QtCore/qchar.h:573:30: note: candidate: constexpr bool operator==(QChar, QChar)
 Q_DECL_CONSTEXPR inline bool operator==(QChar c1, QChar c2) Q_DECL_NOTHROW { return c1.ucs == c2.ucs; }
                              ^~~~~~~~
make: *** [Makefile:583: src/qsmsmessage.o] Error 1

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 src/qsmsmessage.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/qsmsmessage.cpp b/src/qsmsmessage.cpp
index 54885bd..63d6952 100644
--- a/src/qsmsmessage.cpp
+++ b/src/qsmsmessage.cpp
@@ -2594,8 +2594,8 @@ QCBSMessage QCBSDeliverMessage::unpack(QTextCodec *codec)
     QString text = userData
         ( (QSMSDataCodingScheme)scheme, codec, headers, false, true );
     len = text.length();
-    while ( len > 0 && ( text[len - 1] == '\r' || text[len - 1] == '\n' ||
-                         text[len - 1] == '\0' ) ) {
+    while ( len > 0 && ( text.at(len - 1) == QChar ('\r') || text.at(len - 1) == QChar ('\n') ||
+                         text.at(len - 1) == QChar ('\0') ) ) {
         --len;
     }
     m.setText( text.left( len ) );
--
2.23.0

  parent reply	other threads:[~2019-10-27  0:04 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-27  0:04 Port ofono-phonesim to Qt5 Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27  0:04 ` [PATCH phonesim 1/7] Port to qt5 Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27  0:04 ` [PATCH phonesim 2/7] Fix random build failure Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27  0:04 ` [PATCH phonesim 3/7] configure.ac: use gnu++11 to fix build with Qt 5.7 Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27  0:04 ` Jonah =?unknown-8bit?q?Br=C3=BCchert?= [this message]
2019-10-27  0:04 ` [PATCH phonesim 5/7] configure.ac: fix checking for host_bins variable Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27  0:04 ` [PATCH phonesim 6/7] Make Qt detect fPIC flag correctly Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27  0:04 ` [PATCH phonesim 7/7] Fix handling of incoming connections Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27  0:11 ` Port ofono-phonesim to Qt5 Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 11:42   ` Alexander Akulich
2019-10-27 16:05     ` Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 16:30       ` Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 16:30         ` [PATCH phonesim v2 1/8] Port to qt5 Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-29 16:06           ` Denis Kenzior
2019-10-29 16:58             ` Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-30 15:44               ` Denis Kenzior
2019-10-30 20:37                 ` [PATCH phonesim v3 1/2] " Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-30 20:37                   ` [PATCH phonesim v3 2/2] Use override at least in server header Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-11-07  0:10                   ` [PATCH phonesim v3 1/2] Port to qt5 Denis Kenzior
2019-11-07 10:26                     ` Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-11-12  2:28                       ` Denis Kenzior
2019-10-27 16:30         ` [PATCH phonesim v2 2/8] Fix random build failure Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 16:30         ` [PATCH phonesim v2 3/8] configure.ac: use gnu++11 to fix build with Qt 5.7 Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 16:30         ` [PATCH phonesim v2 4/8] Fix build with Qt 5.8 Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 16:30         ` [PATCH phonesim v2 5/8] configure.ac: fix checking for host_bins variable Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 16:30         ` [PATCH phonesim v2 6/8] Make Qt detect fPIC flag correctly Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 16:30         ` [PATCH phonesim v2 7/8] Fix Qt5 port on 64-bit platforms Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 16:30         ` [PATCH phonesim v2 8/8] Use override at least in server header Jonah =?unknown-8bit?q?Br=C3=BCchert?=

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191027000425.14022-5-jbb.prv@gmx.de \
    --to=jbb.prv@gmx.de \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.