All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonah =?unknown-8bit?q?Br=C3=BCchert?= <jbb.prv@gmx.de>
To: ofono@ofono.org
Subject: [PATCH phonesim 5/7] configure.ac: fix checking for host_bins variable
Date: Sun, 27 Oct 2019 02:04:23 +0200	[thread overview]
Message-ID: <20191027000425.14022-6-jbb.prv@gmx.de> (raw)
In-Reply-To: <20191027000425.14022-1-jbb.prv@gmx.de>

[-- Attachment #1: Type: text/plain, Size: 1814 bytes --]

From: Martin Jansa <Martin.Jansa@gmail.com>

$PKG_CONFIG --variable=host_bins Qt5Core
returns absolute path without the prefix to sysroot when cross compiling

Before https://github.com/meta-qt5/meta-qt5/commit/b716195f609de6547cfdfadfd4fd25292a6bbf09
this will return:

pkg-config --variable=host_bins Qt5Core
/usr/bin/qt5

which is bad, but is replaced with ${OE_QMAKE_PATH_EXTERNAL_HOST_BINS}
in the generated Makefile after configure as in:
https://github.com/webOS-ports/meta-webos-ports/blob/e4283e7906e3fbd2e0bcffcd317d2d1a9e2ebcd5/meta-luneos/recipes-connectivity/ofono/phonesim_1.20.bb#L22

but with empty QT_DIR_NAME the returned value is:
pkg-config --variable=host_bins Qt5Core
/usr/bin

and these 2 replaces fail, causing
make: /usr/bin/uic: Command not found

Use PKG_CHECK_VAR for host_bins which we can override with
OE_QMAKE_PATH_EXTERNAL_HOST_BINS from the environment and
the generated Mafile will be correct right away.

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 configure.ac | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/configure.ac b/configure.ac
index 4eb969a..e339691 100644
--- a/configure.ac
+++ b/configure.ac
@@ -31,13 +31,18 @@ CXXFLAGS="$CXXFLAGS --std=gnu++11"
 AC_SUBST(QT_CFLAGS)
 AC_SUBST(QT_LIBS)

+AC_MSG_CHECKING(for Qt5 host_bins)
+PKG_CHECK_VAR(QMAKE_PATH_HOST_BINS, Qt5Core, host_bins)
+AC_SUBST(QMAKE_PATH_HOST_BINS)
+AC_MSG_RESULT($QMAKE_PATH_HOST_BINS)
+
 AC_MSG_CHECKING(for moc)
-MOC="`$PKG_CONFIG --variable=host_bins Qt5Core`/moc"
+MOC="$QMAKE_PATH_HOST_BINS/moc"
 AC_SUBST(MOC)
 AC_MSG_RESULT($MOC)

 AC_MSG_CHECKING(for uic)
-UIC="`$PKG_CONFIG --variable=host_bins Qt5Core`/uic"
+UIC="$QMAKE_PATH_HOST_BINS/uic"
 AC_SUBST(UIC)
 AC_MSG_RESULT($UIC)

--
2.23.0

  parent reply	other threads:[~2019-10-27  0:04 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-27  0:04 Port ofono-phonesim to Qt5 Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27  0:04 ` [PATCH phonesim 1/7] Port to qt5 Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27  0:04 ` [PATCH phonesim 2/7] Fix random build failure Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27  0:04 ` [PATCH phonesim 3/7] configure.ac: use gnu++11 to fix build with Qt 5.7 Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27  0:04 ` [PATCH phonesim 4/7] Fix build with Qt 5.8 Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27  0:04 ` Jonah =?unknown-8bit?q?Br=C3=BCchert?= [this message]
2019-10-27  0:04 ` [PATCH phonesim 6/7] Make Qt detect fPIC flag correctly Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27  0:04 ` [PATCH phonesim 7/7] Fix handling of incoming connections Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27  0:11 ` Port ofono-phonesim to Qt5 Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 11:42   ` Alexander Akulich
2019-10-27 16:05     ` Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 16:30       ` Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 16:30         ` [PATCH phonesim v2 1/8] Port to qt5 Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-29 16:06           ` Denis Kenzior
2019-10-29 16:58             ` Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-30 15:44               ` Denis Kenzior
2019-10-30 20:37                 ` [PATCH phonesim v3 1/2] " Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-30 20:37                   ` [PATCH phonesim v3 2/2] Use override at least in server header Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-11-07  0:10                   ` [PATCH phonesim v3 1/2] Port to qt5 Denis Kenzior
2019-11-07 10:26                     ` Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-11-12  2:28                       ` Denis Kenzior
2019-10-27 16:30         ` [PATCH phonesim v2 2/8] Fix random build failure Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 16:30         ` [PATCH phonesim v2 3/8] configure.ac: use gnu++11 to fix build with Qt 5.7 Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 16:30         ` [PATCH phonesim v2 4/8] Fix build with Qt 5.8 Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 16:30         ` [PATCH phonesim v2 5/8] configure.ac: fix checking for host_bins variable Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 16:30         ` [PATCH phonesim v2 6/8] Make Qt detect fPIC flag correctly Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 16:30         ` [PATCH phonesim v2 7/8] Fix Qt5 port on 64-bit platforms Jonah =?unknown-8bit?q?Br=C3=BCchert?=
2019-10-27 16:30         ` [PATCH phonesim v2 8/8] Use override at least in server header Jonah =?unknown-8bit?q?Br=C3=BCchert?=

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191027000425.14022-6-jbb.prv@gmx.de \
    --to=jbb.prv@gmx.de \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.