From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/9] boot/arm-trusted-firmware: Add u-boot-dtb.bin support
Date: Wed, 20 Nov 2019 10:07:56 +0100 [thread overview]
Message-ID: <20191120100756.0e269e98@windsurf.home> (raw)
In-Reply-To: <20191120073754.ror57blke4sx2gup@bars>
Hello Sergey, Hello Jerry,
On Wed, 20 Nov 2019 10:37:54 +0300
Sergey Matyukevich <geomatsi@gmail.com> wrote:
> > ifeq ($(BR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_AS_BL33),y)
> > +ifeq ($(BR2_TARGET_UBOOT_FORMAT_DTB_BIN),y)
> > +ARM_TRUSTED_FIRMWARE_MAKE_OPTS += BL33=$(BINARIES_DIR)/u-boot-dtb.bin
> > +else
> > ARM_TRUSTED_FIRMWARE_MAKE_OPTS += BL33=$(BINARIES_DIR)/u-boot.bin
> > +endif
> > ARM_TRUSTED_FIRMWARE_DEPENDENCIES += uboot
> > endif
>
> Hi Jerry, Thomas, and all
>
> Looks good, but probably we could make it a little bit more future-proof.
> What do you think about using the same pattern-based approach here as
> implemented in commit e4d276c357fdf9f19f99f8 (buildroot next branch)
> for ATF firmware images.
>
> In brief, to add option BR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_BL33_IMAGE
> in arm-trusted-firmware Config.in and set its default value to u-boot.bin.
> Then u-boot-dtb.bin value could be specified in the board defconfig.
I was going to say that Jerry's solution looks better, as it's more
automatic for the user.
However, the selection of the U-Boot image format is not a Kconfig
"choice" in boot/uboot/Config.in: one can select multiple images. In
this case, how can ATF know which one to use ? Jerry's proposal is to
assume that if BR2_TARGET_UBOOT_FORMAT_DTB_BIN=y, then you want to use
u-boot-dtb.bin, but if there are multiple U-Boot images enabled, it's
indeed difficult to know which one to chose for ATF.
So, I agree with Sergey: probably the easiest is simply some free-form
string option, with a default to u-boot.bin to preserve backward
compatibility.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-11-20 9:07 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 4:07 [Buildroot] [PATCH 0/9] new board ls1028ardb introduced Changming Huang
2019-11-20 4:07 ` [Buildroot] [PATCH 1/9] package/rcw: upgrade the rcw version to LSDK-19.09 Changming Huang
2019-11-20 7:59 ` Thomas Petazzoni
2019-11-20 8:04 ` [Buildroot] [EXT] " Jerry Huang
2019-11-20 9:21 ` [Buildroot] " Michael Walle
2019-11-20 9:32 ` Thomas Petazzoni
2019-11-20 9:38 ` Matthew Weber
2019-11-20 9:45 ` Thomas Petazzoni
2019-11-20 9:51 ` [Buildroot] [External] " Matthew Weber
2019-11-20 9:57 ` [Buildroot] [EXT] " Jerry Huang
2019-11-20 10:00 ` [Buildroot] " Michael Walle
2019-11-20 10:23 ` Matthew Weber
2019-11-20 9:54 ` [Buildroot] [EXT] " Jerry Huang
2019-11-20 4:07 ` [Buildroot] [PATCH 2/9] package/rcw: add target rcw binary support Changming Huang
2019-11-20 9:30 ` Matthew Weber
2019-11-20 4:07 ` [Buildroot] [PATCH 3/9] boot/arm-trusted-firmware: Add u-boot-dtb.bin support Changming Huang
2019-11-20 7:37 ` Sergey Matyukevich
2019-11-20 8:13 ` [Buildroot] [EXT] " Jerry Huang
2019-11-20 9:07 ` Thomas Petazzoni [this message]
2019-11-20 4:07 ` [Buildroot] [PATCH 4/9] boot/arm-trusted-firmware: Add RCW support Changming Huang
2019-11-20 7:50 ` Sergey Matyukevich
2019-11-20 8:45 ` [Buildroot] [EXT] " Jerry Huang
2019-11-21 8:02 ` Sergey Matyukevich
2019-11-21 8:37 ` Jerry Huang
2019-11-21 8:39 ` Jerry Huang
2019-11-20 4:07 ` [Buildroot] [PATCH 5/9] package/freescale-qoriq: new package directory Changming Huang
2019-11-20 8:57 ` Thomas Petazzoni
2019-11-20 4:07 ` [Buildroot] [PATCH 6/9] package/freescale-qoriq/cadence: new package Changming Huang
2019-11-20 9:13 ` Thomas Petazzoni
2019-11-20 9:30 ` [Buildroot] [EXT] " Jerry Huang
2019-11-20 9:36 ` Thomas Petazzoni
2019-11-20 9:47 ` Jerry Huang
2019-11-20 4:07 ` [Buildroot] [PATCH 7/9] package/rcw: Enable IIC5_PMUX and CLK_OUT_PMUX for GPIO Changming Huang
2019-11-20 9:14 ` Thomas Petazzoni
2019-11-20 9:34 ` [Buildroot] [EXT] " Jerry Huang
2019-11-20 9:38 ` Thomas Petazzoni
2019-11-20 10:22 ` Jerry Huang
2019-11-20 4:07 ` [Buildroot] [PATCH 8/9] board/freescale/common/ls: Add standard post image script for Layerscape processors Changming Huang
2019-11-20 4:07 ` [Buildroot] [PATCH 9/9] configs/freescale_ls1028ardb*: new board Changming Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191120100756.0e269e98@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.