All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] drm: Handle connector tile support only for modes that match tile size
@ 2019-12-11 21:24 ` Manasi Navare
  0 siblings, 0 replies; 13+ messages in thread
From: Manasi Navare @ 2019-12-11 21:24 UTC (permalink / raw)
  To: intel-gfx, dri-devel; +Cc: Manasi Navare, Jani Nikula, Dave Airlie

DRM Fb driver expects multiple CRTCs if it sees connector->has_tile
is set, but we need to handle tile support and look for multiple CRTCs
only for the modes that match the tile size. The other modes should
be able to be displayed without tile support or uisng single CRTC.

This patch adds the check to match the tile size with requested mode
to handle the tile support.

Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Dave Airlie <airlied@redhat.com>
Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
---
 drivers/gpu/drm/drm_fb_helper.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index fb9bff0f4581..4978363714a9 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm/drm_fb_helper.c
@@ -1558,7 +1558,9 @@ static int drm_fb_helper_single_fb_probe(struct drm_fb_helper *fb_helper,
 		for (j = 0; j < mode_set->num_connectors; j++) {
 			struct drm_connector *connector = mode_set->connectors[j];
 
-			if (connector->has_tile) {
+			if (connector->has_tile &&
+			    desired_mode->hdisplay == connector->tile_h_size &&
+			    desired_mode->vdisplay == connector->tile_v_size) {
 				lasth = (connector->tile_h_loc == (connector->num_h_tile - 1));
 				lastv = (connector->tile_v_loc == (connector->num_v_tile - 1));
 				/* cloning to multiple tiles is just crazy-talk, so: */
-- 
2.19.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2019-12-17 20:57 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-11 21:24 [PATCH 1/2] drm: Handle connector tile support only for modes that match tile size Manasi Navare
2019-12-11 21:24 ` [Intel-gfx] " Manasi Navare
2019-12-11 21:24 ` [PATCH 2/2] drm/fbdev: Fallback to non tiled mode if all tiles not present Manasi Navare
2019-12-11 21:24   ` [Intel-gfx] " Manasi Navare
2019-12-12  2:46 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm: Handle connector tile support only for modes that match tile size Patchwork
2019-12-12 21:28   ` Manasi Navare
2019-12-13  8:54     ` Tomi Sarvela
2019-12-16 23:59       ` Manasi Navare
2019-12-17  7:56         ` Tomi Sarvela
2019-12-17 20:57           ` Manasi Navare
2019-12-13 20:40 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork
2019-12-17 20:58 ` [PATCH 1/2] " Manasi Navare
2019-12-17 20:58   ` [Intel-gfx] " Manasi Navare

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.