From: "Michael S. Tsirkin" <mst@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: "virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
Tyler Sanderson <tysand@google.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Nadav Amit <namit@vmware.com>,
David Rientjes <rientjes@google.com>,
Alexander Duyck <alexander.h.duyck@linux.intel.com>,
Michal Hocko <mhocko@kernel.org>
Subject: Re: Balloon pressuring page cache
Date: Tue, 4 Feb 2020 03:40:40 -0500 [thread overview]
Message-ID: <20200204033657-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <d69eafb4-ad0d-1617-9248-ea4fc776da58@redhat.com>
On Tue, Feb 04, 2020 at 09:35:21AM +0100, David Hildenbrand wrote:
> >>> I would say reverting probably makes sense. I'm not sure there is much
> >>> value to having a shrinker running deflation when you are actively trying
> >>> to increase the balloon. It would make more sense to wait until you are
> >>> actually about to start hitting oom.
> >>
> >> I think the shrinker makes sense for free page hinting feature
> >> (everything on free_page_list).
> >>
> >> So instead of only reverting, I think we should split it up and always
> >> register the shrinker for VIRTIO_BALLOON_F_FREE_PAGE_HINT and the OOM
> >> notifier (as before) for VIRTIO_BALLOON_F_MUST_TELL_HOST.
>
> s/VIRTIO_BALLOON_F_MUST_TELL_HOST/VIRTIO_BALLOON_F_DEFLATE_ON_OOM/
>
> :)
Well VIRTIO_BALLOON_F_MUST_TELL_HOST is also broken by shrinker
with VIRTIO_BALLOON_F_FREE_PAGE_HINT as that code adds buffers
but does not wait for them to be used even with VIRTIO_BALLOON_F_MUST_TELL_HOST.
We never noticed because QEMU does not advertize
VIRTIO_BALLOON_F_MUST_TELL_HOST.
> >>
> >> (Of course, adapting what is being done in the shrinker and in the OOM
> >> notifier)
> >
> > David,
> >
> > Please keep me posted. I decided to adapt the same solution as the virtio
> > balloon for the VMware balloon. If the verdict is that this is damaging and
> > the OOM notifier should be used instead, I will submit patches to move to
> > OOM notifier as well.
>
> Will do. It all sounds sub-optimal to me at this point ... but I prefer
> the old variant where a simple "drop_slab()" won't deflate the balloon.
> That looks broken to me.
Okay. Could you post a patch?
> --
> Thanks,
>
> David / dhildenb
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: Nadav Amit <namit@vmware.com>,
Alexander Duyck <alexander.h.duyck@linux.intel.com>,
Tyler Sanderson <tysand@google.com>,
"Wang, Wei W" <wei.w.wang@intel.com>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
David Rientjes <rientjes@google.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Michal Hocko <mhocko@kernel.org>
Subject: Re: Balloon pressuring page cache
Date: Tue, 4 Feb 2020 03:40:40 -0500 [thread overview]
Message-ID: <20200204033657-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <d69eafb4-ad0d-1617-9248-ea4fc776da58@redhat.com>
On Tue, Feb 04, 2020 at 09:35:21AM +0100, David Hildenbrand wrote:
> >>> I would say reverting probably makes sense. I'm not sure there is much
> >>> value to having a shrinker running deflation when you are actively trying
> >>> to increase the balloon. It would make more sense to wait until you are
> >>> actually about to start hitting oom.
> >>
> >> I think the shrinker makes sense for free page hinting feature
> >> (everything on free_page_list).
> >>
> >> So instead of only reverting, I think we should split it up and always
> >> register the shrinker for VIRTIO_BALLOON_F_FREE_PAGE_HINT and the OOM
> >> notifier (as before) for VIRTIO_BALLOON_F_MUST_TELL_HOST.
>
> s/VIRTIO_BALLOON_F_MUST_TELL_HOST/VIRTIO_BALLOON_F_DEFLATE_ON_OOM/
>
> :)
Well VIRTIO_BALLOON_F_MUST_TELL_HOST is also broken by shrinker
with VIRTIO_BALLOON_F_FREE_PAGE_HINT as that code adds buffers
but does not wait for them to be used even with VIRTIO_BALLOON_F_MUST_TELL_HOST.
We never noticed because QEMU does not advertize
VIRTIO_BALLOON_F_MUST_TELL_HOST.
> >>
> >> (Of course, adapting what is being done in the shrinker and in the OOM
> >> notifier)
> >
> > David,
> >
> > Please keep me posted. I decided to adapt the same solution as the virtio
> > balloon for the VMware balloon. If the verdict is that this is damaging and
> > the OOM notifier should be used instead, I will submit patches to move to
> > OOM notifier as well.
>
> Will do. It all sounds sub-optimal to me at this point ... but I prefer
> the old variant where a simple "drop_slab()" won't deflate the balloon.
> That looks broken to me.
Okay. Could you post a patch?
> --
> Thanks,
>
> David / dhildenb
next prev parent reply other threads:[~2020-02-04 8:40 UTC|newest]
Thread overview: 119+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 0:22 Balloon pressuring page cache Tyler Sanderson via Virtualization
2020-01-29 10:31 ` David Hildenbrand
2020-01-29 19:11 ` Tyler Sanderson via Virtualization
2020-01-30 15:02 ` David Hildenbrand
2020-01-30 15:02 ` David Hildenbrand
2020-01-30 15:20 ` Michael S. Tsirkin
2020-01-30 15:20 ` Michael S. Tsirkin
2020-01-30 15:23 ` David Hildenbrand
2020-01-30 15:23 ` David Hildenbrand
2020-01-30 15:31 ` Wang, Wei W
2020-01-30 15:31 ` Wang, Wei W
2020-01-30 19:59 ` Tyler Sanderson via Virtualization
2020-01-30 19:59 ` Tyler Sanderson
2020-02-03 13:11 ` Michael S. Tsirkin
2020-02-03 13:11 ` Michael S. Tsirkin
2020-02-03 16:18 ` Alexander Duyck
2020-02-03 16:34 ` David Hildenbrand
2020-02-03 16:34 ` David Hildenbrand
2020-02-03 17:03 ` Michael S. Tsirkin
2020-02-03 17:03 ` Michael S. Tsirkin
2020-02-03 20:32 ` Tyler Sanderson via Virtualization
2020-02-03 20:32 ` Tyler Sanderson
2020-02-03 21:22 ` Alexander Duyck
2020-02-03 23:16 ` Tyler Sanderson via Virtualization
2020-02-03 23:16 ` Tyler Sanderson
2020-02-04 0:10 ` Alexander Duyck
2020-02-04 5:45 ` Michael S. Tsirkin
2020-02-04 5:45 ` Michael S. Tsirkin
2020-02-04 8:29 ` David Hildenbrand
2020-02-04 8:29 ` David Hildenbrand
2020-02-04 18:52 ` Tyler Sanderson via Virtualization
2020-02-04 18:52 ` Tyler Sanderson
2020-02-04 18:56 ` Michael S. Tsirkin
2020-02-04 18:56 ` Michael S. Tsirkin
2020-02-04 19:17 ` David Hildenbrand
2020-02-04 19:17 ` David Hildenbrand
2020-02-04 23:58 ` Tyler Sanderson via Virtualization
2020-02-04 23:58 ` Tyler Sanderson
2020-02-05 0:15 ` Tyler Sanderson via Virtualization
2020-02-05 0:15 ` Tyler Sanderson
2020-02-05 6:57 ` Michael S. Tsirkin
2020-02-05 6:57 ` Michael S. Tsirkin
2020-02-05 19:01 ` Tyler Sanderson via Virtualization
2020-02-05 19:01 ` Tyler Sanderson
2020-02-05 19:22 ` Alexander Duyck
2020-02-05 21:44 ` Tyler Sanderson via Virtualization
2020-02-05 21:44 ` Tyler Sanderson
2020-02-06 11:00 ` David Hildenbrand
2020-02-06 11:00 ` David Hildenbrand
2020-02-03 22:50 ` Nadav Amit via Virtualization
2020-02-03 22:50 ` Nadav Amit
2020-02-04 8:35 ` David Hildenbrand
2020-02-04 8:35 ` David Hildenbrand
2020-02-04 8:40 ` Michael S. Tsirkin [this message]
2020-02-04 8:40 ` Michael S. Tsirkin
2020-02-04 8:48 ` David Hildenbrand
2020-02-04 8:48 ` David Hildenbrand
2020-02-04 14:30 ` David Hildenbrand
2020-02-04 14:30 ` David Hildenbrand
2020-02-04 16:50 ` Michael S. Tsirkin
2020-02-04 16:50 ` Michael S. Tsirkin
2020-02-04 16:56 ` David Hildenbrand
2020-02-04 16:56 ` David Hildenbrand
2020-02-04 20:33 ` [virtio-dev] " Michael S. Tsirkin
2020-02-04 20:33 ` Michael S. Tsirkin
2020-02-04 20:33 ` Michael S. Tsirkin
2020-02-05 8:31 ` [virtio-dev] " David Hildenbrand
2020-02-05 8:31 ` David Hildenbrand
2020-02-05 6:52 ` Wang, Wei W
2020-02-05 6:52 ` Wang, Wei W
2020-02-05 7:05 ` Michael S. Tsirkin
2020-02-05 7:05 ` Michael S. Tsirkin
2020-02-05 8:50 ` Wang, Wei W
2020-02-05 8:50 ` Wang, Wei W
2020-02-05 6:49 ` Wang, Wei W
2020-02-05 6:49 ` Wang, Wei W
2020-02-05 8:19 ` David Hildenbrand
2020-02-05 8:19 ` David Hildenbrand
2020-02-05 8:54 ` Wang, Wei W
2020-02-05 8:54 ` Wang, Wei W
2020-02-05 8:56 ` David Hildenbrand
2020-02-05 8:56 ` David Hildenbrand
2020-02-05 9:00 ` Wang, Wei W
2020-02-05 9:00 ` Wang, Wei W
2020-02-05 9:05 ` David Hildenbrand
2020-02-05 9:05 ` David Hildenbrand
2020-02-05 9:19 ` Wang, Wei W
2020-02-05 9:19 ` Wang, Wei W
2020-02-05 9:22 ` David Hildenbrand
2020-02-05 9:22 ` David Hildenbrand
2020-02-05 9:35 ` Wang, Wei W
2020-02-05 9:35 ` Wang, Wei W
2020-02-05 9:37 ` David Hildenbrand
2020-02-05 9:37 ` David Hildenbrand
2020-02-05 9:49 ` Wang, Wei W
2020-02-05 9:49 ` Wang, Wei W
2020-02-05 9:58 ` David Hildenbrand
2020-02-05 9:58 ` David Hildenbrand
2020-02-05 10:25 ` Michael S. Tsirkin
2020-02-05 10:25 ` Michael S. Tsirkin
2020-02-05 10:42 ` David Hildenbrand
2020-02-05 10:42 ` David Hildenbrand
2020-02-05 9:35 ` Michael S. Tsirkin
2020-02-05 9:35 ` Michael S. Tsirkin
2020-02-05 18:43 ` Tyler Sanderson via Virtualization
2020-02-05 18:43 ` Tyler Sanderson
2020-02-06 9:30 ` Wang, Wei W
2020-02-06 9:30 ` Wang, Wei W
2020-02-05 7:35 ` Nadav Amit via Virtualization
2020-02-05 7:35 ` Nadav Amit
2020-02-05 8:19 ` David Hildenbrand
2020-02-05 8:19 ` David Hildenbrand
2020-02-05 10:27 ` Michael S. Tsirkin
2020-02-05 10:27 ` Michael S. Tsirkin
2020-02-05 10:43 ` David Hildenbrand
2020-02-05 10:43 ` David Hildenbrand
2020-01-30 22:46 ` Tyler Sanderson via Virtualization
2020-01-30 22:46 ` Tyler Sanderson
2020-02-02 0:21 ` David Rientjes via Virtualization
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200204033657-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alexander.h.duyck@linux.intel.com \
--cc=david@redhat.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=namit@vmware.com \
--cc=rientjes@google.com \
--cc=tysand@google.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.