From: Mark Brown <broonie@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Jaedon Shin <jaedon.shin@gmail.com>,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Florian Fainelli <f.fainelli@gmail.com>,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Andrew Murray <amurray@thegoodpenguin.co.uk>,
Gregory Fong <gregory.0xf0@gmail.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-pci <linux-pci@vger.kernel.org>
Subject: Re: [PATCH 2/3] PCI: brcmstb: Add regulator support
Date: Fri, 14 Feb 2020 11:52:23 +0000 [thread overview]
Message-ID: <20200214115223.GD4827@sirena.org.uk> (raw)
In-Reply-To: <CACRpkdZ9A_SJzxQ__f0oani+A97N3yLT3=oJ8z3vNJ5Ucyo8vA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 304 bytes --]
On Fri, Feb 14, 2020 at 11:06:51AM +0100, Linus Walleij wrote:
> So what this does is just grab any regulators, no matter what they are
> named, and enable them? The swiss army knife used is the raw
> of_* parsing functions.
> I don't think that is very good practice.
This is a really bad idea, yes.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
linux-pci <linux-pci@vger.kernel.org>,
Jaedon Shin <jaedon.shin@gmail.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Gregory Fong <gregory.0xf0@gmail.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Andrew Murray <amurray@thegoodpenguin.co.uk>
Subject: Re: [PATCH 2/3] PCI: brcmstb: Add regulator support
Date: Fri, 14 Feb 2020 11:52:23 +0000 [thread overview]
Message-ID: <20200214115223.GD4827@sirena.org.uk> (raw)
In-Reply-To: <CACRpkdZ9A_SJzxQ__f0oani+A97N3yLT3=oJ8z3vNJ5Ucyo8vA@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 304 bytes --]
On Fri, Feb 14, 2020 at 11:06:51AM +0100, Linus Walleij wrote:
> So what this does is just grab any regulators, no matter what they are
> named, and enable them? The swiss army knife used is the raw
> of_* parsing functions.
> I don't think that is very good practice.
This is a really bad idea, yes.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-14 11:52 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 2:59 [PATCH 0/3] PCI: brcmstb: Add Broadcom STB support Jaedon Shin
2020-02-13 2:59 ` Jaedon Shin
2020-02-13 2:59 ` [PATCH 1/3] PCI: brcmstb: Enable ARCH_BRCMSTB Jaedon Shin
2020-02-13 2:59 ` Jaedon Shin
2020-02-13 3:58 ` Florian Fainelli
2020-02-13 3:58 ` Florian Fainelli
2020-02-13 2:59 ` [PATCH 2/3] PCI: brcmstb: Add regulator support Jaedon Shin
2020-02-13 2:59 ` Jaedon Shin
2020-02-13 3:58 ` Florian Fainelli
2020-02-13 3:58 ` Florian Fainelli
2020-02-20 11:07 ` Gregory Fong
2020-02-20 11:07 ` Gregory Fong
2020-02-13 15:25 ` Jim Quinlan
2020-02-13 15:25 ` Jim Quinlan
2020-02-14 10:06 ` Linus Walleij
2020-02-14 10:06 ` Linus Walleij
2020-02-14 11:52 ` Mark Brown [this message]
2020-02-14 11:52 ` Mark Brown
2020-02-14 11:01 ` Nicolas Saenz Julienne
2020-02-14 11:01 ` Nicolas Saenz Julienne
2020-02-13 2:59 ` [PATCH 3/3] PCI: brcmstb: Drop clk_put when probe fails and remove Jaedon Shin
2020-02-13 2:59 ` Jaedon Shin
2020-02-13 4:01 ` Florian Fainelli
2020-02-13 4:01 ` Florian Fainelli
2020-02-14 10:55 ` Nicolas Saenz Julienne
2020-02-14 10:55 ` Nicolas Saenz Julienne
2020-02-13 3:54 ` [PATCH 0/3] PCI: brcmstb: Add Broadcom STB support Florian Fainelli
2020-02-13 3:54 ` Florian Fainelli
2020-02-13 5:15 ` Jaedon Shin
2020-02-13 5:15 ` Jaedon Shin
2020-02-13 15:54 ` Jim Quinlan
2020-02-13 15:54 ` Jim Quinlan
2020-02-14 2:16 ` Jaedon Shin
2020-02-14 2:16 ` Jaedon Shin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200214115223.GD4827@sirena.org.uk \
--to=broonie@kernel.org \
--cc=amurray@thegoodpenguin.co.uk \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bgolaszewski@baylibre.com \
--cc=bhelgaas@google.com \
--cc=f.fainelli@gmail.com \
--cc=gregory.0xf0@gmail.com \
--cc=jaedon.shin@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=nsaenzjulienne@suse.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.