From: Florian Fainelli <f.fainelli@gmail.com>
To: Jaedon Shin <jaedon.shin@gmail.com>,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
bcm-kernel-feedback-list@broadcom.com,
Jim Quinlan <james.quinlan@Broadcom.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Andrew Murray <amurray@thegoodpenguin.co.uk>,
Gregory Fong <gregory.0xf0@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH 1/3] PCI: brcmstb: Enable ARCH_BRCMSTB
Date: Wed, 12 Feb 2020 19:58:16 -0800 [thread overview]
Message-ID: <6c6d240d-b9d3-907b-df79-8823a281e480@gmail.com> (raw)
In-Reply-To: <20200213025930.27943-2-jaedon.shin@gmail.com>
On 2/12/2020 6:59 PM, Jaedon Shin wrote:
> Add PCIe support for ARM-based Broadcom STB SoCs.
>
> Signed-off-by: Jaedon Shin <jaedon.shin@gmail.com>
> ---
> Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 8 +++++++-
> drivers/pci/controller/Kconfig | 2 +-
> drivers/pci/controller/pcie-brcmstb.c | 1 +
> 3 files changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> index 77d3e81a437b..fb1a78606f78 100644
> --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> @@ -14,7 +14,13 @@ allOf:
>
> properties:
> compatible:
> - const: brcm,bcm2711-pcie # The Raspberry Pi 4
> + oneOf:
> + - description:
> + BCM2711 based Boards
> + const: brcm,bcm2711-pcie
> + - description:
> + ARM-based BCM7XXX Broadcom STB Boards
> + const: brcm,bcm7445-pcie
You would also need to document the regulator properties as optional here.
>
> reg:
> maxItems: 1
> diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
> index 20bf00f587bd..c60a27cff81a 100644
> --- a/drivers/pci/controller/Kconfig
> +++ b/drivers/pci/controller/Kconfig
> @@ -254,7 +254,7 @@ config VMD
>
> config PCIE_BRCMSTB
> tristate "Broadcom Brcmstb PCIe host controller"
> - depends on ARCH_BCM2835 || COMPILE_TEST
> + depends on ARCH_BCM2835 || ARCH_BRCMSTB || COMPILE_TEST
This part looks entirely reasonable.
--
Florian
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: Jaedon Shin <jaedon.shin@gmail.com>,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
bcm-kernel-feedback-list@broadcom.com,
Jim Quinlan <james.quinlan@Broadcom.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
linux-gpio@vger.kernel.org, linux-pci@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Gregory Fong <gregory.0xf0@gmail.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-arm-kernel@lists.infradead.org,
Andrew Murray <amurray@thegoodpenguin.co.uk>
Subject: Re: [PATCH 1/3] PCI: brcmstb: Enable ARCH_BRCMSTB
Date: Wed, 12 Feb 2020 19:58:16 -0800 [thread overview]
Message-ID: <6c6d240d-b9d3-907b-df79-8823a281e480@gmail.com> (raw)
In-Reply-To: <20200213025930.27943-2-jaedon.shin@gmail.com>
On 2/12/2020 6:59 PM, Jaedon Shin wrote:
> Add PCIe support for ARM-based Broadcom STB SoCs.
>
> Signed-off-by: Jaedon Shin <jaedon.shin@gmail.com>
> ---
> Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 8 +++++++-
> drivers/pci/controller/Kconfig | 2 +-
> drivers/pci/controller/pcie-brcmstb.c | 1 +
> 3 files changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> index 77d3e81a437b..fb1a78606f78 100644
> --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> @@ -14,7 +14,13 @@ allOf:
>
> properties:
> compatible:
> - const: brcm,bcm2711-pcie # The Raspberry Pi 4
> + oneOf:
> + - description:
> + BCM2711 based Boards
> + const: brcm,bcm2711-pcie
> + - description:
> + ARM-based BCM7XXX Broadcom STB Boards
> + const: brcm,bcm7445-pcie
You would also need to document the regulator properties as optional here.
>
> reg:
> maxItems: 1
> diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
> index 20bf00f587bd..c60a27cff81a 100644
> --- a/drivers/pci/controller/Kconfig
> +++ b/drivers/pci/controller/Kconfig
> @@ -254,7 +254,7 @@ config VMD
>
> config PCIE_BRCMSTB
> tristate "Broadcom Brcmstb PCIe host controller"
> - depends on ARCH_BCM2835 || COMPILE_TEST
> + depends on ARCH_BCM2835 || ARCH_BRCMSTB || COMPILE_TEST
This part looks entirely reasonable.
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-13 3:58 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 2:59 [PATCH 0/3] PCI: brcmstb: Add Broadcom STB support Jaedon Shin
2020-02-13 2:59 ` Jaedon Shin
2020-02-13 2:59 ` [PATCH 1/3] PCI: brcmstb: Enable ARCH_BRCMSTB Jaedon Shin
2020-02-13 2:59 ` Jaedon Shin
2020-02-13 3:58 ` Florian Fainelli [this message]
2020-02-13 3:58 ` Florian Fainelli
2020-02-13 2:59 ` [PATCH 2/3] PCI: brcmstb: Add regulator support Jaedon Shin
2020-02-13 2:59 ` Jaedon Shin
2020-02-13 3:58 ` Florian Fainelli
2020-02-13 3:58 ` Florian Fainelli
2020-02-20 11:07 ` Gregory Fong
2020-02-20 11:07 ` Gregory Fong
2020-02-13 15:25 ` Jim Quinlan
2020-02-13 15:25 ` Jim Quinlan
2020-02-14 10:06 ` Linus Walleij
2020-02-14 10:06 ` Linus Walleij
2020-02-14 11:52 ` Mark Brown
2020-02-14 11:52 ` Mark Brown
2020-02-14 11:01 ` Nicolas Saenz Julienne
2020-02-14 11:01 ` Nicolas Saenz Julienne
2020-02-13 2:59 ` [PATCH 3/3] PCI: brcmstb: Drop clk_put when probe fails and remove Jaedon Shin
2020-02-13 2:59 ` Jaedon Shin
2020-02-13 4:01 ` Florian Fainelli
2020-02-13 4:01 ` Florian Fainelli
2020-02-14 10:55 ` Nicolas Saenz Julienne
2020-02-14 10:55 ` Nicolas Saenz Julienne
2020-02-13 3:54 ` [PATCH 0/3] PCI: brcmstb: Add Broadcom STB support Florian Fainelli
2020-02-13 3:54 ` Florian Fainelli
2020-02-13 5:15 ` Jaedon Shin
2020-02-13 5:15 ` Jaedon Shin
2020-02-13 15:54 ` Jim Quinlan
2020-02-13 15:54 ` Jim Quinlan
2020-02-14 2:16 ` Jaedon Shin
2020-02-14 2:16 ` Jaedon Shin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c6d240d-b9d3-907b-df79-8823a281e480@gmail.com \
--to=f.fainelli@gmail.com \
--cc=amurray@thegoodpenguin.co.uk \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bgolaszewski@baylibre.com \
--cc=bhelgaas@google.com \
--cc=gregory.0xf0@gmail.com \
--cc=jaedon.shin@gmail.com \
--cc=james.quinlan@Broadcom.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=nsaenzjulienne@suse.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.