From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 2/5] f2fs: force compressed data into warm area
Date: Tue, 10 Mar 2020 09:32:39 -0700 [thread overview]
Message-ID: <20200310163239.GC240315@google.com> (raw)
In-Reply-To: <20200310125009.12966-2-yuchao0@huawei.com>
On 03/10, Chao Yu wrote:
> Generally, data shows better continuity in warm data area as its
> default allocation direction is right, in order to enhance
> sequential read/write performance of compress inode, let's force
> compress data into warm area.
Not quite sure tho, compressed blocks are logically cold, no?
>
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> ---
> fs/f2fs/segment.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index 601d67e72c50..ab1bc750712a 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -3037,9 +3037,10 @@ static int __get_segment_type_6(struct f2fs_io_info *fio)
> if (fio->type == DATA) {
> struct inode *inode = fio->page->mapping->host;
>
> - if (is_cold_data(fio->page) || file_is_cold(inode) ||
> - f2fs_compressed_file(inode))
> + if (is_cold_data(fio->page) || file_is_cold(inode))
> return CURSEG_COLD_DATA;
> + if (f2fs_compressed_file(inode))
> + return CURSEG_WARM_DATA;
> if (file_is_hot(inode) ||
> is_inode_flag_set(inode, FI_HOT_DATA) ||
> f2fs_is_atomic_file(inode) ||
> --
> 2.18.0.rc1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, chao@kernel.org
Subject: Re: [PATCH 2/5] f2fs: force compressed data into warm area
Date: Tue, 10 Mar 2020 09:32:39 -0700 [thread overview]
Message-ID: <20200310163239.GC240315@google.com> (raw)
In-Reply-To: <20200310125009.12966-2-yuchao0@huawei.com>
On 03/10, Chao Yu wrote:
> Generally, data shows better continuity in warm data area as its
> default allocation direction is right, in order to enhance
> sequential read/write performance of compress inode, let's force
> compress data into warm area.
Not quite sure tho, compressed blocks are logically cold, no?
>
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> ---
> fs/f2fs/segment.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index 601d67e72c50..ab1bc750712a 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -3037,9 +3037,10 @@ static int __get_segment_type_6(struct f2fs_io_info *fio)
> if (fio->type == DATA) {
> struct inode *inode = fio->page->mapping->host;
>
> - if (is_cold_data(fio->page) || file_is_cold(inode) ||
> - f2fs_compressed_file(inode))
> + if (is_cold_data(fio->page) || file_is_cold(inode))
> return CURSEG_COLD_DATA;
> + if (f2fs_compressed_file(inode))
> + return CURSEG_WARM_DATA;
> if (file_is_hot(inode) ||
> is_inode_flag_set(inode, FI_HOT_DATA) ||
> f2fs_is_atomic_file(inode) ||
> --
> 2.18.0.rc1
next prev parent reply other threads:[~2020-03-10 16:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 12:50 [f2fs-dev] [PATCH 1/5] f2fs: change default compression algorithm Chao Yu
2020-03-10 12:50 ` Chao Yu
2020-03-10 12:50 ` [f2fs-dev] [PATCH 2/5] f2fs: force compressed data into warm area Chao Yu
2020-03-10 12:50 ` Chao Yu
2020-03-10 16:32 ` Jaegeuk Kim [this message]
2020-03-10 16:32 ` Jaegeuk Kim
2020-03-11 3:45 ` [f2fs-dev] " Chao Yu
2020-03-11 3:45 ` Chao Yu
2020-03-10 12:50 ` [f2fs-dev] [PATCH 3/5] f2fs: fix to account compressed inode correctly Chao Yu
2020-03-10 12:50 ` Chao Yu
2020-03-10 12:50 ` [f2fs-dev] [PATCH 4/5] f2fs: fix to check dirty pages during compressed inode conversion Chao Yu
2020-03-10 12:50 ` Chao Yu
2020-03-10 12:50 ` [f2fs-dev] [PATCH 5/5] f2fs: allow to clear F2FS_COMPR_FL flag Chao Yu
2020-03-10 12:50 ` Chao Yu
2020-03-10 16:15 ` [f2fs-dev] [PATCH 1/5] f2fs: change default compression algorithm Eric Biggers
2020-03-10 16:15 ` Eric Biggers
2020-03-11 0:41 ` Chao Yu
2020-03-11 0:41 ` Chao Yu
2020-03-11 3:07 ` Jaegeuk Kim
2020-03-11 3:07 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200310163239.GC240315@google.com \
--to=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.