* [PATCH] staging: hp100: Block comments use a trailing */ on a separate line @ 2020-03-21 1:31 Gokce Kuler 2020-03-21 9:33 ` Greg KH 0 siblings, 1 reply; 6+ messages in thread From: Gokce Kuler @ 2020-03-21 1:31 UTC (permalink / raw) To: outreachy-kernel; +Cc: gregkh Moved to the bottom line */ for block comments Signed-off-by: Gokce Kuler <gokcekuler@gmail.com> --- drivers/staging/hp/hp100.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/hp/hp100.h b/drivers/staging/hp/hp100.h index 7239b94..a331587 100644 --- a/drivers/staging/hp/hp100.h +++ b/drivers/staging/hp/hp100.h @@ -538,7 +538,8 @@ /* Tx or Rx Ring Entry */ typedef struct hp100_ring { u_int *pdl; /* Address of PDLs PDH, dword before - * this address is used for rx hdr */ + * this address is used for rx hdr + */ u_int pdl_paddr; /* Physical address of PDL */ struct sk_buff *skb; struct hp100_ring *next; -- 2.7.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: hp100: Block comments use a trailing */ on a separate line 2020-03-21 1:31 [PATCH] staging: hp100: Block comments use a trailing */ on a separate line Gokce Kuler @ 2020-03-21 9:33 ` Greg KH 2020-03-21 12:44 ` [Outreachy kernel] " Sam Muhammed 0 siblings, 1 reply; 6+ messages in thread From: Greg KH @ 2020-03-21 9:33 UTC (permalink / raw) To: Gokce Kuler; +Cc: outreachy-kernel On Sat, Mar 21, 2020 at 04:31:01AM +0300, Gokce Kuler wrote: > Moved to the bottom line */ for block comments Again, you said what you did, but not why. Also, you _added_ two new checkpatch warnings, not a good ratio :( thanks, greg k-h ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH] staging: hp100: Block comments use a trailing */ on a separate line 2020-03-21 9:33 ` Greg KH @ 2020-03-21 12:44 ` Sam Muhammed 2020-03-21 12:46 ` Greg KH 0 siblings, 1 reply; 6+ messages in thread From: Sam Muhammed @ 2020-03-21 12:44 UTC (permalink / raw) To: Greg KH, Gokce Kuler; +Cc: outreachy-kernel On Sat, 2020-03-21 at 10:33 +0100, Greg KH wrote: > On Sat, Mar 21, 2020 at 04:31:01AM +0300, Gokce Kuler wrote: > > Moved to the bottom line */ for block comments > > Again, you said what you did, but not why. > > Also, you _added_ two new checkpatch warnings, not a good ratio :( > > thanks, > Iam sorry, are we allowed to work on this driver, because i got; WARNING: drivers/staging/hp/hp100.c is marked as 'obsolete' in the MAINTAINERS hierarchy. No unnecessary modifications please. Sam > greg k-h > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH] staging: hp100: Block comments use a trailing */ on a separate line 2020-03-21 12:44 ` [Outreachy kernel] " Sam Muhammed @ 2020-03-21 12:46 ` Greg KH 2020-03-21 12:50 ` Sam Muhammed 0 siblings, 1 reply; 6+ messages in thread From: Greg KH @ 2020-03-21 12:46 UTC (permalink / raw) To: Sam Muhammed; +Cc: Gokce Kuler, outreachy-kernel On Sat, Mar 21, 2020 at 08:44:48AM -0400, Sam Muhammed wrote: > On Sat, 2020-03-21 at 10:33 +0100, Greg KH wrote: > > On Sat, Mar 21, 2020 at 04:31:01AM +0300, Gokce Kuler wrote: > > > Moved to the bottom line */ for block comments > > > > Again, you said what you did, but not why. > > > > Also, you _added_ two new checkpatch warnings, not a good ratio :( > > > > thanks, > > > > Iam sorry, are we allowed to work on this driver, because i got; > WARNING: drivers/staging/hp/hp100.c is marked as 'obsolete' in the > MAINTAINERS hierarchy. No unnecessary modifications please. For basic code cleanups, to learn the process, it's fine, but note that the code will be deleted from the kernel "soon", so any changes you make will not stick around. thanks, greg k-h ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH] staging: hp100: Block comments use a trailing */ on a separate line 2020-03-21 12:46 ` Greg KH @ 2020-03-21 12:50 ` Sam Muhammed 2020-03-21 13:51 ` Greg KH 0 siblings, 1 reply; 6+ messages in thread From: Sam Muhammed @ 2020-03-21 12:50 UTC (permalink / raw) To: Greg KH; +Cc: Gokce Kuler, outreachy-kernel On Sat, 2020-03-21 at 13:46 +0100, Greg KH wrote: > On Sat, Mar 21, 2020 at 08:44:48AM -0400, Sam Muhammed wrote: > > On Sat, 2020-03-21 at 10:33 +0100, Greg KH wrote: > > > On Sat, Mar 21, 2020 at 04:31:01AM +0300, Gokce Kuler wrote: > > > > Moved to the bottom line */ for block comments > > > > > > Again, you said what you did, but not why. > > > > > > Also, you _added_ two new checkpatch warnings, not a good ratio :( > > > > > > thanks, > > > > > > > Iam sorry, are we allowed to work on this driver, because i got; > > WARNING: drivers/staging/hp/hp100.c is marked as 'obsolete' in the > > MAINTAINERS hierarchy. No unnecessary modifications please. > > For basic code cleanups, to learn the process, it's fine, but note that > the code will be deleted from the kernel "soon", so any changes you make > will not stick around. > So outreachy-wise, would this be considered as a contribution? This driver is juicy :) Sam > thanks, > > greg k-h ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH] staging: hp100: Block comments use a trailing */ on a separate line 2020-03-21 12:50 ` Sam Muhammed @ 2020-03-21 13:51 ` Greg KH 0 siblings, 0 replies; 6+ messages in thread From: Greg KH @ 2020-03-21 13:51 UTC (permalink / raw) To: Sam Muhammed; +Cc: Gokce Kuler, outreachy-kernel On Sat, Mar 21, 2020 at 08:50:49AM -0400, Sam Muhammed wrote: > On Sat, 2020-03-21 at 13:46 +0100, Greg KH wrote: > > On Sat, Mar 21, 2020 at 08:44:48AM -0400, Sam Muhammed wrote: > > > On Sat, 2020-03-21 at 10:33 +0100, Greg KH wrote: > > > > On Sat, Mar 21, 2020 at 04:31:01AM +0300, Gokce Kuler wrote: > > > > > Moved to the bottom line */ for block comments > > > > > > > > Again, you said what you did, but not why. > > > > > > > > Also, you _added_ two new checkpatch warnings, not a good ratio :( > > > > > > > > thanks, > > > > > > > > > > Iam sorry, are we allowed to work on this driver, because i got; > > > WARNING: drivers/staging/hp/hp100.c is marked as 'obsolete' in the > > > MAINTAINERS hierarchy. No unnecessary modifications please. > > > > For basic code cleanups, to learn the process, it's fine, but note that > > the code will be deleted from the kernel "soon", so any changes you make > > will not stick around. > > > > So outreachy-wise, would this be considered as a contribution? > This driver is juicy :) Sure, I'll take contributions to it until Wednesday, and then I'll delete it from the tree as it's about time it needs to go. thanks, greg k-h ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-03-21 13:51 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-03-21 1:31 [PATCH] staging: hp100: Block comments use a trailing */ on a separate line Gokce Kuler 2020-03-21 9:33 ` Greg KH 2020-03-21 12:44 ` [Outreachy kernel] " Sam Muhammed 2020-03-21 12:46 ` Greg KH 2020-03-21 12:50 ` Sam Muhammed 2020-03-21 13:51 ` Greg KH
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.