From: Jason Gunthorpe <jgg@ziepe.ca>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Doug Ledford <dledford@redhat.com>,
Leon Romanovsky <leon@kernel.org>,
Danit Goldberg <danitg@mellanox.com>,
Parav Pandit <parav@mellanox.com>,
linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] RDMA/cm: Fix an error check in cm_alloc_id_priv()
Date: Mon, 06 Apr 2020 14:51:09 +0000 [thread overview]
Message-ID: <20200406145109.GQ20941@ziepe.ca> (raw)
In-Reply-To: <20200406144335.GD68494@mwanda>
On Mon, Apr 06, 2020 at 05:43:35PM +0300, Dan Carpenter wrote:
> The xa_alloc_cyclic_irq() function returns either 0 or 1 on success and
> negatives on error. This code treats 1 as an error and returns
> ERR_PTR(1) which will cause an Oops in the caller.
>
> Fixes: e8dc4e885c45 ("RDMA/cm: Fix ordering of xa_alloc_cyclic() in ib_create_cm_id()")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> The Fixes tag may not be correct. That's the patch which introduces an
> Oops but we may want to backport this further back.
Right it should be
Fixes: ae78ff3a0f0c ("RDMA/cm: Convert local_id_table to XArray")
Thanks,
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@ziepe.ca>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Doug Ledford <dledford@redhat.com>,
Leon Romanovsky <leon@kernel.org>,
Danit Goldberg <danitg@mellanox.com>,
Parav Pandit <parav@mellanox.com>,
linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] RDMA/cm: Fix an error check in cm_alloc_id_priv()
Date: Mon, 6 Apr 2020 11:51:09 -0300 [thread overview]
Message-ID: <20200406145109.GQ20941@ziepe.ca> (raw)
In-Reply-To: <20200406144335.GD68494@mwanda>
On Mon, Apr 06, 2020 at 05:43:35PM +0300, Dan Carpenter wrote:
> The xa_alloc_cyclic_irq() function returns either 0 or 1 on success and
> negatives on error. This code treats 1 as an error and returns
> ERR_PTR(1) which will cause an Oops in the caller.
>
> Fixes: e8dc4e885c45 ("RDMA/cm: Fix ordering of xa_alloc_cyclic() in ib_create_cm_id()")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> The Fixes tag may not be correct. That's the patch which introduces an
> Oops but we may want to backport this further back.
Right it should be
Fixes: ae78ff3a0f0c ("RDMA/cm: Convert local_id_table to XArray")
Thanks,
Jason
next prev parent reply other threads:[~2020-04-06 14:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 14:43 [PATCH] RDMA/cm: Fix an error check in cm_alloc_id_priv() Dan Carpenter
2020-04-06 14:43 ` Dan Carpenter
2020-04-06 14:51 ` Jason Gunthorpe [this message]
2020-04-06 14:51 ` Jason Gunthorpe
2020-04-07 9:37 ` [PATCH v2] " Dan Carpenter
2020-04-07 9:37 ` Dan Carpenter
2020-04-07 16:59 ` Matthew Wilcox
2020-04-07 16:59 ` Matthew Wilcox
2020-04-14 19:02 ` Jason Gunthorpe
2020-04-14 19:02 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200406145109.GQ20941@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=dan.carpenter@oracle.com \
--cc=danitg@mellanox.com \
--cc=dledford@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=parav@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.