From: Jason Gunthorpe <jgg@ziepe.ca>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Doug Ledford <dledford@redhat.com>,
Matthew Wilcox <willy@infradead.org>,
Leon Romanovsky <leon@kernel.org>,
Danit Goldberg <danitg@mellanox.com>,
Parav Pandit <parav@mellanox.com>,
linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] RDMA/cm: Fix an error check in cm_alloc_id_priv()
Date: Tue, 14 Apr 2020 19:02:11 +0000 [thread overview]
Message-ID: <20200414190211.GA12156@ziepe.ca> (raw)
In-Reply-To: <20200407093714.GA80285@mwanda>
On Tue, Apr 07, 2020 at 12:37:14PM +0300, Dan Carpenter wrote:
> The xa_alloc_cyclic_irq() function returns either 0 or 1 on success and
> negatives on error. This code treats 1 as an error and returns
> ERR_PTR(1) which will cause an Oops in the caller.
>
> Fixes: ae78ff3a0f0c ("RDMA/cm: Convert local_id_table to XArray")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> ---
> v2: Use the correct Fixes tag and add Matthew to the CC list.
>
> drivers/infiniband/core/cm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to for-next, thanks
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@ziepe.ca>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Doug Ledford <dledford@redhat.com>,
Matthew Wilcox <willy@infradead.org>,
Leon Romanovsky <leon@kernel.org>,
Danit Goldberg <danitg@mellanox.com>,
Parav Pandit <parav@mellanox.com>,
linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] RDMA/cm: Fix an error check in cm_alloc_id_priv()
Date: Tue, 14 Apr 2020 16:02:11 -0300 [thread overview]
Message-ID: <20200414190211.GA12156@ziepe.ca> (raw)
In-Reply-To: <20200407093714.GA80285@mwanda>
On Tue, Apr 07, 2020 at 12:37:14PM +0300, Dan Carpenter wrote:
> The xa_alloc_cyclic_irq() function returns either 0 or 1 on success and
> negatives on error. This code treats 1 as an error and returns
> ERR_PTR(1) which will cause an Oops in the caller.
>
> Fixes: ae78ff3a0f0c ("RDMA/cm: Convert local_id_table to XArray")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> ---
> v2: Use the correct Fixes tag and add Matthew to the CC list.
>
> drivers/infiniband/core/cm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to for-next, thanks
Jason
next prev parent reply other threads:[~2020-04-14 19:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 14:43 [PATCH] RDMA/cm: Fix an error check in cm_alloc_id_priv() Dan Carpenter
2020-04-06 14:43 ` Dan Carpenter
2020-04-06 14:51 ` Jason Gunthorpe
2020-04-06 14:51 ` Jason Gunthorpe
2020-04-07 9:37 ` [PATCH v2] " Dan Carpenter
2020-04-07 9:37 ` Dan Carpenter
2020-04-07 16:59 ` Matthew Wilcox
2020-04-07 16:59 ` Matthew Wilcox
2020-04-14 19:02 ` Jason Gunthorpe [this message]
2020-04-14 19:02 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414190211.GA12156@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=dan.carpenter@oracle.com \
--cc=danitg@mellanox.com \
--cc=dledford@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=parav@mellanox.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.