All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Jason Yan <yanaijie@huawei.com>
Cc: gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org,
	dri-devel@lists.freedesktop.org, b.zolnierkie@samsung.com
Subject: Re: [PATCH] video: fbdev: mb862xx: remove set but not used variable 'mdr'
Date: Wed, 08 Apr 2020 10:19:27 +0000	[thread overview]
Message-ID: <20200408101927.GD20795@ravnborg.org> (raw)
In-Reply-To: <20200403022553.33320-1-yanaijie@huawei.com>

Hi Jason.

On Fri, Apr 03, 2020 at 10:25:53AM +0800, Jason Yan wrote:
> Fix the following gcc warning:
> 
> drivers/video/fbdev/mb862xx/mb862xxfb_accel.c:187:6: warning: variable
> ‘mdr’ set but not used [-Wunused-but-set-variable]
>   int mdr;
>       ^~~
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>

Thanks, committed to drm-misc-next.
The fix will show up durign the next merge window.

	Sam

> ---
>  drivers/video/fbdev/mb862xx/mb862xxfb_accel.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/video/fbdev/mb862xx/mb862xxfb_accel.c b/drivers/video/fbdev/mb862xx/mb862xxfb_accel.c
> index 42569264801f..d40b806461ca 100644
> --- a/drivers/video/fbdev/mb862xx/mb862xxfb_accel.c
> +++ b/drivers/video/fbdev/mb862xx/mb862xxfb_accel.c
> @@ -184,7 +184,6 @@ static void mb86290fb_imageblit16(u32 *cmd, u16 step, u16 dx, u16 dy,
>  static void mb86290fb_imageblit(struct fb_info *info,
>  				const struct fb_image *image)
>  {
> -	int mdr;
>  	u32 *cmd = NULL;
>  	void (*cmdfn) (u32 *, u16, u16, u16, u16, u16, u32, u32,
>  		       const struct fb_image *, struct fb_info *) = NULL;
> @@ -196,7 +195,6 @@ static void mb86290fb_imageblit(struct fb_info *info,
>  	u16 dx = image->dx, dy = image->dy;
>  	int x2, y2, vxres, vyres;
>  
> -	mdr = (GDC_ROP_COPY << 9);
>  	x2 = image->dx + image->width;
>  	y2 = image->dy + image->height;
>  	vxres = info->var.xres_virtual;
> -- 
> 2.17.2
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Jason Yan <yanaijie@huawei.com>
Cc: gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org,
	dri-devel@lists.freedesktop.org, b.zolnierkie@samsung.com
Subject: Re: [PATCH] video: fbdev: mb862xx: remove set but not used variable 'mdr'
Date: Wed, 8 Apr 2020 12:19:27 +0200	[thread overview]
Message-ID: <20200408101927.GD20795@ravnborg.org> (raw)
In-Reply-To: <20200403022553.33320-1-yanaijie@huawei.com>

Hi Jason.

On Fri, Apr 03, 2020 at 10:25:53AM +0800, Jason Yan wrote:
> Fix the following gcc warning:
> 
> drivers/video/fbdev/mb862xx/mb862xxfb_accel.c:187:6: warning: variable
> ‘mdr’ set but not used [-Wunused-but-set-variable]
>   int mdr;
>       ^~~
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>

Thanks, committed to drm-misc-next.
The fix will show up durign the next merge window.

	Sam

> ---
>  drivers/video/fbdev/mb862xx/mb862xxfb_accel.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/video/fbdev/mb862xx/mb862xxfb_accel.c b/drivers/video/fbdev/mb862xx/mb862xxfb_accel.c
> index 42569264801f..d40b806461ca 100644
> --- a/drivers/video/fbdev/mb862xx/mb862xxfb_accel.c
> +++ b/drivers/video/fbdev/mb862xx/mb862xxfb_accel.c
> @@ -184,7 +184,6 @@ static void mb86290fb_imageblit16(u32 *cmd, u16 step, u16 dx, u16 dy,
>  static void mb86290fb_imageblit(struct fb_info *info,
>  				const struct fb_image *image)
>  {
> -	int mdr;
>  	u32 *cmd = NULL;
>  	void (*cmdfn) (u32 *, u16, u16, u16, u16, u16, u32, u32,
>  		       const struct fb_image *, struct fb_info *) = NULL;
> @@ -196,7 +195,6 @@ static void mb86290fb_imageblit(struct fb_info *info,
>  	u16 dx = image->dx, dy = image->dy;
>  	int x2, y2, vxres, vyres;
>  
> -	mdr = (GDC_ROP_COPY << 9);
>  	x2 = image->dx + image->width;
>  	y2 = image->dy + image->height;
>  	vxres = info->var.xres_virtual;
> -- 
> 2.17.2
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-04-08 10:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-03  2:25 [PATCH] video: fbdev: mb862xx: remove set but not used variable 'mdr' Jason Yan
2020-04-03  2:25 ` Jason Yan
2020-04-08 10:19 ` Sam Ravnborg [this message]
2020-04-08 10:19   ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200408101927.GD20795@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=b.zolnierkie@samsung.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=yanaijie@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.