* [PATCH] video: fbdev: mb862xx: remove set but not used variable 'mdr'
@ 2020-04-03 2:25 ` Jason Yan
0 siblings, 0 replies; 4+ messages in thread
From: Jason Yan @ 2020-04-03 2:25 UTC (permalink / raw)
To: b.zolnierkie, gregkh, dri-devel, linux-fbdev; +Cc: Jason Yan
Fix the following gcc warning:
drivers/video/fbdev/mb862xx/mb862xxfb_accel.c:187:6: warning: variable
‘mdr’ set but not used [-Wunused-but-set-variable]
int mdr;
^~~
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/video/fbdev/mb862xx/mb862xxfb_accel.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/video/fbdev/mb862xx/mb862xxfb_accel.c b/drivers/video/fbdev/mb862xx/mb862xxfb_accel.c
index 42569264801f..d40b806461ca 100644
--- a/drivers/video/fbdev/mb862xx/mb862xxfb_accel.c
+++ b/drivers/video/fbdev/mb862xx/mb862xxfb_accel.c
@@ -184,7 +184,6 @@ static void mb86290fb_imageblit16(u32 *cmd, u16 step, u16 dx, u16 dy,
static void mb86290fb_imageblit(struct fb_info *info,
const struct fb_image *image)
{
- int mdr;
u32 *cmd = NULL;
void (*cmdfn) (u32 *, u16, u16, u16, u16, u16, u32, u32,
const struct fb_image *, struct fb_info *) = NULL;
@@ -196,7 +195,6 @@ static void mb86290fb_imageblit(struct fb_info *info,
u16 dx = image->dx, dy = image->dy;
int x2, y2, vxres, vyres;
- mdr = (GDC_ROP_COPY << 9);
x2 = image->dx + image->width;
y2 = image->dy + image->height;
vxres = info->var.xres_virtual;
--
2.17.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] video: fbdev: mb862xx: remove set but not used variable 'mdr'
@ 2020-04-03 2:25 ` Jason Yan
0 siblings, 0 replies; 4+ messages in thread
From: Jason Yan @ 2020-04-03 2:25 UTC (permalink / raw)
To: b.zolnierkie, gregkh, dri-devel, linux-fbdev; +Cc: Jason Yan
Fix the following gcc warning:
drivers/video/fbdev/mb862xx/mb862xxfb_accel.c:187:6: warning: variable
‘mdr’ set but not used [-Wunused-but-set-variable]
int mdr;
^~~
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/video/fbdev/mb862xx/mb862xxfb_accel.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/video/fbdev/mb862xx/mb862xxfb_accel.c b/drivers/video/fbdev/mb862xx/mb862xxfb_accel.c
index 42569264801f..d40b806461ca 100644
--- a/drivers/video/fbdev/mb862xx/mb862xxfb_accel.c
+++ b/drivers/video/fbdev/mb862xx/mb862xxfb_accel.c
@@ -184,7 +184,6 @@ static void mb86290fb_imageblit16(u32 *cmd, u16 step, u16 dx, u16 dy,
static void mb86290fb_imageblit(struct fb_info *info,
const struct fb_image *image)
{
- int mdr;
u32 *cmd = NULL;
void (*cmdfn) (u32 *, u16, u16, u16, u16, u16, u32, u32,
const struct fb_image *, struct fb_info *) = NULL;
@@ -196,7 +195,6 @@ static void mb86290fb_imageblit(struct fb_info *info,
u16 dx = image->dx, dy = image->dy;
int x2, y2, vxres, vyres;
- mdr = (GDC_ROP_COPY << 9);
x2 = image->dx + image->width;
y2 = image->dy + image->height;
vxres = info->var.xres_virtual;
--
2.17.2
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] video: fbdev: mb862xx: remove set but not used variable 'mdr'
2020-04-03 2:25 ` Jason Yan
@ 2020-04-08 10:19 ` Sam Ravnborg
-1 siblings, 0 replies; 4+ messages in thread
From: Sam Ravnborg @ 2020-04-08 10:19 UTC (permalink / raw)
To: Jason Yan; +Cc: gregkh, linux-fbdev, dri-devel, b.zolnierkie
Hi Jason.
On Fri, Apr 03, 2020 at 10:25:53AM +0800, Jason Yan wrote:
> Fix the following gcc warning:
>
> drivers/video/fbdev/mb862xx/mb862xxfb_accel.c:187:6: warning: variable
> ‘mdr’ set but not used [-Wunused-but-set-variable]
> int mdr;
> ^~~
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Thanks, committed to drm-misc-next.
The fix will show up durign the next merge window.
Sam
> ---
> drivers/video/fbdev/mb862xx/mb862xxfb_accel.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/mb862xx/mb862xxfb_accel.c b/drivers/video/fbdev/mb862xx/mb862xxfb_accel.c
> index 42569264801f..d40b806461ca 100644
> --- a/drivers/video/fbdev/mb862xx/mb862xxfb_accel.c
> +++ b/drivers/video/fbdev/mb862xx/mb862xxfb_accel.c
> @@ -184,7 +184,6 @@ static void mb86290fb_imageblit16(u32 *cmd, u16 step, u16 dx, u16 dy,
> static void mb86290fb_imageblit(struct fb_info *info,
> const struct fb_image *image)
> {
> - int mdr;
> u32 *cmd = NULL;
> void (*cmdfn) (u32 *, u16, u16, u16, u16, u16, u32, u32,
> const struct fb_image *, struct fb_info *) = NULL;
> @@ -196,7 +195,6 @@ static void mb86290fb_imageblit(struct fb_info *info,
> u16 dx = image->dx, dy = image->dy;
> int x2, y2, vxres, vyres;
>
> - mdr = (GDC_ROP_COPY << 9);
> x2 = image->dx + image->width;
> y2 = image->dy + image->height;
> vxres = info->var.xres_virtual;
> --
> 2.17.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] video: fbdev: mb862xx: remove set but not used variable 'mdr'
@ 2020-04-08 10:19 ` Sam Ravnborg
0 siblings, 0 replies; 4+ messages in thread
From: Sam Ravnborg @ 2020-04-08 10:19 UTC (permalink / raw)
To: Jason Yan; +Cc: gregkh, linux-fbdev, dri-devel, b.zolnierkie
Hi Jason.
On Fri, Apr 03, 2020 at 10:25:53AM +0800, Jason Yan wrote:
> Fix the following gcc warning:
>
> drivers/video/fbdev/mb862xx/mb862xxfb_accel.c:187:6: warning: variable
> ‘mdr’ set but not used [-Wunused-but-set-variable]
> int mdr;
> ^~~
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Thanks, committed to drm-misc-next.
The fix will show up durign the next merge window.
Sam
> ---
> drivers/video/fbdev/mb862xx/mb862xxfb_accel.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/mb862xx/mb862xxfb_accel.c b/drivers/video/fbdev/mb862xx/mb862xxfb_accel.c
> index 42569264801f..d40b806461ca 100644
> --- a/drivers/video/fbdev/mb862xx/mb862xxfb_accel.c
> +++ b/drivers/video/fbdev/mb862xx/mb862xxfb_accel.c
> @@ -184,7 +184,6 @@ static void mb86290fb_imageblit16(u32 *cmd, u16 step, u16 dx, u16 dy,
> static void mb86290fb_imageblit(struct fb_info *info,
> const struct fb_image *image)
> {
> - int mdr;
> u32 *cmd = NULL;
> void (*cmdfn) (u32 *, u16, u16, u16, u16, u16, u32, u32,
> const struct fb_image *, struct fb_info *) = NULL;
> @@ -196,7 +195,6 @@ static void mb86290fb_imageblit(struct fb_info *info,
> u16 dx = image->dx, dy = image->dy;
> int x2, y2, vxres, vyres;
>
> - mdr = (GDC_ROP_COPY << 9);
> x2 = image->dx + image->width;
> y2 = image->dy + image->height;
> vxres = info->var.xres_virtual;
> --
> 2.17.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-08 10:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-03 2:25 [PATCH] video: fbdev: mb862xx: remove set but not used variable 'mdr' Jason Yan
2020-04-03 2:25 ` Jason Yan
2020-04-08 10:19 ` Sam Ravnborg
2020-04-08 10:19 ` Sam Ravnborg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.