drivers/i2c/busses/i2c-img-scb.c:1348:2-9: line 1348 is redundant because platform_get_irq() already prints an error

drivers/i2c/busses/i2c-img-scb.c:1348:2-9: line 1348 is redundant because platform_get_irq() already prints an error

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1135 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: YueHaibing <yuehaibing@huawei.com>
CC: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
CC: Stephen Boyd <swboyd@chromium.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   435faf5c218a47fd6258187f62d9bb1009717896
commit: ca7ce5a2710ad2a57bf7d0c4c712590bb69a5e1c coccinelle: platform_get_irq: Fix parse error
date:   9 months ago
:::::: branch date: 11 hours ago
:::::: commit date: 9 months ago
config: mips-randconfig-c022-20200605 (attached as .config)
compiler: mips-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


coccinelle warnings: (new ones prefixed by >>)

>> drivers/i2c/busses/i2c-img-scb.c:1348:2-9: line 1348 is redundant because platform_get_irq() already prints an error

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 27091 bytes --]

[PATCH] coccinelle: platform_get_irq: fix platform_get_irq.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1598 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: YueHaibing <yuehaibing@huawei.com>
CC: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
CC: Stephen Boyd <swboyd@chromium.org>
CC: Kate Stewart <kstewart@linuxfoundation.org>
CC: Allison Randal <allison@lohutok.net>
CC: Enrico Weigelt <info@metux.net>
CC: Thomas Gleixner <tglx@linutronix.de>
CC: linux-i2c(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/i2c/busses/i2c-img-scb.c:1348:2-9: line 1348 is redundant because platform_get_irq() already prints an error

 Remove dev_err() messages after platform_get_irq*() failures
Generated by: scripts/coccinelle/api/platform_get_irq.cocci

Fixes: ca7ce5a2710a ("coccinelle: platform_get_irq: Fix parse error")
CC: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   435faf5c218a47fd6258187f62d9bb1009717896
commit: ca7ce5a2710ad2a57bf7d0c4c712590bb69a5e1c coccinelle: platform_get_irq: Fix parse error
:::::: branch date: 11 hours ago
:::::: commit date: 9 months ago

Please take the patch only if it's a positive warning. Thanks!

 i2c-img-scb.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/i2c/busses/i2c-img-scb.c
+++ b/drivers/i2c/busses/i2c-img-scb.c
@@ -1345,7 +1345,6 @@ static int img_i2c_probe(struct platform
 
 	irq = platform_get_irq(pdev, 0);
 	if (irq < 0) {
-		dev_err(&pdev->dev, "can't get irq number\n");
 		return irq;
 	}
 

drivers/mailbox/platform_mhu.c:141:3-10: line 141 is redundant because platform_get_irq() already prints an error

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1138 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: YueHaibing <yuehaibing@huawei.com>
CC: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
CC: Stephen Boyd <swboyd@chromium.org>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   3208167a865e862fff5045d7910387941ff7e114
commit: ca7ce5a2710ad2a57bf7d0c4c712590bb69a5e1c coccinelle: platform_get_irq: Fix parse error
date:   11 months ago
:::::: branch date: 3 hours ago
:::::: commit date: 11 months ago
config: x86_64-randconfig-c002-20200803 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


coccinelle warnings: (new ones prefixed by >>)

>> drivers/mailbox/platform_mhu.c:141:3-10: line 141 is redundant because platform_get_irq() already prints an error

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 35589 bytes --]

[PATCH] coccinelle: platform_get_irq: fix platform_get_irq.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1570 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: YueHaibing <yuehaibing@huawei.com>
CC: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
CC: Stephen Boyd <swboyd@chromium.org>
CC: Jassi Brar <jassisinghbrar@gmail.com>
CC: linux-kernel(a)vger.kernel.org

From: kernel test robot <lkp@intel.com>

drivers/mailbox/platform_mhu.c:141:3-10: line 141 is redundant because platform_get_irq() already prints an error

 Remove dev_err() messages after platform_get_irq*() failures
Generated by: scripts/coccinelle/api/platform_get_irq.cocci

Fixes: ca7ce5a2710a ("coccinelle: platform_get_irq: Fix parse error")
CC: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   3208167a865e862fff5045d7910387941ff7e114
commit: ca7ce5a2710ad2a57bf7d0c4c712590bb69a5e1c coccinelle: platform_get_irq: Fix parse error
:::::: branch date: 3 hours ago
:::::: commit date: 11 months ago

Please take the patch only if it's a positive warning. Thanks!

 platform_mhu.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/mailbox/platform_mhu.c
+++ b/drivers/mailbox/platform_mhu.c
@@ -138,7 +138,6 @@ static int platform_mhu_probe(struct pla
 		mhu->chan[i].con_priv = &mhu->mlink[i];
 		mhu->mlink[i].irq = platform_get_irq(pdev, i);
 		if (mhu->mlink[i].irq < 0) {
-			dev_err(dev, "failed to get irq%d\n", i);
 			return mhu->mlink[i].irq;
 		}
 		mhu->mlink[i].rx_reg = mhu->base + platform_mhu_reg[i];