All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: Chirantan Ekbote <chirantan@chromium.org>
Cc: virtio-fs-list <virtio-fs@redhat.com>,
	Miklos Szeredi <miklos@szeredi.hu>,
	qemu-devel@nongnu.org
Subject: Re: [Virtio-fs] [PATCH 0/2] virtiofsd: drop Linux capabilities(7)
Date: Thu, 25 Jun 2020 08:55:08 -0400	[thread overview]
Message-ID: <20200625125508.GB149340@redhat.com> (raw)
In-Reply-To: <CAJFHJroGNbfO-tXqrod_snCHcnN4NKjX8t9LTeroyiNEwjtVcQ@mail.gmail.com>

On Thu, Jun 25, 2020 at 12:19:39PM +0900, Chirantan Ekbote wrote:
[..]
> > Chirantan,
> >
> > So you ended up renaming all "trusted", "security" and "system" xattrs?
> > Only "user" xattrs are complete passthrough?
> >
> 
> No, we only rename "security" xattrs (except for selinux).
> 
> >
> > IOW, security.selinux will be renamed to user.virtiofs.security.selinux
> > on host?
> >
> 
> We don't relabel security.selinux because it only requires CAP_FOWNER
> in the process's user namespace and it also does its own MAC-based
> checks.  Also we have some tools that label files beforehand so it
> seemed easier to leave them unchanged.

If we rename selinux xattr also, then we can support selinux both in
guest and host and they both can have their own independent policies.

Otherwise we either have to disable selinux on host (if we want to
support it in guest) or somehow guest and how policies will have
to know about each other and be able to work together (which will
be hard for a generic use case).

Vivek


WARNING: multiple messages have this Message-ID (diff)
From: Vivek Goyal <vgoyal@redhat.com>
To: Chirantan Ekbote <chirantan@chromium.org>
Cc: virtio-fs-list <virtio-fs@redhat.com>,
	Miklos Szeredi <miklos@szeredi.hu>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	qemu-devel@nongnu.org
Subject: Re: [Virtio-fs] [PATCH 0/2] virtiofsd: drop Linux capabilities(7)
Date: Thu, 25 Jun 2020 08:55:08 -0400	[thread overview]
Message-ID: <20200625125508.GB149340@redhat.com> (raw)
In-Reply-To: <CAJFHJroGNbfO-tXqrod_snCHcnN4NKjX8t9LTeroyiNEwjtVcQ@mail.gmail.com>

On Thu, Jun 25, 2020 at 12:19:39PM +0900, Chirantan Ekbote wrote:
[..]
> > Chirantan,
> >
> > So you ended up renaming all "trusted", "security" and "system" xattrs?
> > Only "user" xattrs are complete passthrough?
> >
> 
> No, we only rename "security" xattrs (except for selinux).
> 
> >
> > IOW, security.selinux will be renamed to user.virtiofs.security.selinux
> > on host?
> >
> 
> We don't relabel security.selinux because it only requires CAP_FOWNER
> in the process's user namespace and it also does its own MAC-based
> checks.  Also we have some tools that label files beforehand so it
> seemed easier to leave them unchanged.

If we rename selinux xattr also, then we can support selinux both in
guest and host and they both can have their own independent policies.

Otherwise we either have to disable selinux on host (if we want to
support it in guest) or somehow guest and how policies will have
to know about each other and be able to work together (which will
be hard for a generic use case).

Vivek



  reply	other threads:[~2020-06-25 12:55 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-16 16:49 [Virtio-fs] [PATCH 0/2] virtiofsd: drop Linux capabilities(7) Stefan Hajnoczi
2020-04-16 16:49 ` Stefan Hajnoczi
2020-04-16 16:49 ` [Virtio-fs] [PATCH 1/2] virtiofsd: only retain file system capabilities Stefan Hajnoczi
2020-04-16 16:49   ` Stefan Hajnoczi
2020-04-28 11:48   ` [Virtio-fs] " Dr. David Alan Gilbert
2020-04-28 11:48     ` Dr. David Alan Gilbert
2020-04-16 16:49 ` [Virtio-fs] [PATCH 2/2] virtiofsd: drop all capabilities in the wait parent process Stefan Hajnoczi
2020-04-16 16:49   ` Stefan Hajnoczi
2020-04-16 17:50   ` [Virtio-fs] " Philippe Mathieu-Daudé
2020-04-16 17:50     ` Philippe Mathieu-Daudé
2020-04-16 20:10 ` [Virtio-fs] [PATCH 0/2] virtiofsd: drop Linux capabilities(7) Vivek Goyal
2020-04-16 20:10   ` Vivek Goyal
2020-04-17  9:42   ` [Virtio-fs] " Stefan Hajnoczi
2020-04-17  9:42     ` Stefan Hajnoczi
2020-05-01 18:28 ` [Virtio-fs] " Dr. David Alan Gilbert
2020-05-01 18:28   ` Dr. David Alan Gilbert
2020-06-18 19:08 ` [Virtio-fs] " Vivek Goyal
2020-06-18 19:16   ` Dr. David Alan Gilbert
2020-06-18 19:16     ` Dr. David Alan Gilbert
2020-06-18 19:27     ` Vivek Goyal
2020-06-18 19:27       ` Vivek Goyal
2020-06-19  4:46       ` Chirantan Ekbote
2020-06-19  4:46         ` Chirantan Ekbote
2020-06-19  8:39         ` Dr. David Alan Gilbert
2020-06-19  9:17           ` Chirantan Ekbote
2020-06-19 11:12             ` Dr. David Alan Gilbert
2020-06-19 19:15         ` Vivek Goyal
2020-06-19 19:15           ` Vivek Goyal
2020-06-25  3:19           ` Chirantan Ekbote
2020-06-25  3:19             ` Chirantan Ekbote
2020-06-25 12:55             ` Vivek Goyal [this message]
2020-06-25 12:55               ` Vivek Goyal
2020-07-13  8:54               ` Chirantan Ekbote
2020-07-13  8:54                 ` Chirantan Ekbote
2020-07-13 13:39                 ` Vivek Goyal
2020-07-13 13:39                   ` Vivek Goyal
2020-07-13 21:39                 ` Daniel Walsh
2020-07-14 12:33                   ` Vivek Goyal
2020-07-14 17:16                     ` Daniel Walsh
2020-06-19  8:27       ` Dr. David Alan Gilbert
2020-06-19  8:27         ` Dr. David Alan Gilbert
2020-06-19 11:39         ` Daniel P. Berrangé
2020-06-19 11:39           ` Daniel P. Berrangé
2020-06-19 11:49           ` Dr. David Alan Gilbert
2020-06-19 11:49             ` Dr. David Alan Gilbert
2020-06-19 12:05             ` Daniel P. Berrangé
2020-06-19 12:05               ` Daniel P. Berrangé
2020-06-19 17:41               ` Vivek Goyal
2020-06-19 17:41                 ` Vivek Goyal
2020-06-19 19:12           ` Vivek Goyal
2020-06-19 19:12             ` Vivek Goyal
2020-06-26 11:26             ` Dr. David Alan Gilbert
2020-06-26 11:26               ` Dr. David Alan Gilbert
2020-06-19 16:09         ` Vivek Goyal
2020-06-19 16:09           ` Vivek Goyal
2020-06-19 16:16           ` Dr. David Alan Gilbert
2020-06-19 16:16             ` Dr. David Alan Gilbert
2020-06-19 17:11             ` Vivek Goyal
2020-06-19 17:11               ` Vivek Goyal
2020-06-19 17:16               ` Dr. David Alan Gilbert
2020-06-19 17:16                 ` Dr. David Alan Gilbert
2020-06-19 14:16   ` Miklos Szeredi
2020-06-19 14:16     ` Miklos Szeredi
2020-06-19 14:25     ` Vivek Goyal
2020-06-19 14:25       ` Vivek Goyal
2020-06-19 15:26       ` Miklos Szeredi
2020-06-19 15:26         ` Miklos Szeredi
2020-06-19 15:57         ` Vivek Goyal
2020-06-19 15:57           ` Vivek Goyal
2020-06-19 14:29     ` Vivek Goyal
2020-06-19 14:29       ` Vivek Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200625125508.GB149340@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=chirantan@chromium.org \
    --cc=miklos@szeredi.hu \
    --cc=qemu-devel@nongnu.org \
    --cc=virtio-fs@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.