From: Eric Biggers <ebiggers@kernel.org>
To: Satya Tangirala <satyat@google.com>
Cc: linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH 3/5] iomap: support direct I/O with fscrypt using blk-crypto
Date: Thu, 9 Jul 2020 14:59:23 -0700 [thread overview]
Message-ID: <20200709215923.GD3855682@gmail.com> (raw)
In-Reply-To: <20200709194751.2579207-4-satyat@google.com>
On Thu, Jul 09, 2020 at 07:47:49PM +0000, Satya Tangirala wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> Wire up iomap direct I/O with the fscrypt additions for direct I/O,
> and set bio crypt contexts on bios when appropriate.
It might be useful to mention why the calls to fscrypt_limit_dio_pages() are
needed. (It's because the iomap code works directly with logical ranges, so it
doesn't have a chance to do fscrypt_mergeable_bio() on every page.)
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> Signed-off-by: Satya Tangirala <satyat@google.com>
> ---
> fs/iomap/direct-io.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
You probably should add linux-xfs@vger.kernel.org to Cc, as per
'./scripts/get_maintainer.pl fs/iomap/'.
- Eric
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org>
To: Satya Tangirala <satyat@google.com>
Cc: linux-fsdevel@vger.kernel.org, linux-fscrypt@vger.kernel.org,
linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 3/5] iomap: support direct I/O with fscrypt using blk-crypto
Date: Thu, 9 Jul 2020 14:59:23 -0700 [thread overview]
Message-ID: <20200709215923.GD3855682@gmail.com> (raw)
In-Reply-To: <20200709194751.2579207-4-satyat@google.com>
On Thu, Jul 09, 2020 at 07:47:49PM +0000, Satya Tangirala wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> Wire up iomap direct I/O with the fscrypt additions for direct I/O,
> and set bio crypt contexts on bios when appropriate.
It might be useful to mention why the calls to fscrypt_limit_dio_pages() are
needed. (It's because the iomap code works directly with logical ranges, so it
doesn't have a chance to do fscrypt_mergeable_bio() on every page.)
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> Signed-off-by: Satya Tangirala <satyat@google.com>
> ---
> fs/iomap/direct-io.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
You probably should add linux-xfs@vger.kernel.org to Cc, as per
'./scripts/get_maintainer.pl fs/iomap/'.
- Eric
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2020-07-09 21:59 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 19:47 [PATCH 0/5] add support for direct I/O with fscrypt using blk-crypto Satya Tangirala
2020-07-09 19:47 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2020-07-09 19:47 ` [PATCH 1/5] fscrypt: Add functions for direct I/O support Satya Tangirala
2020-07-09 19:47 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2020-07-09 21:54 ` Eric Biggers
2020-07-09 21:54 ` [f2fs-dev] " Eric Biggers
2020-07-09 19:47 ` [PATCH 2/5] direct-io: add support for fscrypt using blk-crypto Satya Tangirala
2020-07-09 19:47 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2020-07-10 5:34 ` Christoph Hellwig
2020-07-10 5:34 ` [f2fs-dev] " Christoph Hellwig
2020-07-13 18:36 ` Eric Biggers
2020-07-13 18:36 ` [f2fs-dev] " Eric Biggers
2020-07-17 1:56 ` Satya Tangirala
2020-07-17 1:56 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2020-07-09 19:47 ` [PATCH 3/5] iomap: support direct I/O with " Satya Tangirala
2020-07-09 19:47 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2020-07-09 21:59 ` Eric Biggers [this message]
2020-07-09 21:59 ` Eric Biggers
2020-07-09 19:47 ` [PATCH 4/5] ext4: " Satya Tangirala
2020-07-09 19:47 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2020-07-09 22:30 ` Eric Biggers
2020-07-09 22:30 ` [f2fs-dev] " Eric Biggers
2020-07-09 19:47 ` [PATCH 5/5] f2fs: " Satya Tangirala
2020-07-09 19:47 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2020-07-10 1:05 ` Chao Yu
2020-07-10 1:05 ` [f2fs-dev] " Chao Yu
2020-07-10 1:15 ` Eric Biggers
2020-07-10 1:15 ` [f2fs-dev] " Eric Biggers
2020-07-09 22:46 ` [PATCH 0/5] add support for " Eric Biggers
2020-07-09 22:46 ` [f2fs-dev] " Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200709215923.GD3855682@gmail.com \
--to=ebiggers@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=satyat@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.