From: Christoph Hellwig <hch@infradead.org>
To: Satya Tangirala <satyat@google.com>
Cc: linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-ext4@vger.kernel.org, Eric Biggers <ebiggers@google.com>
Subject: Re: [PATCH 2/5] direct-io: add support for fscrypt using blk-crypto
Date: Fri, 10 Jul 2020 06:34:06 +0100 [thread overview]
Message-ID: <20200710053406.GA25530@infradead.org> (raw)
In-Reply-To: <20200709194751.2579207-3-satyat@google.com>
On Thu, Jul 09, 2020 at 07:47:48PM +0000, Satya Tangirala wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> Set bio crypt contexts on bios by calling into fscrypt when required,
> and explicitly check for DUN continuity when adding pages to the bio.
> (While DUN continuity is usually implied by logical block contiguity,
> this is not the case when using certain fscrypt IV generation methods
> like IV_INO_LBLK_32).
I know it is asking you for more work, but instead of adding more
features to the legacy direct I/O code, could you just switch the user
of it (I guess this is for f2f2?) to the iomap one?
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Satya Tangirala <satyat@google.com>
Cc: linux-fsdevel@vger.kernel.org, linux-fscrypt@vger.kernel.org,
linux-ext4@vger.kernel.org, Eric Biggers <ebiggers@google.com>,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 2/5] direct-io: add support for fscrypt using blk-crypto
Date: Fri, 10 Jul 2020 06:34:06 +0100 [thread overview]
Message-ID: <20200710053406.GA25530@infradead.org> (raw)
In-Reply-To: <20200709194751.2579207-3-satyat@google.com>
On Thu, Jul 09, 2020 at 07:47:48PM +0000, Satya Tangirala wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> Set bio crypt contexts on bios by calling into fscrypt when required,
> and explicitly check for DUN continuity when adding pages to the bio.
> (While DUN continuity is usually implied by logical block contiguity,
> this is not the case when using certain fscrypt IV generation methods
> like IV_INO_LBLK_32).
I know it is asking you for more work, but instead of adding more
features to the legacy direct I/O code, could you just switch the user
of it (I guess this is for f2f2?) to the iomap one?
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2020-07-10 5:34 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 19:47 [PATCH 0/5] add support for direct I/O with fscrypt using blk-crypto Satya Tangirala
2020-07-09 19:47 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2020-07-09 19:47 ` [PATCH 1/5] fscrypt: Add functions for direct I/O support Satya Tangirala
2020-07-09 19:47 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2020-07-09 21:54 ` Eric Biggers
2020-07-09 21:54 ` [f2fs-dev] " Eric Biggers
2020-07-09 19:47 ` [PATCH 2/5] direct-io: add support for fscrypt using blk-crypto Satya Tangirala
2020-07-09 19:47 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2020-07-10 5:34 ` Christoph Hellwig [this message]
2020-07-10 5:34 ` Christoph Hellwig
2020-07-13 18:36 ` Eric Biggers
2020-07-13 18:36 ` [f2fs-dev] " Eric Biggers
2020-07-17 1:56 ` Satya Tangirala
2020-07-17 1:56 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2020-07-09 19:47 ` [PATCH 3/5] iomap: support direct I/O with " Satya Tangirala
2020-07-09 19:47 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2020-07-09 21:59 ` Eric Biggers
2020-07-09 21:59 ` [f2fs-dev] " Eric Biggers
2020-07-09 19:47 ` [PATCH 4/5] ext4: " Satya Tangirala
2020-07-09 19:47 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2020-07-09 22:30 ` Eric Biggers
2020-07-09 22:30 ` [f2fs-dev] " Eric Biggers
2020-07-09 19:47 ` [PATCH 5/5] f2fs: " Satya Tangirala
2020-07-09 19:47 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2020-07-10 1:05 ` Chao Yu
2020-07-10 1:05 ` [f2fs-dev] " Chao Yu
2020-07-10 1:15 ` Eric Biggers
2020-07-10 1:15 ` [f2fs-dev] " Eric Biggers
2020-07-09 22:46 ` [PATCH 0/5] add support for " Eric Biggers
2020-07-09 22:46 ` [f2fs-dev] " Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200710053406.GA25530@infradead.org \
--to=hch@infradead.org \
--cc=ebiggers@google.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=satyat@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.