From: Peng Fan <peng.fan@nxp.com>
To: bjorn.andersson@linaro.org, mathieu.poirier@linaro.org,
o.rempel@pengutronix.de, robh+dt@kernel.org
Cc: linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Peng Fan <peng.fan@nxp.com>
Subject: [PATCH 03/10] remoteproc: imx: use devm_ioremap
Date: Fri, 24 Jul 2020 16:08:06 +0800 [thread overview]
Message-ID: <20200724080813.24884-4-peng.fan@nxp.com> (raw)
In-Reply-To: <20200724080813.24884-1-peng.fan@nxp.com>
We might need to map an region multiple times, becaue the region might
be shared between remote processors, such i.MX8QM with dual M4 cores.
So use devm_ioremap, not devm_ioremap_resource.
Reviewed-by: Richard Zhu <hongxing.zhu@nxp.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
drivers/remoteproc/imx_rproc.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
index 3b3904ebac75..82594a800a1b 100644
--- a/drivers/remoteproc/imx_rproc.c
+++ b/drivers/remoteproc/imx_rproc.c
@@ -296,9 +296,10 @@ static int imx_rproc_addr_init(struct imx_rproc *priv,
if (b >= IMX7D_RPROC_MEM_MAX)
break;
- priv->mem[b].cpu_addr = devm_ioremap_resource(&pdev->dev, &res);
+ /* Not use resource version, because we might share region*/
+ priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev, res.start, resource_size(&res));
if (IS_ERR(priv->mem[b].cpu_addr)) {
- dev_err(dev, "devm_ioremap_resource failed\n");
+ dev_err(dev, "devm_ioremap %pR failed\n", &res);
err = PTR_ERR(priv->mem[b].cpu_addr);
return err;
}
--
2.16.4
WARNING: multiple messages have this Message-ID (diff)
From: Peng Fan <peng.fan@nxp.com>
To: bjorn.andersson@linaro.org, mathieu.poirier@linaro.org,
o.rempel@pengutronix.de, robh+dt@kernel.org
Cc: devicetree@vger.kernel.org, Peng Fan <peng.fan@nxp.com>,
festevam@gmail.com, s.hauer@pengutronix.de,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-imx@nxp.com, kernel@pengutronix.de, shawnguo@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH 03/10] remoteproc: imx: use devm_ioremap
Date: Fri, 24 Jul 2020 16:08:06 +0800 [thread overview]
Message-ID: <20200724080813.24884-4-peng.fan@nxp.com> (raw)
In-Reply-To: <20200724080813.24884-1-peng.fan@nxp.com>
We might need to map an region multiple times, becaue the region might
be shared between remote processors, such i.MX8QM with dual M4 cores.
So use devm_ioremap, not devm_ioremap_resource.
Reviewed-by: Richard Zhu <hongxing.zhu@nxp.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
drivers/remoteproc/imx_rproc.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
index 3b3904ebac75..82594a800a1b 100644
--- a/drivers/remoteproc/imx_rproc.c
+++ b/drivers/remoteproc/imx_rproc.c
@@ -296,9 +296,10 @@ static int imx_rproc_addr_init(struct imx_rproc *priv,
if (b >= IMX7D_RPROC_MEM_MAX)
break;
- priv->mem[b].cpu_addr = devm_ioremap_resource(&pdev->dev, &res);
+ /* Not use resource version, because we might share region*/
+ priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev, res.start, resource_size(&res));
if (IS_ERR(priv->mem[b].cpu_addr)) {
- dev_err(dev, "devm_ioremap_resource failed\n");
+ dev_err(dev, "devm_ioremap %pR failed\n", &res);
err = PTR_ERR(priv->mem[b].cpu_addr);
return err;
}
--
2.16.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-24 7:43 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 8:08 [PATCH 00/10] remoteproc: imx_rproc: support iMX8M and early boot Peng Fan
2020-07-24 8:08 ` Peng Fan
2020-07-24 8:08 ` [PATCH 01/10] dt-bindings: remoteproc: imx_rproc: add i.MX8MQ/M Peng Fan
2020-07-24 8:08 ` Peng Fan
2020-07-31 20:14 ` Rob Herring
2020-07-31 20:14 ` Rob Herring
2020-07-24 8:08 ` [PATCH 02/10] remoteproc: imx_rproc: correct err message Peng Fan
2020-07-24 8:08 ` Peng Fan
2020-08-11 19:56 ` Mathieu Poirier
2020-08-11 19:56 ` Mathieu Poirier
2020-07-24 8:08 ` Peng Fan [this message]
2020-07-24 8:08 ` [PATCH 03/10] remoteproc: imx: use devm_ioremap Peng Fan
2020-07-27 6:23 ` Oleksij Rempel
2020-07-27 6:23 ` Oleksij Rempel
2020-07-27 6:28 ` Peng Fan
2020-07-27 6:28 ` Peng Fan
2020-07-27 6:41 ` Oleksij Rempel
2020-07-27 6:41 ` Oleksij Rempel
2020-07-27 6:51 ` Peng Fan
2020-07-27 6:51 ` Peng Fan
2020-07-27 7:37 ` Oleksij Rempel
2020-07-27 7:37 ` Oleksij Rempel
2020-07-27 8:11 ` Peng Fan
2020-07-27 8:11 ` Peng Fan
2020-07-28 7:20 ` Oleksij Rempel
2020-07-28 7:20 ` Oleksij Rempel
2020-07-24 8:08 ` [PATCH 04/10] remoteproc: imx_rproc: make syscon optional Peng Fan
2020-07-24 8:08 ` Peng Fan
2020-08-11 22:40 ` Mathieu Poirier
2020-08-11 22:40 ` Mathieu Poirier
2020-08-18 21:43 ` Mathieu Poirier
2020-08-18 21:43 ` Mathieu Poirier
2020-08-19 0:51 ` Peng Fan
2020-08-19 0:51 ` Peng Fan
2020-08-19 19:45 ` Mathieu Poirier
2020-08-19 19:45 ` Mathieu Poirier
2020-08-20 2:04 ` Peng Fan
2020-08-20 2:04 ` Peng Fan
2020-08-20 19:27 ` Mathieu Poirier
2020-08-20 19:27 ` Mathieu Poirier
2020-07-24 8:08 ` [PATCH 05/10] remoteproc: imx_rproc: make clk optional Peng Fan
2020-07-24 8:08 ` Peng Fan
2020-07-24 8:08 ` [PATCH 06/10] remoteproc: imx_rproc: add load hook Peng Fan
2020-07-24 8:08 ` Peng Fan
2020-07-27 5:20 ` Oleksij Rempel
2020-07-27 5:20 ` Oleksij Rempel
2020-08-11 21:40 ` Mathieu Poirier
2020-08-11 21:40 ` Mathieu Poirier
2020-07-24 8:08 ` [PATCH 07/10] remoteproc: imx_rproc: add i.MX specific parse fw hook Peng Fan
2020-07-24 8:08 ` Peng Fan
2020-08-11 21:56 ` Mathieu Poirier
2020-08-11 21:56 ` Mathieu Poirier
2020-07-24 8:08 ` [PATCH 08/10] remoteproc: imx_rproc: support i.MX8MQ/M Peng Fan
2020-07-24 8:08 ` Peng Fan
2020-07-24 8:08 ` [PATCH 09/10] remoteproc: imx_proc: enable virtio/mailbox Peng Fan
2020-07-24 8:08 ` Peng Fan
2020-07-24 8:08 ` [PATCH 10/10] remoteproc: imx_rproc: support coproc booting before Linux Peng Fan
2020-07-24 8:08 ` Peng Fan
2020-08-11 22:36 ` Mathieu Poirier
2020-08-11 22:36 ` Mathieu Poirier
2020-07-27 6:38 ` [PATCH 00/10] remoteproc: imx_rproc: support iMX8M and early boot Oleksij Rempel
2020-07-27 6:38 ` Oleksij Rempel
2020-07-27 6:44 ` Peng Fan
2020-07-27 6:44 ` Peng Fan
2020-07-27 7:54 ` Oleksij Rempel
2020-07-27 7:54 ` Oleksij Rempel
2020-07-27 9:18 ` Peng Fan
2020-07-27 9:18 ` Peng Fan
2020-07-28 7:26 ` Oleksij Rempel
2020-07-28 7:26 ` Oleksij Rempel
2020-07-28 7:50 ` Peng Fan
2020-07-28 7:50 ` Peng Fan
2020-07-28 7:55 ` Oleksij Rempel
2020-07-28 7:55 ` Oleksij Rempel
2020-07-28 9:36 ` Peng Fan
2020-07-28 9:36 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200724080813.24884-4-peng.fan@nxp.com \
--to=peng.fan@nxp.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=o.rempel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.