Re: [PATCH 2/3] ARM: dts: Add ethernet

From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Łukasz Stelmach" <l.stelmach@samsung.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Kukjin Kim <kgene@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	m.szyprowski@samsung.com, b.zolnierkie@samsung.com
Subject: Re: [PATCH 2/3] ARM: dts: Add ethernet
Date: Tue, 25 Aug 2020 20:49:14 +0200	[thread overview]
Message-ID: <20200825184914.GB2693@kozik-lap> (raw)
In-Reply-To: <20200825170311.24886-2-l.stelmach@samsung.com>

On Tue, Aug 25, 2020 at 07:03:10PM +0200, Łukasz Stelmach wrote:
> Add node for ax88796c ethernet chip.

Subject
  ARM: dts: exynos: Add Ethernet to Artik 5 board

> 
> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
> ---
>  arch/arm/boot/dts/exynos3250-artik5-eval.dts | 21 ++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos3250-artik5-eval.dts b/arch/arm/boot/dts/exynos3250-artik5-eval.dts
> index 20446a846a98..44151a2cb35d 100644
> --- a/arch/arm/boot/dts/exynos3250-artik5-eval.dts
> +++ b/arch/arm/boot/dts/exynos3250-artik5-eval.dts
> @@ -37,3 +37,24 @@ &mshc_2 {
>  &serial_2 {
>  	status = "okay";
>  };
> +
> +&spi_0 {
> +		status = "okay";
> +		cs-gpios = <&gpx3 4 GPIO_ACTIVE_LOW>, <0>;
> +
> +		assigned-clocks        = <&cmu CLK_MOUT_MPLL>, <&cmu CLK_DIV_MPLL_PRE>, <&cmu CLK_MOUT_SPI0>,    <&cmu CLK_DIV_SPI0>,  <&cmu CLK_DIV_SPI0_PRE>, <&cmu CLK_SCLK_SPI0>;
> +		assigned-clock-parents = <&cmu CLK_FOUT_MPLL>, <&cmu CLK_MOUT_MPLL>,    <&cmu CLK_DIV_MPLL_PRE>, <&cmu CLK_MOUT_SPI0>, <&cmu CLK_DIV_SPI0>,     <&cmu CLK_DIV_SPI0_PRE>;
> +
> +		ax88796c@0 {
> +			compatible = "asix,ax88796c";

Isn't checkpatch complaining about undocumented compatible? I didn't see
a binding here.

> +			interrupt-parent = <&gpx2>;
> +			interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
> +			spi-max-frequency = <40000000>;
> +			reg = <0x0>;
> +			reset-gpios = <&gpe0 2 GPIO_ACTIVE_LOW>;

One line break.

> +			controller-data {
> +				samsung,spi-feedback-delay = <2>;
> +				samsung,spi-chip-select-mode;

What does samsung,spi-chip-select-mode mean? git grep does not find a binding.

> +		};
> +	};

Whatever formatting you used here, it is not Linux coding style. Please
fix indentation, linewrapping.

Best regards,
Krzysztof