From: Halil Pasic <pasic@linux.ibm.com>
To: Pierre Morel <pmorel@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org, borntraeger@de.ibm.com,
frankja@linux.ibm.com, mst@redhat.com, jasowang@redhat.com,
cohuck@redhat.com, kvm@vger.kernel.org,
linux-s390@vger.kernel.org,
virtualization@lists.linux-foundation.org,
thomas.lendacky@amd.com, david@gibson.dropbear.id.au,
linuxram@us.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com
Subject: Re: [PATCH v11 1/2] virtio: let arch advertise guest's memory access restrictions
Date: Tue, 8 Sep 2020 00:22:12 +0200 [thread overview]
Message-ID: <20200908002212.462303b4.pasic@linux.ibm.com> (raw)
In-Reply-To: <1599471547-28631-2-git-send-email-pmorel@linux.ibm.com>
On Mon, 7 Sep 2020 11:39:06 +0200
Pierre Morel <pmorel@linux.ibm.com> wrote:
> An architecture may restrict host access to guest memory,
> e.g. IBM s390 Secure Execution or AMD SEV.
>
> Provide a new Kconfig entry the architecture can select,
> CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS, when it provides
> the arch_has_restricted_virtio_memory_access callback to advertise
> to VIRTIO common code when the architecture restricts memory access
> from the host.
>
> The common code can then fail the probe for any device where
> VIRTIO_F_ACCESS_PLATFORM is required, but not set.
>
> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Halil Pasic <pasic@linux.ibm.com>
[..]
>
> +config ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
> + bool
> + help
> + This option is selected if the architecture may need to enforce
> + VIRTIO_F_IOMMU_PLATFORM.
> +
A small nit: you use F_ACCESS_PLATFORM everywhere but here.
Regards,
Halil
WARNING: multiple messages have this Message-ID (diff)
From: Halil Pasic <pasic@linux.ibm.com>
To: Pierre Morel <pmorel@linux.ibm.com>
Cc: gor@linux.ibm.com, linux-s390@vger.kernel.org,
frankja@linux.ibm.com, kvm@vger.kernel.org, mst@redhat.com,
cohuck@redhat.com, linuxram@us.ibm.com,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
borntraeger@de.ibm.com, thomas.lendacky@amd.com,
hca@linux.ibm.com, david@gibson.dropbear.id.au
Subject: Re: [PATCH v11 1/2] virtio: let arch advertise guest's memory access restrictions
Date: Tue, 8 Sep 2020 00:22:12 +0200 [thread overview]
Message-ID: <20200908002212.462303b4.pasic@linux.ibm.com> (raw)
In-Reply-To: <1599471547-28631-2-git-send-email-pmorel@linux.ibm.com>
On Mon, 7 Sep 2020 11:39:06 +0200
Pierre Morel <pmorel@linux.ibm.com> wrote:
> An architecture may restrict host access to guest memory,
> e.g. IBM s390 Secure Execution or AMD SEV.
>
> Provide a new Kconfig entry the architecture can select,
> CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS, when it provides
> the arch_has_restricted_virtio_memory_access callback to advertise
> to VIRTIO common code when the architecture restricts memory access
> from the host.
>
> The common code can then fail the probe for any device where
> VIRTIO_F_ACCESS_PLATFORM is required, but not set.
>
> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Halil Pasic <pasic@linux.ibm.com>
[..]
>
> +config ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
> + bool
> + help
> + This option is selected if the architecture may need to enforce
> + VIRTIO_F_IOMMU_PLATFORM.
> +
A small nit: you use F_ACCESS_PLATFORM everywhere but here.
Regards,
Halil
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2020-09-07 22:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 9:39 [PATCH v11 0/2] s390: virtio: let arch validate VIRTIO features Pierre Morel
2020-09-07 9:39 ` Pierre Morel
2020-09-07 9:39 ` [PATCH v11 1/2] virtio: let arch advertise guest's memory access restrictions Pierre Morel
2020-09-07 9:39 ` Pierre Morel
2020-09-07 22:22 ` Halil Pasic [this message]
2020-09-07 22:22 ` Halil Pasic
2020-09-07 9:39 ` [PATCH v11 2/2] s390: virtio: PV needs VIRTIO I/O device protection Pierre Morel
2020-09-07 9:39 ` Pierre Morel
2020-09-07 22:37 ` Halil Pasic
2020-09-07 22:37 ` Halil Pasic
2020-09-08 13:39 ` kernel test robot
2020-09-08 13:39 ` kernel test robot
2020-09-07 22:39 ` [PATCH v11 0/2] s390: virtio: let arch validate VIRTIO features Halil Pasic
2020-09-07 22:39 ` Halil Pasic
2020-09-08 6:55 ` Cornelia Huck
2020-09-08 6:55 ` Cornelia Huck
2020-09-08 8:35 ` Michael S. Tsirkin
2020-09-08 8:35 ` Michael S. Tsirkin
2020-09-08 7:57 ` Michael S. Tsirkin
2020-09-08 7:57 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200908002212.462303b4.pasic@linux.ibm.com \
--to=pasic@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=frankja@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxram@us.ibm.com \
--cc=mst@redhat.com \
--cc=pmorel@linux.ibm.com \
--cc=thomas.lendacky@amd.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.